fbe 0.7.1 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1ce252b4d0093ff1f94e319d2c65502e134dad520398ca018fad1820b9dac78
-  data.tar.gz: f0039a70dcd2533e2acd36f80b7ef3ac68441f1f68611b38ee07d9c67449ddf3
+  metadata.gz: 3828337a178cb00363cfde7328b72d719e412861b1faeedeacbfa90ecdf55f01
+  data.tar.gz: 13e04faef8302ce164266d19cf5b54d9876376500c113a692467c30bde96345e
 SHA512:
-  metadata.gz: 25191aefeccb723456f4de449c6f042ce628c895fc7f2e941f5e63e0685bfb2bccf550e04c288ff28e288acf8a4c0b57f3402b2826cae5ccb5da549c977f1ffe
-  data.tar.gz: 6362777ada12c805d463db462afbfbf5bab5d20b897565b798c2ede567d097f3250622d1a67656731e94f0ac8fc37fb604ace94c150e51e47c2a83ec14f4be60
+  metadata.gz: 7f35b12b769b206e111a63de0575f673be0c8514c42b3b90b33009a65529d8572f98d173d6c18dce29e8edd231afb7cd890c8dbe17af1b2e58733e7359453e73
+  data.tar.gz: 1743b4a1fe9deb57b39763f666683eb51ea6878fd56b86bc99fe1189c4fa58fcb42762b8e6f14cb7b0fd4256aca858824b8ca4ca6c0a7238d4f547c80d673b45

data/assets/bylaws/code-contribution-was-rewarded.liquid

@@ -51,19 +51,6 @@
     (give bonus_for_comments "for too many (${comments}) comments that were made during review")
     "deduct ${comments_k} points for every comment made during review, but not more than ${comments_max} points")
 
-  (aka
-    (let few_comments_fee {{ 2 | times: anger }})
-    (let comments_needed {{ 3 | times: paranoia }})
-    (set penalty_for_few_comments (if (and (lt comments comments_needed) (not (eq comments 0))) (times -1 few_comments_fee) 0))
-    (give penalty_for_few_comments "for very few (${comments}) comments")
-    "deduct ${few_comments_fee} points if there were less than ${comments_needed} comments made during review")
-
-  (aka
-    (let silence_fee {{ 8 | times: anger }})
-    (set penalty_for_silence (if (eq comments 0) (times -1 silence_fee) 0))
-    (give penalty_for_silence "for absolutely no comments posted by reviewers")
-    "deduct ${silence_fee} points if there were absolutely no comments made by reviewers during the review")
-
   (aka
     (let few_hoc_fee {{ 4 | times: anger }})
     (let hoc_needed {{ 10 | times: paranoia }})

data/lib/fbe/conclude.rb

@@ -18,6 +18,11 @@ require_relative 'if_absent'
 # @param [Loog] loog The logging facility
 # @yield [Factbase::Fact] The fact
 def Fbe.conclude(fb: Fbe.fb, judge: $judge, loog: $loog, options: $options, global: $global, &)
+  raise 'The fb is nil' if fb.nil?
+  raise 'The $judge is not set' if judge.nil?
+  raise 'The $global is not set' if global.nil?
+  raise 'The $options is not set' if options.nil?
+  raise 'The $loog is not set' if loog.nil?
   c = Fbe::Conclude.new(fb:, judge:, loog:, options:, global:)
   c.instance_eval(&)
 end

data/lib/fbe/enter.rb

@@ -14,6 +14,10 @@ require_relative '../fbe'
 # @param [Loog] loog The logging facility
 # @return [String] Full name of the user
 def Fbe.enter(badge, why, options: $options, loog: $loog, &)
+  raise 'The badge is nil' if badge.nil?
+  raise 'The why is nil' if why.nil?
+  raise 'The $options is not set' if options.nil?
+  raise 'The $loog is not set' if loog.nil?
   return yield unless options.testing.nil?
   baza = BazaRb.new('api.zerocracy.com', 443, options.zerocracy_token, loog:)
   baza.enter(options.job_name, badge, why, options.job_id.to_i, &)

data/lib/fbe/fb.rb

@@ -26,6 +26,10 @@ require_relative '../fbe'
 # @param [Loog] loog The logging facility
 # @return [Factbase] The global factbase
 def Fbe.fb(fb: $fb, global: $global, options: $options, loog: $loog)
+  raise 'The fb is nil' if fb.nil?
+  raise 'The $global is not set' if global.nil?
+  raise 'The $options is not set' if options.nil?
+  raise 'The $loog is not set' if loog.nil?
   global[:fb] ||=
     begin
       rules = Dir.glob(File.join('rules', '*.fe')).map { |f| File.read(f) }

data/lib/fbe/issue.rb

@@ -19,6 +19,10 @@ require_relative 'octo'
 # @param [Loog] loog The logging facility
 # @return [String] Textual representation of GitHub issue number
 def Fbe.issue(fact, options: $options, global: $global, loog: $loog)
+  raise 'The fact is nil' if fact.nil?
+  raise 'The $global is not set' if global.nil?
+  raise 'The $options is not set' if options.nil?
+  raise 'The $loog is not set' if loog.nil?
   rid = fact['repository']
   raise "There is no 'repository' property" if rid.nil?
   rid = rid.first.to_i

data/lib/fbe/iterate.rb

@@ -18,6 +18,10 @@ require_relative 'unmask_repos'
 # @param [Loog] loog The logging facility
 # @yield [Factbase::Fact] The fact
 def Fbe.iterate(fb: Fbe.fb, loog: $loog, options: $options, global: $global, &)
+  raise 'The fb is nil' if fb.nil?
+  raise 'The $global is not set' if global.nil?
+  raise 'The $options is not set' if options.nil?
+  raise 'The $loog is not set' if loog.nil?
   c = Fbe::Iterate.new(fb:, loog:, options:, global:)
   c.instance_eval(&)
 end

data/lib/fbe/octo.rb

@@ -26,6 +26,8 @@ require_relative 'middleware/formatter'
 # @return [Hash] Usually returns a JSON, as it comes from the GitHub API
 def Fbe.octo(options: $options, global: $global, loog: $loog)
   raise 'The $global is not set' if global.nil?
+  raise 'The $options is not set' if options.nil?
+  raise 'The $loog is not set' if loog.nil?
   global[:octo] ||=
     begin
       if options.testing.nil?
@@ -94,13 +96,16 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
         end
 
         def user_name_by_id(id)
+          raise 'The ID of the user is nil' if id.nil?
+          raise 'The ID of the user must be an Integer' unless id.is_a?(Integer)
           json = @origin.user(id)
-          name = json[:login]
+          name = json[:login].downcase
           @loog.debug("GitHub user ##{id} has a name: @#{name}")
           name
         end
 
         def repo_id_by_name(name)
+          raise 'The name of the repo is nil' if name.nil?
           json = @origin.repository(name)
           id = json[:id]
           @loog.debug("GitHub repository #{name.inspect} has an ID: ##{id}")
@@ -108,8 +113,10 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
         end
 
         def repo_name_by_id(id)
+          raise 'The ID of the repo is nil' if id.nil?
+          raise 'The ID of the repo must be an Integer' unless id.is_a?(Integer)
           json = @origin.repository(id)
-          name = json[:full_name]
+          name = json[:full_name].downcase
           @loog.debug("GitHub repository ##{id} has a name: #{name}")
           name
         end

data/lib/fbe/overwrite.rb

@@ -21,6 +21,7 @@ require_relative 'fb'
 # @return [Factbase::Fact] Returns new fact or previous one
 def Fbe.overwrite(fact, property, value, fb: Fbe.fb)
   raise 'The fact is nil' if fact.nil?
+  raise 'The fb is nil' if fb.nil?
   raise "The property is not a String but #{property.class} (#{property})" unless property.is_a?(String)
   return fact if !fact[property].nil? && fact[property].size == 1 && fact[property].first == value
   before = {}

data/lib/fbe/regularly.rb

@@ -16,6 +16,11 @@ require_relative 'fb'
 # @param [Loog] loog The logging facility
 # @return [nil] Nothing
 def Fbe.regularly(area, p_every_days, p_since_days = nil, fb: Fbe.fb, judge: $judge, loog: $loog, &)
+  raise 'The area is nil' if area.nil?
+  raise 'The p_every_days is nil' if p_every_days.nil?
+  raise 'The fb is nil' if fb.nil?
+  raise 'The $judge is not set' if judge.nil?
+  raise 'The $loog is not set' if loog.nil?
   pmp = fb.query("(and (eq what 'pmp') (eq area '#{area}') (exists #{p_every_days}))").each.to_a.first
   interval = pmp.nil? ? 7 : pmp[p_every_days].first
   unless fb.query(

data/lib/fbe/repeatedly.rb

@@ -16,6 +16,11 @@ require_relative 'overwrite'
 # @param [Loog] loog The logging facility
 # @return [nil] Nothing
 def Fbe.repeatedly(area, p_every_hours, fb: Fbe.fb, judge: $judge, loog: $loog, &)
+  raise 'The area is nil' if area.nil?
+  raise 'The p_every_hours is nil' if p_every_hours.nil?
+  raise 'The fb is nil' if fb.nil?
+  raise 'The $judge is not set' if judge.nil?
+  raise 'The $loog is not set' if loog.nil?
   pmp = fb.query("(and (eq what 'pmp') (eq area '#{area}') (exists #{p_every_hours}))").each.to_a.first
   hours = pmp.nil? ? 24 : pmp[p_every_hours].first
   unless fb.query(

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.7.1' unless const_defined?(:VERSION)
+  VERSION = '0.8.1' unless const_defined?(:VERSION)
 end

data/test/fbe/test_bylaws.rb

@@ -61,7 +61,7 @@ class TestBylaws < Fbe::Test
         { hoc: 50, comments: 25, reviews: 0 } => 4,
         { hoc: 180, comments: 7, reviews: 2 } => 13,
         { hoc: 199, comments: 8, reviews: 3 } => 14,
-        { hoc: 150, comments: 5, reviews: 1 } => 8,
+        { hoc: 150, comments: 5, reviews: 1 } => 12,
         { hoc: 500, comments: 25, reviews: 2 } => 4,
         { hoc: 99, comments: 6, reviews: 1 } => 4,
         { hoc: 1_500, comments: 3, reviews: 0 } => 4,

data/test/fbe/test_octo.rb

@@ -51,6 +51,28 @@ class TestOcto < Fbe::Test
     assert_equal(100, o.rate_limit.remaining)
   end
 
+  def test_reads_nickname_by_id
+    WebMock.disable_net_connect!
+    global = {}
+    o = Fbe.octo(loog: Loog::NULL, global:, options: Judges::Options.new)
+    stub_request(:get, 'https://api.github.com/user/42').to_return(
+      body: { login: 'Dude56' }.to_json, headers: { 'Content-Type': 'application/json' }
+    )
+    nick = o.user_name_by_id(42)
+    assert_equal('dude56', nick)
+  end
+
+  def test_reads_repo_name_by_id
+    WebMock.disable_net_connect!
+    global = {}
+    o = Fbe.octo(loog: Loog::NULL, global:, options: Judges::Options.new)
+    stub_request(:get, 'https://api.github.com/repositories/42').to_return(
+      body: { full_name: 'Foo/bar56-Ff' }.to_json, headers: { 'Content-Type': 'application/json' }
+    )
+    nick = o.repo_name_by_id(42)
+    assert_equal('foo/bar56-ff', nick)
+  end
+
   def test_caching
     WebMock.disable_net_connect!
     global = {}

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.1
 platform: ruby
 authors:
 - Yegor Bugayenko
 bindir: bin
 cert_chain: []
-date: 2025-04-16 00:00:00.000000000 Z
+date: 2025-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace