fbe 0.48.4 → 0.48.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d0089866ec9064d80a2061dc5219b7a6804d028ffefe8e685547e09a3847284
-  data.tar.gz: c2720200173179080383889a4dbc7f8445729296c0ba53f2695b74b502f8ebd3
+  metadata.gz: e54b9ecd59fd5bf0087090ec4d320a09e4468fd1d30c943968255992d37af3a9
+  data.tar.gz: d309db436c5f4902e1bfb50f6c32fbc93a5aeed57aa47653d60828079cb5540e
 SHA512:
-  metadata.gz: '09035a890d7e838df5820a4e2cafa6d5333f31b743087855351041f788d5bd0d5ec9c8a454e79ca3bf0fe69f1286e97d8a87e4a6d8554e79f3c465e4acfcb0fa'
-  data.tar.gz: c5800d374a1b0245a9fc55849d1b3e8d576fb84607b200020b08b14da63fce8f302dde9cee7d17652effc1144a105f9f1436c126332da0ef50bef680ee0ac100
+  metadata.gz: c0131eae4897865be58003cda673768124456e990e74be4650d671bb2038fb71fcf58fec08d7f2c922c3e694875abfbfc52f2a9584a3a54e4a9ca7a5ef5c2076
+  data.tar.gz: c68253c55d621d3ce8d7da0721f7e330532fe4b8eec18ef641acb801b57098c884307782fa31c2d403781a5b38afbbcaddb5574505eb6da4ab8be6587614a1ca

data/.github/workflows/codecov.yml

@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 4.0.2
+          ruby-version: 4.0.3
           bundler-cache: true
       - run: bundle config set --global path "$(pwd)/vendor/bundle"
       - run: bundle install --no-color

data/.github/workflows/markdown-lint.yml

@@ -20,4 +20,4 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v6
-      - uses: DavidAnson/markdownlint-cli2-action@v23.0.0
+      - uses: DavidAnson/markdownlint-cli2-action@v23.2.0

data/.github/workflows/typos.yml

@@ -16,6 +16,6 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v6
-      - uses: crate-ci/typos@v1.45.1
+      - uses: crate-ci/typos@v1.46.0
         with:
           config: .github/.typos.toml

data/Gemfile.lock

@@ -152,7 +152,7 @@ GEM
     loog (0.8.0)
       ellipsized
       logger (~> 1.0)
-    minitest (6.0.4)
+    minitest (6.0.6)
       drb (~> 2.0)
       prism (~> 1.5)
     minitest-mock (5.27.0)
@@ -190,7 +190,7 @@ GEM
       date
       stringio
     public_suffix (7.0.5)
-    qbash (0.8.2)
+    qbash (0.8.3)
       backtrace (> 0)
       elapsed (> 0)
       loog (> 0)
@@ -219,7 +219,7 @@ GEM
     rubocop-ast (1.49.1)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
-    rubocop-elegant (0.0.15)
+    rubocop-elegant (0.0.16)
       lint_roller (~> 1.1)
       rubocop (~> 1.75)
     rubocop-minitest (0.39.1)
@@ -274,7 +274,7 @@ GEM
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
     yaml (0.4.0)
-    yard (0.9.41)
+    yard (0.9.43)
 
 PLATFORMS
   arm64-darwin-22

data/README.md

@@ -15,7 +15,7 @@ It's a collection of tools for
 You are not supposed to use it directly, but only in a combination
 with other tools of Zerocracy.
 
-The following tools runs a block:
+The following tools run a block:
 
 * `Fbe.regularly` runs a block of code every X days.
 * `Fbe.conclude` runs a block on every fact from a query.

data/assets/bylaws/bad-branch-name-was-punished.fe.liquid

@@ -1,5 +1,5 @@
 (award
-  (explain "If a branch has a name that doesn\\\'t obey the convention, a penalty is given to the author")
+  (explain "If a branch has a name that doesn\'t obey the convention, a penalty is given to the author")
   (aka
     (let fee {{ -6 | times: anger }})
     (give fee "as a basis")

data/lib/fbe/conclude.rb

@@ -36,16 +36,16 @@ end
 # A concluding block.
 #
 # You may want to use this class when you want to go through a number
-# of facts in the factbase, applying certain algorithm to each of them
+# of facts in the factbase, applying a certain algorithm to each of them
 # and possibly creating new facts from them.
 #
 # For example, you want to make a new +good+ fact for every +bad+ fact found:
 #
 #  require 'fbe/conclude'
 #  conclude do
-#    on '(exist bad)'
+#    on '(exists bad)'
 #    follow 'when'
-#    draw on |n, b|
+#    draw do |n, b|
 #      n.good = 'yes!'
 #    end
 #  end
@@ -132,9 +132,9 @@ class Fbe::Conclude
   #
   #  require 'fbe/conclude'
   #  conclude do
-  #    on '(exist win)'
+  #    on '(exists win)'
   #    follow 'win when'
-  #    draw on |n, w|
+  #    draw do |n, w|
   #      n.reward = 10
   #    end
   #  end
@@ -161,7 +161,7 @@ class Fbe::Conclude
   #  require 'fbe/conclude'
   #  conclude do
   #    on '(always)'
-  #    consider on |f|
+  #    consider do |f|
   #      f.when = Time.new
   #    end
   #  end
@@ -208,7 +208,12 @@ class Fbe::Conclude
       )
       @fb.txn do |fbt|
         n = yield(fbt, a)
-        @loog.info("#{n.what}: #{n.details}") unless n.nil?
+        unless n.nil?
+          props = n.all_properties
+          if props.include?('what') && props.include?('details')
+            @loog.info("#{n.what}: #{n.details}")
+          end
+        end
       end
       passed += 1
     end

data/lib/fbe/github_graph.rb

@@ -287,11 +287,12 @@ class Fbe::Graph # rubocop:disable Metrics/ClassLength
   #     cursor = json['next_cursor']
   #   end
   def pull_requests_with_reviews(owner, name, since, cursor: nil)
+    after = "after: \"#{cursor}\", " unless cursor.nil?
     result = query(
       <<~GRAPHQL
         {
           repository(owner: "#{owner}", name: "#{name}") {
-            pullRequests(first: 100, after: "#{cursor}") {
+            pullRequests(#{after}first: 100) {
               nodes {
                 id
                 number
@@ -310,16 +311,16 @@ class Fbe::Graph # rubocop:disable Metrics/ClassLength
         }
       GRAPHQL
     ).to_h
+    nodes = result.dig('repository', 'pullRequests', 'nodes')
+    raise(Fbe::Error, "Repository '#{owner}/#{name}' not found") if nodes.nil?
     {
-      'pulls_with_reviews' => result
-        .dig('repository', 'pullRequests', 'nodes')
-        .filter_map do |pull|
-          next if pull.dig('timelineItems', 'nodes').empty?
-          {
-            'id' => pull['id'],
-            'number' => pull['number']
-          }
-        end,
+      'pulls_with_reviews' => nodes.filter_map do |pull|
+        next if pull.dig('timelineItems', 'nodes').empty?
+        {
+          'id' => pull['id'],
+          'number' => pull['number']
+        }
+      end,
       'has_next_page' => result.dig('repository', 'pullRequests', 'pageInfo', 'hasNextPage'),
       'next_cursor' => result.dig('repository', 'pullRequests', 'pageInfo', 'endCursor')
     }
@@ -349,11 +350,12 @@ class Fbe::Graph # rubocop:disable Metrics/ClassLength
   def pull_request_reviews(owner, name, pulls: [])
     requests =
       pulls.map do |number, cursor|
+        after = "after: \"#{cursor}\", " unless cursor.nil?
         <<~GRAPHQL
           pr_#{number}: pullRequest(number: #{number}) {
             id
             number
-            reviews(first: 100, after: "#{cursor}") {
+            reviews(#{after}first: 100) {
               nodes {
                 id
                 submittedAt

data/lib/fbe/iterate.rb

@@ -105,28 +105,27 @@ class Fbe::Iterate
     @timeout = true
   end
 
-  # Makes the iterator aware of GitHub API quota limits.
+  # Makes the iterator unaware of GitHub API quota limits.
   #
-  # When enabled, the iterator will check quota status before processing
-  # each repository and gracefully stop when the quota is exhausted.
-  # This prevents API errors and allows for resuming later.
+  # When disabled, the iterator will not check quota status before processing
+  # each repository and will not gracefully stop when the quota is exhausted.
   #
   # @return [nil] Nothing is returned
-  # @example Enable quota awareness
-  #   iterator.quota_aware
-  #   iterator.over { |repo, item| ... }  # Will stop if quota exhausted
+  # @example Disable quota awareness
+  #   iterator.quota_unaware
+  #   iterator.over { |repo, item| ... }  # Will not stop on quota exhaustion
   def quota_unaware
     @quota = false
   end
 
-  # Makes the iterator aware of lifetime limits.
+  # Makes the iterator unaware of lifetime limits.
   #
   # @return [nil] Nothing is returned
   def lifetime_unaware
     @lifetime = false
   end
 
-  # Makes the iterator aware of timeout limits.
+  # Makes the iterator unaware of timeout limits.
   #
   # @return [nil] Nothing is returned
   def timeout_unaware
@@ -313,7 +312,13 @@ class Fbe::Iterate
             @since
           else
             @loog.debug("Next is ##{nxt}, starting from it")
-            yield(repo, nxt)
+            begin
+              yield(repo, nxt)
+            rescue Fbe::OffQuota
+              raise
+            rescue StandardError => e
+              raise(e.class, "Failure in repository ##{repo} at ##{nxt}: #{e.message}")
+            end
           end
         unless before[repo].is_a?(Integer)
           raise(Fbe::Error, "Iterator must return an Integer, but #{before[repo].class} was returned")

data/lib/fbe/middleware/formatter.rb

@@ -39,6 +39,19 @@ require_relative '../../fbe/middleware'
 # Copyright:: Copyright (c) 2024-2026 Zerocracy
 # License:: MIT
 class Fbe::Middleware::Formatter < Faraday::Logging::Formatter
+  # Registers a filter that masks the credential portion of an
+  # `Authorization` header so live tokens never reach the log.
+  # Matches any auth scheme: `Authorization: "Bearer xxx"`,
+  # `Authorization: "Basic yyy"`, etc. The scheme is preserved,
+  # the credential is replaced with `[FILTERED]`.
+  #
+  # @param [Logger] logger The Faraday-supplied logger
+  # @param [Hash] options Faraday formatter options
+  def initialize(logger:, options:)
+    super
+    filter(/(Authorization:\s*"?\s*\S+\s+)[^"\s]+/i, '\1[FILTERED]')
+  end
+
   # Captures HTTP request details for later use in error logging.
   #
   # @param [Hash] http Request data including method, url, headers, and body

data/lib/fbe/regularly.rb

@@ -55,7 +55,7 @@ def Fbe.regularly(area, p_every_days, p_since_days = nil, fb: Fbe.fb, judge: $ju
     f.what = judge
     f.when = Time.now
     unless p_since_days.nil?
-      days = pmp.nil? ? 28 : pmp[p_since_days].first
+      days = pmp.nil? || pmp[p_since_days].nil? ? 28 : pmp[p_since_days].first
       since = Time.now - (days * 24 * 60 * 60)
       f.since = since
     end

data/lib/fbe.rb

@@ -9,6 +9,6 @@
 # Copyright:: Copyright (c) 2024-2026 Zerocracy
 # License:: MIT
 module Fbe
-  VERSION = '0.48.4' unless const_defined?(:VERSION)
+  VERSION = '0.48.5' unless const_defined?(:VERSION)
   class Error < StandardError; end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.48.4
+  version: 0.48.5
 platform: ruby
 authors:
 - Yegor Bugayenko