fbe 0.48.3 → 0.48.4

data/lib/fbe/award.rb

@@ -37,7 +37,7 @@ class Fbe::Award
   # @param [Judges::Options] options The options coming from the +judges+ tool
   # @param [Loog] loog The logging facility
   def initialize(query = nil, judge: $judge, global: $global, options: $options, loog: $loog)
-    query = Fbe.pmp(fb: Fbe.fb, global:, options:, loog:).hr.send(judge.tr('-', '_')) if query.nil?
+    query = Fbe.pmp(fb: Fbe.fb, global:, options:, loog:).hr.public_send(judge.tr('-', '_')) if query.nil?
     @query = query
   end
 
@@ -109,26 +109,26 @@ class Fbe::Award
         @operands.each do |o|
           o.bill_to(bill)
         rescue StandardError => e
-          raise "Failure in #{o}: #{e.message}"
+          raise(Fbe::Error, "Failure in #{o}: #{e.message}")
         end
       when :aka
         @operands[0..-2].each do |o|
           o.bill_to(bill)
         rescue StandardError => e
-          raise "Failure in #{o}: #{e.message}"
+          raise(Fbe::Error, "Failure in #{o}: #{e.message}")
         end
       when :let, :set
         v = to_val(@operands[1], bill)
-        raise "Can't #{@op.inspect} #{@operands[0].inspect} to nil" if v.nil?
+        raise(Fbe::Error, "Can't #{@op.inspect} #{@operands[0].inspect} to nil") if v.nil?
         bill.set(@operands[0], v)
       when :give
         text = @operands[1]
         text = '' if text.nil?
         bill.line(to_val(@operands[0], bill), text)
       when :explain, :in
-        # nothing, just ignore
+        nil
       else
-        raise "Unknown term '#{@op}'"
+        raise(Fbe::Error, "Unknown term '#{@op}'")
       end
     end
 
@@ -147,7 +147,7 @@ class Fbe::Award
         any.calc(bill)
       elsif any.is_a?(Symbol)
         v = bill.vars[any]
-        raise "Unknown name #{any.inspect} among: #{bill.vars.keys.map(&:inspect).joined}" if v.nil?
+        raise(Fbe::Error, "Unknown name #{any.inspect} among: #{bill.vars.keys.map(&:inspect).joined}") if v.nil?
         v
       else
         any
@@ -169,7 +169,7 @@ class Fbe::Award
     #   term = Factbase::Syntax.new('(times x y)').to_term
     #   term.redress!(Fbe::Award::BTerm)
     #   term.calc(bill) #=> 50
-    def calc(bill)
+    def calc(bill) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
       case @op
       when :total
         bill.points
@@ -211,23 +211,23 @@ class Fbe::Award
         return 0 if (!v.negative? && v < min) || (!v.positive? && v > max)
         v.clamp(min, max)
       else
-        raise "Unknown term '#{@op}'"
+        raise(Fbe::Error, "Unknown term '#{@op}'")
       end
     end
   end
 
   # A term for bylaw.
   module PTerm
-    def to_s
+    def to_s # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
       case @op
       when :total
         'total'
       when :if
         "if #{to_p(@operands[0])} then #{to_p(@operands[1])} else #{to_p(@operands[2])}"
       when :and
-        @operands.map(&:to_s).join(' and ')
+        @operands.join(' and ')
       when :or
-        @operands.map(&:to_s).join(' or ')
+        @operands.join(' or ')
       when :not
         "not #{@operands[0]}"
       when :eq
@@ -255,7 +255,7 @@ class Fbe::Award
       when :between
         "at least #{to_p(@operands[0])} and at most #{to_p(@operands[1])}"
       else
-        raise "Unknown term '#{@op}'"
+        raise(Fbe::Error, "Unknown term '#{@op}'")
       end
     end
 
@@ -273,16 +273,16 @@ class Fbe::Award
         @operands.each do |o|
           o.publish_to(bylaw)
         rescue StandardError => e
-          raise "Failure in #{o}: #{e.message}"
+          raise(Fbe::Error, "Failure in #{o}: #{e.message}")
         end
       when :aka
         @operands[0..-2].each do |o|
           o.publish_to(bylaw)
         rescue StandardError => e
-          raise "Failure in #{o}: #{e.message}"
+          raise(Fbe::Error, "Failure in #{o}: #{e.message}")
         end
         bylaw.revert(@operands.size - 1)
-        bylaw.line(to_p(@operands[@operands.size - 1]))
+        bylaw.line(to_p(@operands[-1]))
       when :explain
         bylaw.intro(to_p(@operands[0]))
       when :in
@@ -295,7 +295,7 @@ class Fbe::Award
       when :give
         bylaw.line("award #{to_p(@operands[0])}")
       else
-        raise "Unknown term '#{@op}'"
+        raise(Fbe::Error, "Unknown term '#{@op}'")
       end
     end
 
@@ -305,19 +305,8 @@ class Fbe::Award
         any.to_s
       when Symbol
         s = any.to_s
-        subs = {
-          0 => '₀',
-          1 => '₁',
-          2 => '₂',
-          3 => '₃',
-          4 => '₄',
-          5 => '₅',
-          6 => '₆',
-          7 => '₇',
-          8 => '₈',
-          9 => '₉'
-        }
-        s.gsub!(/([a-z]+)([0-9])/) { |_| "#{Regexp.last_match[1]}#{subs[Regexp.last_match[2].to_i]}" }
+        subs = { 0 => '₀', 1 => '₁', 2 => '₂', 3 => '₃', 4 => '₄', 5 => '₅', 6 => '₆', 7 => '₇', 8 => '₈', 9 => '₉' }
+        s.gsub!(/([a-z]+)([0-9])/) { |_| "#{Regexp.last_match[1]}#{subs[Integer(Regexp.last_match[2], 10)]}" }
         "_#{s.tr('_', '-')}_"
       when Integer, Float
         "**#{any}**"
@@ -333,7 +322,6 @@ class Fbe::Award
   # for each award component. It provides methods to calculate total points
   # and generate a human-readable summary of the rewards.
   class Bill
-    # @return [Hash] Variables set in this bill
     attr_reader :vars
 
     # Creates a new empty bill.
@@ -380,7 +368,7 @@ class Fbe::Award
     #   bill.line(42.5, "for answer")
     #   bill.points #=> 43
     def points
-      @lines.sum { |l| l[:v] }.to_f.round.to_i
+      Integer(Float(@lines.sum { |l| l[:v] }).round.to_s, 10)
     end
 
     # Generates a human-readable summary of the bill.
@@ -410,7 +398,6 @@ class Fbe::Award
   # introductions, calculation steps, and variable substitutions.
   # It produces Markdown-formatted output describing how awards are calculated.
   class Bylaw
-    # @return [Hash] Variables defined in this bylaw
     attr_reader :vars
 
     # Creates a new empty bylaw.

data/lib/fbe/bylaws.rb

@@ -36,15 +36,15 @@ require_relative '../fbe'
 #   bylaws['dud-was-punished']
 #   # => "award { -16 * anger }"
 def Fbe.bylaws(anger: 2, love: 2, paranoia: 2)
-  raise "The 'anger' must be in the [0..4] interval: #{anger.inspect}" unless !anger.negative? && anger < 5
-  raise "The 'love' must be in the [0..4] interval: #{love.inspect}" unless !love.negative? && love < 5
-  raise "The 'paranoia' must be in the [1..4] interval: #{paranoia.inspect}" unless paranoia.positive? && paranoia < 5
+  raise(Fbe::Error, "The 'anger' must be in the [0..4] interval: #{anger.inspect}") unless !anger.negative? && anger < 5
+  raise(Fbe::Error, "The 'love' must be in the [0..4] interval: #{love.inspect}") unless !love.negative? && love < 5
+  unless paranoia.positive? && paranoia < 5
+    raise(Fbe::Error, "The 'paranoia' must be in the [1..4] interval: #{paranoia.inspect}")
+  end
   home = File.join(__dir__, '../../assets/bylaws')
-  raise "The directory with templates is absent #{home.inspect}" unless File.exist?(home)
+  raise(Fbe::Error, "The directory with templates is absent #{home.inspect}") unless File.exist?(home)
   Dir[File.join(home, '*.fe.liquid')].to_h do |f|
-    formula = Liquid::Template.parse(File.read(f)).render(
-      'anger' => anger, 'love' => love, 'paranoia' => paranoia
-    )
+    formula = Liquid::Template.parse(File.read(f)).render('anger' => anger, 'love' => love, 'paranoia' => paranoia)
     [File.basename(f).gsub(/\.fe.liquid$/, ''), formula]
   end
 end

data/lib/fbe/conclude.rb

@@ -24,11 +24,11 @@ def Fbe.conclude(
   fb: Fbe.fb, judge: $judge, loog: $loog, options: $options, global: $global,
   epoch: $epoch || Time.now, kickoff: $kickoff || Time.now, &
 )
-  raise 'The fb is nil' if fb.nil?
-  raise 'The $judge is not set' if judge.nil?
-  raise 'The $global is not set' if global.nil?
-  raise 'The $options is not set' if options.nil?
-  raise 'The $loog is not set' if loog.nil?
+  raise(Fbe::Error, 'The fb is nil') if fb.nil?
+  raise(Fbe::Error, 'The $judge is not set') if judge.nil?
+  raise(Fbe::Error, 'The $global is not set') if global.nil?
+  raise(Fbe::Error, 'The $options is not set') if options.nil?
+  raise(Fbe::Error, 'The $loog is not set') if loog.nil?
   c = Fbe::Conclude.new(fb:, judge:, loog:, options:, global:, epoch:, kickoff:)
   c.instance_eval(&)
 end
@@ -76,9 +76,9 @@ class Fbe::Conclude
     @kickoff = kickoff
     @query = nil
     @follows = []
-    @lifetime_aware = true
-    @timeout_aware = true
-    @quota_aware = true
+    @lifetime = true
+    @timeout = true
+    @quota = true
   end
 
   # Make this block not aware of GitHub API quota.
@@ -88,7 +88,7 @@ class Fbe::Conclude
   #
   # @return [nil] Nothing is returned
   def quota_unaware
-    @quota_aware = false
+    @quota = false
   end
 
   # Make this block NOT aware of lifetime limitations.
@@ -97,7 +97,7 @@ class Fbe::Conclude
   #
   # @return [nil] Nothing is returned
   def lifetime_unaware
-    @lifetime_aware = false
+    @lifetime = false
   end
 
   # Make this block NOT aware of timeout limitations.
@@ -106,7 +106,7 @@ class Fbe::Conclude
   #
   # @return [nil] Nothing is returned
   def timeout_unaware
-    @timeout_aware = false
+    @timeout = false
   end
 
   # Set the query that should find the facts in the factbase.
@@ -114,7 +114,7 @@ class Fbe::Conclude
   # @param [String] query The query to execute
   # @return [nil] Nothing is returned
   def on(query)
-    raise 'Query is already set' unless @query.nil?
+    raise(Fbe::Error, 'Query is already set') unless @query.nil?
     @query = query
   end
 
@@ -170,7 +170,7 @@ class Fbe::Conclude
   # @return [Integer] The count of the facts processed
   def consider(&)
     roll do |_fbt, a|
-      yield a
+      yield(a)
       nil
     end
   end
@@ -198,16 +198,16 @@ class Fbe::Conclude
   def roll(&)
     return 0 if Fbe.over?(
       global: @global, options: @options, loog: @loog, epoch: @epoch, kickoff: @kickoff,
-      quota_aware: @quota_aware, lifetime_aware: @lifetime_aware, timeout_aware: @timeout_aware
+      quota_aware: @quota, lifetime_aware: @lifetime, timeout_aware: @timeout
     )
     passed = 0
     @fb.query(@query).each do |a|
       break if Fbe.over?(
         global: @global, options: @options, loog: @loog, epoch: @epoch, kickoff: @kickoff,
-        quota_aware: @quota_aware, lifetime_aware: @lifetime_aware, timeout_aware: @timeout_aware
+        quota_aware: @quota, lifetime_aware: @lifetime, timeout_aware: @timeout
       )
       @fb.txn do |fbt|
-        n = yield fbt, a
+        n = yield(fbt, a)
         @loog.info("#{n.what}: #{n.details}") unless n.nil?
       end
       passed += 1
@@ -242,10 +242,10 @@ class Fbe::Conclude
   #   end
   def fill(fact, prev)
     @follows.each do |follow|
-      v = prev.send(follow)
-      fact.send(:"#{follow}=", v)
+      v = prev.public_send(follow)
+      fact.public_send(:"#{follow}=", v)
     end
-    r = yield fact, prev
+    r = yield(fact, prev)
     return unless r.is_a?(String)
     fact.details = r
     fact.what = @judge

data/lib/fbe/consider.rb

@@ -25,7 +25,7 @@ def Fbe.consider(
   lifetime_aware: true, timeout_aware: true, &
 )
   Fbe.conclude(fb:, judge:, loog:, options:, global:, epoch:, kickoff:) do
-    on query
+    on(query)
     timeout_unaware unless timeout_aware
     lifetime_unaware unless lifetime_aware
     consider(&)

data/lib/fbe/copy.rb

@@ -24,15 +24,15 @@ require_relative 'fb'
 #   count = Fbe.copy(source, target, except: ['_time', '_id'])
 #   puts "Copied #{count} property values"
 def Fbe.copy(source, target, except: [])
-  raise 'The source is nil' if source.nil?
-  raise 'The target is nil' if target.nil?
-  raise 'The except is nil' if except.nil?
+  raise(Fbe::Error, 'The source is nil') if source.nil?
+  raise(Fbe::Error, 'The target is nil') if target.nil?
+  raise(Fbe::Error, 'The except is nil') if except.nil?
   copied = 0
   source.all_properties.each do |k|
     next unless target[k].nil?
     next if except.include?(k)
     source[k].each do |v|
-      target.send(:"#{k}=", v)
+      target.public_send(:"#{k}=", v)
       copied += 1
     end
   end

data/lib/fbe/delete.rb

@@ -23,10 +23,10 @@ require_relative 'fb'
 #   new_fact = Fbe.delete(fact, 'age', 'city')
 #   # new_fact will have all properties except 'age' and 'city'
 def Fbe.delete(fact, *props, fb: Fbe.fb, id: '_id')
-  raise 'The fact is nil' if fact.nil?
+  raise(Fbe::Error, 'The fact is nil') if fact.nil?
   return if props.all? { |k| fact[k].nil? }
   i = fact[id]
-  raise "There is no #{id.inspect} in the fact" if i.nil?
+  raise(Fbe::Error, "There is no #{id.inspect} in the fact") if i.nil?
   i = i.first
   before = {}
   fact.all_properties.each do |k|
@@ -40,7 +40,7 @@ def Fbe.delete(fact, *props, fb: Fbe.fb, id: '_id')
     before.each do |k, vv|
       next unless c[k].nil?
       vv.each do |v|
-        c.send(:"#{k}=", v)
+        c.public_send(:"#{k}=", v)
       end
     end
   end

data/lib/fbe/delete_one.rb

@@ -19,9 +19,9 @@ require_relative 'fb'
 # @param [String] id The property name used as unique identifier (defaults to '_id')
 # @return [nil] Nothing
 def Fbe.delete_one(fact, prop, value, fb: Fbe.fb, id: '_id')
-  raise 'The fact is nil' if fact.nil?
+  raise(Fbe::Error, 'The fact is nil') if fact.nil?
   i = fact[id]
-  raise "There is no #{id.inspect} in the fact" if i.nil?
+  raise(Fbe::Error, "There is no #{id.inspect} in the fact") if i.nil?
   i = i.first
   before = {}
   fact.all_properties.each do |k|
@@ -36,7 +36,7 @@ def Fbe.delete_one(fact, prop, value, fb: Fbe.fb, id: '_id')
     before.each do |k, vv|
       next unless c[k].nil?
       vv.each do |v|
-        c.send(:"#{k}=", v)
+        c.public_send(:"#{k}=", v)
       end
     end
   end

data/lib/fbe/enter.rb

@@ -26,11 +26,11 @@ require_relative '../fbe'
 #     validate_payment(data)
 #   end
 def Fbe.enter(badge, why, options: $options, loog: $loog, &)
-  raise 'The badge is nil' if badge.nil?
-  raise 'The why is nil' if why.nil?
-  raise 'The $options is not set' if options.nil?
-  raise 'The $loog is not set' if loog.nil?
+  raise(Fbe::Error, 'The badge is nil') if badge.nil?
+  raise(Fbe::Error, 'The why is nil') if why.nil?
+  raise(Fbe::Error, 'The $options is not set') if options.nil?
+  raise(Fbe::Error, 'The $loog is not set') if loog.nil?
   return yield unless options.testing.nil?
   baza = BazaRb.new('api.zerocracy.com', 443, options.zerocracy_token, loog:)
-  baza.enter(options.job_name, badge, why, options.job_id.to_i, &)
+  baza.enter(options.job_name, badge, why, options.job_id.nil? ? 0 : Integer(options.job_id.to_s, 10), &)
 end

data/lib/fbe/fb.rb

@@ -27,10 +27,10 @@ require_relative '../fbe'
 # @param [Loog] loog The logging facility
 # @return [Factbase] The global factbase
 def Fbe.fb(fb: $fb, global: $global, options: $options, loog: $loog)
-  raise 'The fb is nil' if fb.nil?
-  raise 'The $global is not set' if global.nil?
-  raise 'The $options is not set' if options.nil?
-  raise 'The $loog is not set' if loog.nil?
+  raise(Fbe::Error, 'The fb is nil') if fb.nil?
+  raise(Fbe::Error, 'The $global is not set') if global.nil?
+  raise(Fbe::Error, 'The $options is not set') if options.nil?
+  raise(Fbe::Error, 'The $loog is not set') if loog.nil?
   global[:fb] ||=
     begin
       rules = Dir.glob(File.join(File.join(__dir__, '../../rules'), '*.fe')).map { |f| File.read(f) }
@@ -44,12 +44,8 @@ def Fbe.fb(fb: $fb, global: $global, options: $options, loog: $loog)
           max = fbt.query('(max _id)').one
           f._id = (max.nil? ? 0 : max) + 1
           f._time = Time.now
-          f._version = [
-            Factbase::VERSION,
-            Judges::VERSION,
-            options.action_version
-          ].compact.join('/')
-          f._job = options.job_id.to_i if options.job_id
+          f._version = [Factbase::VERSION, Judges::VERSION, options.action_version].compact.join('/')
+          f._job = Integer(options.job_id.to_s, 10) if options.job_id
         end
       Factbase::Impatient.new(
         Factbase::Logged.new(

data/lib/fbe/github_graph.rb

@@ -29,7 +29,7 @@ end
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
 # Copyright:: Copyright (c) 2024-2026 Zerocracy
 # License:: MIT
-class Fbe::Graph
+class Fbe::Graph # rubocop:disable Metrics/ClassLength
   def initialize(token:, host: 'api.github.com')
     @token = token
     @host = host
@@ -85,9 +85,9 @@ class Fbe::Graph
         }
       GRAPHQL
     )
-    result&.to_h&.dig('repository', 'pullRequest', 'reviewThreads', 'nodes')&.select do |thread|
-      thread['isResolved']
-    end || []
+    nodes = result&.to_h&.dig('repository', 'pullRequest', 'reviewThreads', 'nodes')
+    return [] if nodes.nil?
+    nodes.select { |thread| thread['isResolved'] }
   end
 
   # Gets the total number of commits in a branch.
@@ -111,11 +111,13 @@ class Fbe::Graph
   #   puts result #=>
   #   [{"owner"=>"zerocracy", "name"=>"fbe", "branch"=>"master", "total_commits"=>754},
   #    {"owner"=>"zerocracy", "name"=>"judges-action", "branch"=>"master", "total_commits"=>2251}]
-  def total_commits(owner = nil, name = nil, branch = nil, repos: nil)
-    raise 'Need owner, name and branch or repos' if owner.nil? && name.nil? && branch.nil? && repos.nil?
-    raise 'Owner, name and branch is required' if (owner.nil? || name.nil? || branch.nil?) && repos.nil?
-    raise 'Repos list cannot be empty' if owner.nil? && name.nil? && branch.nil? && repos&.empty?
-    raise 'Need only owner, name and branch or repos' if (!owner.nil? || !name.nil? || !branch.nil?) && !repos.nil?
+  def total_commits(owner = nil, name = nil, branch = nil, repos: nil) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+    raise(Fbe::Error, 'Need owner, name and branch or repos') if owner.nil? && name.nil? && branch.nil? && repos.nil?
+    raise(Fbe::Error, 'Owner, name and branch is required') if (owner.nil? || name.nil? || branch.nil?) && repos.nil?
+    raise(Fbe::Error, 'Repos list cannot be empty') if owner.nil? && name.nil? && branch.nil? && repos&.empty?
+    if (!owner.nil? || !name.nil? || !branch.nil?) && !repos.nil?
+      raise(Fbe::Error, 'Need only owner, name and branch or repos')
+    end
     repos ||= [[owner, name, branch]]
     requests =
       repos.each_with_index.map do |(owner, name, branch), i|
@@ -136,12 +138,12 @@ class Fbe::Graph
     result = query("{\n#{requests.join("\n")}\n}")
     if owner && name && branch
       ref = result.repo_0&.ref
-      raise "Repository '#{owner}/#{name}' or branch '#{branch}' not found" unless ref&.target&.history
+      raise(Fbe::Error, "Repository '#{owner}/#{name}' or branch '#{branch}' not found") unless ref&.target&.history
       ref.target.history.total_count
     else
       repos.each_with_index.map do |(owner, name, branch), i|
-        ref = result.send(:"repo_#{i}")&.ref
-        raise "Repository '#{owner}/#{name}' or branch '#{branch}' not found" unless ref&.target&.history
+        ref = result.public_send(:"repo_#{i}")&.ref
+        raise(Fbe::Error, "Repository '#{owner}/#{name}' or branch '#{branch}' not found") unless ref&.target&.history
         {
           'owner' => owner,
           'name' => name,
@@ -230,7 +232,7 @@ class Fbe::Graph
     ).to_h
     return unless result['node']
     type = result.dig('node', '__typename')
-    prev_issue_type =
+    previous =
       if type == 'IssueTypeChangedEvent'
         {
           'id' => result.dig('node', 'prevIssueType', 'id'),
@@ -246,7 +248,7 @@ class Fbe::Graph
         'name' => result.dig('node', 'issueType', 'name'),
         'description' => result.dig('node', 'issueType', 'description')
       },
-      'prev_issue_type' => prev_issue_type,
+      'prev_issue_type' => previous,
       'actor' => {
         'login' => result.dig('node', 'actor', 'login'),
         'type' => result.dig('node', 'actor', '__typename'),
@@ -311,8 +313,8 @@ class Fbe::Graph
     {
       'pulls_with_reviews' => result
         .dig('repository', 'pullRequests', 'nodes')
-        .reject { _1.dig('timelineItems', 'nodes').empty? }
-        .map do |pull|
+        .filter_map do |pull|
+          next if pull.dig('timelineItems', 'nodes').empty?
           {
             'id' => pull['id'],
             'number' => pull['number']
@@ -579,11 +581,7 @@ class Fbe::Graph
     #   fake.resolved_conversations('zerocracy', 'baza', 42)
     #   # => [conversation data for zerocracy_baza]
     def resolved_conversations(owner, name, _number)
-      data = {
-        zerocracy_baza: [
-          conversation('PRRT_kwDOK2_4A85BHZAR')
-        ]
-      }
+      data = { zerocracy_baza: [conversation('PRRT_kwDOK2_4A85BHZAR')] }
       data[:"#{owner}_#{name}"] || []
     end
 
@@ -609,11 +607,13 @@ class Fbe::Graph
     # @param [String] branch Branch name
     # @param [Array<Array<String, String, String>>] repos List of owner, name, branch
     # @return [Integer, Array<Hash>] Returns 1484 for single repo or array of hashes
-    def total_commits(owner = nil, name = nil, branch = nil, repos: nil)
-      raise 'Need owner, name and branch or repos' if owner.nil? && name.nil? && branch.nil? && repos.nil?
-      raise 'Owner, name and branch is required' if (owner.nil? || name.nil? || branch.nil?) && repos.nil?
-      raise 'Repos list cannot be empty' if owner.nil? && name.nil? && branch.nil? && repos&.empty?
-      raise 'Need only owner, name and branch or repos' if (!owner.nil? || !name.nil? || !branch.nil?) && !repos.nil?
+    def total_commits(owner = nil, name = nil, branch = nil, repos: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      raise(Fbe::Error, 'Need owner, name and branch or repos') if owner.nil? && name.nil? && branch.nil? && repos.nil?
+      raise(Fbe::Error, 'Owner, name and branch is required') if (owner.nil? || name.nil? || branch.nil?) && repos.nil?
+      raise(Fbe::Error, 'Repos list cannot be empty') if owner.nil? && name.nil? && branch.nil? && repos&.empty?
+      if (!owner.nil? || !name.nil? || !branch.nil?) && !repos.nil?
+        raise(Fbe::Error, 'Need only owner, name and branch or repos')
+      end
       if owner && name && branch
         1484
       else

data/lib/fbe/if_absent.rb

@@ -54,14 +54,14 @@ def Fbe.if_absent(fb: Fbe.fb, always: false)
       if k.end_with?('=')
         k = k[0..-2].to_sym
         v = args[1]
-        raise "Can't set #{k} to nil" if v.nil?
-        raise "Can't set #{k} to empty string" if v.is_a?(String) && v.empty?
+        raise(Fbe::Error, "Can't set #{k} to nil") if v.nil?
+        raise(Fbe::Error, "Can't set #{k} to empty string") if v.is_a?(String) && v.empty?
         @map[k] = v
       else
         @map[k.to_sym]
       end
     end
-  yield f
+  yield(f)
   q = attrs.except('_id', '_time', '_version').map do |k, v|
     vv = v.to_s
     if v.is_a?(String)
@@ -76,6 +76,6 @@ def Fbe.if_absent(fb: Fbe.fb, always: false)
   return before if before && always
   return nil if before
   n = fb.insert
-  attrs.each { |k, v| n.send(:"#{k}=", v) }
+  attrs.each { |k, v| n.public_send(:"#{k}=", v) }
   n
 end

data/lib/fbe/issue.rb

@@ -28,15 +28,15 @@ require_relative 'octo'
 #   issue_fact.issue = 42               # Issue number
 #   puts Fbe.issue(issue_fact)  # => "zerocracy/fbe#42"
 def Fbe.issue(fact, options: $options, global: $global, loog: $loog)
-  raise 'The fact is nil' if fact.nil?
-  raise 'The $global is not set' if global.nil?
-  raise 'The $options is not set' if options.nil?
-  raise 'The $loog is not set' if loog.nil?
+  raise(Fbe::Error, 'The fact is nil') if fact.nil?
+  raise(Fbe::Error, 'The $global is not set') if global.nil?
+  raise(Fbe::Error, 'The $options is not set') if options.nil?
+  raise(Fbe::Error, 'The $loog is not set') if loog.nil?
   rid = fact['repository']
-  raise "There is no 'repository' property" if rid.nil?
-  rid = rid.first.to_i
+  raise(Fbe::Error, "There is no 'repository' property") if rid.nil?
+  rid = Integer(rid.first.to_s, 10)
   issue = fact['issue']
-  raise "There is no 'issue' property" if issue.nil?
-  issue = issue.first.to_i
+  raise(Fbe::Error, "There is no 'issue' property") if issue.nil?
+  issue = Integer(issue.first.to_s, 10)
   "#{Fbe.octo(global:, options:, loog:).repo_name_by_id(rid)}##{issue}"
 end