fbe 0.39.0 → 0.41.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bcdd3a7dc6452b707cd14157c1009b9b7a1f551f9ea66c5cc31c08849e87a2d3
-  data.tar.gz: 2d1b97f86162a5e853df3a19e8ba6c4f96f398c51c19aa5a2bab0ee036cba1b4
+  metadata.gz: 1e140ff5523bde9171719f3481941dfdf36b381696f313c98b7bb570b172ec49
+  data.tar.gz: a0fa3c06b03e0d0de48ab5e00e9d7985e933b68d174f0625b6a5b9388d2d980a
 SHA512:
-  metadata.gz: a8e6f7be8faebeaa3aa2ad93f809988ef7fba01265faa67da6bf0c292cf088f1a655305820b1a72570dcd2282a065a1f6570daa349c0ea26458beed96a3d0845
-  data.tar.gz: 4c2747bdf3bee54e7ecdf667db8d55f93323fc4448f1398753200b963404d5723e094f34064461787999456fa1316a551f470890dc7c6569310f28ccd8338c68
+  metadata.gz: a1fdf1f6e32990d2f34dd33337b4b6f73f0e423092c09834bce6d216746d5c387eb61befa3786c907a84c37e75dd00a0058ff8816b4b7ddc9de09ed166564e55
+  data.tar.gz: 5b7a3331b84db4c7b2b36b700e132987be7dd235b86b97ee7f3d4032a43b30d0bdf0d7a907700726bf7ca8fafcd13fb35e03c895f35b0e32964e57064c2d1a57

data/.github/workflows/reuse.yml

@@ -16,4 +16,4 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v5
-      - uses: fsfe/reuse-action@v5
+      - uses: fsfe/reuse-action@v6

data/.github/workflows/typos.yml

@@ -16,6 +16,6 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v5
-      - uses: crate-ci/typos@v1.36.3
+      - uses: crate-ci/typos@v1.37.2
         with:
           config: .github/.typos.toml

data/lib/fbe/conclude.rb

@@ -8,6 +8,7 @@ require_relative '../fbe'
 require_relative 'fb'
 require_relative 'if_absent'
 require_relative 'octo'
+require_relative 'over'
 
 # Creates an instance of {Fbe::Conclude} and evals it with the block provided.
 #
@@ -195,29 +196,16 @@ class Fbe::Conclude
   #     end
   #   end
   def roll(&)
-    if @lifetime_aware && @options.lifetime && Time.now - @epoch > @options.lifetime * 0.9
-      @loog.debug("We ran out of lifetime (#{@epoch.ago} already), can't even start")
-      return
-    end
-    if @timeout_aware && @options.timeout && Time.now - @kickoff > @options.timeout * 0.9
-      @loog.debug("We've spent more than #{@kickoff.ago}, won't even start")
-      return
-    end
+    return 0 if Fbe.over?(
+      global: @global, options: @options, loog: @loog, epoch: @epoch, kickoff: @kickoff,
+      quota_aware: @quota_aware, lifetime_aware: @lifetime_aware, timeout_aware: @timeout_aware
+    )
     passed = 0
-    oct = Fbe.octo(loog: @loog, options: @options, global: @global)
     @fb.query(@query).each do |a|
-      if @quota_aware && oct.off_quota?
-        @loog.info('We ran out of GitHub quota, must stop here')
-        break
-      end
-      if @lifetime_aware && @options.lifetime && Time.now - @epoch > @options.lifetime * 0.9
-        @loog.debug("We ran out of lifetime (#{@epoch.ago} already), must stop here")
-        break
-      end
-      if @timeout_aware && @options.timeout && Time.now - @kickoff > @options.timeout * 0.9
-        @loog.debug("We've spent more than #{@kickoff.ago}, must stop here")
-        break
-      end
+      break if Fbe.over?(
+        global: @global, options: @options, loog: @loog, epoch: @epoch, kickoff: @kickoff,
+        quota_aware: @quota_aware, lifetime_aware: @lifetime_aware, timeout_aware: @timeout_aware
+      )
       @fb.txn do |fbt|
         n = yield fbt, a
         @loog.info("#{n.what}: #{n.details}") unless n.nil?
@@ -226,6 +214,9 @@ class Fbe::Conclude
     end
     @loog.debug("Found and processed #{passed} facts by: #{@query}")
     passed
+  rescue Fbe::OffQuota => e
+    @loog.info(e.message)
+    passed
   end
 
   # Populates a new fact based on a previous fact and a processing block.

data/lib/fbe/github_graph.rb

@@ -232,6 +232,132 @@ class Fbe::Graph
     }
   end
 
+  # Get pulls id and number with review from since
+  #
+  # @param [String] owner The repository owner (username or organization)
+  # @param [String] name The repository name
+  # @param [Time] since The datetime from
+  # @param [String, nil] cursor Github cursor for next page
+  # @return [Hash] A hash with pulls
+  # @example
+  #   graph = Fbe::Graph.new(token: 'github_token')
+  #   cursor = nil
+  #   pulls = []
+  #   loop do
+  #     json = graph.pull_requests_with_reviews(
+  #       'zerocracy', 'judges-action', Time.parse('2025-08-01T18:00:00Z'), cursor:
+  #     )
+  #     json['pulls_with_reviews'].each do |p|
+  #       pulls.push(p['number'])
+  #     end
+  #     break unless json['has_next_page']
+  #     cursor = json['next_cursor']
+  #   end
+  def pull_requests_with_reviews(owner, name, since, cursor: nil)
+    result = query(
+      <<~GRAPHQL
+        {
+          repository(owner: "#{owner}", name: "#{name}") {
+            pullRequests(first: 100, after: "#{cursor}") {
+              nodes {
+                id
+                number
+                timelineItems(first: 1, itemTypes: [PULL_REQUEST_REVIEW], since: "#{since.utc.iso8601}") {
+                  nodes {
+                    ... on PullRequestReview { id }
+                  }
+                }
+              }
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
+            }
+          }
+        }
+      GRAPHQL
+    ).to_h
+    {
+      'pulls_with_reviews' => result
+        .dig('repository', 'pullRequests', 'nodes')
+        .reject { _1.dig('timelineItems', 'nodes').empty? }
+        .map do |pull|
+          {
+            'id' => pull['id'],
+            'number' => pull['number']
+          }
+        end,
+      'has_next_page' => result.dig('repository', 'pullRequests', 'pageInfo', 'hasNextPage'),
+      'next_cursor' => result.dig('repository', 'pullRequests', 'pageInfo', 'endCursor')
+    }
+  end
+
+  # Get reviews by pull numbers
+  #
+  # @param [String] owner The repository owner (username or organization)
+  # @param [String] name The repository name
+  # @param [Array<Array<Integer, (String, nil)>>] pulls Array of pull number and Github cursor
+  # @return [Hash] A hash with reviews
+  # @example
+  #   graph = Fbe::Graph.new(token: 'github_token')
+  #   queue = [[1108, nil], [1105, nil]]
+  #   until queue.empty?
+  #     pulls = graph.pull_request_reviews('zerocracy', 'judges-action', pulls: queue.shift(10))
+  #     pulls.each do |pull|
+  #       puts pull['id'], pull['number']
+  #       pull['reviews'].each do |r|
+  #         puts r['id'], r['submitted_at']
+  #       end
+  #     end
+  #     pulls.select { _1['reviews_has_next_page'] }.each do |p|
+  #       queue.push([p['number'], p['reviews_next_cursor']])
+  #     end
+  #   end
+  def pull_request_reviews(owner, name, pulls: [])
+    requests =
+      pulls.map do |number, cursor|
+        <<~GRAPHQL
+          pr_#{number}: pullRequest(number: #{number}) {
+            id
+            number
+            reviews(first: 100, after: "#{cursor}") {
+              nodes {
+                id
+                submittedAt
+              }
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
+            }
+          }
+        GRAPHQL
+      end
+    result = query(
+      <<~GRAPHQL
+        {
+          repository(owner: "#{owner}", name: "#{name}") {
+            #{requests.join("\n")}
+          }
+        }
+      GRAPHQL
+    ).to_h
+    result['repository'].map do |_k, v|
+      {
+        'id' => v['id'],
+        'number' => v['number'],
+        'reviews' => v.dig('reviews', 'nodes').map do |r|
+          {
+            'id' => r['id'],
+            'submitted_at' => Time.parse(r['submittedAt'])
+          }
+        end,
+        'reviews_has_next_page' => v.dig('reviews', 'pageInfo', 'hasNextPage'),
+        'reviews_next_cursor' => v.dig('reviews', 'pageInfo', 'endCursor')
+      }
+    end
+  end
+
   private
 
   # Creates or returns a cached GraphQL client instance.
@@ -403,6 +529,47 @@ class Fbe::Graph
       end
     end
 
+    def pull_requests_with_reviews(_owner, _name, _since, **)
+      {
+        'pulls_with_reviews' => [
+          { 'id' => 'PR_kwDOL6J6Ss6iprCx', 'number' => 2 },
+          { 'id' => 'PR_kwDOL6J6Ss6rhJ7T', 'number' => 5 },
+          { 'id' => 'PR_kwDOL6J6Ss6r13fG', 'number' => 21 }
+        ],
+        'has_next_page' => false,
+        'next_cursor' => 'Y3Vyc29yOnYyOpHOdh_xUw=='
+      }
+    end
+
+    def pull_request_reviews(_owner, _name, **)
+      [
+        {
+          'id' => 'PR_kwDOL6J6Ss6iprCx',
+          'number' => 2,
+          'reviews' => [
+            { 'id' => 'PRR_kwDOL6J6Ss647NCl', 'submitted_at' => Time.parse('2025-10-02 12:58:42 UTC') },
+            { 'id' => 'PRR_kwDOL6J6Ss647NC8', 'submitted_at' => Time.parse('2025-10-02 15:58:42 UTC') }
+          ],
+          'reviews_has_next_page' => false,
+          'reviews_next_cursor' => 'yc29yOnYyO1'
+        },
+        {
+          'id' => 'PR_kwDOL6J6Ss6rhJ7T',
+          'number' => 5,
+          'reviews' => [{ 'id' => 'PRR_kwDOL6J6Ss64_mnn', 'submitted_at' => Time.parse('2025-10-03 15:58:42 UTC') }],
+          'reviews_has_next_page' => false,
+          'reviews_next_cursor' => 'yc29yOnYyO2'
+        },
+        {
+          'id' => 'PR_kwDOL6J6Ss6r13fG',
+          'number' => 21,
+          'reviews' => [{ 'id' => 'PRR_kwDOL6J6Ss65AbIA', 'submitted_at' => Time.parse('2025-10-04 15:58:42 UTC') }],
+          'reviews_has_next_page' => false,
+          'reviews_next_cursor' => 'yc29yOnYyO3'
+        }
+      ]
+    end
+
     private
 
     # Generates mock conversation thread data.

data/lib/fbe/iterate.rb

@@ -10,6 +10,7 @@ require_relative '../fbe'
 require_relative 'fb'
 require_relative 'if_absent'
 require_relative 'octo'
+require_relative 'over'
 require_relative 'overwrite'
 require_relative 'unmask_repos'
 
@@ -249,6 +250,7 @@ class Fbe::Iterate
     repos = Fbe.unmask_repos(
       loog: @loog, options: @options, global: @global, quota_aware: @quota_aware
     ).map { |n| oct.repo_id_by_name(n) }
+    started = Time.now
     restarted = []
     before =
       repos.to_h do |repo|
@@ -266,29 +268,19 @@ class Fbe::Iterate
     starts = before.dup
     values = {}
     loop do
-      if @quota_aware && oct.off_quota?
-        @loog.info("We are off GitHub quota, time to stop after #{started.ago}")
-        break
-      end
-      if @lifetime_aware && @options.lifetime && Time.now - @epoch > @options.lifetime * 0.9
-        @loog.debug("We ran out of lifetime (#{@epoch.ago} already), must stop here")
-        break
-      end
-      if @timeout_aware && @options.timeout && Time.now - @kickoff > @options.timeout * 0.9
-        @loog.debug("We've spent more than #{@kickoff.ago}, must stop here")
+      if Fbe.over?(
+        global: @global, options: @options, loog: @loog, epoch: @epoch, kickoff: @kickoff,
+        quota_aware: @quota_aware, lifetime_aware: @lifetime_aware, timeout_aware: @timeout_aware
+      )
+        @loog.info("Time to stop after #{started.ago}")
         break
       end
       repos.each do |repo|
-        if @quota_aware && oct.off_quota?
-          @loog.info("We are off GitHub quota, we must skip #{repo}")
-          break
-        end
-        if @lifetime_aware && @options.lifetime && Time.now - @epoch > @options.lifetime * 0.9
-          @loog.info("We are working for #{@epoch.ago} already, won't check repository ##{repo}")
-          next
-        end
-        if @timeout_aware && @options.timeout && Time.now - @kickoff > @options.timeout * 0.9
-          @loog.debug("We've spent more than #{@kickoff.ago}, won't check repository ##{repo}")
+        if Fbe.over?(
+          global: @global, options: @options, loog: @loog, epoch: @epoch, kickoff: @kickoff,
+          quota_aware: @quota_aware, lifetime_aware: @lifetime_aware, timeout_aware: @timeout_aware
+        )
+          @loog.info("Won't check repository ##{repo}")
           break
         end
         next if restarted.include?(repo)
@@ -334,16 +326,21 @@ class Fbe::Iterate
         break
       end
     end
-    repos.each do |repo|
-      next if before[repo] == starts[repo]
-      f =
-        Fbe.if_absent(fb: @fb, always: true) do |n|
-          n.what = 'iterate'
-          n.where = 'github'
-          n.repository = repo
-        end
-      Fbe.overwrite(f, @label, before[repo], fb: @fb)
-    end
     @loog.debug("Finished scanning #{repos.size} repos in #{@kickoff.ago}: #{seen.map { |k, v| "#{k}:#{v}" }.joined}")
+  rescue Fbe::OffQuota => e
+    @loog.info(e.message)
+  ensure
+    if defined?(repos) && defined?(before) && defined?(starts)
+      repos.each do |repo|
+        next if before[repo] == starts[repo]
+        f =
+          Fbe.if_absent(fb: @fb, always: true) do |n|
+            n.what = 'iterate'
+            n.where = 'github'
+            n.repository = repo
+          end
+        Fbe.overwrite(f, @label, before[repo], fb: @fb)
+      end
+    end
   end
 end

data/lib/fbe/octo.rb

@@ -24,6 +24,9 @@ require_relative 'middleware/rate_limit'
 require_relative 'middleware/sqlite_store'
 require_relative 'middleware/trace'
 
+# When we are off quota.
+class Fbe::OffQuota < StandardError; end
+
 # Makes a call to the GitHub API.
 #
 # It is supposed to be used instead of +Octokit::Client+, because it
@@ -221,7 +224,7 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
       o =
         intercepted(o) do |e, m, _args, _r|
           if e == :before && m != :off_quota? && m != :print_trace! && m != :rate_limit && o.off_quota?
-            raise "We are off-quota (remaining: #{o.rate_limit.remaining}), can't do #{m}()"
+            raise Fbe::OffQuota, "We are off-quota (remaining: #{o.rate_limit.remaining}), can't do #{m}()"
           end
         end
       o

data/lib/fbe/over.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+# SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
+# SPDX-License-Identifier: MIT
+
+require_relative '../fbe'
+require_relative 'octo'
+
+# Check GitHub API quota, lifetime, and timeout.
+#
+# @param [Hash] global Hash of global options
+# @param [Judges::Options] options The options available globally
+# @param [Loog] loog Logging facility
+# @param [Time] epoch When the entire update started
+# @param [Time] kickoff When the particular judge started
+# @param [Boolean] quota_aware Enable or disable check of GitHub API quota
+# @param [Boolean] lifetime_aware Enable or disable check of lifetime limitations
+# @param [Boolean] timeout_aware Enable or disable check of timeout limitations
+# @return [Boolean] check result
+def Fbe.over?(
+  global: $global, options: $options, loog: $loog,
+  epoch: $epoch || Time.now, kickoff: $kickoff || Time.now,
+  quota_aware: true, lifetime_aware: true, timeout_aware: true
+)
+  if quota_aware && Fbe.octo(loog:, options:, global:).off_quota?(threshold: 100)
+    loog.info('We are off GitHub quota, time to stop')
+    return true
+  end
+  if lifetime_aware && options.lifetime && Time.now - epoch > options.lifetime * 0.9
+    loog.info("We ran out of lifetime (#{epoch.ago} already), must stop here")
+    return true
+  end
+  if timeout_aware && options.timeout && Time.now - kickoff > options.timeout * 0.9
+    loog.info("We've spent more than #{kickoff.ago}, must stop here")
+    return true
+  end
+  false
+end

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.39.0' unless const_defined?(:VERSION)
+  VERSION = '0.41.0' unless const_defined?(:VERSION)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.39.0
+  version: 0.41.0
 platform: ruby
 authors:
 - Yegor Bugayenko
@@ -384,6 +384,7 @@ files:
 - lib/fbe/middleware/sqlite_store.rb
 - lib/fbe/middleware/trace.rb
 - lib/fbe/octo.rb
+- lib/fbe/over.rb
 - lib/fbe/overwrite.rb
 - lib/fbe/pmp.rb
 - lib/fbe/regularly.rb