fbe 0.38.2 → 0.40.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84ae98aaec66eaacc0865c0be05fc5490305a5e723c402c66eabc65d9d5490f2
-  data.tar.gz: 4d3922a6dbfd4b04d8ac2eda2a155fda33ddc3e2c71886c0b99d61558830ff26
+  metadata.gz: d19c0535556f2bc17f04be6cd25be80552d3016e22d1abc52ad867425e29cd31
+  data.tar.gz: 9a9dc13820984a088462dae32ce4b1c3adeb236290770a56529ee9aa1308405e
 SHA512:
-  metadata.gz: 15d6d7d1b03ebe56d06fef55c9981ccd6a97c5c072bbf54a81e87c9841323659af82124b6e968e2a4d9d1495672830249c8b66a7273f8411b56a7d6b85f9b0a5
-  data.tar.gz: 79b5bd15396e2bed6317b1f202cd07f302c8a0db674165fafa1796da2119c0e22e2d218211106f4d6438b1aaa7012f1f102f80f59250908481876a00ebc6b956
+  metadata.gz: d81b8b123cd43763746e53d02f62b9f2430fb9ab0a21e70d4f6250ca499ac5a3fc59775ddfbd37138fadcc8c7d51f0cc8a724e4923c3c9837deecd022d3c789b
+  data.tar.gz: 63e1fd591916726362b7fdc68c2153f57f3e2a22c5db01b4d280262d6dd3fbbf86b573bc612c2e4c3fb51b8e0211f7c89e910f0b85bdb59bf1edfa4913f3e7ab

data/.github/workflows/typos.yml

@@ -16,6 +16,6 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v5
-      - uses: crate-ci/typos@v1.36.2
+      - uses: crate-ci/typos@v1.37.2
         with:
           config: .github/.typos.toml

data/Gemfile.lock

@@ -87,7 +87,7 @@ GEM
       others (~> 0.1)
       tago (~> 0.1)
       yaml (~> 0.3)
-    faraday (2.13.4)
+    faraday (2.14.0)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger
@@ -189,7 +189,7 @@ GEM
     regexp_parser (2.11.3)
     retries (0.0.5)
     rexml (3.4.4)
-    rubocop (1.80.2)
+    rubocop (1.81.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -197,7 +197,7 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.46.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.47.1)

data/lib/fbe/conclude.rb

@@ -206,7 +206,7 @@ class Fbe::Conclude
     passed = 0
     oct = Fbe.octo(loog: @loog, options: @options, global: @global)
     @fb.query(@query).each do |a|
-      if @quota_aware && oct.off_quota?
+      if @quota_aware && oct.off_quota?(threshold: 100)
         @loog.info('We ran out of GitHub quota, must stop here')
         break
       end

data/lib/fbe/github_graph.rb

@@ -232,6 +232,132 @@ class Fbe::Graph
     }
   end
 
+  # Get pulls id and number with review from since
+  #
+  # @param [String] owner The repository owner (username or organization)
+  # @param [String] name The repository name
+  # @param [Time] since The datetime from
+  # @param [String, nil] cursor Github cursor for next page
+  # @return [Hash] A hash with pulls
+  # @example
+  #   graph = Fbe::Graph.new(token: 'github_token')
+  #   cursor = nil
+  #   pulls = []
+  #   loop do
+  #     json = graph.pull_requests_with_reviews(
+  #       'zerocracy', 'judges-action', Time.parse('2025-08-01T18:00:00Z'), cursor:
+  #     )
+  #     json['pulls_with_reviews'].each do |p|
+  #       pulls.push(p['number'])
+  #     end
+  #     break unless json['has_next_page']
+  #     cursor = json['next_cursor']
+  #   end
+  def pull_requests_with_reviews(owner, name, since, cursor: nil)
+    result = query(
+      <<~GRAPHQL
+        {
+          repository(owner: "#{owner}", name: "#{name}") {
+            pullRequests(first: 100, after: "#{cursor}") {
+              nodes {
+                id
+                number
+                timelineItems(first: 1, itemTypes: [PULL_REQUEST_REVIEW], since: "#{since.utc.iso8601}") {
+                  nodes {
+                    ... on PullRequestReview { id }
+                  }
+                }
+              }
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
+            }
+          }
+        }
+      GRAPHQL
+    ).to_h
+    {
+      'pulls_with_reviews' => result
+        .dig('repository', 'pullRequests', 'nodes')
+        .reject { _1.dig('timelineItems', 'nodes').empty? }
+        .map do |pull|
+          {
+            'id' => pull['id'],
+            'number' => pull['number']
+          }
+        end,
+      'has_next_page' => result.dig('repository', 'pullRequests', 'pageInfo', 'hasNextPage'),
+      'next_cursor' => result.dig('repository', 'pullRequests', 'pageInfo', 'endCursor')
+    }
+  end
+
+  # Get reviews by pull numbers
+  #
+  # @param [String] owner The repository owner (username or organization)
+  # @param [String] name The repository name
+  # @param [Array<Array<Integer, (String, nil)>>] pulls Array of pull number and Github cursor
+  # @return [Hash] A hash with reviews
+  # @example
+  #   graph = Fbe::Graph.new(token: 'github_token')
+  #   queue = [[1108, nil], [1105, nil]]
+  #   until queue.empty?
+  #     pulls = graph.pull_request_reviews('zerocracy', 'judges-action', pulls: queue.shift(10))
+  #     pulls.each do |pull|
+  #       puts pull['id'], pull['number']
+  #       pull['reviews'].each do |r|
+  #         puts r['id'], r['submitted_at']
+  #       end
+  #     end
+  #     pulls.select { _1['reviews_has_next_page'] }.each do |p|
+  #       queue.push([p['number'], p['reviews_next_cursor']])
+  #     end
+  #   end
+  def pull_request_reviews(owner, name, pulls: [])
+    requests =
+      pulls.map do |number, cursor|
+        <<~GRAPHQL
+          pr_#{number}: pullRequest(number: #{number}) {
+            id
+            number
+            reviews(first: 100, after: "#{cursor}") {
+              nodes {
+                id
+                submittedAt
+              }
+              pageInfo {
+                hasNextPage
+                endCursor
+              }
+            }
+          }
+        GRAPHQL
+      end
+    result = query(
+      <<~GRAPHQL
+        {
+          repository(owner: "#{owner}", name: "#{name}") {
+            #{requests.join("\n")}
+          }
+        }
+      GRAPHQL
+    ).to_h
+    result['repository'].map do |_k, v|
+      {
+        'id' => v['id'],
+        'number' => v['number'],
+        'reviews' => v.dig('reviews', 'nodes').map do |r|
+          {
+            'id' => r['id'],
+            'submitted_at' => Time.parse(r['submittedAt'])
+          }
+        end,
+        'reviews_has_next_page' => v.dig('reviews', 'pageInfo', 'hasNextPage'),
+        'reviews_next_cursor' => v.dig('reviews', 'pageInfo', 'endCursor')
+      }
+    end
+  end
+
   private
 
   # Creates or returns a cached GraphQL client instance.
@@ -403,6 +529,47 @@ class Fbe::Graph
       end
     end
 
+    def pull_requests_with_reviews(_owner, _name, _since, **)
+      {
+        'pulls_with_reviews' => [
+          { 'id' => 'PR_kwDOL6J6Ss6iprCx', 'number' => 2 },
+          { 'id' => 'PR_kwDOL6J6Ss6rhJ7T', 'number' => 5 },
+          { 'id' => 'PR_kwDOL6J6Ss6r13fG', 'number' => 21 }
+        ],
+        'has_next_page' => false,
+        'next_cursor' => 'Y3Vyc29yOnYyOpHOdh_xUw=='
+      }
+    end
+
+    def pull_request_reviews(_owner, _name, **)
+      [
+        {
+          'id' => 'PR_kwDOL6J6Ss6iprCx',
+          'number' => 2,
+          'reviews' => [
+            { 'id' => 'PRR_kwDOL6J6Ss647NCl', 'submitted_at' => Time.parse('2025-10-02 12:58:42 UTC') },
+            { 'id' => 'PRR_kwDOL6J6Ss647NC8', 'submitted_at' => Time.parse('2025-10-02 15:58:42 UTC') }
+          ],
+          'reviews_has_next_page' => false,
+          'reviews_next_cursor' => 'yc29yOnYyO1'
+        },
+        {
+          'id' => 'PR_kwDOL6J6Ss6rhJ7T',
+          'number' => 5,
+          'reviews' => [{ 'id' => 'PRR_kwDOL6J6Ss64_mnn', 'submitted_at' => Time.parse('2025-10-03 15:58:42 UTC') }],
+          'reviews_has_next_page' => false,
+          'reviews_next_cursor' => 'yc29yOnYyO2'
+        },
+        {
+          'id' => 'PR_kwDOL6J6Ss6r13fG',
+          'number' => 21,
+          'reviews' => [{ 'id' => 'PRR_kwDOL6J6Ss65AbIA', 'submitted_at' => Time.parse('2025-10-04 15:58:42 UTC') }],
+          'reviews_has_next_page' => false,
+          'reviews_next_cursor' => 'yc29yOnYyO3'
+        }
+      ]
+    end
+
     private
 
     # Generates mock conversation thread data.

data/lib/fbe/iterate.rb

@@ -97,6 +97,7 @@ class Fbe::Iterate
     @label = nil
     @since = 0
     @query = nil
+    @sort_by = nil
     @repeats = 1
     @quota_aware = true
     @lifetime_aware = true
@@ -164,6 +165,24 @@ class Fbe::Iterate
     @query = query
   end
 
+  # Sets the field to sort results by in ascending order.
+  #
+  # When set, all matching results will be fetched, sorted by the specified
+  # field, and iterated in order. This executes the query once per repository
+  # instead of calling one() repeatedly.
+  #
+  # @param [String] prop The fact attribute to sort by
+  # @return [nil] Nothing is returned
+  # @raise [RuntimeError] If prop is nil, already set, or not a valid field name
+  # @example Sort issues by number
+  #   iterator.sort_by('issue')
+  def sort_by(prop)
+    raise 'Sort field is already set' unless @sort_by.nil?
+    raise 'Cannot set sort field to nil' if prop.nil?
+    raise 'Sort field must be a String' unless prop.is_a?(String)
+    @sort_by = prop
+  end
+
   # Sets the label for tracking iteration state.
   #
   # The label is used to create marker facts in the factbase that track
@@ -230,6 +249,7 @@ class Fbe::Iterate
     repos = Fbe.unmask_repos(
       loog: @loog, options: @options, global: @global, quota_aware: @quota_aware
     ).map { |n| oct.repo_id_by_name(n) }
+    started = Time.now
     restarted = []
     before =
       repos.to_h do |repo|
@@ -245,8 +265,9 @@ class Fbe::Iterate
         ]
       end
     starts = before.dup
+    values = {}
     loop do
-      if @quota_aware && oct.off_quota?
+      if @quota_aware && oct.off_quota?(threshold: 100)
         @loog.info("We are off GitHub quota, time to stop after #{started.ago}")
         break
       end
@@ -259,7 +280,7 @@ class Fbe::Iterate
         break
       end
       repos.each do |repo|
-        if @quota_aware && oct.off_quota?
+        if @quota_aware && oct.off_quota?(threshold: 100)
           @loog.info("We are off GitHub quota, we must skip #{repo}")
           break
         end
@@ -277,11 +298,24 @@ class Fbe::Iterate
           @loog.debug("We've seen too many (#{seen[repo]}) in #{repo}, let's see next one")
           next
         end
-        nxt = @fb.query(@query).one(@fb, before: before[repo], repository: repo)
+        nxt =
+          if @sort_by
+            values[repo] ||= @fb.query(@query).each(
+              @fb, before: before[repo], repository: repo
+            ).map { _1[@sort_by]&.first }.compact.sort.each
+            begin
+              values[repo].next
+            rescue StopIteration
+              nil
+            end
+          else
+            @fb.query(@query).one(@fb, before: before[repo], repository: repo)
+          end
         before[repo] =
           if nxt.nil?
             @loog.debug("Next element after ##{before[repo]} not suggested, re-starting from ##{@since}: #{@query}")
             restarted << repo
+            values.delete(repo) if @sort_by
             @since
           else
             @loog.debug("Next is ##{nxt}, starting from it")

data/lib/fbe/octo.rb

@@ -24,6 +24,9 @@ require_relative 'middleware/rate_limit'
 require_relative 'middleware/sqlite_store'
 require_relative 'middleware/trace'
 
+# When we are off quota.
+class Fbe::OffQuota < StandardError; end
+
 # Makes a call to the GitHub API.
 #
 # It is supposed to be used instead of +Octokit::Client+, because it
@@ -221,7 +224,7 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
       o =
         intercepted(o) do |e, m, _args, _r|
           if e == :before && m != :off_quota? && m != :print_trace! && m != :rate_limit && o.off_quota?
-            raise "We are off-quota (remaining: #{o.rate_limit.remaining}), can't do #{m}()"
+            raise Fbe::OffQuota, "We are off-quota (remaining: #{o.rate_limit.remaining}), can't do #{m}()"
           end
         end
       o

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.38.2' unless const_defined?(:VERSION)
+  VERSION = '0.40.0' unless const_defined?(:VERSION)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.38.2
+  version: 0.40.0
 platform: ruby
 authors:
 - Yegor Bugayenko