fbe 0.26.7 → 0.26.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe68814ff3c4dcb4e73fb8e6a868ce29c06e25f361ff5587565bf9b7802d4bea
-  data.tar.gz: c874b5e1e83ed8513251bd0e274942438012a43507d02cda8adf3b2369ab532f
+  metadata.gz: 8b08046f15653d392c8a4441ea55cffb0d36838b192bf0a8147bf4237e157e15
+  data.tar.gz: d70f364d33b36740908a990a9339e366720d688ab86c637f6559af3ee5589454
 SHA512:
-  metadata.gz: 9360815bab88ae494cfbafcbb10ba177dead193666d155163ddbab94351dddd4d302c53ffbea74f55d669dfe5fb5ee88c1ee58abeac0f9c94ac58756abee6d58
-  data.tar.gz: 78f4ff0c72c5a957b58948e223bd86ed6878a693e9f53f5ea6b3673cc7bfcad947a017ca510dd426cfe0c376ed771ad97ed83a0ecbbee79ce3e3247e11779376
+  metadata.gz: 41ecad63a09077b376321f026f46b84e963baf211b7b0fc896f64e635c23f15a0fc939e63621f1654fb89ec37c58df203b45fa8030a4148b6e8a59af8d8958f4
+  data.tar.gz: 2212f426f77a2ddcd52a35f17dcc01bd38cba9fb78b73e7cafd0e20ffc69d53da282e67d1c5223d0797d21d31319373249377d1761a4b9c98c9604606ce15f63

data/.github/workflows/typos.yml

@@ -16,6 +16,6 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
-      - uses: crate-ci/typos@v1.35.2
+      - uses: crate-ci/typos@v1.35.3
         with:
           config: .github/.typos.toml

data/lib/fbe/delete.rb

@@ -16,7 +16,7 @@ require_relative 'fb'
 # @param [Array<String>] props List of property names to delete
 # @param [Factbase] fb The factbase to use (defaults to Fbe.fb)
 # @param [String] id The property name used as unique identifier (defaults to '_id')
-# @return [Factbase::Fact] New fact without the deleted properties
+# @return [nil] Nothing
 # @raise [RuntimeError] If fact is nil, has no ID, or ID property doesn't exist
 # @example Delete multiple properties from a fact
 #   fact = fb.query('(eq type "user")').first
@@ -36,12 +36,11 @@ def Fbe.delete(fact, *props, fb: Fbe.fb, id: '_id')
   end
   before.delete(id)
   fb.query("(eq #{id} #{i})").delete!
-  c = nil
   fb.txn do |fbt|
     c = fbt.insert
     before.each do |k, v|
       c.send(:"#{k}=", v) if c[k].nil?
     end
   end
-  c
+  nil
 end

data/lib/fbe/overwrite.rb

@@ -19,7 +19,7 @@ require_relative 'fb'
 # @param [String] property The name of the property to set
 # @param [Any] value The value to set (can be any type)
 # @param [Factbase] fb The factbase to use (defaults to Fbe.fb)
-# @return [Factbase::Fact] Returns new fact if recreated, or original if unchanged
+# @return [nil] Nothing
 # @raise [RuntimeError] If fact is nil, has no _id, or property is not a String
 # @note This operation preserves all other properties during recreation
 # @note If property already has the same single value, no changes are made
@@ -39,13 +39,15 @@ def Fbe.overwrite(fact, property, value, fb: Fbe.fb)
   id = fact['_id']&.first
   raise 'There is no _id in the fact, cannot use Fbe.overwrite' if id.nil?
   raise "No facts by _id = #{id}" if fb.query("(eq _id #{id})").delete!.zero?
-  n = fb.insert
-  before[property.to_s] = [value]
-  before.each do |k, vv|
-    next unless n[k].nil?
-    vv.each do |v|
-      n.send(:"#{k}=", v)
+  fb.txn do |fbt|
+    n = fbt.insert
+    before[property.to_s] = [value]
+    before.each do |k, vv|
+      next unless n[k].nil?
+      vv.each do |v|
+        n.send(:"#{k}=", v)
+      end
     end
   end
-  n
+  nil
 end

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.26.7' unless const_defined?(:VERSION)
+  VERSION = '0.26.9' unless const_defined?(:VERSION)
 end

data/rules/basic.fe

@@ -55,7 +55,7 @@
   (and
     (one where)
     (eq "String" (type where))
-    (eq "github" where))))
+    (or (eq "github" where) (eq "gitlab" where)))))
 
 (explain (when
   (exists _time)

data/test/fbe/test_overwrite.rb

@@ -4,6 +4,8 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
+require 'judges/options'
+require 'loog'
 require_relative '../../lib/fbe/overwrite'
 require_relative '../test__helper'
 
@@ -39,15 +41,6 @@ class TestOverwrite < Fbe::Test
     assert_equal(['bye'], f2['foo'])
   end
 
-  def test_overwrite_twice
-    fb = Factbase.new
-    f = fb.insert
-    f._id = 1
-    f2 = Fbe.overwrite(f, 'foo', 42, fb:)
-    Fbe.overwrite(f2, 'bar', 7, fb:)
-    assert_equal(42, fb.query('(exists foo)').each.to_a.first.foo)
-  end
-
   def test_no_need_to_overwrite
     fb = Factbase.new
     f = fb.insert
@@ -86,4 +79,25 @@ class TestOverwrite < Fbe::Test
     Fbe.overwrite(f3, 'foo', 42, fb:)
     assert_equal(3, fb.size)
   end
+
+  def test_overwrites_in_transaction
+    $fb = Factbase.new
+    $global = {}
+    $options = Judges::Options.new(job_id: 42)
+    $loog = Loog::Buffer.new
+    Fbe.fb.txn do |fbt|
+      fbt.insert.then do |f|
+        f.issue = 444
+        f.where = 'github'
+        f.repository = 555
+        f.who = 887
+        f.when = Time.now
+        f.foo = 1
+      end
+    end
+    f1 = Fbe.fb.query('(always)').each.to_a.first
+    Fbe.overwrite(f1, 'foo', 'bar')
+    f2 = Fbe.fb.query('(always)').each.to_a.first
+    assert_equal('bar', f2.foo)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.26.7
+  version: 0.26.9
 platform: ruby
 authors:
 - Yegor Bugayenko