fbe 0.26.4 → 0.26.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62bd70b9796023f978e1361f3cda58077a7b76bc482cb50b364ebe84fea1b404
-  data.tar.gz: aa1fb244aec77b1f8d0b4255dbbafcc61769c7cfe9ccd91ab3a6137c301cdb51
+  metadata.gz: cf2399a111418b6530d902e778b061da2f166b0662888b5d9fa00b0d7868a0d9
+  data.tar.gz: bff1d535e9a76b6bce3a6c7a9507c829eb427593526f6f52c2eb1f788d0d62a0
 SHA512:
-  metadata.gz: 63ae4cba9b18458ecd16f06f7c86ade4322f587bb02aa1fa7ee1eff7872578c74ed852df09bec9d865aba0a437a1f309f05a7c327855de4d59b07fcdc12e918a
-  data.tar.gz: 65c9500fa79217b84ba8c043d8140f5b30b18c22880ba1809427008cda8c0ecfe59d4906fe3e385c5f7d5687ada1eec04fdde8716ad67a50c3548f02d4583246
+  metadata.gz: fa3d845df7b5b5094150c4d8db0e49290304f88cc84739c5038f3de8051236e1ee63661eabda169f757c595ac015814c299b99ec155dd35dc89097b4a8463a1d
+  data.tar.gz: 96ef2d27467da682f4339f52a431eb5dc7e2a1e4cfa130c9fc1d9c7dba62cd97095a2cb68ea0d9a41155f57f061113c5698fb1aaa1356af8dc39d159c585fc56

data/lib/fbe/delete.rb

@@ -34,10 +34,14 @@ def Fbe.delete(fact, *props, fb: Fbe.fb, id: '_id')
       before[k] = v
     end
   end
+  before.delete(id)
   fb.query("(eq #{id} #{i})").delete!
-  c = fb.insert
-  before.each do |k, v|
-    c.send(:"#{k}=", v) if c[k].nil?
+  c = nil
+  fb.txn do |fbt|
+    c = fbt.insert
+    before.each do |k, v|
+      c.send(:"#{k}=", v) if c[k].nil?
+    end
   end
   c
 end

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.26.4' unless const_defined?(:VERSION)
+  VERSION = '0.26.6' unless const_defined?(:VERSION)
 end

data/test/fbe/test_delete.rb

@@ -50,4 +50,45 @@ class TestDelete < Fbe::Test
     assert_equal([1], f2['_id'])
     assert_equal([42], f2['_job'])
   end
+
+  def test_deletes_id
+    fb = Factbase.new
+    f = fb.insert
+    f._id = 44
+    Fbe.delete(f, '_id', fb:)
+    f2 = fb.query('(always)').each.to_a.first
+    assert_nil(f2['_id'])
+    assert_empty(f2.all_properties)
+  end
+
+  def test_deletes_in_transaction
+    $fb = Factbase.new
+    $global = {}
+    $options = Judges::Options.new(job_id: 42)
+    $loog = Loog::Buffer.new
+    Fbe.fb.txn do |fbt|
+      fbt.insert.then do |f|
+        f.issue = 444
+        f.where = 'github'
+        f.repository = 555
+        f.who = 887
+        f.when = Time.now
+        f.foo = 1
+      end
+    end
+    f1 = Fbe.fb.query('(always)').each.to_a.first
+    Fbe.delete(f1, 'foo')
+    f2 = Fbe.fb.query('(always)').each.to_a.first
+    assert_nil(f2['foo'])
+  end
+
+  def test_deletes_when_duplicate_id
+    fb = Factbase.new
+    f = fb.insert
+    f._id = 44
+    f._id = 45
+    Fbe.delete(f, '_id', fb:)
+    f2 = fb.query('(always)').each.to_a.first
+    assert_nil(f2['_id'])
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.26.4
+  version: 0.26.6
 platform: ruby
 authors:
 - Yegor Bugayenko