fbe 0.24.2 → 0.24.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1896cdb2e02c15259d12df1f1ecddb5049b902ff0b52dd67cb25a9c113606175
-  data.tar.gz: b3fdf07d9b80f1b7cffb9974f09296c8f1f33eb44d88f4faa54918f747fcd0cf
+  metadata.gz: 92baa5e54a0df9b2e57f2d6619cfad4d4ee1b4a4150b1e30b82780062dd9bd34
+  data.tar.gz: ac08a108536716ff130271018211616e02b58a55dcef303bed0c0d01808387eb
 SHA512:
-  metadata.gz: bfa0a5da515f2054d9e22c7894ea329f70894a7751dc9879c77ba074fcc07df24d70a0332771381c9698b37b83a896bd88bccd40b49877a97d35a688e858af0b
-  data.tar.gz: f15e90b61d66b43e54bf44ecc767b7943ab5f22167203e1ea36900a1b29476a8208bbcece5f8d1c66eb9d5abf9d49d551d190fdcef7dc01c274ce749282cd218
+  metadata.gz: 4b87c1fefa9477f19588b01eeb7a7d593ca38f1eed068fe7d27a84a66b4cc35214f83b8f6128a169a007df962063f4ae5373442a17c61d12f1c7e876c1099ef6
+  data.tar.gz: ae01c566bca05de64432b34b6f27bbf82497d5d72817c5bbb0ef9f80e0f62f742681f1ae820d30bc081d891b31f926369ee1f0efe42e4b778a0223b4be26959e

data/.rubocop.yml

@@ -56,3 +56,5 @@ Metrics/ParameterLists:
   Enabled: false
 Layout/MultilineAssignmentLayout:
   Enabled: true
+Style/RequireOrder:
+  Enabled: true

data/Gemfile.lock

@@ -189,7 +189,7 @@ GEM
     regexp_parser (2.10.0)
     retries (0.0.5)
     rexml (3.4.1)
-    rubocop (1.77.0)
+    rubocop (1.78.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)

data/Rakefile

@@ -4,9 +4,9 @@
 # SPDX-License-Identifier: MIT
 
 require 'qbash'
-require 'rubygems'
 require 'rake'
 require 'rake/clean'
+require 'rubygems'
 
 def name
   @name ||= File.basename(Dir['*.gemspec'].first, '.*')

data/lib/fbe/conclude.rb

@@ -6,8 +6,8 @@
 require 'tago'
 require_relative '../fbe'
 require_relative 'fb'
-require_relative 'octo'
 require_relative 'if_absent'
+require_relative 'octo'
 
 # Creates an instance of {Fbe::Conclude} and evals it with the block provided.
 #
@@ -17,13 +17,13 @@ require_relative 'if_absent'
 # @param [Judges::Options] options The options coming from the +judges+ tool
 # @param [Loog] loog The logging facility
 # @yield [Factbase::Fact] The fact
-def Fbe.conclude(fb: Fbe.fb, judge: $judge, loog: $loog, options: $options, global: $global, &)
+def Fbe.conclude(fb: Fbe.fb, judge: $judge, loog: $loog, options: $options, global: $global, time: Time, &)
   raise 'The fb is nil' if fb.nil?
   raise 'The $judge is not set' if judge.nil?
   raise 'The $global is not set' if global.nil?
   raise 'The $options is not set' if options.nil?
   raise 'The $loog is not set' if loog.nil?
-  c = Fbe::Conclude.new(fb:, judge:, loog:, options:, global:)
+  c = Fbe::Conclude.new(fb:, judge:, loog:, options:, global:, time:)
   c.instance_eval(&)
 end
 
@@ -58,7 +58,8 @@ class Fbe::Conclude
   # @param [Hash] global The hash for global caching
   # @param [Judges::Options] options The options coming from the +judges+ tool
   # @param [Loog] loog The logging facility
-  def initialize(fb:, judge:, global:, options:, loog:)
+  # @param [Time] time The time
+  def initialize(fb:, judge:, global:, options:, loog:, time: Time)
     @fb = fb
     @judge = judge
     @loog = loog
@@ -68,6 +69,7 @@ class Fbe::Conclude
     @follows = []
     @quota_aware = false
     @timeout = 60
+    @time = time
   end
 
   # Make this block aware of GitHub API quota.
@@ -180,22 +182,23 @@ class Fbe::Conclude
   #   end
   def roll(&)
     passed = 0
-    start = Time.now
+    start = @time.now
     oct = Fbe.octo(loog: @loog, options: @options, global: @global)
     @fb.query(@query).each do |a|
+      if @quota_aware && oct.off_quota?
+        @loog.debug('We ran out of GitHub quota, must stop here')
+        break
+      end
+      now = @time.now
+      if now > start + @timeout
+        @loog.debug("We've spent more than #{start.ago}, must stop here")
+        break
+      end
       @fb.txn do |fbt|
-        if @quota_aware && oct.off_quota?
-          @loog.debug('We ran out of GitHub quota, must stop here')
-          throw :commit
-        end
-        if Time.now > start + @timeout
-          @loog.debug("We've spent more than #{start.ago}, must stop here")
-          throw :commit
-        end
         n = yield fbt, a
         @loog.info("#{n.what}: #{n.details}") unless n.nil?
-        passed += 1
       end
+      passed += 1
     end
     @loog.debug("Found and processed #{passed} facts by: #{@query}")
     passed

data/lib/fbe/fb.rb

@@ -4,11 +4,11 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
+require 'factbase/cached/cached_factbase'
+require 'factbase/indexed/indexed_factbase'
 require 'factbase/logged'
 require 'factbase/pre'
 require 'factbase/rules'
-require 'factbase/cached/cached_factbase'
-require 'factbase/indexed/indexed_factbase'
 require 'factbase/sync/sync_factbase'
 require 'judges'
 require 'loog'

data/lib/fbe/just_one.rb

@@ -3,8 +3,8 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
 # SPDX-License-Identifier: MIT
 
-require 'time'
 require 'others'
+require 'time'
 require_relative '../fbe'
 require_relative 'fb'
 

data/lib/fbe/middleware/formatter.rb

@@ -3,6 +3,7 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
 # SPDX-License-Identifier: MIT
 
+require 'ellipsized'
 require 'faraday'
 require 'faraday/logging/formatter'
 require_relative '../../fbe'
@@ -66,6 +67,21 @@ class Fbe::Middleware::Formatter < Faraday::Logging::Formatter
       )
       return
     end
+    if http.status >= 500 && http.response_headers['content-type']&.start_with?('text')
+      error(
+        [
+          "#{@req.method.upcase} #{apply_filters(@req.url.to_s)} HTTP/1.1",
+          shifted(apply_filters(dump_headers(@req.request_headers))),
+          '',
+          shifted(apply_filters(@req.request_body)),
+          "HTTP/1.1 #{http.status}",
+          shifted(apply_filters(dump_headers(http.response_headers))),
+          '',
+          shifted(apply_filters(http.response_body&.ellipsized(100, :right)))
+        ].join("\n")
+      )
+      return
+    end
     error(
       [
         "#{@req.method.upcase} #{apply_filters(@req.url.to_s)} HTTP/1.1",

data/lib/fbe/middleware/sqlite_store.rb

@@ -3,12 +3,12 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
 # SPDX-License-Identifier: MIT
 
-require 'zlib'
 require 'filesize'
 require 'json'
 require 'loog'
 require 'sqlite3'
 require 'time'
+require 'zlib'
 require_relative '../../fbe'
 require_relative '../../fbe/middleware'
 
@@ -53,8 +53,10 @@ class Fbe::Middleware::SqliteStore
   # @param loog [Loog] Logger instance (optional, defaults to Loog::NULL)
   # @param maxsize [Integer] Maximum database size in bytes (optional, defaults to 10MB)
   # @param maxvsize [Integer] Maximum size in bytes of a single value (optional, defaults to 10Kb)
-  # @raise [ArgumentError] If path is nil/empty, directory doesn't exist, or version is nil/empty
-  def initialize(path, version, loog: Loog::NULL, maxsize: '10Mb', maxvsize: '10Kb')
+  # @param ttl [Integer, nil] lifetime of keys in hours
+  # @raise [ArgumentError] If path is nil/empty, directory doesn't exist, version is nil/empty,
+  # or ttl is not nil or not Integer or not positive
+  def initialize(path, version, loog: Loog::NULL, maxsize: '10Mb', maxvsize: '10Kb', ttl: nil)
     raise ArgumentError, 'Database path cannot be nil or empty' if path.nil? || path.empty?
     dir = File.dirname(path)
     raise ArgumentError, "Directory #{dir} does not exist" unless File.directory?(dir)
@@ -64,6 +66,8 @@ class Fbe::Middleware::SqliteStore
     @loog = loog
     @maxsize = Filesize.from(maxsize.to_s).to_i
     @maxvsize = Filesize.from(maxvsize.to_s).to_i
+    raise ArgumentError, 'TTL can be nil or Integer > 0' if !ttl.nil? && !(ttl.is_a?(Integer) && ttl.positive?)
+    @ttl = ttl
   end
 
   # Read a value from the cache.
@@ -106,8 +110,8 @@ class Fbe::Middleware::SqliteStore
     return if value.bytesize > @maxvsize
     perform do |t|
       t.execute(<<~SQL, [key, value, Time.now.utc.iso8601])
-        INSERT INTO cache(key, value, touched_at) VALUES(?1, ?2, ?3)
-        ON CONFLICT(key) DO UPDATE SET value = ?2, touched_at = ?3
+        INSERT INTO cache(key, value, touched_at, created_at) VALUES(?1, ?2, ?3, ?3)
+        ON CONFLICT(key) DO UPDATE SET value = ?2, touched_at = ?3, created_at = ?3
       SQL
     end
     nil
@@ -153,10 +157,29 @@ class Fbe::Middleware::SqliteStore
             SQL
             t.execute 'INSERT INTO cache SELECT * FROM cache_old;'
             t.execute 'DROP TABLE cache_old;'
+            t.execute 'CREATE INDEX IF NOT EXISTS cache_key_idx ON cache(key);'
             t.execute 'CREATE INDEX IF NOT EXISTS cache_touched_at_idx ON cache(touched_at);'
           end
           d.execute 'VACUUM;'
         end
+        if d.execute("SELECT 1 FROM pragma_table_info('cache') WHERE name = 'created_at';").dig(0, 0) != 1
+          d.transaction do |t|
+            t.execute 'ALTER TABLE cache ADD COLUMN created_at TEXT;'
+            t.execute 'UPDATE cache set created_at = ?;', [Time.now.utc.iso8601]
+            t.execute 'ALTER TABLE cache RENAME TO cache_old;'
+            t.execute <<~SQL
+              CREATE TABLE IF NOT EXISTS cache(
+                key TEXT UNIQUE NOT NULL, value TEXT, touched_at TEXT NOT NULL, created_at TEXT NOT NULL
+              );
+            SQL
+            t.execute 'INSERT INTO cache SELECT * FROM cache_old;'
+            t.execute 'DROP TABLE cache_old;'
+            t.execute 'CREATE INDEX IF NOT EXISTS cache_key_idx ON cache(key);'
+            t.execute 'CREATE INDEX IF NOT EXISTS cache_touched_at_idx ON cache(touched_at);'
+            t.execute 'CREATE INDEX IF NOT EXISTS cache_created_at_idx ON cache(created_at);'
+          end
+          d.execute 'VACUUM;'
+        end
         found = d.execute("SELECT value FROM meta WHERE key = 'version' LIMIT 1;").dig(0, 0)
         if found != @version
           @loog.info("Version mismatch in SQLite cache: stored '#{found}' != current '#{@version}', cleaning up")
@@ -166,6 +189,15 @@ class Fbe::Middleware::SqliteStore
           end
           d.execute 'VACUUM;'
         end
+        unless @ttl.nil?
+          d.transaction do |t|
+            t.execute <<~SQL, [(Time.now.utc - (@ttl * 60 * 60)).iso8601]
+              DELETE FROM cache
+              WHERE key IN (SELECT key FROM cache WHERE (created_at < ?));
+            SQL
+          end
+          d.execute 'VACUUM;'
+        end
         if File.size(@path) > @maxsize
           @loog.info(
             "SQLite cache file size (#{Filesize.from(File.size(@path).to_s).pretty} bytes) exceeds " \

data/lib/fbe/octo.rb

@@ -93,7 +93,9 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
             if options.sqlite_cache
               maxsize = Filesize.from(options.sqlite_cache_maxsize || '100M').to_i
               maxvsize = Filesize.from(options.sqlite_cache_maxvsize || '100K').to_i
-              store = Fbe::Middleware::SqliteStore.new(options.sqlite_cache, Fbe::VERSION, loog:, maxsize:, maxvsize:)
+              store = Fbe::Middleware::SqliteStore.new(
+                options.sqlite_cache, Fbe::VERSION, loog:, maxsize:, maxvsize:, ttl: 24
+              )
               loog.info(
                 "Using HTTP cache in SQLite file: #{store.path} (" \
                 "#{File.exist?(store.path) ? Filesize.from(File.size(store.path).to_s).pretty : 'file is absent'}, " \
@@ -665,7 +667,8 @@ class Fbe::FakeOctokit
         user: { login: 'yegor256', id: 526_301, type: 'User' },
         created_at: Time.parse('2025-06-01 12:00:55 UTC'),
         updated_at: Time.parse('2025-06-01 15:47:18 UTC'),
-        closed_at: Time.parse('2025-06-02 15:00:00 UTC')
+        closed_at: Time.parse('2025-06-02 15:00:00 UTC'),
+        closed_by: { id: 526_301, login: 'yegor256' }
       }
     elsif number == 143
       {
@@ -676,7 +679,8 @@ class Fbe::FakeOctokit
         pull_request: { merged_at: nil },
         created_at: Time.parse('2025-05-29 17:00:55 UTC'),
         updated_at: Time.parse('2025-05-29 19:00:00 UTC'),
-        closed_at: Time.parse('2025-06-01 18:20:00 UTC')
+        closed_at: Time.parse('2025-06-01 18:20:00 UTC'),
+        closed_by: { id: 526_301, login: 'yegor256' }
       }
     else
       {
@@ -708,6 +712,11 @@ class Fbe::FakeOctokit
       repo: {
         full_name: repo
       },
+      base: {
+        repo: {
+          full_name: repo
+        }
+      },
       state: 'closed',
       user: { login: 'yegor256', id: 526_301, type: 'User' },
       head: { ref: 'master', sha: '6dcb09b5b57875f334f61aebed695e2e4193db5e' },
@@ -716,6 +725,7 @@ class Fbe::FakeOctokit
       changed_files: 3,
       comments: 2,
       review_comments: 2,
+      closed_at: Time.parse('2024-12-20'),
       merged_at: Time.parse('2024-12-20'),
       created_at: Time.parse('2024-09-20')
     }

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.24.2' unless const_defined?(:VERSION)
+  VERSION = '0.24.4' unless const_defined?(:VERSION)
 end

data/test/fbe/middleware/test_formatter.rb

@@ -5,10 +5,11 @@
 
 require 'faraday'
 require 'loog'
-require_relative '../../test__helper'
+require 'securerandom'
 require_relative '../../../lib/fbe'
 require_relative '../../../lib/fbe/middleware'
 require_relative '../../../lib/fbe/middleware/formatter'
+require_relative '../../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
@@ -49,9 +50,38 @@ class LoggingFormatterTest < Fbe::Test
     end
   end
 
+  def test_truncate_body_for_error_text_response
+    body = SecureRandom.alphanumeric(120)
+    log_it(
+      status: 502,
+      response_body: body,
+      response_headers: {
+        'content-type' => 'text/html; charset=utf-8',
+        'x-github-api-version-selected' => '2022-11-28'
+      }
+    ) do |loog|
+      str = loog.to_s
+      refute_empty(str)
+      [
+        %r{http://example.com},
+        /Authorization:/,
+        /some request body/,
+        %r{HTTP/1.1 502},
+        /x-github-api-version-selected: "2022-11-28"/,
+        %r{content-type: "text/html; charset=utf-8"},
+        "#{body.slice(0, 97)}..."
+      ].each { |ptn| assert_match(ptn, str) }
+    end
+  end
+
   private
 
-  def log_it(status:, method: :get)
+  def log_it(
+    status:,
+    method: :get,
+    response_body: '{"message": "hello, world!"}',
+    response_headers: { 'content-type' => 'application/json', 'x-github-api-version-selected' => '2022-11-28' }
+  )
     loog = Loog::Buffer.new
     formatter = Fbe::Middleware::Formatter.new(logger: loog, options: {})
     formatter.request(
@@ -67,16 +97,7 @@ class LoggingFormatterTest < Fbe::Test
       )
     )
     formatter.response(
-      Faraday::Env.from(
-        {
-          status:,
-          response_body: '{"message": "hello, world!"}',
-          response_headers: {
-            'content-type' => 'application/json',
-            'x-github-api-version-selected' => '2022-11-28'
-          }
-        }
-      )
+      Faraday::Env.from({ status:, response_body:, response_headers: })
     )
     yield loog
   end

data/test/fbe/middleware/test_rate_limit.rb

@@ -5,10 +5,10 @@
 
 require 'faraday'
 require 'webmock'
-require_relative '../../test__helper'
 require_relative '../../../lib/fbe'
 require_relative '../../../lib/fbe/middleware'
 require_relative '../../../lib/fbe/middleware/rate_limit'
+require_relative '../../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

data/test/fbe/middleware/test_sqlite_store.rb

@@ -3,11 +3,11 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
 # SPDX-License-Identifier: MIT
 
-require 'securerandom'
 require 'qbash'
-require_relative '../../test__helper'
+require 'securerandom'
 require_relative '../../../lib/fbe/middleware'
 require_relative '../../../lib/fbe/middleware/sqlite_store'
+require_relative '../../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
@@ -237,6 +237,99 @@ class SqliteStoreTest < Fbe::Test
     end
   end
 
+  def test_upgrade_sqlite_schema_for_add_created_at_column
+    with_tmpfile('a.db') do |f|
+      SQLite3::Database.new(f).tap do |d|
+        d.execute 'CREATE TABLE IF NOT EXISTS cache(key TEXT UNIQUE NOT NULL, value TEXT, touched_at TEXT NOT NULL);'
+        [
+          ['key1', Zlib::Deflate.deflate(JSON.dump('value1')), Time.now.utc.iso8601],
+          ['key2', Zlib::Deflate.deflate(JSON.dump('value2')), Time.now.utc.iso8601]
+        ].each { d.execute 'INSERT INTO cache(key, value, touched_at) VALUES(?1, ?2, ?3);', _1 }
+        d.execute 'CREATE TABLE IF NOT EXISTS meta(key TEXT UNIQUE NOT NULL, value TEXT);'
+        d.execute "INSERT INTO meta(key, value) VALUES('version', ?);", ['0.0.1']
+      end
+      Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog).then do |store|
+        assert_equal('value1', store.read('key1'))
+        assert_equal('value2', store.read('key2'))
+      rescue SQLite3::SQLException => e
+        assert_nil(e)
+      end
+    end
+  end
+
+  def test_set_correct_ttl
+    with_tmpfile('c.db') do |f|
+      s = Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: nil)
+      refute_nil(s)
+      s = Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 24)
+      refute_nil(s)
+    end
+  end
+
+  def test_set_incorrect_ttl
+    with_tmpfile('c.db') do |f|
+      ex =
+        assert_raises(ArgumentError) do
+          Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 0)
+        end
+      assert_equal('TTL can be nil or Integer > 0', ex.message)
+      ex =
+        assert_raises(ArgumentError) do
+          Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: -10)
+        end
+      assert_equal('TTL can be nil or Integer > 0', ex.message)
+      ex =
+        assert_raises(ArgumentError) do
+          Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 10.0)
+        end
+      assert_equal('TTL can be nil or Integer > 0', ex.message)
+      ex =
+        assert_raises(ArgumentError) do
+          Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: '10')
+        end
+      assert_equal('TTL can be nil or Integer > 0', ex.message)
+      ex =
+        assert_raises(ArgumentError) do
+          Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: Object.new)
+        end
+      assert_equal('TTL can be nil or Integer > 0', ex.message)
+    end
+  end
+
+  def test_delete_keys_if_ttl_expired
+    with_tmpfile('c.db') do |f|
+      now = Time.now
+      Time.stub(:now, now) do
+        Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 24).then do |s|
+          s.write('test1', 'value1')
+          s.write('test2', 'value2')
+        end
+      end
+      Time.stub(:now, now + (12 * 60 * 60)) do
+        Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 24).then do |s|
+          s.write('test3', 'value3')
+          s.write('test4', 'value4')
+        end
+      end
+      Time.stub(:now, now + (24 * 60 * 60)) do
+        Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 24).then do |s|
+          assert_equal('value1', s.read('test1'))
+          assert_equal('value2', s.read('test2'))
+          assert_equal('value3', s.read('test3'))
+          assert_equal('value4', s.read('test4'))
+        end
+      end
+      Time.stub(:now, now + (24 * 60 * 60) + 1) do
+        Fbe::Middleware::SqliteStore.new(f, '0.0.1', loog: fake_loog, ttl: 24).then do |s|
+          assert_nil(s.read('test1'))
+          assert_nil(s.read('test2'))
+          assert_equal('value3', s.read('test3'))
+          assert_equal('value4', s.read('test4'))
+        end
+      end
+    end
+  end
+
   private
 
   def with_tmpfile(name = 'test.db', &)

data/test/fbe/middleware/test_trace.rb

@@ -6,10 +6,10 @@
 require 'faraday'
 require 'faraday/http_cache'
 require 'webmock'
-require_relative '../../test__helper'
 require_relative '../../../lib/fbe'
 require_relative '../../../lib/fbe/middleware'
 require_relative '../../../lib/fbe/middleware/trace'
+require_relative '../../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

data/test/fbe/test_conclude.rb

@@ -125,4 +125,48 @@ class TestConclude < Fbe::Test
     end
     assert_equal(2, fb.size)
   end
+
+  def test_stop_if_timeout_exceeded
+    $fb = Factbase.new
+    $fb.insert.then do |f|
+      f._id = 1
+      f.foo = 5
+    end
+    $fb.insert.then do |f|
+      f._id = 2
+      f.foo = 4
+    end
+    $fb.insert.then do |f|
+      f._id = 3
+      f.bar = 3
+    end
+    $fb.insert.then do |f|
+      f._id = 4
+      f.foo = 2
+    end
+    $fb.insert.then do |f|
+      f._id = 5
+      f.foo = 1
+    end
+    $global = {}
+    $options = Judges::Options.new({ 'testing' => true })
+    $loog = Loog::NULL
+    $judge = ''
+    total = 0
+    now = Time.now
+    time = Minitest::Mock.new
+    time.expect(:now, now)
+    time.expect(:now, now + 4)
+    time.expect(:now, now + 8)
+    time.expect(:now, now + 12)
+    Fbe.conclude(time: time) do
+      on '(exists foo)'
+      timeout 10
+      consider do |f|
+        total += f.foo
+      end
+    end
+    assert_equal(9, total)
+    time.verify
+  end
 end

data/test/fbe/test_github_graph.rb

@@ -4,10 +4,10 @@
 # SPDX-License-Identifier: MIT
 
 require 'judges/options'
-require 'webmock/minitest'
 require 'loog'
-require_relative '../test__helper'
+require 'webmock/minitest'
 require_relative '../../lib/fbe/github_graph'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

data/test/fbe/test_if_absent.rb

@@ -3,11 +3,11 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
 # SPDX-License-Identifier: MIT
 
-require 'tmpdir'
 require 'factbase'
 require 'loog'
-require_relative '../test__helper'
+require 'tmpdir'
 require_relative '../../lib/fbe/if_absent'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

data/test/fbe/test_just_one.rb

@@ -4,8 +4,8 @@
 # SPDX-License-Identifier: MIT
 
 require 'factbase'
-require_relative '../test__helper'
 require_relative '../../lib/fbe/just_one'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

data/test/fbe/test_octo.rb

@@ -662,4 +662,51 @@ class TestOcto < Fbe::Test
       https://github.com/octokit/octokit.rb/blob/ea3413c3174571e87c83d358fc893cc7613091fa/lib/octokit/connection.rb#L109-L119
     MSG
   end
+
+  def test_octo_cache_still_available_on_duration_of_age
+    WebMock.disable_net_connect!
+    now = Time.now
+    age = 60
+    stub_request(:get, 'https://api.github.com/rate_limit')
+      .to_return(
+        status: 200, headers: { 'Content-Type' => 'application/json', 'X-RateLimit-Remaining' => '5000' },
+        body: { 'rate' => { 'limit' => 5000, 'remaining' => 5000, 'reset' => 1_672_531_200 } }.to_json
+      )
+    Dir.mktmpdir do |dir|
+      sqlite_cache = File.expand_path('t.db', dir)
+      o = Fbe.octo(loog: fake_loog, global: {}, options: Judges::Options.new({ 'sqlite_cache' => sqlite_cache }))
+      stub_request(:get, 'https://api.github.com/repositories/798641472').to_return(
+        status: 200,
+        body: { id: 798_641_472, name: 'factbase' }.to_json,
+        headers: {
+          'Date' => now.httpdate,
+          'Content-Type' => 'application/json; charset=utf-8',
+          'Cache-Control' => "public, max-age=#{age}, s-maxage=#{age}",
+          'Etag' => 'W/"f5f1ea995fd7266816f681aca5a81f539420c469070a47568bebdaa3055487bc"',
+          'Last-Modified' => 'Fri, 04 Jul 2025 13:39:42 GMT'
+        }
+      ).times(1).then.to_raise('no more request to /repositories/798641472')
+      assert_equal('factbase', o.repo(798_641_472)['name'])
+      Time.stub(:now, now + age - 1) do
+        assert_equal('factbase', o.repo(798_641_472)['name'])
+      end
+      stub_request(:get, 'https://api.github.com/repositories/798641472').to_return(
+        status: 200,
+        body: { id: 798_641_472, name: 'factbase_changed' }.to_json,
+        headers: {
+          'Date' => (now + age).httpdate,
+          'Content-Type' => 'application/json; charset=utf-8',
+          'Cache-Control' => "public, max-age=#{age}, s-maxage=#{age}",
+          'Etag' => 'W/"f5f1ea995fd7266816f681aca5a81f539420c469070a47568bebdaa3055487be"',
+          'Last-Modified' => 'Fri, 04 Jul 2025 13:39:42 GMT'
+        }
+      ).times(1).then.to_raise('no more request to /repositories/798641472')
+      Time.stub(:now, now + age) do
+        assert_equal('factbase_changed', o.repo(798_641_472)['name'])
+      end
+      Time.stub(:now, now + (2 * age) - 1) do
+        assert_equal('factbase_changed', o.repo(798_641_472)['name'])
+      end
+    end
+  end
 end

data/test/fbe/test_unmask_repos.rb

@@ -5,8 +5,8 @@
 
 require 'judges/options'
 require 'loog'
-require_relative '../test__helper'
 require_relative '../../lib/fbe/unmask_repos'
+require_relative '../test__helper'
 
 # Test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

data/test/test__helper.rb

@@ -32,8 +32,8 @@ require 'minitest/reporters'
 Minitest::Reporters.use! [Minitest::Reporters::SpecReporter.new]
 
 require 'loog'
-require 'minitest/stub_const'
 require 'minitest/autorun'
+require 'minitest/stub_const'
 require 'webmock/minitest'
 require_relative '../lib/fbe'
 

data/test/test_fbe.rb

@@ -3,8 +3,8 @@
 # SPDX-FileCopyrightText: Copyright (c) 2024-2025 Zerocracy
 # SPDX-License-Identifier: MIT
 
-require_relative 'test__helper'
 require_relative '../lib/fbe'
+require_relative 'test__helper'
 
 # Main module test.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.24.2
+  version: 0.24.4
 platform: ruby
 authors:
 - Yegor Bugayenko