fbe 0.0.61 → 0.0.63

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 714cfed283ff521d4b0c51a0520157a1663da7786a0665debdc835fefcb39ea2
-  data.tar.gz: 61e090588bc4b073e00a3f496e382545d9e5a04f73d36225474fbee69d8423b3
+  metadata.gz: 1bfbf479f7d6cc0686058767d0b66c251d32fb5d810287098e719cba2c26fa21
+  data.tar.gz: 2109aa7b2b2c41e356ec8ed3aad4cbe328b9b5c3b65642aef434529f5a5d0fad
 SHA512:
-  metadata.gz: f819bf9191c6f18fc5671578f3bb3368ff3a6220df378e6938d0412fbd088d3f41f17017d3bf5d1abb59fbda12b06df99fd984769931ab7d558a31cfa1a1cd71
-  data.tar.gz: cf1a95c3f4ecbb8ed0a4c0bf644e2b2e286a0d041a8db93781bdf40280097f7ba5c2f6b21a891807067a2a92ee999a2f335bc255d58cbeaeeb2c63129b08adcd
+  metadata.gz: 969259e7bbbf1d4d0063bb8e1aa7ad3ee055590def1c8d09dd090cf9f1977f0f9593d8f65db72fb3d9312fe0fdf9be14f7e0df89e6cd6f16542da39d422b58e7
+  data.tar.gz: 27bb3190c5471fb5b8157e5e03b4678116b56951bf761f92c78a7f3aaf5984e4687be4e9feb8800c388fbe7aa665fc988821881560c4a6ab0b451eae37161233

data/assets/bylaws/bug-report-was-rewarded.liquid

@@ -1,7 +1,7 @@
 (award
   (explain "When a bug is reported and accepted by the team, the reporter gets a bonus")
   (aka
-    (let bonus {{ 8 | times: love }})
+    (let bonus {{ 4 | times: love }})
     (give bonus "as a basis")
     "award ${bonus} points")
   )

data/assets/bylaws/code-contribution-was-rewarded.liquid

@@ -5,12 +5,12 @@
   (in reviews "the number of reviews provided")
 
   (aka
-    (let basis {{ 8 | times: love }})
+    (let basis {{ 2 | times: love }})
     (give basis "as a basis")
     "award ${basis} points")
 
   (aka
-    (let hoc_k {{ 0.05 | times: love }})
+    (let hoc_k {{ 0.025 | times: love }})
     (let hoc_threshold {{ 400 | divided_by: paranoia }})
     (let hoc_max 16)
     (let hoc_min 5)
@@ -72,7 +72,7 @@
     "deduct ${few_hoc_fee} points if you contribute less than ${hoc_needed} hits-of-code")
 
   (aka
-    (let max 32)
+    (let max 24)
     (set over (if (gt (total) max) (minus max (total)) 0))
     (give over "to not go over the cap")
     (let min 4)

data/assets/bylaws/code-review-was-rewarded.liquid

@@ -5,7 +5,7 @@
   (in self "1 if the review was made for their own code contribution, otherwise zero")
 
   (aka
-    (let basis {{ 4 | times: love }})
+    (let basis {{ 2 | times: love }})
     (give basis "as a basis")
     "award ${basis} points")
 
@@ -16,7 +16,7 @@
     "deduct ${self_fee} points if they reviewed their own contribution")
 
   (aka
-    (let hoc_k {{ 0.01 | times: love }})
+    (let hoc_k {{ 0.005 | times: love }})
     (let hoc_max 16)
     (let hoc_min 5)
     (set bonus_for_hoc (times hoc hoc_k))
@@ -41,7 +41,7 @@
     "deduct ${silence_fee} points if there were absolutely no comments made during review")
 
   (aka
-    (let comments_k {{ 0.25 | times: love }})
+    (let comments_k {{ 0.125 | times: love }})
     (let comments_max 8)
     (let comments_min 5)
     (set bonus_for_comments (times comments comments_k))
@@ -58,7 +58,7 @@
     "deduct ${hoc_fee} points if there were less than ${hoc_needed} hits-of-code")
 
   (aka
-    (let max 32)
+    (let max 24)
     (set over (if (gt (total) max) (minus max (total)) 0))
     (give over "to not go over the cap")
     (let min 4)

data/assets/bylaws/enhancement-suggestion-was-rewarded.liquid

@@ -1,7 +1,7 @@
 (award
   (explain "When an enhancement is suggested and accepted by the team, the reporter gets a bonus")
   (aka
-    (let bonus {{ 8 | times: love }})
+    (let bonus {{ 4 | times: love }})
     (give bonus "as a basis")
     "award ${bonus} points")
   )

data/assets/bylaws/resolved-bug-was-rewarded.liquid

@@ -4,12 +4,12 @@
   (in self "1 if the bug was reported and resolved by the same person, otherwise zero")
   (set days (div hours 24))
   (aka
-    (let basis {{ 8 | times: love }})
+    (let basis {{ 2 | times: love }})
     (give basis "as a basis")
     "award ${basis} points")
 
   (aka
-    (let b1 {{ 4 | times: love }})
+    (let b1 {{ 2 | times: love }})
     (let hours_threshold {{ 48 | divided_by: paranoia }})
     (set b1 (if (lt hours hours_threshold) b1 0))
     (give b1 "for resolving it in less than ${hours_threshold} hours")
@@ -30,7 +30,7 @@
     "deduct ${day_fee} points for each day of delay, but no more than ${days_fee_max} points")
 
   (aka
-    (let max 24)
+    (let max 16)
     (set over (if (gt (total) max) (minus max (total)) 0))
     (give over "to not go over the cap")
     (let min 4)

data/lib/fbe/octo.rb

@@ -297,6 +297,29 @@ class Fbe::FakeOctokit
     }
   end
 
+  def pull_request_reviews(_repo, _number)
+    [
+      {
+        id: 22_449_327,
+        user: { login: 'yegor256', id: 526_301, type: 'User' },
+        body: 'Some text 2',
+        state: 'CHANGES_REQUESTED',
+        author_association: 'CONTRIBUTOR',
+        submitted_at: Time.parse('2024-08-22 10:00:00 UTC'),
+        commit_id: 'b15c2893f1b5453'
+      },
+      {
+        id: 22_449_326,
+        user: { login: 'yegor256', id: 526_301, type: 'User' },
+        body: 'Some text 1',
+        state: 'CHANGES_REQUESTED',
+        author_association: 'CONTRIBUTOR',
+        submitted_at: Time.parse('2024-08-21 22:00:00 UTC'),
+        commit_id: 'a15c2893f1b5453'
+      }
+    ]
+  end
+
   def add_comment(_repo, _issue, _text)
     {
       id: 42
@@ -335,12 +358,14 @@ class Fbe::FakeOctokit
           {
             id: 42,
             number: 10,
-            title: 'Awesome PR 10'
+            title: 'Awesome PR 10',
+            created_at: Time.parse('2024-08-21 19:00:00 UTC')
           },
           {
             id: 43,
             number: 11,
-            title: 'Awesome PR 11'
+            title: 'Awesome PR 11',
+            created_at: Time.parse('2024-08-21 20:00:00 UTC')
           }
         ]
       }
@@ -983,6 +1008,7 @@ class Fbe::FakeOctokit
         conclusion: 'success',
         name: 'copyrights',
         started_at: '2024-08-18T08:04:44Z',
+        run_started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       },
       {
@@ -991,6 +1017,7 @@ class Fbe::FakeOctokit
         conclusion: 'success',
         name: 'markdown-lint',
         started_at: '2024-08-18T08:04:44Z',
+        run_started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       },
       {
@@ -999,6 +1026,7 @@ class Fbe::FakeOctokit
         conclusion: 'failure',
         name: 'pdd',
         started_at: '2024-08-18T08:04:44Z',
+        run_started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       },
       {
@@ -1007,6 +1035,7 @@ class Fbe::FakeOctokit
         conclusion: 'success',
         name: 'rake',
         started_at: '2024-08-18T08:04:44Z',
+        run_started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       },
       {
@@ -1015,6 +1044,7 @@ class Fbe::FakeOctokit
         conclusion: 'success',
         name: 'shellcheck',
         started_at: '2024-08-18T08:04:44Z',
+        run_started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       },
       {
@@ -1023,6 +1053,7 @@ class Fbe::FakeOctokit
         conclusion: 'failure',
         name: 'yamllint',
         started_at: '2024-08-18T08:04:44Z',
+        run_started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       }
     ].select { |json| json[:id] == id }.first || {
@@ -1035,6 +1066,7 @@ class Fbe::FakeOctokit
       conclusion: 'success',
       workflow_id: id,
       created_at: random_time,
+      run_started_at: random_time,
       repository: repository(repo)
     }
   end

data/lib/fbe.rb

@@ -27,5 +27,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by .rultor.yml on every release)
-  VERSION = '0.0.61'
+  VERSION = '0.0.63'
 end

data/test/fbe/test_bylaws.rb

@@ -51,13 +51,13 @@ class TestBylaws < Minitest::Test
         { hoc: 30_000, contributors: 1 } => 32
       },
       'resolved-bug-was-rewarded' => {
-        { hours: 1, self: 0 } => 24,
-        { hours: 48, self: 0 } => 14,
-        { hours: 80, self: 0 } => 13,
+        { hours: 1, self: 0 } => 8,
+        { hours: 48, self: 0 } => 4,
+        { hours: 80, self: 0 } => 4,
         { hours: 300, self: 0 } => 4,
         { hours: 3_000, self: 0 } => 4,
         { hours: 30_000, self: 0 } => 4,
-        { hours: 1, self: 1 } => 8
+        { hours: 1, self: 1 } => 4
       },
       'push-to-master-was-punished' => {
         {} => -16
@@ -65,10 +65,10 @@ class TestBylaws < Minitest::Test
       'code-review-was-rewarded' => {
         { hoc: 0, comments: 0, self: 0 } => 4,
         { hoc: 3, comments: 0, self: 0 } => 4,
-        { hoc: 78, comments: 7, self: 0 } => 8,
-        { hoc: 600, comments: 1, self: 0 } => 10,
-        { hoc: 500, comments: 40, self: 0 } => 26,
-        { hoc: 5_000, comments: 100, self: 0 } => 32,
+        { hoc: 78, comments: 7, self: 0 } => 4,
+        { hoc: 600, comments: 1, self: 0 } => 4,
+        { hoc: 500, comments: 40, self: 0 } => 17,
+        { hoc: 5_000, comments: 100, self: 0 } => 24,
         { hoc: 100, comments: 50, self: 1 } => 4,
         { hoc: 10_000, comments: 200, self: 1 } => 4
       },
@@ -77,20 +77,21 @@ class TestBylaws < Minitest::Test
         { hoc: 3, comments: 0, reviews: 0 } => 4,
         { hoc: 78, comments: 0, reviews: 0 } => 4,
         { hoc: 78, comments: 1, reviews: 0 } => 4,
-        { hoc: 50, comments: 15, reviews: 0 } => 5,
+        { hoc: 50, comments: 15, reviews: 0 } => 4,
         { hoc: 50, comments: 25, reviews: 0 } => 4,
-        { hoc: 180, comments: 7, reviews: 2 } => 32,
-        { hoc: 150, comments: 5, reviews: 1 } => 27,
+        { hoc: 180, comments: 7, reviews: 2 } => 13,
+        { hoc: 199, comments: 8, reviews: 3 } => 14,
+        { hoc: 150, comments: 5, reviews: 1 } => 8,
         { hoc: 500, comments: 25, reviews: 2 } => 4,
-        { hoc: 99, comments: 6, reviews: 1 } => 26,
+        { hoc: 99, comments: 6, reviews: 1 } => 4,
         { hoc: 1_500, comments: 3, reviews: 0 } => 4,
         { hoc: 15_000, comments: 40, reviews: 0 } => 4
       },
       'bug-report-was-rewarded' => {
-        {} => 16
+        {} => 8
       },
       'enhancement-suggestion-was-rewarded' => {
-        {} => 16
+        {} => 8
       },
       'dud-was-punished' => {
         {} => -16
@@ -104,7 +105,7 @@ class TestBylaws < Minitest::Test
       assert(!formula.nil?, title)
       a = Fbe::Award.new(formula)
       help = [
-        "  '#{title.gsub('-', '_')}' => {\n    ",
+        "  '#{title.gsub('_', '-')}' => {\n    ",
         pairs.map do |args, _|
           [
             '{',

data/test/fbe/test_octo.rb

@@ -160,7 +160,7 @@ class TestOcto < Minitest::Test
       assert(!o.off_quota) if n > 100
       limit -= 1
     end
-    assert_in_delta(pause, Time.now - start_time, 1)
+    assert_in_delta(pause, Time.now - start_time, 5)
   end
 
   def test_fetches_fake_check_runs_for_ref

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.0.61
+  version: 0.0.63
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-08-25 00:00:00.000000000 Z
+date: 2024-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace