fbe 0.0.60 → 0.0.62

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4933facacd974e44985f3931125665ab4456062b0f4a45faf3bdc6a970e42c21
-  data.tar.gz: 53f0dde5e526aa66a703f8ee088ecd08e7aedb49d847b46c3b6a0080930509d6
+  metadata.gz: 9db76ff808a838d58140d80ab38a5abcaa73cac5e2db61a1fdf0f5eba7893ebc
+  data.tar.gz: 7adbb08362be5719e5213b86fae16d958b7b8472037d3a3d5472188fbdd9f044
 SHA512:
-  metadata.gz: 17c95861794f3865ecd9e5e5f1afe3863a7194393dce7fa7d1bd479455595ca563868819f2e7e445590ddc819f09907411923a4c21c65a26e7201165809270c4
-  data.tar.gz: 2404df0f1d5514a696f8e6604fada7792f5ce8e605dec85f48938b831dc5cd833221137e5c907e233723b67d080d78d77a1bdbf38db37f4cbe06a54cb84e72f2
+  metadata.gz: 666d18d08f85c279c8eeb556b77faf69dcbe1836e9bc222ddc3be7320f13e52a80ecc1d00b5cff60540e04a649e39fcda697934b5be02385dfb0e313ddb8f128
+  data.tar.gz: d33b53016e62a49726639efe3058a92bf875b71a21fa07c6466b60ebd8f85ed48fff3a08ca08d20f1a3df25b7d31c4f913d591f354a99961d7959983a0beb9a7

data/assets/bylaws/bug-report-was-rewarded.liquid

@@ -1,7 +1,7 @@
 (award
   (explain "When a bug is reported and accepted by the team, the reporter gets a bonus")
   (aka
-    (let bonus {{ 8 | times: love }})
+    (let bonus {{ 4 | times: love }})
     (give bonus "as a basis")
     "award ${bonus} points")
   )

data/assets/bylaws/code-contribution-was-rewarded.liquid

@@ -5,12 +5,12 @@
   (in reviews "the number of reviews provided")
 
   (aka
-    (let basis {{ 8 | times: love }})
+    (let basis {{ 2 | times: love }})
     (give basis "as a basis")
     "award ${basis} points")
 
   (aka
-    (let hoc_k {{ 0.05 | times: love }})
+    (let hoc_k {{ 0.025 | times: love }})
     (let hoc_threshold {{ 400 | divided_by: paranoia }})
     (let hoc_max 16)
     (let hoc_min 5)
@@ -72,7 +72,7 @@
     "deduct ${few_hoc_fee} points if you contribute less than ${hoc_needed} hits-of-code")
 
   (aka
-    (let max 32)
+    (let max 24)
     (set over (if (gt (total) max) (minus max (total)) 0))
     (give over "to not go over the cap")
     (let min 4)

data/assets/bylaws/code-review-was-rewarded.liquid

@@ -5,7 +5,7 @@
   (in self "1 if the review was made for their own code contribution, otherwise zero")
 
   (aka
-    (let basis {{ 4 | times: love }})
+    (let basis {{ 2 | times: love }})
     (give basis "as a basis")
     "award ${basis} points")
 
@@ -16,7 +16,7 @@
     "deduct ${self_fee} points if they reviewed their own contribution")
 
   (aka
-    (let hoc_k {{ 0.01 | times: love }})
+    (let hoc_k {{ 0.005 | times: love }})
     (let hoc_max 16)
     (let hoc_min 5)
     (set bonus_for_hoc (times hoc hoc_k))
@@ -41,7 +41,7 @@
     "deduct ${silence_fee} points if there were absolutely no comments made during review")
 
   (aka
-    (let comments_k {{ 0.25 | times: love }})
+    (let comments_k {{ 0.125 | times: love }})
     (let comments_max 8)
     (let comments_min 5)
     (set bonus_for_comments (times comments comments_k))
@@ -58,7 +58,7 @@
     "deduct ${hoc_fee} points if there were less than ${hoc_needed} hits-of-code")
 
   (aka
-    (let max 32)
+    (let max 24)
     (set over (if (gt (total) max) (minus max (total)) 0))
     (give over "to not go over the cap")
     (let min 4)

data/assets/bylaws/enhancement-suggestion-was-rewarded.liquid

@@ -1,7 +1,7 @@
 (award
   (explain "When an enhancement is suggested and accepted by the team, the reporter gets a bonus")
   (aka
-    (let bonus {{ 8 | times: love }})
+    (let bonus {{ 4 | times: love }})
     (give bonus "as a basis")
     "award ${bonus} points")
   )

data/assets/bylaws/resolved-bug-was-rewarded.liquid

@@ -4,12 +4,12 @@
   (in self "1 if the bug was reported and resolved by the same person, otherwise zero")
   (set days (div hours 24))
   (aka
-    (let basis {{ 8 | times: love }})
+    (let basis {{ 2 | times: love }})
     (give basis "as a basis")
     "award ${basis} points")
 
   (aka
-    (let b1 {{ 4 | times: love }})
+    (let b1 {{ 2 | times: love }})
     (let hours_threshold {{ 48 | divided_by: paranoia }})
     (set b1 (if (lt hours hours_threshold) b1 0))
     (give b1 "for resolving it in less than ${hours_threshold} hours")
@@ -30,7 +30,7 @@
     "deduct ${day_fee} points for each day of delay, but no more than ${days_fee_max} points")
 
   (aka
-    (let max 24)
+    (let max 16)
     (set over (if (gt (total) max) (minus max (total)) 0))
     (give over "to not go over the cap")
     (let min 4)

data/lib/fbe/octo.rb

@@ -541,6 +541,64 @@ class Fbe::FakeOctokit
             changed_files: 2
           }
         }
+      },
+      {
+        id: 43,
+        created_at: Time.now,
+        actor: { id: 42 },
+        type: 'PullRequestEvent',
+        repo: { id: repo },
+        payload: {
+          action: 'closed',
+          number: 172,
+          ref_type: 'tag',
+          ref: 'foo',
+          pull_request: {
+            url: 'https://api.github.com/repos/yegor256/judges/pulls/93',
+            id: 1_990_323_142,
+            node_id: 'PR_kwDOL6GCO852oevG',
+            number: 172,
+            state: 'closed',
+            locked: false,
+            title: '#999 new feature',
+            user: {
+              login: 'test',
+              id: 88_084_038,
+              node_id: 'MDQ6VXNlcjE2NDYwMjA=',
+              type: 'User',
+              site_admin: false
+            },
+            base: {
+              label: 'zerocracy:master',
+              ref: 'master',
+              user: {
+                login: 'zerocracy',
+                id: 24_234_201
+              },
+              repo: {
+                id: repo,
+                node_id: 'R_kgDOK2_4Aw',
+                name: 'judges-action',
+                full_name: 'zerocracy/judges-action',
+                private: false,
+                owner: {
+                  login: 'zerocracy'
+                }
+              }
+            },
+            head: {
+              ref: 'zerocracy/judges-action',
+              sha: '74d0c234967de0f690805c6943e78db42a294c1a'
+            },
+            merged_at: Time.now,
+            comments: 2,
+            review_comments: 2,
+            commits: 1,
+            additions: 3,
+            deletions: 3,
+            changed_files: 2
+          }
+        }
       }
     ]
   end
@@ -691,65 +749,166 @@ class Fbe::FakeOctokit
     ]
   end
 
-  def check_runs_for_ref(_repo, sha)
-    {
-      total_count: 7,
-      check_runs: [
-        {
-          id: 28_907_016_501,
-          name: 'make',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_603,
-          name: 'copyrights',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_550,
-          name: 'markdown-lint',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_483,
-          name: 'pdd',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_433,
-          name: 'rake',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_405,
-          name: 'shellcheck',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_379,
-          name: 'yamllint',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        }
-      ]
+  def check_runs_for_ref(repo, sha)
+    data = {
+      'zerocracy/baza' => {
+        total_count: 7,
+        check_runs: [
+          {
+            id: 28_907_016_501,
+            name: 'make',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_603,
+            name: 'copyrights',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_550,
+            name: 'markdown-lint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_483,
+            name: 'pdd',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_433,
+            name: 'rake',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_405,
+            name: 'shellcheck',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_379,
+            name: 'yamllint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          }
+        ]
+      },
+      'zerocracy/judges-action' => {
+        total_count: 7,
+        check_runs: [
+          {
+            id: 28_907_016_501,
+            name: 'Codacy Static Code Analysis',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'codacy-production'
+            }
+          },
+          {
+            id: 28_906_596_603,
+            name: 'copyrights',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_550,
+            name: 'markdown-lint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_483,
+            name: 'pdd',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_433,
+            name: 'rake',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_405,
+            name: 'shellcheck',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_379,
+            name: 'yamllint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          }
+        ]
+      }
     }
+    data.fetch(repo) do
+      { total_count: 0, check_runs: [] }
+    end
   end
 
   def workflow_run_job(_repo, job)
-    result = [
+    [
       {
         id: 28_907_016_501,
         run_id: 10_438_531_072,
@@ -799,12 +958,17 @@ class Fbe::FakeOctokit
         started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       }
-    ].select { |json| json[:id] == job }
-    result.first
+    ].select { |json| json[:id] == job }.first || {
+      id: job,
+      run_id: 1234,
+      name: 'run job',
+      started_at: '2024-08-18T08:04:44Z',
+      completed_at: '2024-08-18T08:20:17Z'
+    }
   end
 
   def workflow_run(repo, id)
-    runs = [
+    [
       {
         id: 10_438_531_072,
         event: 'pull_request',
@@ -861,22 +1025,17 @@ class Fbe::FakeOctokit
         started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       }
-    ].select { |json| json[:id] == id }
-    if runs.first.nil?
-      {
-        id:,
-        name: 'copyrights',
-        head_branch: 'master',
-        head_sha: '7d34c53e6743944dbf6fc729b1066bcbb3b18443',
-        event: 'push',
-        status: 'completed',
-        conclusion: 'success',
-        workflow_id: id,
-        created_at: random_time,
-        repository: repository(repo)
-      }
-    else
-      runs.first
-    end
+    ].select { |json| json[:id] == id }.first || {
+      id:,
+      name: 'copyrights',
+      head_branch: 'master',
+      head_sha: '7d34c53e6743944dbf6fc729b1066bcbb3b18443',
+      event: 'push',
+      status: 'completed',
+      conclusion: 'success',
+      workflow_id: id,
+      created_at: random_time,
+      repository: repository(repo)
+    }
   end
 end

data/lib/fbe.rb

@@ -27,5 +27,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by .rultor.yml on every release)
-  VERSION = '0.0.60'
+  VERSION = '0.0.62'
 end

data/test/fbe/test_bylaws.rb

@@ -51,13 +51,13 @@ class TestBylaws < Minitest::Test
         { hoc: 30_000, contributors: 1 } => 32
       },
       'resolved-bug-was-rewarded' => {
-        { hours: 1, self: 0 } => 24,
-        { hours: 48, self: 0 } => 14,
-        { hours: 80, self: 0 } => 13,
+        { hours: 1, self: 0 } => 8,
+        { hours: 48, self: 0 } => 4,
+        { hours: 80, self: 0 } => 4,
         { hours: 300, self: 0 } => 4,
         { hours: 3_000, self: 0 } => 4,
         { hours: 30_000, self: 0 } => 4,
-        { hours: 1, self: 1 } => 8
+        { hours: 1, self: 1 } => 4
       },
       'push-to-master-was-punished' => {
         {} => -16
@@ -65,10 +65,10 @@ class TestBylaws < Minitest::Test
       'code-review-was-rewarded' => {
         { hoc: 0, comments: 0, self: 0 } => 4,
         { hoc: 3, comments: 0, self: 0 } => 4,
-        { hoc: 78, comments: 7, self: 0 } => 8,
-        { hoc: 600, comments: 1, self: 0 } => 10,
-        { hoc: 500, comments: 40, self: 0 } => 26,
-        { hoc: 5_000, comments: 100, self: 0 } => 32,
+        { hoc: 78, comments: 7, self: 0 } => 4,
+        { hoc: 600, comments: 1, self: 0 } => 4,
+        { hoc: 500, comments: 40, self: 0 } => 17,
+        { hoc: 5_000, comments: 100, self: 0 } => 24,
         { hoc: 100, comments: 50, self: 1 } => 4,
         { hoc: 10_000, comments: 200, self: 1 } => 4
       },
@@ -77,20 +77,21 @@ class TestBylaws < Minitest::Test
         { hoc: 3, comments: 0, reviews: 0 } => 4,
         { hoc: 78, comments: 0, reviews: 0 } => 4,
         { hoc: 78, comments: 1, reviews: 0 } => 4,
-        { hoc: 50, comments: 15, reviews: 0 } => 5,
+        { hoc: 50, comments: 15, reviews: 0 } => 4,
         { hoc: 50, comments: 25, reviews: 0 } => 4,
-        { hoc: 180, comments: 7, reviews: 2 } => 32,
-        { hoc: 150, comments: 5, reviews: 1 } => 27,
+        { hoc: 180, comments: 7, reviews: 2 } => 13,
+        { hoc: 199, comments: 8, reviews: 3 } => 14,
+        { hoc: 150, comments: 5, reviews: 1 } => 8,
         { hoc: 500, comments: 25, reviews: 2 } => 4,
-        { hoc: 99, comments: 6, reviews: 1 } => 26,
+        { hoc: 99, comments: 6, reviews: 1 } => 4,
         { hoc: 1_500, comments: 3, reviews: 0 } => 4,
         { hoc: 15_000, comments: 40, reviews: 0 } => 4
       },
       'bug-report-was-rewarded' => {
-        {} => 16
+        {} => 8
       },
       'enhancement-suggestion-was-rewarded' => {
-        {} => 16
+        {} => 8
       },
       'dud-was-punished' => {
         {} => -16
@@ -104,7 +105,7 @@ class TestBylaws < Minitest::Test
       assert(!formula.nil?, title)
       a = Fbe::Award.new(formula)
       help = [
-        "  '#{title.gsub('-', '_')}' => {\n    ",
+        "  '#{title.gsub('_', '-')}' => {\n    ",
         pairs.map do |args, _|
           [
             '{',

data/test/fbe/test_octo.rb

@@ -160,6 +160,42 @@ class TestOcto < Minitest::Test
       assert(!o.off_quota) if n > 100
       limit -= 1
     end
-    assert_in_delta(pause, Time.now - start_time, 1)
+    assert_in_delta(pause, Time.now - start_time, 5)
+  end
+
+  def test_fetches_fake_check_runs_for_ref
+    WebMock.disable_net_connect!
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'testing' => true }))
+    sha = 'f2ca1bb6c7e907d06'
+    result = o.check_runs_for_ref('zerocracy/baza', sha)
+    assert_equal(7, result[:total_count])
+    assert_equal(7, result[:check_runs].count)
+    result = o.check_runs_for_ref('zerocracy/judges-action', sha)
+    assert_equal(7, result[:total_count])
+    assert_equal(7, result[:check_runs].count)
+    result = o.check_runs_for_ref('zerocracy/something', sha)
+    assert_equal(0, result[:total_count])
+    assert_instance_of(Array, result[:check_runs])
+    assert_equal(0, result[:check_runs].count)
+  end
+
+  def test_fetches_fake_workflow_run
+    WebMock.disable_net_connect!
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'testing' => true }))
+    id = 10_438_531_072
+    result = o.workflow_run('zerocracy/baza', id)
+    assert_equal(id, result[:id])
+    result = o.workflow_run('zerocracy/baza', 0)
+    assert_equal(0, result[:id])
+  end
+
+  def test_fetches_fake_workflow_run_job
+    WebMock.disable_net_connect!
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'testing' => true }))
+    id = 28_906_596_433
+    result = o.workflow_run_job('zerocracy/baza', id)
+    assert_equal(id, result[:id])
+    result = o.workflow_run_job('zerocracy/baza', 0)
+    assert_equal(0, result[:id])
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.0.60
+  version: 0.0.62
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-08-22 00:00:00.000000000 Z
+date: 2024-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace