fbe 0.0.59 → 0.0.61

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcb7a83f13eadb9bd57bd7a4741709a4b41622109f64e716ffabe98df60f2e7e
-  data.tar.gz: b854b1108dc729e24cee35970cefc92387c4e44c0a171c3991a162a819e7e256
+  metadata.gz: 714cfed283ff521d4b0c51a0520157a1663da7786a0665debdc835fefcb39ea2
+  data.tar.gz: 61e090588bc4b073e00a3f496e382545d9e5a04f73d36225474fbee69d8423b3
 SHA512:
-  metadata.gz: 95584b9296deb9707f364d29b8351505f70e12273c3df3794704535febd965a18f0777318ec8d445a51bcc2309453820094039354e1d3dc3f82aa50635f81b1c
-  data.tar.gz: a2893b12fef6a7f24ffda4ac0152c08500ac58a9ac27e6bc9e32ae3ba329b7b8f781dbfae7514bd6ade9b0c9fff38ac109706f1e2a6d8a67b7631b8a6a1be020
+  metadata.gz: f819bf9191c6f18fc5671578f3bb3368ff3a6220df378e6938d0412fbd088d3f41f17017d3bf5d1abb59fbda12b06df99fd984769931ab7d558a31cfa1a1cd71
+  data.tar.gz: cf1a95c3f4ecbb8ed0a4c0bf644e2b2e286a0d041a8db93781bdf40280097f7ba5c2f6b21a891807067a2a92ee999a2f335bc255d58cbeaeeb2c63129b08adcd

data/assets/bylaws/bad-branch-name-was-punished.liquid

@@ -1,7 +1,7 @@
 (award
   (explain "If a branch has a name that doesn\\\'t obey the convention, a penalty is given to the author")
   (aka
-    (let fee -12)
+    (let fee {{ -6 | times: anger }})
     (give fee "as a basis")
     "deduct ${fee} points")
   )

data/assets/bylaws/code-contribution-was-rewarded.liquid

@@ -11,7 +11,7 @@
 
   (aka
     (let hoc_k {{ 0.05 | times: love }})
-    (let hoc_threshold 200)
+    (let hoc_threshold {{ 400 | divided_by: paranoia }})
     (let hoc_max 16)
     (let hoc_min 5)
     (set bonus_for_hoc (if (lt hoc hoc_threshold) (times hoc hoc_k) 0))
@@ -30,7 +30,7 @@
 
   (aka
     (let many_hoc_fee2 {{ 8 | times: anger }})
-    (let hoc_threshold2 800)
+    (let hoc_threshold2 {{ 1600 | divided_by: paranoia }})
     (set penalty_for_hoc2 (if (gte hoc hoc_threshold2) (times -1 many_hoc_fee2) 0))
     (give penalty_for_hoc2 "for way too many hits-of-code (${hoc} >= ${hoc_threshold2})")
     "deduct ${many_hoc_fee2} points if more than ${hoc_threshold2}
@@ -53,7 +53,7 @@
 
   (aka
     (let few_comments_fee {{ 2 | times: anger }})
-    (let comments_needed 5)
+    (let comments_needed {{ 3 | times: paranoia }})
     (set penalty_for_few_comments (if (and (lt comments comments_needed) (not (eq comments 0))) (times -1 few_comments_fee) 0))
     (give penalty_for_few_comments "for very few (${comments}) comments")
     "deduct ${few_comments_fee} points if there were less than ${comments_needed} comments made during review")
@@ -66,7 +66,7 @@
 
   (aka
     (let few_hoc_fee {{ 4 | times: anger }})
-    (let hoc_needed 20)
+    (let hoc_needed {{ 10 | times: paranoia }})
     (set penalty_for_few_hoc (if (lt hoc hoc_needed) (times -1 few_hoc_fee) 0))
     (give penalty_for_few_hoc "for too few (${hoc}) hits-of-code")
     "deduct ${few_hoc_fee} points if you contribute less than ${hoc_needed} hits-of-code")

data/assets/bylaws/code-review-was-rewarded.liquid

@@ -29,7 +29,7 @@
 
   (aka
     (let few_comments_fee {{ 5 | times: anger }})
-    (let comments_needed 6)
+    (let comments_needed {{ 3 | times: paranoia }})
     (set penalty_for_few_comments (if (and (lt comments comments_needed) (not (eq comments 0))) (times -1 few_comments_fee) 0))
     (give penalty_for_few_comments "for very few (${comments}) comments")
     "deduct ${few_comments_fee} points if there were less than ${comments_needed} comments made during review")
@@ -52,7 +52,7 @@
 
   (aka
     (let hoc_fee {{ 4 | times: anger }})
-    (let hoc_needed 15)
+    (let hoc_needed {{ 8 | times: paranoia }})
     (set penalty_for_hoc (if (lt hoc hoc_needed) (times -1 hoc_fee) 0))
     (give penalty_for_hoc "for too few (${hoc}) hits-of-code")
     "deduct ${hoc_fee} points if there were less than ${hoc_needed} hits-of-code")

data/assets/bylaws/push-to-master-was-punished.liquid

@@ -1,7 +1,7 @@
 (award
   (explain "When someone pushes directly to the default branch, they get a penalty")
   (aka
-    (let fee -16)
+    (let fee {{ -8 | times: anger }})
     (give fee "as a basis")
     "${fee} points")
   )

data/assets/bylaws/resolved-bug-was-rewarded.liquid

@@ -10,7 +10,7 @@
 
   (aka
     (let b1 {{ 4 | times: love }})
-    (let hours_threshold 24)
+    (let hours_threshold {{ 48 | divided_by: paranoia }})
     (set b1 (if (lt hours hours_threshold) b1 0))
     (give b1 "for resolving it in less than ${hours_threshold} hours")
     "add ${b1} points if it was resolved in less than ${hours_threshold} hours")

data/lib/fbe/bylaws.rb

@@ -30,12 +30,15 @@ require_relative '../fbe'
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
 # Copyright:: Copyright (c) 2024 Yegor Bugayenko
 # License:: MIT
-def Fbe.bylaws(anger: 2, love: 2)
+def Fbe.bylaws(anger: 2, love: 2, paranoia: 2)
+  raise 'The "anger" must be in the [0..4] interval' unless !anger.negative? && anger < 5
+  raise 'The "lover" must be in the [0..4] interval' unless !love.negative? && love < 5
+  raise 'The "paranoia" must be in the [1..4] interval' unless paranoia.positive? && paranoia < 5
   home = File.join(__dir__, '../../assets/bylaws')
   raise "The directory with templates is absent '#{home}'" unless File.exist?(home)
   Dir[File.join(home, '*.liquid')].to_h do |f|
     formula = Liquid::Template.parse(File.read(f)).render(
-      'anger' => anger, 'love' => love
+      'anger' => anger, 'love' => love, 'paranoia' => paranoia
     )
     [File.basename(f).gsub(/\.liquid$/, ''), formula]
   end

data/lib/fbe/octo.rb

@@ -541,6 +541,64 @@ class Fbe::FakeOctokit
             changed_files: 2
           }
         }
+      },
+      {
+        id: 43,
+        created_at: Time.now,
+        actor: { id: 42 },
+        type: 'PullRequestEvent',
+        repo: { id: repo },
+        payload: {
+          action: 'closed',
+          number: 172,
+          ref_type: 'tag',
+          ref: 'foo',
+          pull_request: {
+            url: 'https://api.github.com/repos/yegor256/judges/pulls/93',
+            id: 1_990_323_142,
+            node_id: 'PR_kwDOL6GCO852oevG',
+            number: 172,
+            state: 'closed',
+            locked: false,
+            title: '#999 new feature',
+            user: {
+              login: 'test',
+              id: 88_084_038,
+              node_id: 'MDQ6VXNlcjE2NDYwMjA=',
+              type: 'User',
+              site_admin: false
+            },
+            base: {
+              label: 'zerocracy:master',
+              ref: 'master',
+              user: {
+                login: 'zerocracy',
+                id: 24_234_201
+              },
+              repo: {
+                id: repo,
+                node_id: 'R_kgDOK2_4Aw',
+                name: 'judges-action',
+                full_name: 'zerocracy/judges-action',
+                private: false,
+                owner: {
+                  login: 'zerocracy'
+                }
+              }
+            },
+            head: {
+              ref: 'zerocracy/judges-action',
+              sha: '74d0c234967de0f690805c6943e78db42a294c1a'
+            },
+            merged_at: Time.now,
+            comments: 2,
+            review_comments: 2,
+            commits: 1,
+            additions: 3,
+            deletions: 3,
+            changed_files: 2
+          }
+        }
       }
     ]
   end
@@ -691,65 +749,166 @@ class Fbe::FakeOctokit
     ]
   end
 
-  def check_runs_for_ref(_repo, sha)
-    {
-      total_count: 7,
-      check_runs: [
-        {
-          id: 28_907_016_501,
-          name: 'make',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_603,
-          name: 'copyrights',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_550,
-          name: 'markdown-lint',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_483,
-          name: 'pdd',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_433,
-          name: 'rake',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_405,
-          name: 'shellcheck',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        },
-        {
-          id: 28_906_596_379,
-          name: 'yamllint',
-          head_sha: sha,
-          started_at: '2024-08-18T08:04:44Z',
-          completed_at: '2024-08-18T08:20:17Z'
-        }
-      ]
+  def check_runs_for_ref(repo, sha)
+    data = {
+      'zerocracy/baza' => {
+        total_count: 7,
+        check_runs: [
+          {
+            id: 28_907_016_501,
+            name: 'make',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_603,
+            name: 'copyrights',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_550,
+            name: 'markdown-lint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_483,
+            name: 'pdd',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_433,
+            name: 'rake',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_405,
+            name: 'shellcheck',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_379,
+            name: 'yamllint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          }
+        ]
+      },
+      'zerocracy/judges-action' => {
+        total_count: 7,
+        check_runs: [
+          {
+            id: 28_907_016_501,
+            name: 'Codacy Static Code Analysis',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'codacy-production'
+            }
+          },
+          {
+            id: 28_906_596_603,
+            name: 'copyrights',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_550,
+            name: 'markdown-lint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_483,
+            name: 'pdd',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_433,
+            name: 'rake',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_405,
+            name: 'shellcheck',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          },
+          {
+            id: 28_906_596_379,
+            name: 'yamllint',
+            head_sha: sha,
+            started_at: '2024-08-18T08:04:44Z',
+            completed_at: '2024-08-18T08:20:17Z',
+            app: {
+              slug: 'github-actions'
+            }
+          }
+        ]
+      }
     }
+    data.fetch(repo) do
+      { total_count: 0, check_runs: [] }
+    end
   end
 
   def workflow_run_job(_repo, job)
-    result = [
+    [
       {
         id: 28_907_016_501,
         run_id: 10_438_531_072,
@@ -799,12 +958,17 @@ class Fbe::FakeOctokit
         started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       }
-    ].select { |json| json[:id] == job }
-    result.first
+    ].select { |json| json[:id] == job }.first || {
+      id: job,
+      run_id: 1234,
+      name: 'run job',
+      started_at: '2024-08-18T08:04:44Z',
+      completed_at: '2024-08-18T08:20:17Z'
+    }
   end
 
   def workflow_run(repo, id)
-    runs = [
+    [
       {
         id: 10_438_531_072,
         event: 'pull_request',
@@ -861,22 +1025,17 @@ class Fbe::FakeOctokit
         started_at: '2024-08-18T08:04:44Z',
         completed_at: '2024-08-18T08:20:17Z'
       }
-    ].select { |json| json[:id] == id }
-    if runs.first.nil?
-      {
-        id:,
-        name: 'copyrights',
-        head_branch: 'master',
-        head_sha: '7d34c53e6743944dbf6fc729b1066bcbb3b18443',
-        event: 'push',
-        status: 'completed',
-        conclusion: 'success',
-        workflow_id: id,
-        created_at: random_time,
-        repository: repository(repo)
-      }
-    else
-      runs.first
-    end
+    ].select { |json| json[:id] == id }.first || {
+      id:,
+      name: 'copyrights',
+      head_branch: 'master',
+      head_sha: '7d34c53e6743944dbf6fc729b1066bcbb3b18443',
+      event: 'push',
+      status: 'completed',
+      conclusion: 'success',
+      workflow_id: id,
+      created_at: random_time,
+      repository: repository(repo)
+    }
   end
 end

data/lib/fbe.rb

@@ -27,5 +27,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by .rultor.yml on every release)
-  VERSION = '0.0.59'
+  VERSION = '0.0.61'
 end

data/test/fbe/test_bylaws.rb

@@ -80,7 +80,7 @@ class TestBylaws < Minitest::Test
         { hoc: 50, comments: 15, reviews: 0 } => 5,
         { hoc: 50, comments: 25, reviews: 0 } => 4,
         { hoc: 180, comments: 7, reviews: 2 } => 32,
-        { hoc: 150, comments: 5, reviews: 1 } => 31,
+        { hoc: 150, comments: 5, reviews: 1 } => 27,
         { hoc: 500, comments: 25, reviews: 2 } => 4,
         { hoc: 99, comments: 6, reviews: 1 } => 26,
         { hoc: 1_500, comments: 3, reviews: 0 } => 4,
@@ -104,7 +104,7 @@ class TestBylaws < Minitest::Test
       assert(!formula.nil?, title)
       a = Fbe::Award.new(formula)
       help = [
-        "  #{title}: {\n    ",
+        "  '#{title.gsub('-', '_')}' => {\n    ",
         pairs.map do |args, _|
           [
             '{',

data/test/fbe/test_octo.rb

@@ -162,4 +162,40 @@ class TestOcto < Minitest::Test
     end
     assert_in_delta(pause, Time.now - start_time, 1)
   end
+
+  def test_fetches_fake_check_runs_for_ref
+    WebMock.disable_net_connect!
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'testing' => true }))
+    sha = 'f2ca1bb6c7e907d06'
+    result = o.check_runs_for_ref('zerocracy/baza', sha)
+    assert_equal(7, result[:total_count])
+    assert_equal(7, result[:check_runs].count)
+    result = o.check_runs_for_ref('zerocracy/judges-action', sha)
+    assert_equal(7, result[:total_count])
+    assert_equal(7, result[:check_runs].count)
+    result = o.check_runs_for_ref('zerocracy/something', sha)
+    assert_equal(0, result[:total_count])
+    assert_instance_of(Array, result[:check_runs])
+    assert_equal(0, result[:check_runs].count)
+  end
+
+  def test_fetches_fake_workflow_run
+    WebMock.disable_net_connect!
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'testing' => true }))
+    id = 10_438_531_072
+    result = o.workflow_run('zerocracy/baza', id)
+    assert_equal(id, result[:id])
+    result = o.workflow_run('zerocracy/baza', 0)
+    assert_equal(0, result[:id])
+  end
+
+  def test_fetches_fake_workflow_run_job
+    WebMock.disable_net_connect!
+    o = Fbe.octo(loog: Loog::NULL, global: {}, options: Judges::Options.new({ 'testing' => true }))
+    id = 28_906_596_433
+    result = o.workflow_run_job('zerocracy/baza', id)
+    assert_equal(id, result[:id])
+    result = o.workflow_run_job('zerocracy/baza', 0)
+    assert_equal(0, result[:id])
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.0.59
+  version: 0.0.61
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-08-22 00:00:00.000000000 Z
+date: 2024-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace