fbe 0.0.58 → 0.0.59

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 037e6b31b619e5a79f4f986f6be016c8cafed2fe3b7b000f0f02de5780052df1
-  data.tar.gz: 85134954a6f355895224da28d587adfad1bca6f0f41b2b3da3b7ae6757d8038f
+  metadata.gz: dcb7a83f13eadb9bd57bd7a4741709a4b41622109f64e716ffabe98df60f2e7e
+  data.tar.gz: b854b1108dc729e24cee35970cefc92387c4e44c0a171c3991a162a819e7e256
 SHA512:
-  metadata.gz: efcd99caa7002a17af0330cc0b9ab64bf049fee54d11c72454e90f4a99fca8b739b2f5ad351caa525023eb0bea0f15a7e964949821c953e77e4a76ff247d929b
-  data.tar.gz: b5d1c69ca30a4973400ceb74c447aa90e909103ab6c73d7e4aefd8e254bbfd868daa1e215a8080bf7da6135f312077de6525437a7fb12da1bad3570d2cfc2fdd
+  metadata.gz: 95584b9296deb9707f364d29b8351505f70e12273c3df3794704535febd965a18f0777318ec8d445a51bcc2309453820094039354e1d3dc3f82aa50635f81b1c
+  data.tar.gz: a2893b12fef6a7f24ffda4ac0152c08500ac58a9ac27e6bc9e32ae3ba329b7b8f781dbfae7514bd6ade9b0c9fff38ac109706f1e2a6d8a67b7631b8a6a1be020

data/lib/fbe/github_graph.rb

@@ -82,7 +82,9 @@ class Fbe::Graph
         }
       GRAPHQL
     )
-    result&.to_h&.dig('repository', 'pullRequest', 'reviewThreads', 'nodes') || []
+    result&.to_h&.dig('repository', 'pullRequest', 'reviewThreads', 'nodes')&.select do |thread|
+      thread['isResolved']
+    end || []
   end
 
   def total_commits(owner, name, branch)

data/lib/fbe.rb

@@ -27,5 +27,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by .rultor.yml on every release)
-  VERSION = '0.0.58'
+  VERSION = '0.0.59'
 end

data/test/fbe/test_github_graph.rb

@@ -91,6 +91,14 @@ class TestGitHubGraph < Minitest::Test
     assert(0, result.count)
   end
 
+  def test_does_not_count_unresolved_conversations
+    skip # it's a "live" test, run it manually if you need it
+    WebMock.allow_net_connect!
+    g = Fbe.github_graph(options: Judges::Options.new, loog: Loog::NULL, global: {})
+    result = g.resolved_conversations('zerocracy', 'judges-action', 296)
+    assert_equal(0, result.count)
+  end
+
   def test_gets_total_commits_of_repo
     skip # it's a "live" test, run it manually if you need it
     WebMock.allow_net_connect!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.0.58
+  version: 0.0.59
 platform: ruby
 authors:
 - Yegor Bugayenko