fbe 0.0.53 → 0.0.55

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14aa27f165a2c6a7ca7cdf10127ba4f6f7aa4a84272316c3098a69381f0017c5
-  data.tar.gz: f6a075f722a9ab583c64ddef3322eac30b3df54804fabb54c63ee6281c0455df
+  metadata.gz: 705cf29669f71d490c86421f566b0ec05c61fa1d8352b97d752ea26b8bcbb294
+  data.tar.gz: e68fc23391048fac0a41a5b26af5ac85c4a34b3c434845710736d093d7eeb714
 SHA512:
-  metadata.gz: 9b712ed154e715c17a54b36b8fd40d163ec176d9f6c7ba7640f4748c92c8de3cb37deb988d513cf4d9a9abb11144513b2cf67aee4a92a15013c8c89ed5fdb8e5
-  data.tar.gz: af7f077c96b1b1f528254b9ef084c3f71c0d0400cd4c2162e5c2ffa4f30d31abb1f2a78faa23b71e1d2633679cb52e24d4d006d21358fc13c01f5549b08a5514
+  metadata.gz: 20ca9dfe05821edf5df55fccc51303fa23598e81dd15361cfb8b8f23db99b399c9e984ed0a1e1e97f43a0ebd048bd0beec5d8f870163cf0cea5c264fc1a505fc
+  data.tar.gz: e8fdc7f6988f441cf0d0cb63c52f29a95f17c9681be435eb6c57012403e903e0ce65bd4b60402e802485221f3c7d7ca0cc847d1ba2f40e318af9be82ab989dcc

data/.rubocop.yml

@@ -45,9 +45,9 @@ Metrics/BlockLength:
 Metrics/AbcSize:
   Enabled: false
 Metrics/CyclomaticComplexity:
-  Max: 25
+  Enabled: false
 Metrics/PerceivedComplexity:
-  Max: 30
+  Enabled: false
 Metrics/ClassLength:
   Enabled: false
 Layout/EmptyLineAfterGuardClause:

data/Gemfile

@@ -24,7 +24,7 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'graphql-client'
-gem 'minitest', '5.25.0', require: false
+gem 'minitest', '5.25.1', require: false
 gem 'minitest-reporters', '1.7.1', require: false
 gem 'rake', '13.2.1', require: false
 gem 'rspec-rails', '6.1.4', require: false

data/Gemfile.lock

@@ -141,7 +141,7 @@ GEM
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     loog (0.6.0)
-    minitest (5.25.0)
+    minitest (5.25.1)
     minitest-reporters (1.7.1)
       ansi
       builder
@@ -287,7 +287,7 @@ PLATFORMS
 DEPENDENCIES
   fbe!
   graphql-client
-  minitest (= 5.25.0)
+  minitest (= 5.25.1)
   minitest-reporters (= 1.7.1)
   rake (= 13.2.1)
   rspec-rails (= 6.1.4)

data/lib/fbe/award.rb

@@ -300,7 +300,7 @@ class Fbe::Award
     end
 
     def points
-      @lines.map { |l| l[:v] }.inject(&:+).to_i
+      @lines.map { |l| l[:v] }.inject(&:+).to_f.round.to_i
     end
 
     def greeting

data/lib/fbe/conclude.rb

@@ -28,6 +28,12 @@ require_relative 'octo'
 require_relative 'if_absent'
 
 # Create a conclude code block.
+#
+# @param [Factbase] fb The factbase
+# @param [String] judge The name of the judge, from the +judges+ tool
+# @param [Hash] global The hash for global caching
+# @param [Judges::Options] options The options coming from the +judges+ tool
+# @param [Loog] logg The logging facility
 def Fbe.conclude(fb: Fbe.fb, judge: $judge, loog: $loog, options: $options, global: $global, &)
   c = Fbe::Conclude.new(fb:, judge:, loog:, options:, global:)
   c.instance_eval(&)
@@ -38,7 +44,14 @@ end
 # Copyright:: Copyright (c) 2024 Zerocracy
 # License:: MIT
 class Fbe::Conclude
-  def initialize(fb:, judge:, loog:, options:, global:)
+  # Ctor.
+  #
+  # @param [Factbase] fb The factbase
+  # @param [String] judge The name of the judge, from the +judges+ tool
+  # @param [Hash] global The hash for global caching
+  # @param [Judges::Options] options The options coming from the +judges+ tool
+  # @param [Loog] logg The logging facility
+  def initialize(fb:, judge:, global:, options:, loog:)
     @fb = fb
     @judge = judge
     @loog = loog
@@ -106,7 +119,6 @@ class Fbe::Conclude
     @follows.each do |follow|
       v = prev.send(follow)
       fact.send("#{follow}=", v)
-      fact.cause = prev._id
     end
     r = yield fact, prev
     return unless r.is_a?(String)

data/lib/fbe/copy.rb

@@ -29,11 +29,14 @@ require_relative 'fb'
 #
 # @param [Factbase::Fact] source The source
 # @param [Factbase::Fact] target The targer
-def Fbe.copy(source, target)
+# @param [Array<String>] except List of properties to NOT copy
+def Fbe.copy(source, target, except: [])
   raise 'The source is nil' if source.nil?
   raise 'The target is nil' if target.nil?
+  raise 'The except is nil' if except.nil?
   source.all_properties.each do |k|
     next unless target[k].nil?
+    next if except.include?(k)
     source[k].each do |v|
       target.send(:"#{k}=", v)
     end

data/lib/fbe/fb.rb

@@ -30,6 +30,12 @@ require 'factbase/pre'
 require 'factbase/rules'
 require_relative '../fbe'
 
+# Returns an instance of +Factbase+ (cached).
+#
+# @param [Factbase] fb The global factbase provided by the +judges+ tool
+# @param [Hash] global The hash for global caching
+# @param [Judges::Options] options The options coming from the +judges+ tool
+# @param [Loog] logg The logging facility
 def Fbe.fb(fb: $fb, global: $global, options: $options, loog: $loog)
   global[:fb] ||=
     begin

data/lib/fbe/issue.rb

@@ -24,6 +24,18 @@
 
 require_relative '../fbe'
 
+# Converts an ID of GitHub issue into a nicely formatting string.
+#
+# @param [Factbase::Fact] fact The fact, where to get the ID of GitHub issue
+# @param [Judges::Options] options The options coming from the +judges+ tool
+# @param [Hash] global The hash for global caching
+# @param [Loog] logg The logging facility
 def Fbe.issue(fact, options: $options, global: $global, loog: $loog)
-  "#{Fbe.octo(global:, options:, loog:).repo_name_by_id(fact.repository)}##{fact.issue}"
+  rid = fact['repository']
+  raise "There is no 'repository' property" if rid.nil?
+  rid = rid.first.to_i
+  issue = fact['issue']
+  raise "There is no 'issue' property" if issue.nil?
+  issue = issue.first.to_i
+  "#{Fbe.octo(global:, options:, loog:).repo_name_by_id(rid)}##{issue}"
 end

data/lib/fbe/octo.rb

@@ -498,6 +498,206 @@ class Fbe::FakeOctokit
         },
         created_at: random_time,
         public: true
+      },
+      {
+        id: 42,
+        created_at: Time.now,
+        actor: { id: 42 },
+        type: 'PullRequestEvent',
+        repo: { id: repo },
+        payload: {
+          action: 'closed',
+          number: 172,
+          ref_type: 'tag',
+          ref: 'foo',
+          pull_request: {
+            url: 'https://api.github.com/repos/yegor256/judges/pulls/93',
+            id: 1_990_323_142,
+            node_id: 'PR_kwDOL6GCO852oevG',
+            number: 172,
+            state: 'closed',
+            locked: false,
+            title: '#999 new feature',
+            user: {
+              login: 'test',
+              id: 88_084_038,
+              node_id: 'MDQ6VXNlcjE2NDYwMjA=',
+              type: 'User',
+              site_admin: false
+            },
+            base: {
+              label: 'zerocracy:master',
+              ref: 'master',
+              user: {
+                login: 'zerocracy',
+                id: 24_234_201
+              },
+              repo: {
+                id: repo,
+                node_id: 'R_kgDOK2_4Aw',
+                name: 'baza',
+                full_name: 'zerocracy/baza',
+                private: false
+              }
+            },
+            head: {
+              ref: 'zerocracy/baza'
+            },
+            merged_at: Time.now,
+            comments: 2,
+            review_comments: 2,
+            commits: 1,
+            additions: 3,
+            deletions: 3,
+            changed_files: 2
+          }
+        }
+      }
+    ]
+  end
+
+  def pull_request_comments(_name, _number)
+    [
+      {
+        pull_request_review_id: 2_227_372_510,
+        id: 1_709_082_318,
+        path: 'test/baza/test_locks.rb',
+        commit_id: 'a9f5f94cf28f29a64d5dd96d0ee23b4174572847',
+        original_commit_id: 'e8c6f94274d14ed3cb26fe71467a9c3f229df59c',
+        user: {
+          login: 'Reviewer',
+          id: 2_566_462
+        },
+        body: 'Most likely, parentheses were missed here.',
+        created_at: '2024-08-08T09:41:46Z',
+        updated_at: '2024-08-08T09:42:46Z',
+        reactions: {
+          url: 'https://api.github.com/repos/zerocracy/baza/pulls/comments/1709082318/reactions',
+          total_count: 0
+        },
+        start_line: 'null',
+        original_start_line: 'null',
+        start_side: 'null',
+        line: 'null',
+        original_line: 62,
+        side: 'RIGHT',
+        original_position: 25,
+        position: 'null',
+        subject_type: 'line'
+      },
+      {
+        pull_request_review_id: 2_227_372_510,
+        id: 1_709_082_319,
+        path: 'test/baza/test_locks.rb',
+        commit_id: 'a9f5f94cf28f29a64d5dd96d0ee23b4174572847',
+        original_commit_id: 'e8c6f94274d14ed3cb26fe71467a9c3f229df59c',
+        user: {
+          login: 'test',
+          id: 88_084_038
+        },
+        body: 'definitely a typo',
+        created_at: '2024-08-08T09:42:46Z',
+        updated_at: '2024-08-08T09:42:46Z',
+        reactions: {
+          url: 'https://api.github.com/repos/zerocracy/baza/pulls/comments/1709082319/reactions',
+          total_count: 0
+        },
+        start_line: 'null',
+        original_start_line: 'null',
+        start_side: 'null',
+        line: 'null',
+        original_line: 62,
+        side: 'RIGHT',
+        original_position: 25,
+        in_reply_to_id: 1_709_082_318,
+        position: 'null',
+        subject_type: 'line'
+      }
+    ]
+  end
+
+  def issue_comments(_name, _number)
+    [
+      {
+        pull_request_review_id: 2_227_372_510,
+        id: 1_709_082_320,
+        path: 'test/baza/test_locks.rb',
+        commit_id: 'a9f5f94cf28f29a64d5dd96d0ee23b4174572847',
+        original_commit_id: 'e8c6f94274d14ed3cb26fe71467a9c3f229df59c',
+        user: {
+          login: 'Reviewer',
+          id: 2_566_462
+        },
+        body: 'reviewer comment',
+        created_at: '2024-08-08T09:41:46Z',
+        updated_at: '2024-08-08T09:42:46Z',
+        reactions: {
+          url: 'https://api.github.com/repos/zerocracy/baza/pulls/comments/1709082320/reactions',
+          total_count: 1
+        },
+        start_line: 'null',
+        original_start_line: 'null',
+        start_side: 'null',
+        line: 'null',
+        original_line: 62,
+        side: 'RIGHT',
+        original_position: 25,
+        position: 'null',
+        subject_type: 'line'
+      },
+      {
+        pull_request_review_id: 2_227_372_510,
+        id: 1_709_082_321,
+        path: 'test/baza/test_locks.rb',
+        commit_id: 'a9f5f94cf28f29a64d5dd96d0ee23b4174572847',
+        original_commit_id: 'e8c6f94274d14ed3cb26fe71467a9c3f229df59c',
+        user: {
+          login: 'test',
+          id: 88_084_038
+        },
+        body: 'author comment',
+        created_at: '2024-08-08T09:42:46Z',
+        updated_at: '2024-08-08T09:42:46Z',
+        reactions: {
+          url: 'https://api.github.com/repos/zerocracy/baza/pulls/comments/1709082321/reactions',
+          total_count: 1
+        },
+        start_line: 'null',
+        original_start_line: 'null',
+        start_side: 'null',
+        line: 'null',
+        original_line: 62,
+        side: 'RIGHT',
+        original_position: 25,
+        in_reply_to_id: 1_709_082_318,
+        position: 'null',
+        subject_type: 'line'
+      }
+    ]
+  end
+
+  def issue_comment_reactions(_name, _comment)
+    [
+      {
+        id: 248_923_574,
+        user: {
+          login: 'user',
+          id: 8_086_956
+        },
+        content: 'heart'
+      }
+    ]
+  end
+
+  def pull_request_review_comment_reactions(_name, _comment)
+    [
+      {
+        id: 248_923_574,
+        user: {
+          login: 'user',
+          id: 8_086_956
+        },
+        content: 'heart'
       }
     ]
   end

data/lib/fbe/pmp.rb

@@ -24,10 +24,14 @@
 
 require 'others'
 require_relative 'fb'
+require_relative '../fbe'
 
-# Project management functions.
-module Fbe; end
-
+# Get configuration parameter from the "PMP" fact.
+#
+# @param [Factbase] fb The factbase
+# @param [Hash] global The hash for global caching
+# @param [Judges::Options] options The options coming from the +judges+ tool
+# @param [Loog] logg The logging facility
 def Fbe.pmp(fb: Fbe.fb, global: $global, options: $options, loog: $loog)
   others do |*args1|
     area = args1.first

data/lib/fbe/regularly.rb

@@ -25,6 +25,14 @@
 require_relative '../fbe'
 require_relative 'fb'
 
+# Run the block provided every X days.
+#
+# @param [String] area The name of the PMP area
+# @param [Integer] p_every_days How frequently to run, every X days
+# @param [Integer] p_since_days Since when to collect stats, X days
+# @param [Factbase] fb The factbase
+# @param [String] judge The name of the judge, from the +judges+ tool
+# @param [Loog] logg The logging facility
 def Fbe.regularly(area, p_every_days, p_since_days = nil, fb: Fbe.fb, judge: $judge, loog: $loog, &)
   pmp = fb.query("(and (eq what 'pmp') (eq area '#{area}') (exists #{p_every_days}))").each.to_a.first
   interval = pmp.nil? ? 7 : pmp[p_every_days].first

data/lib/fbe/repeatedly.rb

@@ -30,6 +30,9 @@ require_relative 'overwrite'
 #
 # @param [String] area The name of the PMP area
 # @param [Integer] p_every_hours How frequently to run, every X hours
+# @param [Factbase] fb The factbase
+# @param [String] judge The name of the judge, from the +judges+ tool
+# @param [Loog] logg The logging facility
 def Fbe.repeatedly(area, p_every_hours, fb: Fbe.fb, judge: $judge, loog: $loog, &)
   pmp = fb.query("(and (eq what 'pmp') (eq area '#{area}') (exists #{p_every_hours}))").each.to_a.first
   hours = pmp.nil? ? 24 : pmp[p_every_hours].first

data/lib/fbe/sec.rb

@@ -24,8 +24,14 @@
 
 require_relative '../fbe'
 
+# Converts number of seconds into text.
+#
+# @param [Factbase::Fact] fact The fact, where to get the number of seconds
+# @param [String] prop The property in the fact, with the seconds
 def Fbe.sec(fact, prop = :seconds)
-  s = fact.send(prop.to_s)
+  s = fact[prop.to_s]
+  raise "There is no #{prop} property" if s.nil?
+  s = s.first.to_i
   if s < 60
     format('%d seconds', s)
   elsif s < 60 * 60

data/lib/fbe/who.rb

@@ -24,6 +24,16 @@
 
 require_relative '../fbe'
 
+# Converts an ID of GitHub user into a nicely formatting string with his name.
+#
+# @param [Factbase::Fact] fact The fact, where to get the ID of GitHub user
+# @param [String] prop The property in the fact, with the ID
+# @param [Judges::Options] options The options coming from the +judges+ tool
+# @param [Hash] global The hash for global caching
+# @param [Loog] logg The logging facility
 def Fbe.who(fact, prop = :who, options: $options, global: $global, loog: $loog)
-  "@#{Fbe.octo(options:, global:, loog:).user_name_by_id(fact.send(prop.to_s))}"
+  id = fact[prop.to_s]
+  raise "There is no #{prop} property" if id.nil?
+  id = id.first.to_i
+  "@#{Fbe.octo(options:, global:, loog:).user_name_by_id(id)}"
 end

data/lib/fbe.rb

@@ -27,5 +27,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by .rultor.yml on every release)
-  VERSION = '0.0.53'
+  VERSION = '0.0.55'
 end

data/test/fbe/test_award.rb

@@ -96,6 +96,7 @@ class TestAward < Minitest::Test
 
   def test_some_greetings
     {
+      '(award (give (times 7 0.25 "fun")))' => 'You\'ve earned +2 points. ',
       '(award (give (times 5 0.25 "fun")))' => 'You\'ve earned +1 points. ',
       '(award (give 25 "for being a good boy"))' => 'You\'ve earned +25 points. ',
       '(award (let x 0.1) (set b (times x 14)) (give b "fun"))' => 'You\'ve earned +1 points. '

data/test/fbe/test_copy.rb

@@ -43,4 +43,15 @@ class TestCopy < Minitest::Test
     assert_equal(2, f2._id)
     assert_equal(42, f2.foo)
   end
+
+  def test_with_except
+    fb = Factbase.new
+    f1 = fb.insert
+    f1._id = 1
+    f1.foo = 42
+    f2 = fb.insert
+    f2._id = 2
+    Fbe.copy(f1, f2, except: ['foo'])
+    assert(f2['foo'].nil?)
+  end
 end

data/test/fbe/test_octo.rb

@@ -160,6 +160,6 @@ class TestOcto < Minitest::Test
       assert(!o.off_quota) if n > 100
       limit -= 1
     end
-    assert_in_delta(pause, Time.now - start_time, 0.4)
+    assert_in_delta(pause, Time.now - start_time, 1)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.0.53
+  version: 0.0.55
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-08-16 00:00:00.000000000 Z
+date: 2024-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace