fb_video_url_converter 0.2.7 → 0.2.8

data/CHANGELOG.rdoc

@@ -1,3 +1,7 @@
+= Version 0.2.8
+* Fixed totaly invalid URL respond status
+* Fixed responding to short urls
+* Fixed video names gathering
 = Version 0.2.7
 * Fixed tests and dependencies
 = Version 0.2.6

data/Rakefile

@@ -3,7 +3,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('fb_video_url_converter', '0.2.7') do |p|
+Echoe.new('fb_video_url_converter', '0.2.8') do |p|
   p.description    = "Facebook Video URL Converter is intended as an easy alternative to changing video hosting from Facebook to a different one."
   p.url            = "https://github.com/mensfeld/FB-Video-URL-Converter"
   p.author         = "Maciej Mensfeld"

data/fb_video_url_converter.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{fb_video_url_converter}
-  s.version = "0.2.7"
+  s.version = "0.2.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Maciej Mensfeld}]
-  s.date = %q{2011-07-03}
+  s.date = %q{2012-01-15}
   s.description = %q{Facebook Video URL Converter is intended as an easy alternative to changing video hosting from Facebook to a different one.}
   s.email = %q{maciej@mensfeld.pl}
   s.extra_rdoc_files = [%q{CHANGELOG.rdoc}, %q{README.md}, %q{lib/facebook_bot.rb}, %q{lib/facebook_video.rb}, %q{lib/fb_video_url_converter.rb}, %q{lib/generators/fb_video_url_converter/install_generator.rb}, %q{lib/generators/fb_video_url_converter/templates/create_facebook_videos_migration.rb}, %q{lib/generators/fb_video_url_converter/templates/facebook_video_converter_init.rb}]

data/lib/facebook_bot.rb

@@ -111,7 +111,7 @@ class FacebookBot
 	end
 
   def get_name(site)
-    name = site.scan(/datawrap\">(.+)<\/h3>/ix).first
+    name = site.scan(/title>(.+)<\/title>/ix).first
     name ? name.first : VIDEO_ERROR
   end
 

data/lib/facebook_video.rb

@@ -84,7 +84,7 @@ class FacebookVideo < ActiveRecord::Base
       http = Net::HTTP.new(host)
       headers = http.head(self.url)
     rescue
-      return true
+      return false
     end
     if headers.code == "200"
       true

data/spec/facebook_bot_spec.rb

@@ -49,7 +49,7 @@ describe FacebookBot do
 
     it "should obtain valid name of a valid movie" do
       fb = subject.new
-      fb.video_name('111449252268656').should eql 'Naruto Shippuuden #203 Part2 [HD]'
+      fb.video_name('111449252268656').should eql 'Naruto Shippuuden #203 Part2'
     end
 
     it "should obtain valid error msg of a invalid movie" do

data/spec/facebook_video_spec.rb

@@ -20,9 +20,9 @@ describe FacebookVideo do
     end
 
     it "should fetch it and return name" do
-      FacebookVideo.get('111449252268656').name.should eql 'Naruto Shippuuden #203 Part2 [HD]'
+      FacebookVideo.get('111449252268656').name.should eql 'Naruto Shippuuden #203 Part2'
       url = 'http://www.facebook.com/video/video.php?v=111449252268656&comments'
-      FacebookVideo.get(url).name.should eql 'Naruto Shippuuden #203 Part2 [HD]'
+      FacebookVideo.get(url).name.should eql 'Naruto Shippuuden #203 Part2'
     end
   end
 
@@ -50,6 +50,17 @@ describe FacebookVideo do
     end
   end
 
+  context "when video url is corrupted" do
+    it "should tell us that video is invalid" do
+      t = Time.now
+      FacebookVideo.get('111449252268656')
+      v = FacebookVideo.find_by_video_id('111449252268656')
+      v.url = 'dasdasdasdasd'
+      v.cached_at = Time.at(946702800)
+      v.valid?.should == false
+    end
+  end
+
   context "when we obtain invalid video" do
     it "should return warning" do
       FacebookVideo.get('').url.should eql :video_id_error

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fb_video_url_converter
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 0.2.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-03 00:00:00.000000000Z
+date: 2012-01-15 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &20129400 !ruby/object:Gem::Requirement
+  requirement: &26614420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *20129400
+  version_requirements: *26614420
 - !ruby/object:Gem::Dependency
   name: mechanize
-  requirement: &20128940 !ruby/object:Gem::Requirement
+  requirement: &26613960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *20128940
+  version_requirements: *26613960
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &20128400 !ruby/object:Gem::Requirement
+  requirement: &26613420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *20128400
+  version_requirements: *26613420
 description: Facebook Video URL Converter is intended as an easy alternative to changing
   video hosting from Facebook to a different one.
 email: maciej@mensfeld.pl