fb_graph 2.7.2 → 2.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e660328032ffbc8b0baa0033cf3099345ff336e0
-  data.tar.gz: 167ec5d9906e89ce2ada0e468e600241fb07978b
+  metadata.gz: c41a5db1d62f6356aceae001c8aa779c785a6f5e
+  data.tar.gz: d08ed080c63f5278124d1001e52ca480abac4cd7
 SHA512:
-  metadata.gz: 0fd73b3676e3b3b26c96ab0c1532f5bc41c9735f096991d154fe642ea365731fd942153221cfe555bb1b576673db0100a097b439e90948299d8ceb2b9bff6788
-  data.tar.gz: ed343eab7ee5fd8e682bb90e8ef85b0dee476130f8879cfb8cec76573f684cdefbbbf7afc82d9c3785ac3cffdb47f259b5617f2c0c2c2dc1c84498250472ae3f
+  metadata.gz: 069da1d9cd6cae38ee5c189066c4ea17e3c3f1b02bf28b5f0012d3214046c3d271dac0234b4914b5377cda7a51ca58a5a0ad07de629368bc112d21324c83daf8
+  data.tar.gz: 752610f699973e87cdea79e2c6dfb78c132f72524e11eefa52b25071ed840f95c34dd41a9f5cd1b85b3fa00bfdc5948930d54e6ba44eefcbef633e08b093006f

data/README.rdoc

@@ -116,16 +116,6 @@ of the specific objects fields in the sidebar under "Objects".
   results.klass.search(results.query, results.collection.next)     # => same with results.next
   results.klass.search(results.query, results.collection.previous) # => same with results.previous
 
-
-==== Comments
-
-  # fetch comment replies
-  FbGraph::Comment.new("10151705618661509_29545180", :access_token => ACCESS_TOKEN).comments
-
-  # fetch if the comment accept replies
-  comment = FbGraph::Comment.fetch("10151705618661509_29545180", :access_token => ACCESS_TOKEN, :fields => "can_comment")
-  comment.can_comment
-
 === POST
 
 ==== Update status (wall post)
@@ -203,14 +193,6 @@ of the specific objects fields in the sidebar under "Objects".
     :message => 'Hello, where is photo?'
   )
 
-==== Reply a comment
-
-  comment = FbGraph::Comment.fetch("10151705618661509_29545180")
-  comment.reply!( 
-    :message => "Hello!",
-    :access_token => ACCESS_TOKEN
-  )
-
 === DELETE
 
 ==== Delete an object
@@ -227,13 +209,6 @@ of the specific objects fields in the sidebar under "Objects".
   post.unlike!(:access_token => ACCESS_TOKEN)
   post.destroy(:access_token => ACCESS_TOKEN)
 
-==== Delete a comment reply
-  
-  reply = comment.comment!( :access_token => ACCESS_TOKEN,
-    :message => "Hello!"
-  )
-  reply.destroy(:access_token => ACCESS_TOKEN)
-
 === Authentication
 
 Both Facebook JavaScript SDK and normal OAuth2 flow is supported.

data/VERSION

@@ -1 +1 @@
-2.7.2
+2.7.3

data/fb_graph.gemspec

@@ -23,6 +23,6 @@ Gem::Specification.new do |s|
     s.add_development_dependency "rcov", ">= 0.9"
   end
   s.add_development_dependency "rspec", ">= 2"
-  s.add_development_dependency "fb_graph-mock", ">= 0.1.4"
+  s.add_development_dependency "fb_graph-mock", ">= 0.1.9"
   s.add_development_dependency "actionpack", ">= 3.0.6"
 end

data/lib/fb_graph/comment.rb

@@ -23,5 +23,10 @@ module FbGraph
         @created_time = Time.parse(attributes[:created_time]).utc
       end
     end
+
+    def can_comment?
+      !!can_comment
+    end
+    alias_method :commentable?, :can_comment
   end
 end

data/spec/fb_graph/comment_spec.rb

@@ -1,67 +1,83 @@
 require 'spec_helper'
 
-describe FbGraph::Comment, '.new' do
+describe FbGraph::Comment do
+  describe '.new' do
+    it 'should setup all supported attributes' do
+      attributes = {
+        :id => '12345',
+        :from => {
+          :id => '23456',
+          :name => 'nov matake'
+        },
+        :message => 'hello',
+        :created_time => '2010-01-02T15:37:40+0000'
+      }
+      comment = FbGraph::Comment.new(attributes.delete(:id), attributes)
+      comment.identifier.should   == '12345'
+      comment.from.should         == FbGraph::User.new('23456', :name => 'nov matake')
+      comment.message.should      == 'hello'
+      comment.created_time.should == Time.parse('2010-01-02T15:37:40+0000')
+    end
 
-  it 'should setup all supported attributes' do
-    attributes = {
-      :id => '12345',
-      :from => {
+    it 'should support page as from' do
+      page_comment = FbGraph::Comment.new('12345', :from => {
         :id => '23456',
-        :name => 'nov matake'
-      },
-      :message => 'hello',
-      :created_time => '2010-01-02T15:37:40+0000'
-    }
-    comment = FbGraph::Comment.new(attributes.delete(:id), attributes)
-    comment.identifier.should   == '12345'
-    comment.from.should         == FbGraph::User.new('23456', :name => 'nov matake')
-    comment.message.should      == 'hello'
-    comment.created_time.should == Time.parse('2010-01-02T15:37:40+0000')
-  end
-
-  it 'should support page as from' do
-    page_comment = FbGraph::Comment.new('12345', :from => {
-      :id => '23456',
-      :name => 'Smart.fm',
-      :category => 'Web Site'
-    })
-    page_comment.from.should == FbGraph::Page.new('23456', :name => 'Smart.fm', :category => 'Web Site')
+        :name => 'Smart.fm',
+        :category => 'Web Site'
+      })
+      page_comment.from.should == FbGraph::Page.new('23456', :name => 'Smart.fm', :category => 'Web Site')
+    end
   end
 
-end
+  describe '#fetch' do
+    context 'when access_token given' do
+      it 'gets the comment message, attributes, and user object' do
+        mock_graph :get, 'comment_id', 'comments/comment', :access_token => 'access_token' do
+          comment = FbGraph::Comment.fetch("comment_id", :access_token => 'access_token')
+          comment.identifier.should == '10151705618661509_29545180'
+          comment.can_comment == nil
+        end
+      end
 
-describe FbGraph::Comment, '#fetch' do
+      it "gets the list of replies for the comment" do
+        mock_graph :get, 'comment_id/comments', 'comments/comments/with_cursor_paging_params', :access_token => 'access_token' do
+          replies = FbGraph::Comment.new("comment_id", :access_token => 'access_token').comments
+          replies.should be_instance_of FbGraph::Connection
+          replies.should be_a FbGraph::Collection
+          replies.collection.next.should include :limit, :after
+          replies.collection.previous.should include :limit, :before
+          replies.collection.cursors.should include :before, :after
+        end
+      end
 
-  context 'when access_token given' do
-    it 'gets the comment message, attributes, and user object' do
-      mock_graph :get, 'comment_id', 'comments/comment', :access_token => 'access_token' do
-        comment = FbGraph::Comment.fetch("comment_id", :access_token => 'access_token')
-        comment.identifier.should == '10151705618661509_29545180'
-        comment.can_comment == nil
+      context 'when can_comment is passed into the fields parameter' do
+        it 'gets the can_comment attribute' do
+          mock_graph :get, 'comment_id', 'comments/with_can_comment', :access_token => 'access_token', :params => {
+            :fields => 'can_comment'
+          } do
+            comment = FbGraph::Comment.fetch("comment_id", :access_token => 'access_token', :fields => 'can_comment')
+            comment.identifier.should == '10151705618661509_29545180'
+            comment.can_comment.should == true
+          end
+        end
       end
     end
+  end
 
-    it "gets the list of replies for the comment" do
-      mock_graph :get, 'comment_id/comments', 'comments/comments/with_cursor_paging_params', :access_token => 'access_token' do
-        replies = FbGraph::Comment.new("comment_id", :access_token => 'access_token').comments
-        replies.should be_instance_of FbGraph::Connection
-        replies.should be_a FbGraph::Collection
-        replies.collection.next.should include :limit, :after
-        replies.collection.previous.should include :limit, :before
-        replies.collection.cursors.should include :before, :after
-      end
+  describe '#commentable?' do
+    context 'when commentable' do
+      subject { FbGraph::Comment.new('12345', :message => 'hello', :can_comment => true) }
+      it { should be_commentable }
     end
 
-    context 'when can_comment is passed into the fields parameter' do
-      it 'gets the can_comment attribute' do
-        mock_graph :get, 'comment_id', 'comments/with_can_comment', :access_token => 'access_token', :params => { :fields => 'can_comment' } do
-          comment = FbGraph::Comment.fetch("comment_id", :access_token => 'access_token', :fields => 'can_comment')
-          comment.identifier.should == '10151705618661509_29545180'
-          comment.can_comment.should == true
-        end
-      end
+    context 'when non commentable' do
+      subject { FbGraph::Comment.new('12345', :message => 'hello', :can_comment => false) }
+      it { should_not be_commentable }
     end
 
+    context 'when unknown' do
+      subject { FbGraph::Comment.new('12345', :message => 'hello') }
+      it { should_not be_commentable }
+    end
   end
-
 end

data/spec/fb_graph/connections/comments_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe FbGraph::Connections::Comments, '#comments' do
-  context 'when included by FbGraph::Post' do
+describe FbGraph::Connections::Comments do
+  describe '#comments' do
     let :post do
       mock_graph :get, 'no_comments', 'posts/no_comments' do
         FbGraph::Post.new('no_comments').fetch
@@ -36,10 +36,8 @@ describe FbGraph::Connections::Comments, '#comments' do
       end
     end
   end
-end
 
-describe FbGraph::Connections::Comments, '#comment!' do
-  context 'when included by FbGraph::Post' do
+  describe '#comment!' do
     context 'when no access_token given' do
       it 'should raise FbGraph::Exception' do
         mock_graph :post, '12345/comments', 'posts/comments/post_without_access_token', :status => [500, 'Internal Server Error'] do
@@ -72,10 +70,8 @@ describe FbGraph::Connections::Comments, '#comment!' do
       end
     end
   end
-end
 
-describe FbGraph::Comment, '#reply!' do
-  context 'when included by FbGraph::Post' do
+  describe '#reply!' do
     context 'when no access_token given' do
       it 'should raise FbGraph::Exception' do
         mock_graph :post, '12345/comments', 'comments/comments/post_without_access_token', :status => [500, 'Internal Server Error'] do
@@ -88,7 +84,9 @@ describe FbGraph::Comment, '#reply!' do
 
     context 'when invalid access_token is given' do
       it 'should raise FbGraph::Exception' do
-        mock_graph :post, '12345/comments', 'comments/comments/post_with_invalid_access_token', :status => [500, 'Internal Server Error'] do
+        mock_graph :post, '12345/comments', 'comments/comments/post_with_invalid_access_token', :access_token => 'invalid', :params => {
+          :message => 'hello'
+        }, :status => [500, 'Internal Server Error'] do
           lambda do
             FbGraph::Post.new('12345', :access_token => 'invalid').reply!(:message => 'hello')
           end.should raise_exception(FbGraph::Exception)
@@ -98,7 +96,9 @@ describe FbGraph::Comment, '#reply!' do
 
     context 'when valid access_token is given' do
       it 'should return generated comment' do
-        mock_graph :post, '12345/comments', 'comments/comments/post_with_valid_access_token' do
+        mock_graph :post, '12345/comments', 'comments/comments/post_with_valid_access_token', :access_token => 'valid', :params => {
+          :message => 'hello'
+        } do
           reply = FbGraph::Comment.new('12345', :access_token => 'valid').reply!(:message => 'hello')
           reply.should be_instance_of FbGraph::Comment
           reply.identifier.should == '10151705618661509_29549300'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fb_graph
 version: !ruby/object:Gem::Version
-  version: 2.7.2
+  version: 2.7.3
 platform: ruby
 authors:
 - nov matake
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.1.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.1.9
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement