fb_graph 2.4.9 → 2.4.10

data/VERSION

@@ -1 +1 @@
-2.4.9
+2.4.10

data/lib/fb_graph/exception.rb

@@ -20,7 +20,13 @@ module FbGraph
     }
 
     def self.handle_httpclient_error(response, headers)
-      return nil unless response[:error]
+      return nil unless (response[:error] || response[:error_code] || response[:error_msg])
+
+      # Sometimes we see an error that does not have the "error" field, but instead has both "error_code" and "error_msg"
+      # example: {"error_code":1,"error_msg":"An unknown error occurred"}
+      if (response[:error_code] && response[:error_msg] && !response[:error])
+        raise InternalServerError.new("#{response[:error_code]} :: #{response[:error_msg]}")
+      end
 
       # Check the WWW-Authenticate header, since it seems to be more standardized than the response
       # body error information.

data/spec/fb_graph/exception_spec.rb

@@ -293,5 +293,18 @@ describe FbGraph::Exception, ".handle_httpclient_error" do
         end
       end
     end
+    context "with an Exception not containing the error field" do
+      let(:parsed_response) do
+        {
+          :error_code => 1,
+          :error_msg => "An unknown error occurred."
+        }
+      end
+
+      it "should raise an InternalServerError exception" do
+        lambda {FbGraph::Exception.handle_httpclient_error(parsed_response, {})}.should raise_exception(FbGraph::InternalServerError)
+      end
+
+    end
   end
 end

metadata

@@ -1,112 +1,155 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: fb_graph
-version: !ruby/object:Gem::Version
-  version: 2.4.9
+version: !ruby/object:Gem::Version 
+  hash: 11
   prerelease: 
+  segments: 
+  - 2
+  - 4
+  - 10
+  version: 2.4.10
 platform: ruby
-authors:
+authors: 
 - nov matake
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-01 00:00:00.000000000Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2012-04-10 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: httpclient
-  requirement: &70177642178520 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 123
+        segments: 
+        - 2
+        - 2
+        - 0
+        - 2
         version: 2.2.0.2
   type: :runtime
-  prerelease: false
-  version_requirements: *70177642178520
-- !ruby/object:Gem::Dependency
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: rack-oauth2
-  requirement: &70177642177980 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 47
+        segments: 
+        - 0
+        - 14
+        - 4
         version: 0.14.4
   type: :runtime
-  prerelease: false
-  version_requirements: *70177642177980
-- !ruby/object:Gem::Dependency
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
   name: tzinfo
-  requirement: &70177642177580 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :runtime
-  prerelease: false
-  version_requirements: *70177642177580
-- !ruby/object:Gem::Dependency
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
   name: rake
-  requirement: &70177642177040 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0.8'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 27
+        segments: 
+        - 0
+        - 8
+        version: "0.8"
   type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: rcov
   prerelease: false
-  version_requirements: *70177642177040
-- !ruby/object:Gem::Dependency
-  name: cover_me
-  requirement: &70177642176520 !ruby/object:Gem::Requirement
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.2.0
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 25
+        segments: 
+        - 0
+        - 9
+        version: "0.9"
   type: :development
-  prerelease: false
-  version_requirements: *70177642176520
-- !ruby/object:Gem::Dependency
+  version_requirements: *id005
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: &70177642176060 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '2'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 2
+        version: "2"
   type: :development
-  prerelease: false
-  version_requirements: *70177642176060
-- !ruby/object:Gem::Dependency
+  version_requirements: *id006
+- !ruby/object:Gem::Dependency 
   name: webmock
-  requirement: &70177642175600 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 11
+        segments: 
+        - 1
+        - 6
+        - 2
         version: 1.6.2
   type: :development
-  prerelease: false
-  version_requirements: *70177642175600
-- !ruby/object:Gem::Dependency
+  version_requirements: *id007
+- !ruby/object:Gem::Dependency 
   name: actionpack
-  requirement: &70177642175140 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 11
+        segments: 
+        - 3
+        - 0
+        - 6
         version: 3.0.6
   type: :development
-  prerelease: false
-  version_requirements: *70177642175140
+  version_requirements: *id008
 description: A full-stack Facebook Graph API wrapper in Ruby.
 email: nov@matake.jp
 executables: []
+
 extensions: []
-extra_rdoc_files:
+
+extra_rdoc_files: 
 - LICENSE
 - README.rdoc
-files:
+files: 
 - .document
 - .gitignore
 - .rspec
@@ -622,30 +665,38 @@ files:
 - spec/spec_helper.rb
 homepage: http://github.com/nov/fb_graph
 licenses: []
+
 post_install_message: 
-rdoc_options:
+rdoc_options: 
 - --charset=UTF-8
-require_paths:
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.12
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: A full-stack Facebook Graph API wrapper in Ruby.
-test_files:
+test_files: 
 - spec/fb_graph/achievement_spec.rb
 - spec/fb_graph/ad_account_spec.rb
 - spec/fb_graph/ad_campaign_spec.rb