fb_graph 2.4.20 → 2.5.0

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    fb_graph (2.4.19)
+    fb_graph (2.4.20)
       httpclient (>= 2.2.0.2)
+      json
       rack-oauth2 (>= 0.14.4)
       tzinfo
 
@@ -27,7 +28,7 @@ GEM
       multi_json (~> 1.0)
     addressable (2.3.2)
     attr_required (0.0.5)
-    builder (3.0.0)
+    builder (3.0.3)
     configatron (2.9.1)
       yamler (>= 0.1.0)
     cover_me (1.2.0)
@@ -41,6 +42,7 @@ GEM
     httpclient (2.2.7)
     i18n (0.6.1)
     journey (1.0.4)
+    json (1.7.5)
     multi_json (1.3.6)
     rack (1.4.1)
     rack-cache (1.2)
@@ -60,7 +62,7 @@ GEM
       rspec-expectations (~> 2.11.0)
       rspec-mocks (~> 2.11.0)
     rspec-core (2.11.1)
-    rspec-expectations (2.11.2)
+    rspec-expectations (2.11.3)
       diff-lcs (~> 1.1.3)
     rspec-mocks (2.11.2)
     sprockets (2.1.3)
@@ -69,7 +71,7 @@ GEM
       tilt (~> 1.1, != 1.3.0)
     tilt (1.3.3)
     tzinfo (0.3.33)
-    webmock (1.8.9)
+    webmock (1.8.10)
       addressable (>= 2.2.7)
       crack (>= 0.1.7)
     yamler (0.1.0)

data/VERSION

@@ -1 +1 @@
-2.4.20
+2.5.0

data/fb_graph.gemspec

@@ -15,6 +15,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "httpclient", ">= 2.2.0.2"
   s.add_runtime_dependency "rack-oauth2", ">= 0.14.4"
   s.add_runtime_dependency "tzinfo"
+  s.add_runtime_dependency "json"
   s.add_development_dependency "rake", ">= 0.8"
   if RUBY_VERSION >= '1.9'
     s.add_development_dependency "cover_me", ">= 1.2.0"

data/lib/fb_graph/ad_creative.rb

@@ -0,0 +1,43 @@
+module FbGraph
+  class AdCreative < Node
+
+    ATTRS = [
+      :id,
+      :view_tag,
+      :alt_view_tags,
+      :creative_id,
+      :type,
+      :title,
+      :body,
+      :image_hash,
+      :link_url,
+      :name,
+      :run_status,
+      :preview_url,
+      :count_current_adgroups,
+      :facebook_object_id, # can't use object_id since it's a core ruby method
+      :story_id,
+      :image_url,
+      :url_tags,
+      :related_fan_page,
+      :auto_update,
+      :action_spec
+    ]
+
+    attr_accessor *ATTRS 
+    def initialize(identifier, attributes = {})
+      super
+      set_attrs(attributes)
+    end
+
+    protected
+
+    def set_attrs(attributes)
+      ATTRS.each do |field|
+        send("#{field}=", attributes[field.to_sym])
+      end
+      self.facebook_object_id = attributes[:object_id]
+    end
+  end
+end
+

data/lib/fb_graph/ad_group.rb

@@ -1,5 +1,7 @@
 module FbGraph
   class AdGroup < Node
+    include Connections::AdCreatives
+
     attr_accessor :ad_id, :campaign_id, :name, :adgroup_status, :bid_type, :max_bid, :targeting, :creative, :creative_ids, :adgroup_id,
       :end_time, :start_time, :updated_time, :bid_info, :disapprove_reason_descriptions
 
@@ -21,6 +23,10 @@ module FbGraph
       response
     end
 
+    def creatives(fetch = true)
+      creative_ids.map { |creative_id| fetch ? AdCreative.fetch(creative_id) : AdCreative.new(creative_id) }
+    end
+
     protected
 
     def set_attrs(attributes)

data/lib/fb_graph/connections/ad_creatives.rb

@@ -0,0 +1,14 @@
+module FbGraph
+  module Connections
+    module AdCreatives
+      def ad_creatives(options = {})
+        ad_creatives = self.connection :adcreatives, options
+        ad_creatives.map! do |ad_creative|
+          AdCreative.new ad_creative[:id], ad_creative.merge(
+            :access_token => options[:access_token] || self.access_token
+          )
+        end
+      end
+    end
+  end
+end

data/lib/fb_graph.rb

@@ -84,6 +84,7 @@ require 'fb_graph/ad_account'
 require 'fb_graph/ad_campaign'
 require 'fb_graph/ad_campaign_stat'
 require 'fb_graph/ad_connection_object'
+require 'fb_graph/ad_creative'
 require 'fb_graph/ad_group'
 require 'fb_graph/ad_group_stat'
 require 'fb_graph/ad_keyword'

data/spec/fb_graph/ad_creative_spec.rb

@@ -0,0 +1,85 @@
+require 'spec_helper'
+
+describe FbGraph::AdCreative, '.new' do
+
+  it 'should setup all supported attributes' do
+    attributes = {
+      :id => '6003590469668',
+      :view_tag => "",
+      :alt_view_tags => [],
+      :creative_id => "6003590469668",
+      :type => 1,
+      :title => "Some Creative",
+      :body => "The Body",
+      :image_hash => "4c34b48cdcbf5dd3055acb717343a9d6",
+      :link_url => "http://www.google.com/",
+      :name => "Creative Name",
+      :run_status => 1,
+      :preview_url => "http://www.facebook.com/ads/api/creative_preview.php?cid=6003590469668",
+      :count_current_adgroups => 1,
+      :object_id => 12345,
+      :story_id => 54321,
+      :image_url => "https://www.google.com/image.png",
+      :url_tags => "url=tags",
+      :related_fan_page => 5799040003,
+      :auto_update => 1,
+      :action_spec => '{"action.type":["flightsim:fly"], "application":[174829001234]}'
+    }
+    ad_creative = FbGraph::AdCreative.new(attributes.delete(:id), attributes)
+    ad_creative.identifier.should == "6003590469668"
+    ad_creative.view_tag.should == ""
+    ad_creative.alt_view_tags.should == []
+    ad_creative.creative_id.should == "6003590469668"
+    ad_creative.type.should == 1
+    ad_creative.title.should == "Some Creative"
+    ad_creative.body.should == "The Body"
+    ad_creative.image_hash.should == "4c34b48cdcbf5dd3055acb717343a9d6"
+    ad_creative.link_url.should == "http://www.google.com/"
+    ad_creative.name.should == "Creative Name"
+    ad_creative.run_status.should == 1
+    ad_creative.preview_url.should == "http://www.facebook.com/ads/api/creative_preview.php?cid=6003590469668"
+    ad_creative.count_current_adgroups.should == 1
+    ad_creative.facebook_object_id.should == 12345
+    ad_creative.image_url.should == "https://www.google.com/image.png"
+    ad_creative.url_tags.should == "url=tags"
+    ad_creative.related_fan_page.should == 5799040003
+    ad_creative.auto_update.should == 1
+    ad_creative.action_spec.should == '{"action.type":["flightsim:fly"], "application":[174829001234]}'
+  end
+end
+
+
+ describe FbGraph::AdCreative, '.fetch' do
+   it 'should get the ad creative' do
+     mock_graph :get, '6003590469668', 'ad_creatives/test_ad_creative', :access_token => 'access_token' do
+       ad_creative = FbGraph::AdCreative.fetch('6003590469668', :access_token => 'access_token')
+       ad_creative.identifier.should == "6003590469668"
+       ad_creative.view_tag.should == ""
+       ad_creative.alt_view_tags.should == []
+       ad_creative.creative_id.should == "6003590469668"
+       ad_creative.type.should == 1
+       ad_creative.title.should == "Some Creative"
+       ad_creative.body.should == "The Body"
+       ad_creative.image_hash.should == "4c34b48cdcbf5dd3055acb717343a9d6"
+       ad_creative.link_url.should == "http://www.google.com/"
+       ad_creative.name.should == "Creative Name"
+       ad_creative.run_status.should == 1
+       ad_creative.preview_url.should == "http://www.facebook.com/ads/api/creative_preview.php?cid=6003590469668"
+       ad_creative.count_current_adgroups.should == 1
+       ad_creative.image_url.should == "https://www.google.com/image.png"
+     end
+   end
+ end
+
+ describe FbGraph::AdCreative, '.update' do
+   it "should return true from facebook" do 
+     mock_graph :post, '6003590469668', 'true', :body => "New Body" do
+       attributes = {
+         :id => '6003590469668',
+         :body => "The Body"
+       }
+       ad_creative = FbGraph::AdCreative.new(attributes.delete(:id), attributes)
+       ad_creative.update(:body => "New Body").should be_true
+     end
+   end
+ end

data/spec/fb_graph/connections/ad_creatives_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe FbGraph::Connections::AdGroups, '#ad_creatives' do
+  context 'when included by FbGraph::AdGroup' do
+    context 'when access_token is given' do
+      it 'should return ad_creatives as FbGraph::AdCreative' do
+        mock_graph :get, '22334455/adcreatives', 'ad_groups/ad_creatives/22334455_ad_creatives', :access_token => 'access_token' do
+          ad_creatives = FbGraph::AdGroup.new('22334455', :access_token => 'access_token').ad_creatives
+          ad_creatives.size.should == 1 
+          ad_creative = ad_creatives.first 
+          ad_creative.identifier.should == "6003590469668"
+          ad_creative.view_tag.should == ""
+          ad_creative.alt_view_tags.should == []
+          ad_creative.creative_id.should == "6003590469668"
+          ad_creative.type.should == 1
+          ad_creative.title.should == "Some Creative"
+          ad_creative.body.should == "The Body"
+          ad_creative.image_hash.should == "4c34b48cdcbf5dd3055acb717343a9d6"
+          ad_creative.link_url.should == "http://www.google.com/"
+          ad_creative.name.should == "Creative Name"
+          ad_creative.run_status.should == 1
+          ad_creative.preview_url.should == "http://www.facebook.com/ads/api/creative_preview.php?cid=6003590469668"
+          ad_creative.count_current_adgroups.should == 1
+          ad_creative.image_url.should == "https://www.google.com/image.png"
+        end
+      end
+    end
+  end
+end

data/spec/mock_json/ad_creatives/test_ad_creative.json

@@ -0,0 +1,16 @@
+{
+  "id": "6003590469668",
+  "view_tag": "",
+  "alt_view_tags": [],
+  "creative_id": "6003590469668",
+  "type": 1,
+  "title": "Some Creative",
+  "body": "The Body",
+  "image_hash": "4c34b48cdcbf5dd3055acb717343a9d6",
+  "link_url": "http://www.google.com/",
+  "name": "Creative Name",
+  "run_status": 1,
+  "preview_url": "http://www.facebook.com/ads/api/creative_preview.php?cid=6003590469668",
+  "count_current_adgroups": 1,
+  "image_url": "https://www.google.com/image.png"
+}

data/spec/mock_json/ad_groups/ad_creatives/22334455_ad_creatives.json

@@ -0,0 +1,18 @@
+{"data": [
+  {
+  "id": "6003590469668",
+  "view_tag": "",
+  "alt_view_tags": [],
+  "creative_id": "6003590469668",
+  "type": 1,
+  "title": "Some Creative",
+  "body": "The Body",
+  "image_hash": "4c34b48cdcbf5dd3055acb717343a9d6",
+  "link_url": "http://www.google.com/",
+  "name": "Creative Name",
+  "run_status": 1,
+  "preview_url": "http://www.facebook.com/ads/api/creative_preview.php?cid=6003590469668",
+  "count_current_adgroups": 1,
+  "image_url": "https://www.google.com/image.png"
+}]
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fb_graph
 version: !ruby/object:Gem::Version
-  version: 2.4.20
+  version: 2.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-02 00:00:00.000000000 Z
+date: 2012-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -59,6 +59,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -167,6 +183,7 @@ files:
 - lib/fb_graph/ad_campaign.rb
 - lib/fb_graph/ad_campaign_stat.rb
 - lib/fb_graph/ad_connection_object.rb
+- lib/fb_graph/ad_creative.rb
 - lib/fb_graph/ad_group.rb
 - lib/fb_graph/ad_group_stat.rb
 - lib/fb_graph/ad_keyword.rb
@@ -194,6 +211,7 @@ files:
 - lib/fb_graph/connections/ad_campaign_stats.rb
 - lib/fb_graph/connections/ad_campaigns.rb
 - lib/fb_graph/connections/ad_connection_objects.rb
+- lib/fb_graph/connections/ad_creatives.rb
 - lib/fb_graph/connections/ad_group_stats.rb
 - lib/fb_graph/connections/ad_groups.rb
 - lib/fb_graph/connections/ad_previews.rb
@@ -330,6 +348,7 @@ files:
 - spec/fb_graph/ad_account_spec.rb
 - spec/fb_graph/ad_campaign_spec.rb
 - spec/fb_graph/ad_connection_object_spec.rb
+- spec/fb_graph/ad_creative_spec.rb
 - spec/fb_graph/ad_group_spec.rb
 - spec/fb_graph/ad_keyword_spec.rb
 - spec/fb_graph/ad_keyword_suggestion_spec.rb
@@ -353,6 +372,7 @@ files:
 - spec/fb_graph/connections/ad_campaign_stat_spec.rb
 - spec/fb_graph/connections/ad_campaigns_spec.rb
 - spec/fb_graph/connections/ad_connection_objects_spec.rb
+- spec/fb_graph/connections/ad_creatives_spec.rb
 - spec/fb_graph/connections/ad_group_stat_spec.rb
 - spec/fb_graph/connections/ad_groups_spec.rb
 - spec/fb_graph/connections/ad_previews_spec.rb
@@ -491,6 +511,8 @@ files:
 - spec/mock_json/ad_campaigns/ad_groups/22334455_ad_groups.json
 - spec/mock_json/ad_campaigns/test_ad_campaign.json
 - spec/mock_json/ad_campaigns/test_ad_campaign_update_with_redownload.json
+- spec/mock_json/ad_creatives/test_ad_creative.json
+- spec/mock_json/ad_groups/ad_creatives/22334455_ad_creatives.json
 - spec/mock_json/ad_groups/test_ad_group.json
 - spec/mock_json/ad_groups/test_ad_group_update_with_redownload.json
 - spec/mock_json/ad_keyword_suggestions/buffy_suggestions.json
@@ -712,6 +734,7 @@ test_files:
 - spec/fb_graph/ad_account_spec.rb
 - spec/fb_graph/ad_campaign_spec.rb
 - spec/fb_graph/ad_connection_object_spec.rb
+- spec/fb_graph/ad_creative_spec.rb
 - spec/fb_graph/ad_group_spec.rb
 - spec/fb_graph/ad_keyword_spec.rb
 - spec/fb_graph/ad_keyword_suggestion_spec.rb
@@ -735,6 +758,7 @@ test_files:
 - spec/fb_graph/connections/ad_campaign_stat_spec.rb
 - spec/fb_graph/connections/ad_campaigns_spec.rb
 - spec/fb_graph/connections/ad_connection_objects_spec.rb
+- spec/fb_graph/connections/ad_creatives_spec.rb
 - spec/fb_graph/connections/ad_group_stat_spec.rb
 - spec/fb_graph/connections/ad_groups_spec.rb
 - spec/fb_graph/connections/ad_previews_spec.rb
@@ -873,6 +897,8 @@ test_files:
 - spec/mock_json/ad_campaigns/ad_groups/22334455_ad_groups.json
 - spec/mock_json/ad_campaigns/test_ad_campaign.json
 - spec/mock_json/ad_campaigns/test_ad_campaign_update_with_redownload.json
+- spec/mock_json/ad_creatives/test_ad_creative.json
+- spec/mock_json/ad_groups/ad_creatives/22334455_ad_creatives.json
 - spec/mock_json/ad_groups/test_ad_group.json
 - spec/mock_json/ad_groups/test_ad_group_update_with_redownload.json
 - spec/mock_json/ad_keyword_suggestions/buffy_suggestions.json