fb_graph 1.7.1 → 1.7.2

data/spec/fb_graph/post_spec.rb

@@ -96,46 +96,44 @@ end
 describe FbGraph::Post, '#fetch' do
 
   context 'when no access_token given' do
-    before do
-      fake_json(:get, 'platform', 'posts/platform_public')
-    end
-
     it 'should get all attributes except some comments' do
-      post = FbGraph::Post.fetch('platform')
-      post.identifier.should == '19292868552_118464504835613'
-      post.from.should == FbGraph::Page.new(
-        "19292868552",
-        :name => "Facebook Platform",
-        :category => "Technology"
-      )
-      post.message.should == "We're getting ready for f8! Check out the latest on the f8 Page, including a video from the first event, when Platform launched :: http://bit.ly/ahHl7j"
-      post.likes.should == [
-        FbGraph::User.new("100000785546814", :name => "Anter Saied")
-      ]
-      post.likes.collection.total_count.should == 270
-      post.created_time.should == Time.parse("2010-04-15T17:37:03+0000")
-      post.updated_time.should == Time.parse("2010-04-22T18:19:13+0000")
-      post.comments.size.should == 4
+      mock_graph :get, 'platform', 'posts/platform_public' do
+        post = FbGraph::Post.fetch('platform')
+        post.identifier.should == '19292868552_118464504835613'
+        post.from.should == FbGraph::Page.new(
+          "19292868552",
+          :name => "Facebook Platform",
+          :category => "Technology"
+        )
+        post.message.should == "We're getting ready for f8! Check out the latest on the f8 Page, including a video from the first event, when Platform launched :: http://bit.ly/ahHl7j"
+        post.likes.should == [
+          FbGraph::User.new("100000785546814", :name => "Anter Saied")
+        ]
+        post.likes.collection.total_count.should == 270
+        post.created_time.should == Time.parse("2010-04-15T17:37:03+0000")
+        post.updated_time.should == Time.parse("2010-04-22T18:19:13+0000")
+        post.comments.size.should == 4
+      end
     end
   end
 
   context 'when access_token given' do
-    before do
-      fake_json(:get, 'platform?access_token=access_token', 'posts/platform_private')
-    end
-
     it 'shold get all attributes and comments' do
-      post = FbGraph::Post.fetch('platform', :access_token => 'access_token')
-      post.identifier.should == '19292868552_118464504835613'
-      post.from.should == FbGraph::Page.new(
-        "19292868552",
-        :name => "Facebook Platform",
-        :category => "Technology"
-      )
-      post.message.should == "We're getting ready for f8! Check out the latest on the f8 Page, including a video from the first event, when Platform launched :: http://bit.ly/ahHl7j"
-      post.created_time.should == Time.parse("2010-04-15T17:37:03+0000")
-      post.updated_time.should == Time.parse("2010-04-22T18:19:13+0000")
-      post.comments.size.should == 9
+      mock_graph :get, 'platform', 'posts/platform_private', :params => {
+        :access_token => 'access_token'
+      } do
+        post = FbGraph::Post.fetch('platform', :access_token => 'access_token')
+        post.identifier.should == '19292868552_118464504835613'
+        post.from.should == FbGraph::Page.new(
+          "19292868552",
+          :name => "Facebook Platform",
+          :category => "Technology"
+        )
+        post.message.should == "We're getting ready for f8! Check out the latest on the f8 Page, including a video from the first event, when Platform launched :: http://bit.ly/ahHl7j"
+        post.created_time.should == Time.parse("2010-04-15T17:37:03+0000")
+        post.updated_time.should == Time.parse("2010-04-22T18:19:13+0000")
+        post.comments.size.should == 9
+      end
     end
   end
 
@@ -145,36 +143,42 @@ describe FbGraph::Post, '#to' do
   subject { post.to.first }
 
   context 'when include Event' do
-    before do
-      fake_json(:get, 'to_event', 'posts/to_event')
+    let :post do
+      mock_graph :get, 'to_event', 'posts/to_event' do
+        FbGraph::Post.fetch('to_event')
+      end
     end
-    let(:post) { FbGraph::Post.fetch('to_event') }
     it { should be_instance_of FbGraph::Event }
   end
 
   context 'when include Application' do
     context 'when fetched as Application#feed' do
-      before do
-        fake_json(:get, 'app/feed', 'applications/feed/public')
+      let :post do
+        mock_graph :get, 'app/feed', 'applications/feed/public' do
+          FbGraph::Application.new('app').feed.first
+        end
       end
-      let(:post) { FbGraph::Application.new('app').feed.first }
       it { should be_instance_of FbGraph::Application }
     end
 
     context 'otherwize' do # no way to detect this case..
-      before do
-        fake_json(:get, 'to_application', 'posts/to_application')
+      let :post do
+        mock_graph :get, 'to_application', 'posts/to_application' do
+          FbGraph::Post.fetch('to_application')
+        end
       end
-      let(:post) { FbGraph::Post.fetch('to_application') }
       it { should be_instance_of FbGraph::User }
     end
   end
 
   context 'when include Group' do
-    before do
-      fake_json(:get, 'to_group?access_token=access_token', 'posts/to_group')
+    let :post do
+      mock_graph :get, 'to_group', 'posts/to_group', :params => {
+        :access_token => 'access_token'
+      } do
+        FbGraph::Post.fetch('to_group', :access_token => 'access_token')
+      end
     end
-    let(:post) { FbGraph::Post.fetch('to_group', :access_token => 'access_token') }
     it { should be_instance_of FbGraph::Group }
   end
 

data/spec/fb_graph/query/core_spec.rb

@@ -1,68 +1,56 @@
 require 'spec_helper'
 
-describe FbGraph::Query, '.new' do
+describe FbGraph::Query do
+  let(:raw_query) { 'SELECT uid FROM user WHERE uid = me()' }
 
-  before do
-    @raw_query = 'SELECT uid FROM user WHERE uid = me()'
-    @query = FbGraph::Query.new(@raw_query, 'access_token')
-  end
-
-  it 'should setup query and access_token' do
-    @query.query.should == @raw_query
-    @query.access_token.should == 'access_token'
-  end
-
-  it 'should setup proper endpoint' do
-    endpoint = @query.send :build_endpoint
-    params = {
-      :query => @raw_query,
-      :format => :json,
-      :access_token => 'access_token'
-    }
-    endpoint.should == "#{FbGraph::Query::ENDPOINT}?#{params.to_query}"
-  end
-
-end
+  describe '.new' do
+    let(:query) { FbGraph::Query.new(raw_query, 'access_token') }
 
-describe FbGraph::Query, '.fetch' do
-
-  before do
-    @raw_query = 'SELECT uid FROM user WHERE uid = me()'
-    @query = FbGraph::Query.new(@raw_query)
-  end
-
-  context 'when no access token given' do
-    before do
-      fake_fql_json @raw_query, 'query/user/without_token'
+    it 'should setup query and access_token' do
+      query.query.should == raw_query
+      query.access_token.should == 'access_token'
     end
 
-    it 'should return blank Hash' do
-      response = @query.fetch
-      response.should == {}
+    it 'should setup proper endpoint' do
+      endpoint = query.send :build_endpoint
+      params = {
+        :query => raw_query,
+        :format => :json,
+        :access_token => 'access_token'
+      }
+      endpoint.should == "#{FbGraph::Query::ENDPOINT}?#{params.to_query}"
     end
   end
 
-  context 'when invalid access token given' do
-    before do
-      fake_fql_json @raw_query, 'query/user/with_invalid_token', :access_token => 'invalid'
-    end
+  describe '.fetch' do
+    let(:query) { FbGraph::Query.new(raw_query) }
 
-    it 'should raise exception' do
-      lambda do
-        @query.fetch('invalid')
-      end.should raise_error(FbGraph::Exception)
+    context 'when no access token given' do
+      it 'should return blank Hash' do
+        mock_fql raw_query, 'query/user/without_token' do
+          response = query.fetch
+          response.should == {}
+        end
+      end
     end
-  end
 
-  context 'when valid access token given' do
-    before do
-      fake_fql_json @raw_query, 'query/user/with_valid_token', :access_token => 'valid'
+    context 'when invalid access token given' do
+      it 'should raise exception' do
+        mock_fql raw_query, 'query/user/with_invalid_token', :access_token => 'invalid' do
+          lambda do
+            query.fetch('invalid')
+          end.should raise_error(FbGraph::Exception)
+        end
+      end
     end
 
-    it 'should return an Array of Hash' do
-      response = @query.fetch('valid')
-      response.should == [{'uid' => 579612276}]
+    context 'when valid access token given' do
+      it 'should return an Array of Hash' do
+        mock_fql raw_query, 'query/user/with_valid_token', :access_token => 'valid' do
+          response = query.fetch('valid')
+          response.should == [{'uid' => 579612276}]
+        end
+      end
     end
   end
-
 end

data/spec/fb_graph/searchable_spec.rb

@@ -11,21 +11,25 @@ describe FbGraph::Searchable do
 end
 
 describe FbGraph::Searchable::Result do
-  before do
-    fake_json :get, 'search?q=fbgraph&type=page', 'pages/search_fb_graph'
-    fake_json :get, 'search?limit=25&offset=25&q=google&type=page', 'pages/search_google'
-    @fb_graph = FbGraph::Page.search('fbgraph')
-    @google_page2 = FbGraph::Page.search('google', :limit => 25, :offset => 25)
+  let :fb_graph do
+    mock_graph :get, 'search?q=fbgraph&type=page', 'pages/search_fb_graph' do
+      FbGraph::Page.search('fbgraph')
+    end
+  end
+  let :google_page2 do
+    mock_graph :get, 'search?limit=25&offset=25&q=google&type=page', 'pages/search_google' do
+      FbGraph::Page.search('google', :limit => 25, :offset => 25)
+    end
   end
 
   it 'should support pagination' do
-    @fb_graph.next.should     == []
-    @fb_graph.previous.should == []
+    fb_graph.next.should     == []
+    fb_graph.previous.should == []
     lambda do
-      @google_page2.next
+      google_page2.next
     end.should request_to('search?limit=25&offset=50&q=google&type=page')
     lambda do
-      @google_page2.previous
+      google_page2.previous
     end.should request_to('search?limit=25&offset=0&q=google&type=page')
   end
 end

data/spec/fb_graph/test_user_spec.rb

@@ -24,17 +24,11 @@ describe FbGraph::TestUser, '.friend!' do
   end
 
   it 'should POST twice' do
-    lambda do
-      @u1.friend! @u2
-    end.should request_to('111/friends/222', :post)
-    fake_json(:post, '111/friends/222', 'true')
-    lambda do
-      @u1.friend! @u2
-    end.should request_to('222/friends/111', :post)
-    fake_json(:post, '222/friends/111', 'true')
-    lambda do
-      @u1.friend! @u2
-    end.should_not raise_error(FakeWeb::NetConnectNotAllowedError)
+    mock_graph :post, '111/friends/222', 'true' do
+      mock_graph :post, '222/friends/111', 'true' do
+        @u1.friend! @u2
+      end
+    end
   end
 
 end

data/spec/fb_graph/user_spec.rb

@@ -32,34 +32,33 @@ describe FbGraph::User, '.me' do
 end
 
 describe FbGraph::User, '.fetch' do
-  before do
-    fake_json(:get, 'me', 'users/me_public', :status => [401, 'Unauthorized'])
-    fake_json(:get, 'me?access_token=access_token', 'users/me_private')
-    fake_json(:get, 'arjun', 'users/arjun_public')
-    fake_json(:get, 'arjun?access_token=access_token', 'users/arjun_private')
-  end
-
   context 'with me context' do
 
     context 'when no access_token given' do
       it 'should raise FbGraph::Unauthorized' do
-        lambda do
-          FbGraph::User.fetch('me')
-        end.should raise_exception(FbGraph::Unauthorized)
+        mock_graph :get, 'me', 'users/me_public', :status => [401, 'Unauthorized'] do
+          lambda do
+            FbGraph::User.fetch('me')
+          end.should raise_exception(FbGraph::Unauthorized)
+        end
       end
     end
 
     context 'when access_token given' do
       it 'should get current user profile' do
-        user = FbGraph::User.me('access_token').fetch
-        user.interested_in.should       == ['female']
-        user.meeting_for.should         == ['Friendship', 'Networking']
-        user.relationship_status.should == 'Married'
-        user.website.should             == 'http://matake.jp'
-        user.religion.should            be_nil
-        user.political.should           be_nil
-        user.timezone.should            == 9
-        user.verified.should            be_true
+        mock_graph :get, 'me', 'users/me_private', :params => {
+          :access_token => 'access_token'
+        } do
+          user = FbGraph::User.me('access_token').fetch
+          user.interested_in.should       == ['female']
+          user.meeting_for.should         == ['Friendship', 'Networking']
+          user.relationship_status.should == 'Married'
+          user.website.should             == 'http://matake.jp'
+          user.religion.should            be_nil
+          user.political.should           be_nil
+          user.timezone.should            == 9
+          user.verified.should            be_true
+        end
       end
     end
 
@@ -67,85 +66,91 @@ describe FbGraph::User, '.fetch' do
 
   context 'when no access_token given' do
     it 'should get only public profile' do
-      user = FbGraph::User.fetch('arjun')
-      user.name.should       == 'Arjun Banker'
-      user.first_name.should == 'Arjun'
-      user.last_name.should  == 'Banker'
-      user.identifier.should == '7901103'
-      user.link.should       == 'http://www.facebook.com/Arjun'
-      user.location.should   == FbGraph::Page.new(114952118516947, :name => 'San Francisco, California')
-      user.gender.should     == 'male'
+      mock_graph :get, 'arjun', 'users/arjun_public' do
+        user = FbGraph::User.fetch('arjun')
+        user.name.should       == 'Arjun Banker'
+        user.first_name.should == 'Arjun'
+        user.last_name.should  == 'Banker'
+        user.identifier.should == '7901103'
+        user.link.should       == 'http://www.facebook.com/Arjun'
+        user.location.should   == FbGraph::Page.new(114952118516947, :name => 'San Francisco, California')
+        user.gender.should     == 'male'
+      end
     end
   end
 
   context 'when access_token given' do
     it 'should get public + private profile' do
-      user = FbGraph::User.fetch('arjun', :access_token => 'access_token')
+      mock_graph :get, 'arjun', 'users/arjun_private', :params => {
+        :access_token => 'access_token'
+      } do
+        user = FbGraph::User.fetch('arjun', :access_token => 'access_token')
 
-      # public
-      user.name.should       == 'Arjun Banker'
-      user.first_name.should == 'Arjun'
-      user.last_name.should  == 'Banker'
-      user.identifier.should == '7901103'
-      user.link.should       == 'http://www.facebook.com/Arjun'
-      user.location.should   == FbGraph::Page.new(114952118516947, :name => 'San Francisco, California')
-      user.gender.should     == 'male'
+        # public
+        user.name.should       == 'Arjun Banker'
+        user.first_name.should == 'Arjun'
+        user.last_name.should  == 'Banker'
+        user.identifier.should == '7901103'
+        user.link.should       == 'http://www.facebook.com/Arjun'
+        user.location.should   == FbGraph::Page.new(114952118516947, :name => 'San Francisco, California')
+        user.gender.should     == 'male'
 
-      # private
-      user.about.should    == 'daydrea'
-      user.birthday.should == Date.strptime("04/15/1984", "%m/%d/%Y")
-      user.work.should     == [
-        FbGraph::Work.new({
-          :employer   => {:name => 'Facebook', :id => 20531316728},
-          :position   => {:name => 'Software Engineer', :id => 107879555911138},
-          :location   => {:name => 'Palo Alto, California', :id => 104022926303756},
-          :start_date => '2007-11'
-        }),
-        FbGraph::Work.new({
-          :employer   => {:name => 'Zillow', :id => 113816405300191},
-          :position   => {:name => 'Business Intelligence Analyst', :id => 105918922782444},
-          :start_date => '2006-03',
-          :end_date   => '2007-10'
-        }),
-        FbGraph::Work.new({
-          :employer   => {:name => 'Microsoft', :id => 20528438720},
-          :position   => {:name => 'SDET', :id => 110006949022640},
-          :start_date => '2004-08',
-          :end_date   => '2006-03'
-        }),
-        FbGraph::Work.new({
-          :employer   => {:name => 'Dell', :id => 7706457055},
-          :position   => {:name => 'Programmer Analyst', :id => 110344568993267},
-          :start_date => '2003-06',
-          :end_date   => '2004-07'
-        })
-      ]
-      user.education.should == [
-        FbGraph::Education.new({
-          :school => {:name => 'Texas Academy Of Math And Science', :id => 107922345906866},
-          :year   => {:name => '2001', :id => 102241906483610}
-        }),
-        FbGraph::Education.new({
-          :school => {:name => 'The University of Texas at Austin', :id => 24147741537},
-          :year   => {:name => '2003', :id => 108077232558120},
-          :concentration => [
-            {:name => 'Computer Science', :id => 116831821660155}
-          ]
-        })
-      ]
-      user.email.should               == nil
-      user.website.should             == nil
-      user.hometown.should            == FbGraph::Page.new(109533479072558, :name => 'Minnetonka, Minnesota')
-      user.interested_in.should       == ['female']
-      user.meeting_for.should         == ['Friendship']
-      user.relationship_status.should == 'In a Relationship'
-      user.religion.should            == 'zorp'
-      user.political.should           == 'Liberal'
-      user.verified.should            be_nil
-      # What's this?
-      # user.significant_other
-      user.timezone.should            be_nil
-      user.updated_time.should        == Time.parse('2010-05-29T04:29:23+0000')
+        # private
+        user.about.should    == 'daydrea'
+        user.birthday.should == Date.strptime("04/15/1984", "%m/%d/%Y")
+        user.work.should     == [
+          FbGraph::Work.new({
+            :employer   => {:name => 'Facebook', :id => 20531316728},
+            :position   => {:name => 'Software Engineer', :id => 107879555911138},
+            :location   => {:name => 'Palo Alto, California', :id => 104022926303756},
+            :start_date => '2007-11'
+          }),
+          FbGraph::Work.new({
+            :employer   => {:name => 'Zillow', :id => 113816405300191},
+            :position   => {:name => 'Business Intelligence Analyst', :id => 105918922782444},
+            :start_date => '2006-03',
+            :end_date   => '2007-10'
+          }),
+          FbGraph::Work.new({
+            :employer   => {:name => 'Microsoft', :id => 20528438720},
+            :position   => {:name => 'SDET', :id => 110006949022640},
+            :start_date => '2004-08',
+            :end_date   => '2006-03'
+          }),
+          FbGraph::Work.new({
+            :employer   => {:name => 'Dell', :id => 7706457055},
+            :position   => {:name => 'Programmer Analyst', :id => 110344568993267},
+            :start_date => '2003-06',
+            :end_date   => '2004-07'
+          })
+        ]
+        user.education.should == [
+          FbGraph::Education.new({
+            :school => {:name => 'Texas Academy Of Math And Science', :id => 107922345906866},
+            :year   => {:name => '2001', :id => 102241906483610}
+          }),
+          FbGraph::Education.new({
+            :school => {:name => 'The University of Texas at Austin', :id => 24147741537},
+            :year   => {:name => '2003', :id => 108077232558120},
+            :concentration => [
+              {:name => 'Computer Science', :id => 116831821660155}
+            ]
+          })
+        ]
+        user.email.should               == nil
+        user.website.should             == nil
+        user.hometown.should            == FbGraph::Page.new(109533479072558, :name => 'Minnetonka, Minnesota')
+        user.interested_in.should       == ['female']
+        user.meeting_for.should         == ['Friendship']
+        user.relationship_status.should == 'In a Relationship'
+        user.religion.should            == 'zorp'
+        user.political.should           == 'Liberal'
+        user.verified.should            be_nil
+        # What's this?
+        # user.significant_other
+        user.timezone.should            be_nil
+        user.updated_time.should        == Time.parse('2010-05-29T04:29:23+0000')
+      end
     end
   end
 end

data/spec/helpers/webmock_helper.rb

@@ -0,0 +1,71 @@
+require 'webmock/rspec'
+
+module WebMockHelper
+  def mock_graph(method, path, response_file, options = {})
+    stub_request(method, endpoint_for(path)).with(
+      request_for(method, options)
+    ).to_return(
+      response_for(response_file, options)
+    )
+    res = yield
+    a_request(method, endpoint_for(path)).with(
+      request_for(method, options)
+    ).should have_been_made.once
+    res
+  end
+
+  def request_to(path, method = :get)
+    raise_error(WebMock::NetConnectNotAllowedError) { |e|
+      e.message.should include("Unregistered request: #{method.to_s.upcase}")
+      e.message.should include(endpoint_for path)
+    }
+  end
+
+  def mock_fql(query, file_path, options = {})
+    params = {
+      :query => query,
+      :format => :json
+    }
+    params[:access_token] = options[:access_token] if options[:access_token]
+    stub_request(:get, FbGraph::Query::ENDPOINT).with(:query => params).to_return(
+      :body => File.read(File.join(File.dirname(__FILE__), '../mock_json', "#{file_path}.json"))
+    )
+    res = yield
+    a_request(:get, FbGraph::Query::ENDPOINT).with(:query => params).should have_been_made.once
+    res
+  end
+
+  private
+
+  def endpoint_for(path)
+    File.join(FbGraph::ROOT_URL, path)
+  end
+
+  def request_for(method, options = {})
+    request = {}
+    if options[:params]
+      case method
+      when :post, :put
+        request[:body] = options[:params]
+      else
+        request[:query] = options[:params]
+      end
+    end
+    if options[:headers]
+      request[:headers] = options[:headers]
+    end
+    request
+  end
+
+  def response_for(response_file, options = {})
+    response = {}
+    response[:body] = File.new(File.join(File.dirname(__FILE__), '../mock_json', "#{response_file}.json"))
+    if options[:status]
+      response[:status] = options[:status]
+    end
+    response
+  end
+end
+
+include WebMockHelper
+WebMock.disable_net_connect!