fb 0.7.0 → 0.7.1

data/README

@@ -178,55 +178,3 @@ conn.close
 
 # We could have called conn.drop.
 # We could still call db.drop
-
-__END__
-5. Changes
-
-0.01 - 1999-06-11 - baseline 
-0.02 - 1999-07-16 - memory bug in ibconn_cursor, English documents.
-0.03 - ???
-0.04 - 2001-08-17 - insert, fetch blobs as strings
-0.05 - 2001-09-05 - add block syntax for Connection#connect and Connection#execute
-0.06 - 2004-11-02 - ???
-0.07 - 2004-11-03 - ???
-
-Change Log
-
-2006-05-18 - 2006-06-04
-
-* Forked to create Fb extension.
-* Converted from K&R to ANSI C.
-* Added ability to create and drop databases.
-* Created near-comprehensive unit tests.
-* Renamed functions for consistency and improved style.
-* Improved error message reporting.
-* Added the option of returning rows as Hashes as well as tuples.
-* Fixed bug inserting blobs larger than 64K.
-* Added methods to retrieve lists of tables, generators, views, stored procedures and roles.
-* Added .NET-style connection strings.
-* Improved reporting on column types.
-* Added the option to report column names in lowercase where they were not already in mixed case (this feature is for Rails).
-* Changed automatic transaction semantics so automatically-started transactions are also committed automatically.
-* Converted from using a single, global transaction to a transaction per connection.
-* Converted from using global buffers to per-cursor input and output buffers.
-* Added RDoc documentation.
-* Insert, update and delete statements may be given an array of tuples for a parameter and will be executed once per tuple.
-* Rewrote README to match new API.
-
-2007-12-11
-
-* Properly scaled NUMERIC and DECIMAL types when inserting with parameters.
-
-2007-12-13
-
-* Rounded instead of flooring NUMERIC and DECIMAL types.
-* Replace deprecated isc_interprete method call for FB2.
-
-2008-04-22
-
-* Implement explicit end-of-data flag for cursors to avoid synchronization error in newer Firebird builds.
-* Allocated longer buffers to avoid memory access error reported by valgrind
-* Tightened up C syntax for stricter compilers.
-* Factored symbol and regex creation out to global scope for efficiency.
-* Removed global transaction functions that weren't exposed anyway.
-* Removed remaining global state. This should allow for better concurrency.

data/extconf.rb

@@ -1,9 +1,9 @@
 #!/usr/bin/env ruby
 # = Windows
 # === Sample of Makefile creation:
-# <tt>ruby extconf.rb --with-opt-dir=C:/Progra~1/Firebird/Firebird_2_1</tt>
+# <tt>ruby extconf.rb --with-opt-dir=C:/Progra~1/Firebird/Firebird_2_5</tt>
 # === Notes
-# * Windows is known to build with Ruby 1.8.7 from rubyinstaller.org.
+# * Windows is known to build with Ruby from rubyinstaller.org.
 # * New in this release is automatically finding your Firebird install under Program Files.
 # * If your install is some place non-standard (or on a non-English version of Windows), you'll need to run extconf.rb manually as above.
 # * mkmf doesn't like directories with spaces, hence the 8.3 notation in the example above.

data/fb.c

@@ -174,7 +174,6 @@ typedef struct trans_opts
 
 /* global utilities */
 
-#define	ALIGN(n, b)	((n + b - 1) & ~(b - 1))
 #define	FB_ALIGN(n, b)	((n + b - 1) & ~(b - 1))
 /* #define FB_ALIGN(n,b)          ((n+1) & ~1) */
 #define	UPPER(c)	(((c) >= 'a' && (c)<= 'z') ? (c) - 'a' + 'A' : (c))
@@ -317,8 +316,9 @@ static void tm_from_timestamp(struct tm *tm, VALUE obj)
 {
 #ifdef TypedData_Get_Struct
 	VALUE year, month, day, hour, min, sec;
-#endif
+#else
 	struct time_object *tobj;
+#endif
 
 	if (!rb_obj_is_kind_of(obj, rb_cTime))
 	{
@@ -646,7 +646,7 @@ static unsigned short fb_connection_db_SQL_Dialect(struct FbConnection *fb_conne
 {
 	long dialect;
 	long length;
-	char db_info_command = isc_info_db_SQL_dialect;
+	char db_info_command = isc_info_db_sql_dialect;
 	char isc_info_buff[16];
 
 	/* Get the db SQL Dialect */
@@ -655,7 +655,7 @@ static unsigned short fb_connection_db_SQL_Dialect(struct FbConnection *fb_conne
 			sizeof(isc_info_buff), isc_info_buff);
 	fb_error_check(fb_connection->isc_status);
 
-	if (isc_info_buff[0] == isc_info_db_SQL_dialect) {
+	if (isc_info_buff[0] == isc_info_db_sql_dialect) {
 		length = isc_vax_integer(&isc_info_buff[1], 2);
 		dialect = isc_vax_integer(&isc_info_buff[3], (short)length);
 	} else {
@@ -1500,7 +1500,7 @@ static void fb_cursor_set_inputparams(struct FbCursor *fb_cursor, long argc, VAL
 	struct FbConnection *fb_connection;
 	long count;
 	long offset;
-	long type;
+	/* long type; */
 	short dtp;
 	VALUE obj;
 	long lvalue;
@@ -1533,7 +1533,7 @@ static void fb_cursor_set_inputparams(struct FbCursor *fb_cursor, long argc, VAL
 	for (count = 0,offset = 0; count < argc; count++) {
 		obj = argv[count];
 
-		type = TYPE(obj);
+		/* type = TYPE(obj); */
 
 		/* Convert the data type for InterBase */
 		var = &fb_cursor->i_sqlda->sqlvar[count];
@@ -1580,7 +1580,11 @@ static void fb_cursor_set_inputparams(struct FbCursor *fb_cursor, long argc, VAL
 							ratio *= 10;
 						obj = double_from_obj(obj);
 						dvalue = NUM2DBL(obj) * ratio;
-						lvalue = (ISC_LONG)(dvalue + 0.5);
+						if (dvalue >= 0.0) {
+							lvalue = (ISC_LONG)(dvalue + 0.5);
+						} else {
+							lvalue = (ISC_LONG)(dvalue - 0.5);
+						}
 					} else {
 						obj = long_from_obj(obj);
 						lvalue = NUM2LONG(obj);
@@ -1601,7 +1605,11 @@ static void fb_cursor_set_inputparams(struct FbCursor *fb_cursor, long argc, VAL
 							ratio *= 10;
 						obj = double_from_obj(obj);
 						dvalue = NUM2DBL(obj) * ratio;
-						lvalue = (ISC_LONG)(dvalue + 0.5);
+						if (dvalue >= 0.0) {
+							lvalue = (ISC_LONG)(dvalue + 0.5);
+						} else {
+							lvalue = (ISC_LONG)(dvalue - 0.5);
+						}
 					} else {
 						obj = long_from_obj(obj);
 						lvalue = NUM2LONG(obj);
@@ -1649,7 +1657,11 @@ static void fb_cursor_set_inputparams(struct FbCursor *fb_cursor, long argc, VAL
 							ratio *= 10;
 						obj = double_from_obj(obj);
 						dvalue = NUM2DBL(obj) * ratio;
-						llvalue = (ISC_INT64)(dvalue + 0.5);
+						if (dvalue >= 0.0) {
+							llvalue = (ISC_INT64)(dvalue + 0.5);
+						} else {
+							llvalue = (ISC_INT64)(dvalue - 0.5);
+						}
 					} else {
 						obj = ll_from_obj(obj);
 						llvalue = NUM2LL(obj);
@@ -2968,7 +2980,7 @@ static void check_page_size(int page_size)
  * :charset:: character set to be used with the connection (default: 'NONE')
  * :role:: database role to connect using (default: nil)
  * :downcase_names:: Column names are reported in lowercase, unless they were originally mixed case (default: nil).
- * :page_size:: page size to use when creating a database (default: 1024)
+ * :page_size:: page size to use when creating a database (default: 4096)
  */
 static VALUE database_initialize(int argc, VALUE *argv, VALUE self)
 {
@@ -2990,7 +3002,7 @@ static VALUE database_initialize(int argc, VALUE *argv, VALUE self)
 		rb_iv_set(self, "@role", rb_hash_aref(parms, ID2SYM(rb_intern("role"))));
 		rb_iv_set(self, "@downcase_names", rb_hash_aref(parms, ID2SYM(rb_intern("downcase_names"))));
 		rb_iv_set(self, "@encoding", default_string(parms, "encoding", "ASCII-8BIT"));
-		rb_iv_set(self, "@page_size", default_int(parms, "page_size", 1024));
+		rb_iv_set(self, "@page_size", default_int(parms, "page_size", 4096));
 	}
 	return self;
 }

data/test/DataTypesTestCases.rb

@@ -483,24 +483,30 @@ class DataTypesTestCases < Test::Unit::TestCase
         elsif cols[i] == 'N92'
           connection.execute(sql_insert, 12345.12)
           connection.execute(sql_insert, "12345.12")
+          connection.execute(sql_insert, -12345.12)
           vals = connection.query(sql_select)
           # puts vals.inspect
           assert_equal 12345.12, vals[0][0], "NUMERIC (decimal)"
           assert_equal 12345.12, vals[1][0], "NUMERIC (string)"
+          assert_equal -12345.12, vals[2][0], "NUMERIC (string)"
         elsif cols[i] == 'D92'
           connection.execute(sql_insert, 12345.12)
           connection.execute(sql_insert, "12345.12")
+          connection.execute(sql_insert, -12345.12)
           vals = connection.query(sql_select)
           # puts vals.inspect
           assert_equal 12345.12, vals[0][0], "DECIMAL (decimal)"
           assert_equal 12345.12, vals[1][0], "DECIMAL (string)"
+          assert_equal -12345.12, vals[2][0], "DECIMAL (string)"
         elsif cols[i] == 'N154'
           connection.execute(sql_insert, 12345.12)
           connection.execute(sql_insert, "12345.12")
+          connection.execute(sql_insert, -12345.12)
           vals = connection.query(sql_select)
           # puts vals.inspect
           assert_equal 12345.12, vals[0][0], "NUMERIC (decimal)"
           assert_equal 12345.12, vals[1][0], "NUMERIC (string)"
+          assert_equal -12345.12, vals[2][0], "NUMERIC (string)"
         end
       end
       connection.drop

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fb
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,9 +9,9 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-15 00:00:00.000000000 Z
+date: 2014-05-07 00:00:00.000000000 Z
 dependencies: []
-description: 
+description: Ruby Firebird Extension Library
 email: rowland@rowlandresearch.com
 executables: []
 extensions:
@@ -32,7 +32,8 @@ files:
 - test/FbTestSuite.rb
 - test/TransactionTestCases.rb
 homepage: http://github.com/rowland/fb
-licenses: []
+licenses:
+- MIT
 post_install_message: 
 rdoc_options:
 - --title
@@ -57,10 +58,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - Firebird client library fbclient.dll, libfbclient.so or Firebird.framework.
-rubyforge_project: fblib
+rubyforge_project: 
 rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: Firebird and Interbase driver
+summary: Firebird database driver
 test_files:
 - test/FbTestSuite.rb