faye-redis-ng 1.0.11 → 1.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a2266042c42929dc9203cf1160bbfd64d429c87cdb076b3369cd55bbf77032e
-  data.tar.gz: 51509e6fb5fb775bfbdcd4db0dada3dfa26f6bee5f5729d2b3fa165b5b417644
+  metadata.gz: 398f99e890ab9d57e91c5f42f93898488c2b1f475f0831d6079e06314a1d4923
+  data.tar.gz: 7191ecc674147302d1ccce44a612ede961d53709059bd21eb69b28cefe527385
 SHA512:
-  metadata.gz: 79c6d4bee6b55572a772a4977fd5b5a5857746c415bac1f6f0a802ad69b16e137642b90d20ec02ec21abb95f69e5fab9ab830f018c6aaa974ad56b2c3202f269
-  data.tar.gz: 38c29ca6cd4330c5a862951b2810e8e095e4dec2939691bd8379ef714f947ad05a0e875bcf55a53de42d35913357d2f05c38f08b0ce16da12e553e2c7a22f1b1
+  metadata.gz: 3fe20898a79896711f0e003aaf9e6e44baa6b455130260bd6d24ce03424460c140d51a55da29fba63920490e6e04691318e244a48d608ac0f9c6ceeca443f4d7
+  data.tar.gz: f3317d04d6423963b17dd05d6e24b5f37b9a416da06780c92f118a94e4e42b3116e444cdb0fa18e89e4ef173d524325bd1e2cc0c54bf7235e4733162df740262

data/CHANGELOG.md

@@ -7,18 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [1.0.11] - 2025-10-31
-
-### Changed - Optimized Subscription TTL
-- **Reduced subscription_ttl from 24 hours to 5 minutes**: More aggressive cleanup of orphaned subscription data
-  - **Previous**: `subscription_ttl: 86400` (24 hours)
-  - **New**: `subscription_ttl: 300` (5 minutes = 5x client_timeout)
-  - **Rationale**: Client keys expire after 60 seconds, keeping subscription data for 24 hours was excessive
-  - **Impact**: Faster memory reclamation for disconnected clients while maintaining safety net
-  - **Benefits**:
-    - Reduces memory footprint by cleaning up orphaned subscriptions faster
-    - Maintains 5-minute safety window (5 GC cycles) for proper cleanup
-    - Allows short-lived reconnections within 5 minutes to reuse subscription data
+## [1.0.12] - 2025-11-01
+
+### Changed - Aligned Subscription TTL with Message TTL
+- **Adjusted subscription_ttl to 1 hour**: Match message_ttl to prevent message loss window
+  - **Previous (v1.0.11)**: `subscription_ttl: 300` (5 minutes)
+  - **New**: `subscription_ttl: 3600` (1 hour, same as message_ttl)
+  - **Rationale**:
+    - Subscription and message TTL must be aligned to prevent message loss window
+    - If subscription expires before messages, new messages won't be enqueued for disconnected clients
+    - Example: If subscription expires at 5 minutes but messages persist for 1 hour, any new messages after 5 minutes won't reach the client even if they reconnect within 1 hour
+  - **Impact**:
+    - Prevents message loss: disconnected clients get all messages within 1-hour window
+    - No TTL gap: subscriptions and messages expire together
+    - Conservative approach for reliable message delivery
+  - **Trade-offs**:
+    - Uses more memory than 5-minute TTL (but still 96% less than original 24 hours)
+    - 1-hour reconnection window is sufficient for most mobile/network interruptions
+    - Maintains 60x safety buffer (60 GC cycles @ 60s interval) for proper cleanup
   - **Affected keys**:
     - `{namespace}:subscriptions:{client_id}` (SET)
     - `{namespace}:channels:{channel}` (SET)
@@ -27,9 +33,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - **Backward compatibility**: Users can still override with custom `subscription_ttl` option
 
 ### Notes
-- This change is safe because automatic GC runs every 60 seconds by default
-- The 5-minute TTL provides sufficient buffer (5 GC cycles) for cleanup
+- This change ensures subscriptions don't expire before their associated messages
+- The 1-hour TTL provides ample buffer (60 GC cycles) for cleanup
 - TTL-safe implementation (v1.0.10) ensures active subscriptions maintain their original TTL
+- Conservative approach: prioritizes message delivery over aggressive memory optimization
+
+## [1.0.11] - 2025-10-31
+
+### Changed - Reduced Subscription TTL (Reverted in v1.0.12)
+- **Reduced subscription_ttl from 24 hours to 5 minutes**: More aggressive cleanup of orphaned subscription data
+  - **Previous**: `subscription_ttl: 86400` (24 hours)
+  - **New**: `subscription_ttl: 300` (5 minutes = 5x client_timeout)
+  - **Issue discovered**: This created a message loss window - subscriptions expired in 5 minutes but messages persisted for 1 hour
+  - **Resolution**: Reverted in v1.0.12 to align with message_ttl (1 hour)
 
 ## [1.0.10] - 2025-10-30
 

data/README.md

@@ -80,7 +80,7 @@ bayeux = Faye::RackAdapter.new(app, {
   # Data expiration
   client_timeout: 60,         # Client session timeout (seconds)
   message_ttl: 3600,          # Message TTL (seconds)
-  subscription_ttl: 300,      # Subscription keys TTL (seconds, default: 5 minutes)
+  subscription_ttl: 3600,     # Subscription keys TTL (seconds, default: 1 hour)
 
   # Garbage collection
   gc_interval: 60,            # Automatic GC interval (seconds), set to 0 or false to disable

data/lib/faye/redis/subscription_manager.rb

@@ -12,7 +12,7 @@ module Faye
       # Subscribe a client to a channel
       def subscribe(client_id, channel, &callback)
         timestamp = Time.now.to_i
-        subscription_ttl = @options[:subscription_ttl] || 300  # 5 minutes default (5x client_timeout)
+        subscription_ttl = @options[:subscription_ttl] || 3600  # 1 hour default (matches message_ttl)
 
         client_subs_key = client_subscriptions_key(client_id)
         channel_subs_key = channel_subscribers_key(channel)

data/lib/faye/redis/version.rb

@@ -1,5 +1,5 @@
 module Faye
   class Redis
-    VERSION = '1.0.11'
+    VERSION = '1.0.12'
   end
 end

data/lib/faye/redis.rb

@@ -25,7 +25,7 @@ module Faye
       retry_delay: 1,
       client_timeout: 60,
       message_ttl: 3600,
-      subscription_ttl: 300,  # Subscription keys TTL (5 minutes = 5x client_timeout), provides safety net if GC fails
+      subscription_ttl: 3600,  # Subscription keys TTL (1 hour, matches message_ttl), provides safety net if GC fails
       namespace: 'faye',
       gc_interval: 60,  # Automatic garbage collection interval (seconds), set to 0 or false to disable
       cleanup_batch_size: 50  # Number of items per batch during cleanup (min: 1, max: 1000, prevents blocking)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: faye-redis-ng
 version: !ruby/object:Gem::Version
-  version: 1.0.11
+  version: 1.0.12
 platform: ruby
 authors:
 - Zac