favicon_extractor 0.1.0 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b44ee0289ac7c0c1df82a2b3d88feeae973629d580fc68dfc051a9451ba85ff5
-  data.tar.gz: bd3723310fa22090b0e49a7d6aede1e2d0ccc9ebf6842bbafdfe59515af87b3f
+  metadata.gz: 187e199988b118245705c57d38190d320b5762f9a524d6c6b3c0a4981e91b142
+  data.tar.gz: be53d57f3048b09384f561ee11f811283623d65db04bf164bd87f2e393ac227a
 SHA512:
-  metadata.gz: dd75749abe808208f3d2b2be8bf61fdc76569e126fe51c4b19d481f93a2a1d678c9835edb591d5fbe6f568c9238c0c2bf8249717b94b1d84ad5b0622338dc644
-  data.tar.gz: 22e4faefc50ce89187f7d0a19ec05cdbe5eb8a4d2f206bb9a119d2b76189ff64e648a3179d6a7fcec2c89dd6d4c62614a26b1c46da28b15aafecb93a91de0182
+  metadata.gz: 2948579cd27161d98505c7caea5c66797ae3fa0f62e67bf16f83f26f0f6976ecb022e325b74f43f6f60f14421137327e03c9233f814afa072e66499d9c34498e
+  data.tar.gz: cf3d613a3deb6ddbfd295db1d863751fe83b92fdd835559e0742224e54f27f74bffcad845421b367668bb7f5ab764841b6bbbb4a7bd1bf3d2ae0279ce2431748

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    favicon_extractor (0.1.0)
+    favicon_extractor (0.1.2)
       fastimage (~> 2.2)
 
 GEM
@@ -54,6 +54,7 @@ GEM
 
 PLATFORMS
   x86_64-darwin-21
+  x86_64-linux
 
 DEPENDENCIES
   fastimage (~> 2.2)

data/README.md

@@ -14,7 +14,7 @@ If bundler is not being used to manage dependencies, install the gem by executin
 
 ## Usage
 
-```
+```ruby
 require 'favicon_extractor'
 
 FaviconExtractor.extract("http://google.com")
@@ -29,7 +29,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/favicon_extractor. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/favicon_extractor/blob/master/CODE_OF_CONDUCT.md).
+Bug reports and pull requests are welcome on GitHub at https://github.com/leeourand/favicon_extractor. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/leeourand/favicon_extractor/blob/master/CODE_OF_CONDUCT.md).
 
 ## License
 
@@ -37,4 +37,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the FaviconExtractor project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/favicon_extractor/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the FaviconExtractor project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/leeourand/favicon_extractor/blob/master/CODE_OF_CONDUCT.md).

data/lib/favicon_extractor/extracts_favicons_from_html.rb

@@ -1,12 +1,14 @@
+require 'pry'
 module FaviconExtractor
   class ExtractsFaviconsFromHtml
     class << self
       def extract(html, url)
-        html.scan(/<link.*icon.*>/).flatten.map do |str|
+        @url = url
+        html.scan(/<link.*?icon.*?>/).flatten.map do |str|
           str.match(/href="(.*?)"/).captures.first
         end
           .map { |str| handle_relative_paths(str) }
-          .append(default_favicon_for(url))
+          .append(default_favicon)
       end
 
       private
@@ -15,7 +17,7 @@ module FaviconExtractor
 
       def handle_relative_paths(str)
         if str.start_with?("/")
-          uri = URI(url)
+          uri = URI(@url)
           uri.path = str
           uri.to_s
         else
@@ -23,8 +25,8 @@ module FaviconExtractor
         end
       end
 
-      def default_favicon_for(url)
-        uri = URI(url)
+      def default_favicon
+        uri = URI(@url)
         uri.path = DEFAULT_FAVICON_PATH
         uri.to_s
       end

data/lib/favicon_extractor/makes_http_requests.rb

@@ -1,27 +1,36 @@
 module FaviconExtractor
   class MakesHttpRequests
     def self.request(location)
-      new.request(location)
+      new(location).request
     end
 
-    def initialize
+    def initialize(url)
       @redirect_limit = 10
       @redirects = 0
+      @url = url
     end
 
-    def request(location)
+    def request
       raise ArgumentError, "too many redirects" if @redirects > redirect_limit
 
       begin
-        response = Net::HTTP.get_response(URI(location))
+        uri = URI(url)
+        response = Net::HTTP.start(uri.host,
+          uri.port,
+          read_timeout: 10,
+          open_timeout: 10,
+          ssl_timeout: 10,
+          use_ssl: uri.scheme == "https") do |http|
+          http.request(Net::HTTP::Get.new(uri))
+        end
 
         case response
         when Net::HTTPSuccess
           response.body
         when Net::HTTPRedirection
           @redirects += 1
-          location = response["location"]
-          request(location)
+          @url = response["location"]
+          request
         else
           response.value
         end
@@ -30,6 +39,6 @@ module FaviconExtractor
 
     private
 
-    attr_reader :redirect_limit
+    attr_reader :redirect_limit, :url
   end
 end

data/lib/favicon_extractor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FaviconExtractor
-  VERSION = "0.1.0"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: favicon_extractor
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.3
 platform: ruby
 authors:
 - Lee Ourand