fat_zebra 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9a4b0c24c9b0a769d463452e4c1826477908e7c
-  data.tar.gz: e023bcc5106aad407e116d72db57c81c3c9b0c0f
+  metadata.gz: 57875bf7e3c1fb775a6fd1dd26ccd44f5d145abf
+  data.tar.gz: fe734d0bb133c3fe08aaab48921e4d95f808019b
 SHA512:
-  metadata.gz: 85db673360acbb895e0e5560eedc8bf5a6683417173769266232e0dc8a61a97a1d5a56ab4ae4065a8c696e679ed7798923dd021077f16c8b4e6f5a20e7e28910
-  data.tar.gz: 04a5cc56c681b18ebd1ab9c26ff573c5903d1a3aa79c1eafe12852a3d8f8314139ffbe10ed2052c100db2eb66689a841bb94ce46c894d0be307ee86aea71aa33
+  metadata.gz: e20f23ef8ea97426baefa11501cd720222793b13417e03ec29e6b16ae55f3c2989e5114fdc38e23a733f018beae019170d69a9ea1e29e8a8c874fa1b30a7dc3c
+  data.tar.gz: 363f87999dadd14104e2594572f8bd906cdb07275519ba510db42060d5a07e2e4aa92b09d2079ee943fddacde2b56878d80960399a7b51277feb9c9e943a3055

data/lib/fat_zebra/batch.rb

@@ -17,9 +17,9 @@ module FatZebra
     include FatZebra::APIOperation::Save
     include FatZebra::APIOperation::Delete
 
-    validates :filename, required: true, class_type: String, on: :create
-    validates :file, required: true, class_type: File, on: :create
-    validates :multipart, required: true, class_type: TrueClass, on: :create
+    validates :filename, required: true, type: :batch_filename, on: :create
+    validates :file, required: true, type: :file_type, on: :create
+    validates :multipart, required: true, type: :boolean, on: :create
 
     class << self
 

data/lib/fat_zebra/direct_credit.rb

@@ -17,7 +17,7 @@ module FatZebra
     include FatZebra::APIOperation::Delete
 
     validates :description, required: true, on: :create
-    validates :amount, required: true, class_type: Integer, on: :create
+    validates :amount, required: true, type: :positive_numeric, on: :create
     validates :bsb, required: true, on: :create
     validates :account_name, required: true, on: :create
     validates :account_number, required: true, on: :create

data/lib/fat_zebra/direct_debit.rb

@@ -17,7 +17,7 @@ module FatZebra
     include FatZebra::APIOperation::Delete
 
     validates :description, required: true, on: :create
-    validates :amount, required: true, class_type: Integer, on: :create
+    validates :amount, required: true, type: :positive_numeric, on: :create
     validates :bsb, required: true, on: :create
     validates :account_name, required: true, on: :create
     validates :account_number, required: true, on: :create

data/lib/fat_zebra/purchase.rb

@@ -22,7 +22,7 @@ module FatZebra
     validates :card_number, required: { unless: %i[card_token wallet] }, on: :create
     validates :card_token, required: { unless: %i[card_number wallet] }, on: :create
     validates :card_expiry, required: { unless: %i[card_token wallet] }, on: :create
-    validates :amount, required: true, class_type: Integer, on: :create
+    validates :amount, required: true, type: :positive_integer, on: :create
     validates :reference, required: true, on: :create
     validates :customer_ip, required: true, on: :create
 

data/lib/fat_zebra/validation.rb

@@ -39,8 +39,24 @@ module FatZebra
       errors << "'#{field}' is required" if params[field].nil? || params[field] == ''
     end
 
-    def validate_class_type(field, options, params)
-      errors << "'#{field}' is not a '#{options}'" unless params[field].is_a?(options)
+    def validate_type(field, options, params)
+      regexp =
+        case options
+        when :positive_numeric
+          /\A\d*\.?\d+\z/
+        when :positive_integer
+          /\A\d*\z/
+        when :batch_filename
+          /\ABATCH-(?<version>v\d)-(?<type>[A-Z]*)-((?<merchant_username>[A-Z0-9]*\-?[A-Z0-9]*)-)?(?<process_date>\d{8})-(?<reference>[a-zA-Z0-9\-_]*).csv\z/i
+        when :file_type
+          /\A\#\<File\:.*\z/
+        when :boolean
+          /\Atrue|false\z/
+        else
+          raise RequestValidationError, "Unknown type #{options} for #{field}"
+        end
+
+      errors << "'#{field}' is not a '#{options}'" unless params[field].to_s =~ regexp
     end
 
   end

data/lib/fat_zebra/version.rb

@@ -1,3 +1,3 @@
 module FatZebra
-  VERSION = '3.0.2'.freeze
+  VERSION = '3.0.3'.freeze
 end

data/spec/cassettes/FatZebra_DirectCredit/_create/validations/valid/1_1_5_1_1.yml

@@ -0,0 +1,54 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://gateway.sandbox.fatzebra.com.au/v1.0/direct_credits
+    body:
+      encoding: UTF-8
+      string: '{"description":"Confirmation","amount":42.42,"bsb":"123-123","account_name":"Test","account_number":"012345678","test":true}'
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - application/json
+      User-Agent:
+      - Ruby
+      Authorization:
+      - Basic VEVTVDpURVNU
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 201
+      message: Created
+    headers:
+      Date:
+      - Thu, 05 Oct 2017 04:32:57 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Status:
+      - 201 Created
+      Cache-Control:
+      - no-store
+      X-Request-Version:
+      - 1.20.4
+      Pragma:
+      - no-cache
+      X-Request-Id:
+      - 304387854316f4399af6ecf6f8bb7eb3
+      X-Runtime:
+      - '0.037728'
+      X-Rack-Cache:
+      - invalidate, pass
+      X-Backend:
+      - sbox-priv-gateway-a
+    body:
+      encoding: UTF-8
+      string: '{"successful":true,"response":{"id":"071-DC-XVIW0KJG","amount":42.42,"bsb":"123-123","account_number":"012345678","account_name":"Test","description":"Confirmation","reference":"071-DC-XVIW0KJG","date":"2017-10-05","process_date":null,"status":"New","result":null,"metadata":{}},"errors":[],"test":true}'
+    http_version: 
+  recorded_at: Thu, 05 Oct 2017 04:32:57 GMT
+recorded_with: VCR 3.0.3

data/spec/cassettes/FatZebra_DirectDebit/_create/validations/valid/1_1_5_1_1.yml

@@ -0,0 +1,54 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://gateway.sandbox.fatzebra.com.au/v1.0/direct_debits
+    body:
+      encoding: UTF-8
+      string: '{"description":"Confirmation","amount":42.42,"bsb":"123-123","account_name":"Test","account_number":"012345678","test":true}'
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - application/json
+      User-Agent:
+      - Ruby
+      Authorization:
+      - Basic VEVTVDpURVNU
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 201
+      message: Created
+    headers:
+      Date:
+      - Thu, 05 Oct 2017 04:28:44 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Status:
+      - 201 Created
+      Cache-Control:
+      - no-store
+      X-Request-Version:
+      - 1.20.4
+      Pragma:
+      - no-cache
+      X-Request-Id:
+      - 2b5ea6816467df484d4649cc7a56932e
+      X-Runtime:
+      - '0.035993'
+      X-Rack-Cache:
+      - invalidate, pass
+      X-Backend:
+      - sbox-priv-gateway-a
+    body:
+      encoding: UTF-8
+      string: '{"successful":true,"response":{"id":"071-DD-551C0W7W","amount":42.42,"bsb":"123-123","account_number":"012345678","account_name":"Test","description":"Confirmation","reference":"071-DD-551C0W7W","date":"2017-10-05","process_date":null,"status":"New","result":null,"metadata":{}},"errors":[],"test":true}'
+    http_version: 
+  recorded_at: Thu, 05 Oct 2017 04:28:44 GMT
+recorded_with: VCR 3.0.3

data/spec/lib/fat_zebra/direct_credit_spec.rb

@@ -19,9 +19,17 @@ describe FatZebra::DirectCredit do
     it { expect(direct_credit.id).to_not be_empty }
 
     context 'validations' do
-      let(:valid_direct_credit_payload) {{}}
+      context 'valid' do
+        before { valid_direct_credit_payload[:amount] = 42.42 }
 
-      it { expect{ direct_credit }.to raise_error(FatZebra::RequestValidationError) }
+        it { is_expected.to be_accepted }
+      end
+
+      context 'failed' do
+        let(:valid_direct_credit_payload) {{}}
+
+        it { expect{ direct_credit }.to raise_error(FatZebra::RequestValidationError) }
+      end
     end
   end
 

data/spec/lib/fat_zebra/direct_debit_spec.rb

@@ -19,9 +19,17 @@ describe FatZebra::DirectDebit do
     it { expect(direct_debit.id).to_not be_empty }
 
     context 'validations' do
-      let(:valid_direct_debit_payload) {{}}
+      context 'valid' do
+        before { valid_direct_debit_payload[:amount] = 42.42 }
 
-      it { expect{ direct_debit }.to raise_error(FatZebra::RequestValidationError) }
+        it { is_expected.to be_accepted }
+      end
+
+      context 'failed' do
+        let(:valid_direct_debit_payload) {{}}
+
+        it { expect{ direct_debit }.to raise_error(FatZebra::RequestValidationError) }
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fat_zebra
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - Matthew Savage
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-18 00:00:00.000000000 Z
+date: 2017-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -209,6 +209,7 @@ files:
 - spec/cassettes/FatZebra_DirectCredit/_create/1_1_4.yml
 - spec/cassettes/FatZebra_DirectCredit/_create/1_1_5.yml
 - spec/cassettes/FatZebra_DirectCredit/_create/validations/1_1_5_1.yml
+- spec/cassettes/FatZebra_DirectCredit/_create/validations/valid/1_1_5_1_1.yml
 - spec/cassettes/FatZebra_DirectCredit/_delete/1_4_1.yml
 - spec/cassettes/FatZebra_DirectCredit/_delete/1_4_2.yml
 - spec/cassettes/FatZebra_DirectCredit/_find/1_2_1.yml
@@ -222,6 +223,7 @@ files:
 - spec/cassettes/FatZebra_DirectDebit/_create/1_1_4.yml
 - spec/cassettes/FatZebra_DirectDebit/_create/1_1_5.yml
 - spec/cassettes/FatZebra_DirectDebit/_create/validations/1_1_5_1.yml
+- spec/cassettes/FatZebra_DirectDebit/_create/validations/valid/1_1_5_1_1.yml
 - spec/cassettes/FatZebra_DirectDebit/_delete/1_4_1.yml
 - spec/cassettes/FatZebra_DirectDebit/_delete/1_4_2.yml
 - spec/cassettes/FatZebra_DirectDebit/_find/1_2_1.yml