fat_zebra 3.0.0 → 3.0.1

data/spec/lib/fat_zebra/bank_account_spec.rb

@@ -11,7 +11,7 @@ describe FatZebra::BankAccount do
   describe '.create', :vcr do
     subject(:bank_account) { FatZebra::BankAccount.create(valid_bank_account_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(bank_account.id).to_not be_empty }
 
     context 'validations' do
@@ -26,7 +26,7 @@ describe FatZebra::BankAccount do
 
     before { 2.times { |i| FatZebra::BankAccount.create(valid_bank_account_payload) } }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(bank_accounts.data.count).to be >= 2 }
     it { expect(bank_accounts.data.first).to be_a(FatZebra::BankAccount) }
   end

data/spec/lib/fat_zebra/batch_spec.rb

@@ -12,7 +12,7 @@ describe FatZebra::Batch do
     subject(:batch) { FatZebra::Batch.create(valid_batch_payload) }
 
     context 'with file' do
-      it { is_expected.to be_successful }
+      it { is_expected.to be_accepted }
       it { expect(batch.reference).to_not be_empty }
     end
 
@@ -22,7 +22,7 @@ describe FatZebra::Batch do
         filename: "BATCH-v1-PURCHASE-TEST-#{Time.now.strftime('%Y%m%d')}-#{SecureRandom.hex}.csv"
       }}
 
-      it { is_expected.to be_successful }
+      it { is_expected.to be_accepted }
       it { expect(batch.reference).to_not be_empty }
     end
 
@@ -37,14 +37,14 @@ describe FatZebra::Batch do
     let(:create) { FatZebra::Batch.create(valid_batch_payload) }
     subject(:batch) { FatZebra::Batch.find(create.reference) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(batch.reference).to eq(create.reference) }
   end
 
   describe '.search', :vcr do
     subject(:batches) { FatZebra::Batch.search }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(batches.data.count).to be >= 2 }
     it { expect(batches.data.first).to be_a(FatZebra::Batch) }
   end

data/spec/lib/fat_zebra/card_spec.rb

@@ -5,7 +5,7 @@ describe FatZebra::Card do
   describe '.create', :vcr do
     subject(:credit_card) { FatZebra::Card.create(valid_credit_card_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(credit_card.token).to_not be_empty }
     it { expect(credit_card.card_holder).to eq('Matthew Savage') }
     it { expect(credit_card.card_number).to_not be_empty }
@@ -27,7 +27,7 @@ describe FatZebra::Card do
     let(:create) { FatZebra::Card.create(valid_credit_card_payload) }
     subject(:credit_card) { FatZebra::Card.update(create.token, valid_credit_card_update_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(credit_card.token).to eq(create.token) }
     it { expect(credit_card.card_expiry).to_not eq(create.card_expiry) }
 

data/spec/lib/fat_zebra/config_spec.rb

@@ -25,8 +25,6 @@ describe FatZebra::Config do
         test_mode:   'my-test_mode',
         http_secure: 'my-http_secure',
         api_version: 'my-api_version',
-        sandbox:     'my-sandbox',
-        options:     'my-options',
         proxy:       'my-proxy'
       }}
 
@@ -35,8 +33,6 @@ describe FatZebra::Config do
       it { expect(config.test_mode).to eq(params[:test_mode]) }
       it { expect(config.http_secure).to eq(params[:http_secure]) }
       it { expect(config.api_version).to eq(params[:api_version]) }
-      it { expect(config.sandbox).to eq(params[:sandbox]) }
-      it { expect(config.options).to eq(params[:options]) }
       it { expect(config.proxy).to eq(params[:proxy]) }
     end
 
@@ -48,5 +44,27 @@ describe FatZebra::Config do
       end
     end
 
+    context 'with gateway' do
+      before { expect(config.valid!).to be_truthy }
+
+      context 'with production' do
+        subject(:config) { FatZebra::Config.new(params.merge(gateway: :production)) }
+
+        it { expect(config.gateway).to eq('gateway.fatzebra.com.au') }
+      end
+    end
+
+    context 'remove http' do
+      let(:params) {{
+        token:    'my-token',
+        username: 'my-username',
+        gateway:  'http://my-gateway',
+        proxy:    'https://my-proxy'
+      }}
+
+      it { expect(config.gateway).to eq('my-gateway') }
+      it { expect(config.proxy).to eq('my-proxy') }
+    end
+
   end
 end

data/spec/lib/fat_zebra/customer_spec.rb

@@ -5,7 +5,7 @@ describe FatZebra::Customer do
   describe '.create', :vcr do
     subject(:customer) { FatZebra::Customer.create(customer_valid_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(customer.id).to_not be_empty }
     it { expect(customer.first_name).to eq(customer_valid_payload[:first_name]) }
     it { expect(customer.last_name).to eq(customer_valid_payload[:last_name]) }
@@ -22,7 +22,7 @@ describe FatZebra::Customer do
   describe '.search', :vcr do
     subject(:purchases) { FatZebra::Customer.search }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(purchases.data.count).to be >= 2 }
     it { expect(purchases.data.first).to be_a(FatZebra::Customer) }
   end
@@ -31,7 +31,7 @@ describe FatZebra::Customer do
     let!(:create) { FatZebra::Customer.create(customer_valid_payload) }
     subject(:customer) { FatZebra::Customer.find(create.reference) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(customer.reference).to eq(create.reference) }
   end
 
@@ -39,7 +39,7 @@ describe FatZebra::Customer do
     let(:create) { FatZebra::Customer.create(customer_valid_payload) }
     subject(:customer) { FatZebra::Customer.update(create.id, first_name: 'New Name') }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(customer.first_name).to eq('New Name') }
   end
 
@@ -47,7 +47,7 @@ describe FatZebra::Customer do
     let(:create) { FatZebra::Customer.create(customer_valid_payload) }
     subject(:customer) { FatZebra::Customer.delete(create.id) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
   end
 
 end

data/spec/lib/fat_zebra/direct_credit_spec.rb

@@ -13,7 +13,7 @@ describe FatZebra::DirectCredit do
   describe '.create', :vcr do
     subject(:direct_credit) { FatZebra::DirectCredit.create(valid_direct_credit_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_credit.bsb).to eq(valid_direct_credit_payload[:bsb]) }
     it { expect(direct_credit.reference).to_not be_empty }
     it { expect(direct_credit.id).to_not be_empty }
@@ -29,7 +29,7 @@ describe FatZebra::DirectCredit do
     let!(:create) { FatZebra::DirectCredit.create(valid_direct_credit_payload) }
     subject(:direct_credit) { FatZebra::DirectCredit.find(create.reference) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_credit.reference).to eq(create.reference) }
   end
 
@@ -39,7 +39,7 @@ describe FatZebra::DirectCredit do
 
     before { 2.times { |i| FatZebra::DirectCredit.create(valid_direct_credit_payload) } }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_credits.data.count).to be >= 2 }
   end
 
@@ -47,7 +47,7 @@ describe FatZebra::DirectCredit do
     let(:create) { FatZebra::DirectCredit.create(valid_direct_credit_payload) }
     subject(:direct_credit) { FatZebra::DirectCredit.delete(create.id) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
   end
 
 end

data/spec/lib/fat_zebra/direct_debit_spec.rb

@@ -13,7 +13,7 @@ describe FatZebra::DirectDebit do
   describe '.create', :vcr do
     subject(:direct_debit) { FatZebra::DirectDebit.create(valid_direct_debit_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_debit.bsb).to eq(valid_direct_debit_payload[:bsb]) }
     it { expect(direct_debit.reference).to_not be_empty }
     it { expect(direct_debit.id).to_not be_empty }
@@ -29,7 +29,7 @@ describe FatZebra::DirectDebit do
     let!(:create) { FatZebra::DirectDebit.create(valid_direct_debit_payload) }
     subject(:direct_debit) { FatZebra::DirectDebit.find(create.reference) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_debit.reference).to eq(create.reference) }
   end
 
@@ -39,7 +39,7 @@ describe FatZebra::DirectDebit do
 
     before { 2.times { |i| FatZebra::DirectDebit.create(valid_direct_debit_payload) } }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_debits.data.count).to be >= 2 }
   end
 
@@ -47,7 +47,7 @@ describe FatZebra::DirectDebit do
     let(:create) { FatZebra::DirectDebit.create(valid_direct_debit_payload) }
     subject(:direct_debit) { FatZebra::DirectDebit.delete(create.id) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
   end
 
 end

data/spec/lib/fat_zebra/fat_zebra_object_spec.rb

@@ -8,6 +8,7 @@ describe FatZebra::FatZebraObject do
   let(:api_response) {{
     'successful' => true,
     'response' => {
+      successful: true,
       id: 84,
       other: 'other test'
     }
@@ -68,7 +69,7 @@ describe FatZebra::FatZebraObject do
 
     before { instance.load_response_api(response) }
 
-    it { expect(instance.successful).to be_truthy }
+    it { expect(instance.accepted).to be_truthy }
     it { expect(instance.errors).to eq([]) }
   end
 
@@ -99,7 +100,7 @@ describe FatZebra::FatZebraObject do
     context 'with array' do
       subject(:instance) { klass.initialize_from(api_responses) }
 
-      it { is_expected.to be_successful }
+      it { is_expected.to be_accepted }
       it { expect(instance.data.size).to eq(1) }
     end
   end

data/spec/lib/fat_zebra/payment_plan_spec.rb

@@ -19,7 +19,7 @@ describe FatZebra::PaymentPlan do
   describe '.create', :vcr do
     subject(:payment_plan) { FatZebra::PaymentPlan.create(payment_plan_valid_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(payment_plan.id).to_not be_empty }
     it { expect(payment_plan.payments.count).to eq(5) }
 
@@ -34,7 +34,7 @@ describe FatZebra::PaymentPlan do
     let!(:create) { FatZebra::PaymentPlan.create(payment_plan_valid_payload) }
     subject(:payment_plan) { FatZebra::PaymentPlan.find(create.reference) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(payment_plan.reference).to eq(create.reference) }
     it { expect(payment_plan).to be_a(FatZebra::PaymentPlan) }
   end
@@ -44,7 +44,7 @@ describe FatZebra::PaymentPlan do
 
     subject(:payment_plan) { FatZebra::PaymentPlan.update(create.id, new_status: 'Suspended') }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(payment_plan.status).to eq('Suspended') }
     it { expect(payment_plan).to be_a(FatZebra::PaymentPlan) }
   end
@@ -62,7 +62,7 @@ describe FatZebra::PaymentPlan do
     let(:create) { FatZebra::PaymentPlan.create(payment_plan_valid_payload) }
     subject(:payment_plan) { FatZebra::PaymentPlan.delete(create.id) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
   end
 
   describe '#destroy', :vcr do

data/spec/lib/fat_zebra/purchase_spec.rb

@@ -5,6 +5,7 @@ describe FatZebra::Purchase do
   describe '.create', :vcr do
     subject(:purchase) { FatZebra::Purchase.create(valid_purchase_payload) }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to be_successful }
     it { expect(purchase.card_holder).to eq(valid_purchase_payload[:card_holder]) }
     it { expect(purchase.currency).to eq('AUD') }
@@ -18,6 +19,13 @@ describe FatZebra::Purchase do
     it { expect(purchase.metadata).to eq({}) }
     it { expect(purchase.response_code).to eq('00') }
 
+    context 'bad request' do
+      subject(:purchase) { FatZebra::Purchase.create(valid_purchase_payload.merge(currency: 'XXX' )) }
+
+      it { is_expected.to_not be_accepted }
+      it { is_expected.to_not be_successful }
+    end
+
     context 'validations' do
       let(:valid_purchase_payload) {{}}
 
@@ -29,6 +37,7 @@ describe FatZebra::Purchase do
     let!(:create) { FatZebra::Purchase.create(valid_purchase_payload) }
     subject(:purchase) { FatZebra::Purchase.find(create.reference) }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to be_successful }
     it { expect(purchase.reference).to eq(create.reference) }
     it { expect(purchase.transaction_id).to eq(create.transaction_id) }
@@ -40,7 +49,7 @@ describe FatZebra::Purchase do
 
     before { 2.times { |i| FatZebra::Purchase.create(valid_purchase_payload.merge(reference: "#{SecureRandom.hex}-#{i}")) } }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(purchases.data.count).to be >= 2 }
     it { expect(purchases.data.first).to be_a(FatZebra::Purchase) }
   end
@@ -49,6 +58,7 @@ describe FatZebra::Purchase do
     let(:purchase) { FatZebra::Purchase.create(valid_purchase_payload) }
     subject(:refund) { purchase.refund }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to be_successful }
     it { expect(refund).to be_a(FatZebra::Refund) }
   end
@@ -57,6 +67,7 @@ describe FatZebra::Purchase do
     let(:purchase) { FatZebra::Purchase.create(valid_purchase_payload.merge(capture: false)) }
     subject(:capture) { purchase.capture }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to be_successful }
     it { expect(capture).to be_a(FatZebra::Purchase) }
   end
@@ -65,15 +76,17 @@ describe FatZebra::Purchase do
     let(:purchase) { FatZebra::Purchase.create(valid_purchase_payload) }
     subject(:void) { FatZebra::Purchase.void(purchase.id) }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to_not be_successful }
     it { expect(void.message).to eq('Voided') }
     it { expect(void).to be_a(FatZebra::Purchase) }
   end
 
   describe '#void', :vcr do
-    let(:purchase) { FatZebra::Purchase.create(valid_purchase_payload) }
+    subject(:purchase) { FatZebra::Purchase.create(valid_purchase_payload) }
     before { expect(purchase.void).to be_truthy }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to_not be_successful }
     it { expect(purchase.message).to eq('Voided') }
     it { expect(purchase).to be_a(FatZebra::Purchase) }
@@ -84,7 +97,7 @@ describe FatZebra::Purchase do
 
     subject(:settlement) { FatZebra::Purchase.settlement(from: Time.now - (86400 * 5), to: Time.now) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(settlement.data.count).to be >= 2 }
     it { expect(settlement.data.first).to be_a(FatZebra::Purchase) }
   end

data/spec/lib/fat_zebra/refund_spec.rb

@@ -13,6 +13,7 @@ describe FatZebra::Refund do
     let(:reference) { purchase.reference }
     subject(:refund) { FatZebra::Refund.create(valid_refund_payload) }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to be_successful }
     it { expect(refund.authorization.to_s).to_not be_empty }
     it { expect(refund.id).to_not be_empty }
@@ -38,6 +39,7 @@ describe FatZebra::Refund do
 
     subject(:direct_credit) { FatZebra::Refund.find(create.reference) }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to be_successful }
     it { expect(direct_credit.reference).to eq(create.reference) }
   end
@@ -52,7 +54,7 @@ describe FatZebra::Refund do
       end
     end
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(direct_credits.data.count).to be >= 2 }
   end
 
@@ -60,10 +62,11 @@ describe FatZebra::Refund do
     let(:purchase) { FatZebra::Purchase.create(valid_purchase_payload) }
     let(:transaction_id) { purchase.transaction_id }
     let(:reference) { purchase.reference }
-    let(:refund) { FatZebra::Refund.create(valid_refund_payload) }
+    subject(:refund) { FatZebra::Refund.create(valid_refund_payload) }
 
     before { refund.void() }
 
+    it { is_expected.to be_accepted }
     it { is_expected.to_not be_successful }
     it { expect(refund.message).to eq('Voided') }
     it { expect(refund).to be_a(FatZebra::Refund) }

data/spec/lib/fat_zebra/util_spec.rb

@@ -10,6 +10,11 @@ describe FatZebra::Util do
     it { expect(FatZebra::Util.encode_parameters(id: 42, other: 'test')).to eq("id=42&other=test") }
   end
 
+  describe '#camelize' do
+    it { expect(FatZebra::Util.camelize('model')).to eq("Model") }
+    it { expect(FatZebra::Util.camelize('my_model')).to eq("MyModel") }
+  end
+
   describe '#underscore' do
     it { expect(FatZebra::Util.underscore('Model')).to eq("model") }
     it { expect(FatZebra::Util.underscore('MyModel')).to eq("my_model") }

data/spec/lib/fat_zebra/web_hook_spec.rb

@@ -12,7 +12,7 @@ describe FatZebra::WebHook do
   describe '.create', :vcr do
     subject(:web_hook) { FatZebra::WebHook.create(valid_web_hook_payload) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(web_hook.name).to eq('test hook') }
     it { expect(web_hook.id).to_not be_empty }
 
@@ -28,7 +28,7 @@ describe FatZebra::WebHook do
 
     before { 2.times { |i| FatZebra::WebHook.create(valid_web_hook_payload) } }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(web_hooks.data.count).to be >= 2 }
   end
 
@@ -36,7 +36,7 @@ describe FatZebra::WebHook do
     subject(:web_hook) { FatZebra::WebHook.create(valid_web_hook_payload) }
     before { web_hook.update(name: 'New Test hook')}
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
     it { expect(web_hook.name).to eq('New Test hook') }
   end
 
@@ -44,7 +44,7 @@ describe FatZebra::WebHook do
     let(:create) { FatZebra::WebHook.create(valid_web_hook_payload) }
     subject(:web_hook) { FatZebra::WebHook.delete(create.id) }
 
-    it { is_expected.to be_successful }
+    it { is_expected.to be_accepted }
   end
 
 end

data/spec/spec_helper.rb

@@ -46,7 +46,7 @@ RSpec.configure do |config|
     FatZebra.configure do |config|
       config.username  = 'TEST'
       config.token     = 'TEST'
-      config.gateway   = 'gateway.sandbox.fatzebra.com.au'
+      config.gateway   = :sandbox
       config.test_mode = true
     end
   end