fat_zebra 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 55ba03265cbd6993f4e0475096a419470df20121
-  data.tar.gz: 9f346b14d906f734c0af030407628107052e7352
+  metadata.gz: 12eca7538a469a8a681e37ee9fb816e113941ceb
+  data.tar.gz: c0b4b46f1dbe9b7da713f7e1b44d814bae1e11db
 SHA512:
-  metadata.gz: e9c0d698fd0bdb5664e2de293889e22a1acbd8dc8db63aae2eba432c3eedc99c5bd69555674ff837ba817276cc1ee64b2b6e75955cc4d6b45b46d47ff4f5d061
-  data.tar.gz: c1d213469e4fe0fb069484b37a27aa97229d64fd7078227903ffea27e20d6d3ca4883f9680f2e08f1270df2479cb74533e15199d65d824a5ddb1efa2db480f3e
+  metadata.gz: 6bd161af6c85201b40d375d0a6d5833cf98216323d874204fe7d2e35b8e3d3f30dca9840c7d6dc655078dc902f8b4eb8f194f0a69e8184ba9ccca580d90e1fe4
+  data.tar.gz: 0290013901adfb328ccbb28a556dd1761c3dd806018b6f9a4bb6b77c272cf3bc2724597a4ab86712553b29d69c4f64692e0a0c539cf2ec9145c1bab965fc7fbf

data/README.markdown

@@ -40,15 +40,15 @@ card_data = {
 	number: "5123456789012346",
 	card_holder: "Bill Simpson",
 	expiry: "05/2023",
-	ccv: "123"
+	cvv: "123"
 }
 
-response = FatZebra::Purchase.create(10000, card_data, "ORDER-23", "203.99.87.4")
+response = FatZebra::Models::Purchase.create(10000, card_data, "ORDER-23", "203.99.87.4")
 
 if response.successful? && response.result.successful
 	puts "Transaction ID: #{response.result.id}"
 else
-	abort "Error in transaction: #{response.error_messages}"
+	abort "Error in transaction: #{response.errors}"
 end
 ```
 

data/lib/fat_zebra/models/purchase.rb

@@ -7,8 +7,8 @@ module FatZebra
   
       # Refunds the current transaction
       #
-      # @param [Integer] the amount to be refunded
-      # @param [String] the refund reference
+      # @param [Integer] amount the amount to be refunded
+      # @param [String] reference the refund reference
       #
       # @return Response (Refund) object
       def refund(amount, reference)
@@ -44,19 +44,19 @@ module FatZebra
       class << self
         # Performs a purchase transaction against the gateway
         #
-        # @param [Integer] the amount as an integer e.g. (1.00 * 100).to_i
-        # @param [Hash] a hash of the card data (example: {:card_holder => "John Smith", :number => "...", :expiry => "...", :cvv => "123"} or {:token => "abcdefg1"})
-        # @param [String] the card holders name
-        # @param [String] the customers credit card number
-        # @param [Date] the customers card expiry date (as Date or string [mm/yyyy])
-        # @param [String] the credit card verification value (cvv, cav, csc etc)
-        # @param [String] a reference for the purchase
-        # @param [String] the customers IP address (for fraud prevention)
-        # @param [String] currency code ("AUD", "USD", etc)
+        # @param [Integer] amount the amount as an integer e.g. (1.00 * 100).to_i
+        # @param [Hash] card_data a hash of the card data (example: {:card_holder => "John Smith", :number => "...", :expiry => "...", :cvv => "123"} or {:token => "abcdefg1"})
+        # @option card_data [String] card_holder the card holders name
+        # @option card_data [String] card_number the customers credit card number
+        # @option card_data [Date] expiry the customers card expiry date (as Date or string [mm/yyyy])
+        # @option card_data [String] cvv the credit card verification value (cvv, cav, csc etc)
+        # @param [String] reference a reference for the purchase
+        # @param [String] customer_ip the customers IP address (for fraud prevention)
+        # @param [String] currency currency code ("AUD", "USD", etc)
         # @param [Hash] optional any optional parameters to be included in the payload
         #
         # @return [Response] response (purchase) object
-        def create(amount, card_data, reference, customer_ip, currency = "AUD", optional = {})
+        def create(amount, card_data, reference, customer_ip, currency = 'AUD', optional = {})
           params = {
             :amount => amount,
             :card_holder => card_data.delete(:card_holder),
@@ -69,10 +69,10 @@ module FatZebra
             :currency => currency
           }
 
-          params.delete_if {|key, value| value.nil? } # If token is nil, remove, otherwise, remove card values
-          validate_params!(params)
+          params.delete_if {|_, value| value.nil? } # If token is nil, remove, otherwise, remove card values
           params.merge!(optional)
-          response = FatZebra.gateway.make_request(:post, "purchases", params)
+          validate_params!(params)
+          response = FatZebra.gateway.make_request(:post, 'purchases', params)
           Response.new(response)
         end
 
@@ -92,29 +92,29 @@ module FatZebra
           options.merge!({:offets => 0, :limit => 10})
 
           # Format dates for the request
-          options[:from] = options[:from].strftime("%Y%m%dT%H%M") if options[:from]
-          options[:to] = options[:to].strftime("%Y%m%dT%H%M") if options[:to]
+          options[:from] = options[:from].strftime('%Y%m%dT%H%M') if options[:from]
+          options[:to] = options[:to].strftime('%Y%m%dT%H%M') if options[:to]
 
 
           if id.nil?
-            response = FatZebra.gateway.make_request(:get, "purchases", options)
-            if response["successful"]
+            response = FatZebra.gateway.make_request(:get, 'purchases', options)
+            if response['successful']
               purchases = []
-              response["response"].each do |purchase|
+              response['response'].each do |purchase|
                 purchases << Purchase.new(purchase)
               end
 
               purchases.size == 1 ? purchases.first : purchases
             else
               # TODO: This should raise a defined exception
-              raise StandardError, "Unable to query purchases, #{response["errors"].inspect}"
+              raise StandardError, "Unable to query purchases, #{response['errors'].inspect}"
             end
           else
             response = FatZebra.gateway.make_request(:get, "purchases/#{id}.json")
-            if response["successful"]
-              Purchase.new(response["response"])
+            if response['successful']
+              Purchase.new(response['response'])
             else
-              raise StandardError, "Unable to query purchases, #{response["errors"].inspect}"
+              raise StandardError, "Unable to query purchases, #{response['errors'].inspect}"
             end
           end
         end
@@ -131,7 +131,7 @@ module FatZebra
           if value.is_a?(String)
             return value
           elsif value.respond_to?(:strftime)
-            return value.strftime("%m/%Y")
+            return value.strftime('%m/%Y')
           end
         end
 
@@ -143,11 +143,11 @@ module FatZebra
         # Raises FatZebra::RequestError if errors are present.
         def validate_params!(params)
           @errors = []
-          @errors << "number or token must be provided" unless params[:card_number].present? || params[:card_token].present?
-          @errors << "amount must be provided or greater then 0" unless params[:amount].present? && params[:amount].to_f > 0
-          @errors << "expiry must be provided" unless params[:card_token].present? || params[:card_expiry].present?
-          @errors << "reference must be provided" unless params[:reference].present?
-          @errors << "customer_ip must be procided" unless params[:customer_ip].present?
+          @errors << 'number or token must be provided' unless params[:card_number].present? || params[:card_token].present? || params[:wallet].present?
+          @errors << 'amount must be provided or greater then 0' unless params[:amount].present? && params[:amount].to_f > 0
+          @errors << 'expiry must be provided' unless params[:card_token].present? || params[:card_expiry].present? || params[:wallet].present?
+          @errors << 'reference must be provided' unless params[:reference].present?
+          @errors << 'customer_ip must be provided' unless params[:customer_ip].present?
 
           raise FatZebra::RequestError.new("The following errors prevent the transaction from being submitted: #{@errors.to_sentence}") if @errors.any?
         end

data/lib/fat_zebra/version.rb

@@ -1,3 +1,3 @@
 module FatZebra
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 end

data/lib/fat_zebra.rb

@@ -5,7 +5,7 @@ require 'active_support/core_ext'
 
 require 'fat_zebra/config'
 require 'fat_zebra/errors'
-require "fat_zebra/version"
+require 'fat_zebra/version'
 require 'fat_zebra/constants'
 require 'fat_zebra/gateway'
 require 'fat_zebra/models/base'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fat_zebra
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Matthew Savage
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-04 00:00:00.000000000 Z
+date: 2014-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec