fat_free_crm 0.17.3 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ca66c981de552c61f57b222cafd88bc9d34e1c2ec4a184a0bc8ffd009d4da37
-  data.tar.gz: d484f322f7594b1c821d13424d8cd9a8bce8a4912d37b7e4151ff7bdfc8d6640
+  metadata.gz: 0e742d170861eae5ac601236d6f2d0ddd25d42186a66651a4adb24f5f65859fa
+  data.tar.gz: 25bea2bb3db3844aac5084caab8c6dd18a6ba857ed3cf3ea997ef7c604435f83
 SHA512:
-  metadata.gz: a3944df108b8ee40424ef0747b0cead3b03a6e08129b164232b8cb7be258a632469126d0d3fc2f1bfeb35066c6089b5712afc5dea8dbf9950ebe493e4dcfcd87
-  data.tar.gz: 3f4544819b61cefb933787a84c2a4ff693810378c1a66c5669aecea9683881000216002d7ad80d692de80b3cc4767e643eed8f93a3e1f421c2f993712ddf9dc8
+  metadata.gz: fea727f3837d27e618797ef91da85a2b628965fede5b84ec579c7362dc1ff7ee9180a5a39b67c705e8be528ff7431bc4077dee9a7985fb61e3c3a0f852b95c03
+  data.tar.gz: e63e10fc312f93a2b5e4f8be302202ebd4221ca400debf663e6a0b5acd66779fee4d03cbe9aafcdd99ece4acdb8db2d68311ec803e64e498664cc944d57491b4

data/.dockerignore

@@ -0,0 +1,11 @@
+.bundle
+.git*
+db/*.sql*
+log/*
+tmp/*
+Dockerfile
+README.md
+spec/reports
+spec/internal/public/avatars
+spec/internal/public/assets
+coverage/*

data/.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 
 Bundler/OrderedGems:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,11 +1,18 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-01-21 02:52:41 +1030 using RuboCop version 0.52.1.
+# on 2018-02-02 11:21:41 +0300 using RuboCop version 0.52.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/Gemfile, **/gems.rb
+Bundler/DuplicatedGem:
+  Exclude:
+    - 'Gemfile'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 Layout/EmptyLinesAroundArguments:
@@ -31,6 +38,11 @@ Lint/BooleanSymbol:
   Exclude:
     - 'config/initializers/ransack.rb'
 
+# Offense count: 1
+Lint/Debugger:
+  Exclude:
+    - 'app/controllers/entities/opportunities_controller.rb'
+
 # Offense count: 1
 Lint/DuplicateMethods:
   Exclude:
@@ -93,7 +105,7 @@ Lint/UselessAssignment:
     - 'app/helpers/application_helper.rb'
     - 'app/views/home/index.atom.builder'
 
-# Offense count: 132
+# Offense count: 131
 Metrics/AbcSize:
   Max: 57
 
@@ -105,13 +117,13 @@ Metrics/BlockNesting:
 # Offense count: 14
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 199
+  Max: 209
 
 # Offense count: 29
 Metrics/CyclomaticComplexity:
   Max: 14
 
-# Offense count: 100
+# Offense count: 102
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 38
@@ -148,7 +160,7 @@ Naming/HeredocDelimiterNaming:
   Exclude:
     - 'app/controllers/passwords_controller.rb'
 
-# Offense count: 4
+# Offense count: 5
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # NamePrefixBlacklist: is_, has_, have_
@@ -158,6 +170,7 @@ Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
     - 'app/inputs/date_time_input.rb'
+    - 'app/models/entities/opportunity.rb'
     - 'app/models/users/user.rb'
     - 'lib/fat_free_crm/fields.rb'
     - 'lib/fat_free_crm/mail_processor/base.rb'
@@ -227,10 +240,11 @@ Style/CommentedKeyword:
     - 'app/models/users/authentication.rb'
     - 'db/migrate/20100928030617_drop_openid_tables.rb'
 
-# Offense count: 3
+# Offense count: 4
 Style/DoubleNegation:
   Exclude:
     - 'app/helpers/application_helper.rb'
+    - 'app/models/entities/opportunity.rb'
     - 'app/models/polymorphic/task.rb'
     - 'lib/gravatar_image_tag.rb'
 
@@ -239,6 +253,14 @@ Style/EvalWithLocation:
   Exclude:
     - 'lib/fat_free_crm/permissions.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: when_needed, always, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'db/schema.rb'
+
 # Offense count: 3
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
@@ -246,7 +268,7 @@ Style/GlobalVars:
     - 'db/migrate/20100928030598_create_sessions.rb'
     - 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
 
-# Offense count: 45
+# Offense count: 46
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
@@ -350,7 +372,7 @@ Style/TrivialAccessors:
   Exclude:
     - 'spec/support/auth_macros.rb'
 
-# Offense count: 1922
+# Offense count: 1924
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:

data/.travis.yml

@@ -1,8 +1,8 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.3.6
   - 2.4.2
+  - 2.5.0
 
 env:
   global:
@@ -11,21 +11,24 @@ env:
     - DB=postgres TEST_SUITE=rubocop
     - DB=postgres TEST_SUITE="rake spec:features"
     - DB=postgres TEST_SUITE="rake spec:models"
-    - DB=postgres TEST_SUITE="rake spec:mailers"
-    - DB=postgres TEST_SUITE="rake spec:controllers"
-    - DB=postgres TEST_SUITE="rake spec:helpers"
-    - DB=postgres TEST_SUITE="rake spec:lib"
-    - DB=postgres TEST_SUITE="rake spec:routing"
-    - DB=postgres TEST_SUITE="rake spec:views"
+    - DB=postgres TEST_SUITE="rake spec:controllers spec:lib spec:routing spec:mailers"
+    - DB=postgres TEST_SUITE="rake spec:views spec:helpers"
     - DB=mysql TEST_SUITE="rake spec:models"
     - DB=sqlite TEST_SUITE="rake spec:models"
 
 matrix:
   fast_finish: true
+  exclude:
+    - rvm: 2.5.0
+      env: DB=postgres TEST_SUITE=rubocop
   allow_failures:
-    - rvm: 2.3.6
-      env: DB=sqlite TEST_SUITE="rake spec:models"
     - rvm: 2.4.2
+      env: DB=mysql TEST_SUITE="rake spec:models"
+    - rvm: 2.4.2
+      env: DB=sqlite TEST_SUITE="rake spec:models"
+    - rvm: 2.5.0
+      env: DB=mysql TEST_SUITE="rake spec:models"
+    - rvm: 2.5.0
       env: DB=sqlite TEST_SUITE="rake spec:models"
 
 addons:
@@ -40,6 +43,8 @@ before_install:
   - "sh -e /etc/init.d/xvfb start"
 
 before_script:
+  # gem update --system is a workaround for travis-ci/travis-ci#8978
+  - "gem update --system"
   - sh -c "cp config/database.$DB.yml config/database.yml"
   - sh -c "if [ \"$DB\" = 'postgres' ]; then psql -c 'create database fat_free_crm_test;' -U postgres; fi"
   - sh -c "if [ \"$DB\" = 'mysql' ]; then mysql -e 'create database fat_free_crm_test;'; fi"

data/CHANGELOG.md

@@ -4,24 +4,60 @@ It does not matter how slowly you go as long as you do not stop.
 First they ignore you, then they laugh at you, then they fight you,
 then you win. –- Mahatma Gandhi
 
-Sat Oct 27, 2018 (0.17.3)
+Unreleased (0.19.0)
+=======
+
+
+Sat Apr 21, 2018 (0.18.0)
 ---------------------------------------------------------------------
 
-#### Fixed XSS flaw in tags_helper
-Credit Antonin Steinhauser (asteinhauser) for discovery and responsible disclosure.
+### Important changes
+#### Mininium ruby version
+#665 Support for Ruby 2.3 has been dropped, with test coverage for 2.4 and 2.5 enabled.
+
+#### Swap to FactoryBot
+If you consume fat free crm as an engine and re-use any factories, you'll need to [upgrade to FactoryBot](https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md).
+
+#### Removed methods
+`Lead.update_with_permissions` is removed, use user_ids and group_ids inside attributes instead and call lead.update_with_account_and_lead_counters
+`FatFreeCRM::Permissions.save_with_permissions` is removed, use user_ids and group_ids inside attributes and call save
+`FatFreeCRM::Permissions.update_with_permissions` is removed, use user_ids and group_ids inside attributes and call update_attributes
+
+#### Other changes
+ - CVE-2018-8048 (loofah gem)
+ - CVE-2018-3741 (rails-html-sanitizer gem)
+ - #768 Fix comment creation on entities
+ - #762 #764 Fix bug in select menu
+ - #759 Improve zero revenue display
+ - #753 Opportunities sort by weighted amount
+ - #749 Fix unsafe reflection and mass assignment
 
 Wed Jan 24, 2018 (0.17.2)
 ---------------------------------------------------------------------
- - Fix CVE-2017-0889
- - Fix #687
+ - CVE-2017-0889
+ - #724 Fixes #589 Autocomplete regression
+ - #723 Fixes #687 Passing string to define a callback is not supported.
 
-Mon Jan 22, 2018 (0.16.2)
+Wed Jan 24, 2018 (0.16.3)
 ---------------------------------------------------------------------
- - Fix #687
+CVE-2017-0889
+
+Wed Jan 24, 2018 (0.15.1)
+---------------------------------------------------------------------
+CVE-2017-0889
+
+Wed Jan 24, 2018 (0.14.1)
+---------------------------------------------------------------------
+CVE-2017-0889
 
 Sat Jan 20, 2018 (0.17.1)
 ---------------------------------------------------------------------
  - #709 Revert accidental minimum ruby version 2.4 changes (#665)
+ - Fix #687 Passing string to define a callback is not supported.
+
+Mon Jan 22, 2018 (0.16.2)
+---------------------------------------------------------------------
+Fix #687
 
 Sat Jan 20, 2018 (0.17.0)
 ---------------------------------------------------------------------

data/CONTRIBUTORS.md

@@ -2,91 +2,133 @@ The following people have contributed code, patches, bug fixes, and language
 translations to the Fat Free CRM:
 
   * Aaron Brethorst
+  * Adis Osmonov ªº
   * Adrian Klingel
-  * Alexander Kabanov (USA)
+  * Ain Tohvri
+  * Alejandro
+  * Aleksander Madland Stapnes
+  * Alexander Kabanov
   * Alex Tomlins
-  * Andrew Neil (United Kingdom)
-  * Apirak Panatkool (Thailand)
-  * Avery Pennarun (Canada)
-  * Beatriz Garcia Parrilla (Spain)
-  * Ben Tillman (Hong Kong)
+  * AndrewsHerrera
+  * Anton Oslyak
+  * Apirak
+  * Apirak Panatkool
+  * Ashwin Phatak
+  * Avery Pennarun
+  * Ben Tillman
   * Brook
-  * Cédric Brancourt (France)
+  * Bryan Helmkamp
   * Chris Carter
   * Codemis
-  * Craig Ulliott (USA)
-  * Daniel Jabbour (USA)
-  * Daniel O'Connor (@CloCkWeRX)
+  * Cody Swann
+  * Daniel Jabbour
+  * Daniel O'Connor
+  * Danilo Lacoste
+  * David Chua
   * David Cornu
   * David Keita
-  * Dirk Kelly (Australia)
-  * Dmitry Dudin (Russia)
-  * Douglas Campos (Brasil)
+  * David Westerink
+  * deppbot
+  * Dirk Kelly
+  * DmitriySalko
+  * Dmitry
+  * Dmitry Avramets
+  * Dmitry Dudin
+  * Douglas Campos
   * Drew Neil
-  * Dr. Nic Williams (Australia)
   * dup2
-  * Elad Meidar (Israel)
   * Electron-libre
-  * Enderson Maia (Brasil)
-  * Eric Davis (USA)
-  * Eric Shelley (USA)
-  * Fritz Thielemann (Germany)
-  * Gavin Baker (USA)
+  * Enderson Maia
+  * Eric Shelley
+  * François Koessler
+  * Fritz Thielemann
+  * Gaston Arbeletche -VAIRIX-
+  * Gavin Baker
+  * Grzegorz Unijewski
   * guesxy
-  * Hamish Rickerby (United Kingdom)
-  * Jack Tang (China)
-  * James Zhang (China)
+  * James Cook
+  * James Zhang
   * Jan Schulz-Hofen
-  * Jim Gay (USA)
-  * Johnny Shields (@jonnyshields)
+  * Jim Gay
+  * johnnyshields
+  * Johnny Shields
+  * John W. M. Carneiro
   * Josef Chmel
-  * Jose Luis Gordo Romero (Spain)
+  * jose-gordo
+  * jose.gordo
+  * Jose Luis Gordo
+  * Jose Luis Gordo Romero
   * Joseph Near
-  * Kamil Politowicz (Germany)
+  * Josh Adams
+  * Kamil Politowicz
+  * ken-wong
   * Kevin Fullerton
   * Kiran Jonnalagadda
   * Kouichi Kishikami
-  * Lana Dvorkin (USA)
-  * Leonid Dinershtein (Russia)
-  * Louis Nyffenegger (Australia)
-  * Lukasz Kosewski (Canada)
+  * Koustubh Sinkar
+  * Lana Dvorkin
+  * Lincoln Lee
+  * Louis Nyffenegger
+  * Lukasz Kosewski
+  * m
+  * Malachai
+  * Marcelo M. Leal
   * Marian Mrózek
   * Mark Friedgan
-  * Martin Gajdos (Switzerland)
-  * Martin Trejo (Mexico)
+  * Martin Gajdos
+  * Martin Trejo
+  * Martin Villero
   * Masaki Muranaka
-  * Matt Beedle (Spain)
+  * Matthew Lehner
   * Mauro Alloro
-  * Michael Dvorkin (USA)
-  * Miles Togoe (USA)
-  * Nathan Broadbent (Hong Kong)
+  * Michael Dvorkin
+  * Mike Dvorkin
+  * Murray Steele
+  * Nathan B
+  * Nathan Broadbent
   * Nicholas Fine
-  * Nicholas Rowe (USA)
-  * Nobuhito Okada (Japan)
-  * Olmo Maldonado (USA)
-  * Patrick Mulder (Germany)
+  * Nicholas Rowe
+  * Nicolas Leger
+  * nigh7m4r3
+  * Nobuhito OKADA
+  * Olle Jonsson
+  * Olmo Maldonado
+  * orthographic-pedant
+  * papilip
+  * Patrick Mulder
   * Paul
-  * Peter McCurdy (Canada)
+  * Peter McCurdy
   * Philipp Ullmann
-  * Ralf Ebert (Germany)
+  * Ralf Ebert
+  * Reuben Salagaras
   * rickerbh
-  * Rit Li (USA)
+  * Rit Li
+  * Road Tang
   * Robert Fletcher
   * Rob Esposito
-  * Roman Smirnov (Russia)
-  * Russell Niller (USA)
-  * Ryan Stenhouse (Scotland)
-  * Scott Miller (USA)
+  * Roman Smirnov
+  * Ryan Stenhouse
+  * Satoru Ishikawa
+  * Scott
+  * Scott Dudley
+  * Scott Miller
   * Sebastian Castro
   * Seb Jacobs
   * Serafim Junior Dos Santos Fagundes
-  * Steve Kenworthy (Hong Kong)
+  * Stanley Hansen
+  * Steve Kenworthy
+  * steveyken
+  * Szeto Bo
   * tarbalazs
-  * Todd Makinster (USA)
-  * Tom Meier (Australia)
-  * Trevor Oke (Canada)
+  * Thomas Pike
+  * Tim Adler
+  * Todd Makinster
+  * Tom Meier
+  * Trevor Oke
   * William Lawson
   * Xughaa
-  * Yury Kotlyarov (Russia)
+  * Yann Hourdel
+  * Yury Kotlyarov
+  * Zlatko Zahariev
 
 Generated using "git shortlog -s -n | cut -f 2 | sort"