fat_free_crm 0.17.3 → 0.18.0

data/spec/views/accounts/show.haml_spec.rb

@@ -12,13 +12,13 @@ describe "/accounts/show" do
 
   before do
     login
-    @account = FactoryGirl.create(:account, id: 42,
-                                            contacts: [FactoryGirl.create(:contact)],
-                                            opportunities: [FactoryGirl.create(:opportunity)])
+    @account = create(:account, id: 42,
+                                contacts: [create(:contact)],
+                                opportunities: [create(:opportunity)])
     assign(:account, @account)
     assign(:users, [current_user])
     assign(:comment, Comment.new)
-    assign(:timeline, [FactoryGirl.create(:comment, commentable: @account)])
+    assign(:timeline, [create(:comment, commentable: @account)])
 
     # controller#controller_name and controller#action_name are not set in view specs
     allow(view).to receive(:template_for_current_view).and_return(nil)

data/spec/views/accounts/update.js.haml_spec.rb

@@ -13,7 +13,7 @@ describe "/accounts/update" do
   before do
     login
 
-    assign(:account, @account = FactoryGirl.build_stubbed(:account, user: current_user))
+    assign(:account, @account = build_stubbed(:account, user: current_user))
     assign(:users, [current_user])
     assign(:account_category_total, Hash.new(1))
   end

data/spec/views/admin/field_groups/create.js.haml_spec.rb

@@ -13,7 +13,7 @@ describe "admin/field_groups/create" do
     assign(:field_group, field_group)
   end
 
-  let(:field_group) { FactoryGirl.build_stubbed(:field_group, label: 'test') }
+  let(:field_group) { build_stubbed(:field_group, label: 'test') }
 
   it "renders javascript" do
     render

data/spec/views/admin/field_groups/destroy.js.haml_spec.rb

@@ -13,7 +13,7 @@ describe "admin/field_groups/destroy" do
     assign(:field_group, field_group)
   end
 
-  let(:field_group) { FactoryGirl.build(:field_group) }
+  let(:field_group) { build(:field_group) }
 
   it "renders destroy javascript" do
     allow(field_group).to receive(:destroyed?).and_return(true)

data/spec/views/admin/field_groups/edit.js.haml_spec.rb

@@ -13,7 +13,7 @@ describe "admin/field_groups/edit" do
     assign(:field_group, field_group)
   end
 
-  let(:field_group) { FactoryGirl.build_stubbed(:field_group, label: 'test') }
+  let(:field_group) { build_stubbed(:field_group, label: 'test') }
 
   it "renders javascript" do
     render

data/spec/views/admin/field_groups/new.js.haml_spec.rb

@@ -13,7 +13,7 @@ describe "admin/field_groups/new" do
     assign(:field_group, field_group)
   end
 
-  let(:field_group) { FactoryGirl.build_stubbed(:field_group, label: 'test') }
+  let(:field_group) { build_stubbed(:field_group, label: 'test') }
 
   it "renders javascript" do
     render

data/spec/views/admin/field_groups/update.js.haml_spec.rb

@@ -13,7 +13,7 @@ describe "admin/field_groups/update" do
     assign(:field_group, field_group)
   end
 
-  let(:field_group) { FactoryGirl.build_stubbed(:field_group, label: 'test') }
+  let(:field_group) { build_stubbed(:field_group, label: 'test') }
 
   it "renders javascript" do
     render

data/spec/views/admin/users/create.js.haml_spec.rb

@@ -14,7 +14,7 @@ describe "admin/users/create" do
 
   describe "create success" do
     before do
-      assign(:user, @user = FactoryGirl.build_stubbed(:user))
+      assign(:user, @user = build_stubbed(:user))
       assign(:users, [@user]) # .paginate
     end
 
@@ -31,7 +31,7 @@ describe "admin/users/create" do
 
   describe "create failure" do
     it "should re-render [create] template in :create_user div" do
-      assign(:user, FactoryGirl.build(:user, username: nil)) # make it invalid
+      assign(:user, build(:user, username: nil)) # make it invalid
       assign(:users, [current_user])
       render
 

data/spec/views/admin/users/destroy.js.haml_spec.rb

@@ -14,7 +14,7 @@ describe "admin/users/destroy" do
 
   describe "user got deleted" do
     before do
-      @user = FactoryGirl.create(:user)
+      @user = create(:user)
       @user.destroy
       assign(:user, @user)
     end
@@ -28,7 +28,7 @@ describe "admin/users/destroy" do
 
   describe "user was not deleted" do
     before do
-      assign(:user, @user = FactoryGirl.build_stubbed(:user))
+      assign(:user, @user = build_stubbed(:user))
     end
 
     it "should remove confirmation panel" do

data/spec/views/admin/users/edit.js.haml_spec.rb

@@ -10,7 +10,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
 describe "admin/users/edit" do
   before do
     login_admin
-    assign(:user, @user = FactoryGirl.build_stubbed(:user))
+    assign(:user, @user = build_stubbed(:user))
   end
 
   it "cancel replaces [Edit User] form with user partial" do
@@ -21,7 +21,7 @@ describe "admin/users/edit" do
   end
 
   it "edit hides previously open [Edit User] and replaces it with user partial" do
-    assign(:previous, previous = FactoryGirl.build_stubbed(:user))
+    assign(:previous, previous = build_stubbed(:user))
     render
 
     expect(rendered).to include("user_#{previous.id}")

data/spec/views/admin/users/index.haml_spec.rb

@@ -13,7 +13,7 @@ describe "/admin/users/index" do
   end
 
   it "renders a list of users" do
-    assign(:users, [FactoryGirl.build_stubbed(:user)].paginate)
+    assign(:users, [build_stubbed(:user)].paginate)
 
     render
     expect(view).to render_template(partial: "_user")

data/spec/views/admin/users/index.js.haml_spec.rb

@@ -13,8 +13,8 @@ describe "admin/users/index" do
   end
 
   it "renders [admin/user] template with @users collection" do
-    amy = FactoryGirl.build_stubbed(:user)
-    bob = FactoryGirl.build_stubbed(:user)
+    amy = build_stubbed(:user)
+    bob = build_stubbed(:user)
     assign(:users, [amy, bob].paginate)
 
     render template: 'admin/users/index', formats: [:js]

data/spec/views/admin/users/reactivate.js.haml_spec.rb

@@ -10,7 +10,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
 describe "admin/users/reactivate" do
   before do
     login_admin
-    assign(:user, @user = FactoryGirl.build_stubbed(:user, suspended_at: Time.now.yesterday))
+    assign(:user, @user = build_stubbed(:user, suspended_at: Time.now.yesterday))
   end
 
   it "reloads the requested user partial" do

data/spec/views/admin/users/suspend.js.haml_spec.rb

@@ -10,7 +10,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper')
 describe "admin/users/suspend" do
   before do
     login_admin
-    assign(:user, @user = FactoryGirl.build_stubbed(:user, suspended_at: nil))
+    assign(:user, @user = build_stubbed(:user, suspended_at: nil))
   end
 
   it "reloads the requested user partial" do

data/spec/views/admin/users/update.js.haml_spec.rb

@@ -10,7 +10,7 @@ require 'spec_helper'
 describe "admin/users/update" do
   before do
     login_admin
-    assign(:user, @user = FactoryGirl.build_stubbed(:user))
+    assign(:user, @user = build_stubbed(:user))
   end
 
   describe "no errors:" do

data/spec/views/application/auto_complete.haml_spec.rb

@@ -17,11 +17,11 @@ describe "/application/_auto_complete" do
   %i[account campaign contact lead opportunity].each do |model|
     it "should render autocomplete list if #{model} matches found" do
       @auto_complete = if model == :lead
-                         FactoryGirl.build_stubbed(:lead, first_name: "Billy", last_name: "Bones", company: "Hello, World!")
+                         build_stubbed(:lead, first_name: "Billy", last_name: "Bones", company: "Hello, World!")
                        elsif model == :contact
-                         FactoryGirl.build_stubbed(:contact, first_name: "Billy", last_name: "Bones")
+                         build_stubbed(:contact, first_name: "Billy", last_name: "Bones")
                        else
-                         FactoryGirl.build_stubbed(model, name: "Hello, World!")
+                         build_stubbed(model, name: "Hello, World!")
       end
       assign(:auto_complete, [@auto_complete])
 

data/spec/views/campaigns/_edit.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/campaigns/_edit" do
 
   before do
     login
-    assign(:campaign, @campaign = FactoryGirl.build_stubbed(:campaign))
+    assign(:campaign, @campaign = build_stubbed(:campaign))
     assign(:users, [current_user])
   end
 

data/spec/views/campaigns/create.js.haml_spec.rb

@@ -14,7 +14,7 @@ describe "/campaigns/create" do
 
   describe "create success" do
     before do
-      assign(:campaign, @campaign = FactoryGirl.build_stubbed(:campaign))
+      assign(:campaign, @campaign = build_stubbed(:campaign))
       assign(:campaigns, [@campaign].paginate)
       assign(:campaign_status_total, Hash.new(1))
       render
@@ -38,8 +38,8 @@ describe "/campaigns/create" do
 
   describe "create failure" do
     it "should re-render [create] template in :create_campaign div" do
-      assign(:campaign, FactoryGirl.build(:campaign, name: nil)) # make it invalid
-      assign(:users, [FactoryGirl.build_stubbed(:user)])
+      assign(:campaign, build(:campaign, name: nil)) # make it invalid
+      assign(:users, [build_stubbed(:user)])
 
       render
 

data/spec/views/campaigns/destroy.js.haml_spec.rb

@@ -10,7 +10,7 @@ require 'spec_helper'
 describe "/campaigns/destroy" do
   before do
     login
-    assign(:campaign, @campaign = FactoryGirl.build_stubbed(:campaign, user: current_user))
+    assign(:campaign, @campaign = build_stubbed(:campaign, user: current_user))
     assign(:campaigns, [@campaign].paginate)
     assign(:campaign_status_total, Hash.new(1))
     render

data/spec/views/campaigns/edit.js.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/campaigns/edit" do
 
   before do
     login
-    assign(:campaign, @campaign = FactoryGirl.build_stubbed(:campaign, user: current_user))
+    assign(:campaign, @campaign = build_stubbed(:campaign, user: current_user))
     assign(:users, [current_user])
   end
 
@@ -33,7 +33,7 @@ describe "/campaigns/edit" do
 
   it "edit: should hide previously open [Edit Campaign] for and replace it with campaign partial" do
     params[:cancel] = nil
-    assign(:previous, previous = FactoryGirl.build_stubbed(:campaign, user: current_user))
+    assign(:previous, previous = build_stubbed(:campaign, user: current_user))
 
     render
     expect(rendered).to include("$('#campaign_#{previous.id}').replaceWith('<li class=\\'campaign highlight\\' id=\\'campaign_#{previous.id}\\'")

data/spec/views/campaigns/index.haml_spec.rb

@@ -19,7 +19,7 @@ describe "/campaigns/index" do
   end
 
   it "should render list of accounts if list of campaigns is not empty" do
-    assign(:campaigns, [FactoryGirl.build_stubbed(:campaign)].paginate)
+    assign(:campaigns, [build_stubbed(:campaign)].paginate)
 
     render
     expect(view).to render_template(partial: "_campaign")

data/spec/views/campaigns/index.js.haml_spec.rb

@@ -15,7 +15,7 @@ describe "/campaigns/index" do
   end
 
   it "should render [campaign] template with @campaigns collection if there are campaigns" do
-    assign(:campaigns, [FactoryGirl.build_stubbed(:campaign, id: 42)].paginate)
+    assign(:campaigns, [build_stubbed(:campaign, id: 42)].paginate)
 
     render template: 'campaigns/index', formats: [:js]
 

data/spec/views/campaigns/show.haml_spec.rb

@@ -12,13 +12,13 @@ describe "/campaigns/show" do
 
   before do
     login
-    @campaign = FactoryGirl.build_stubbed(:campaign, id: 42,
-                                                     leads: [FactoryGirl.build_stubbed(:lead)],
-                                                     opportunities: [FactoryGirl.build_stubbed(:opportunity)])
+    @campaign = build_stubbed(:campaign, id: 42,
+                                         leads: [build_stubbed(:lead)],
+                                         opportunities: [build_stubbed(:opportunity)])
     assign(:campaign, @campaign)
     assign(:users, [current_user])
     assign(:comment, Comment.new)
-    assign(:timeline, [FactoryGirl.build_stubbed(:comment, commentable: @campaign)])
+    assign(:timeline, [build_stubbed(:comment, commentable: @campaign)])
     allow(view).to receive(:params) { { id: 123 } }
 
     # controller#controller_name and controller#action_name are not set in view specs

data/spec/views/campaigns/update.js.haml_spec.rb

@@ -10,7 +10,7 @@ require 'spec_helper'
 describe "/campaigns/update" do
   before do
     login
-    assign(:campaign, @campaign = FactoryGirl.build_stubbed(:campaign, user: current_user))
+    assign(:campaign, @campaign = build_stubbed(:campaign, user: current_user))
     assign(:users, [current_user])
     assign(:status, Setting.campaign_status)
     assign(:campaign_status_total, Hash.new(1))

data/spec/views/contacts/_edit.haml_spec.rb

@@ -12,12 +12,12 @@ describe "/contacts/_edit" do
 
   before do
     login
-    assign(:account, @account = FactoryGirl.create(:account))
+    assign(:account, @account = create(:account))
     assign(:accounts, [@account])
   end
 
   it "should render [edit contact] form" do
-    assign(:contact, @contact = FactoryGirl.create(:contact))
+    assign(:contact, @contact = create(:contact))
     assign(:users, [current_user])
 
     render
@@ -33,7 +33,7 @@ describe "/contacts/_edit" do
 
   it "should pick default assignee (Myself)" do
     assign(:users, [current_user])
-    assign(:contact, FactoryGirl.create(:contact, assignee: nil))
+    assign(:contact, create(:contact, assignee: nil))
 
     render
     expect(rendered).to have_tag("select[id=contact_assigned_to]") do |options|
@@ -42,9 +42,9 @@ describe "/contacts/_edit" do
   end
 
   it "should show correct assignee" do
-    @user = FactoryGirl.create(:user)
+    @user = create(:user)
     assign(:users, [current_user, @user])
-    assign(:contact, FactoryGirl.create(:contact, assignee: @user))
+    assign(:contact, create(:contact, assignee: @user))
 
     render
     expect(rendered).to have_tag("select[id=contact_assigned_to]") do |_options|
@@ -55,7 +55,7 @@ describe "/contacts/_edit" do
 
   it "should render background info field if settings require so" do
     assign(:users, [current_user])
-    assign(:contact, FactoryGirl.create(:contact))
+    assign(:contact, create(:contact))
     Setting.background_info = [:contact]
 
     render
@@ -64,7 +64,7 @@ describe "/contacts/_edit" do
 
   it "should not render background info field if settings do not require so" do
     assign(:users, [current_user])
-    assign(:contact, FactoryGirl.create(:contact))
+    assign(:contact, create(:contact))
     Setting.background_info = []
 
     render

data/spec/views/contacts/_new.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/contacts/_new" do
 
   before do
     login
-    @account = FactoryGirl.build_stubbed(:account)
+    @account = build_stubbed(:account)
     assign(:contact, Contact.new)
     assign(:users, [current_user])
     assign(:account, @account)

data/spec/views/contacts/create.js.haml_spec.rb

@@ -16,7 +16,7 @@ describe "/contacts/create" do
 
   describe "create success" do
     before do
-      assign(:contact, @contact = FactoryGirl.build_stubbed(:contact))
+      assign(:contact, @contact = build_stubbed(:contact))
       assign(:contacts, [@contact].paginate)
     end
 
@@ -51,9 +51,9 @@ describe "/contacts/create" do
 
   describe "create failure" do
     it "create (failure): should re-render [create] template in :create_contact div" do
-      assign(:contact, FactoryGirl.build(:contact, first_name: nil)) # make it invalid
-      @account = FactoryGirl.build_stubbed(:account)
-      assign(:users, [FactoryGirl.build_stubbed(:user)])
+      assign(:contact, build(:contact, first_name: nil)) # make it invalid
+      @account = build_stubbed(:account)
+      assign(:users, [build_stubbed(:user)])
       assign(:account, @account)
       assign(:accounts, [@account])
 

data/spec/views/contacts/destroy.js.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/contacts/destroy" do
 
   before do
     login
-    assign(:contact, @contact = FactoryGirl.build_stubbed(:contact))
+    assign(:contact, @contact = build_stubbed(:contact))
     assign(:contacts, [@contact].paginate)
   end
 

data/spec/views/contacts/edit.js.haml_spec.rb

@@ -12,9 +12,9 @@ describe "/contacts/edit" do
 
   before do
     login
-    assign(:contact, @contact = FactoryGirl.build_stubbed(:contact, user: current_user))
+    assign(:contact, @contact = build_stubbed(:contact, user: current_user))
     assign(:users, [current_user])
-    assign(:account, @account = FactoryGirl.build_stubbed(:account))
+    assign(:account, @account = build_stubbed(:account))
     assign(:accounts, [@account])
   end
 
@@ -35,7 +35,7 @@ describe "/contacts/edit" do
 
   it "edit: should hide previously open [Edit Contact] for and replace it with contact partial" do
     params[:cancel] = nil
-    assign(:previous, previous = FactoryGirl.build_stubbed(:contact, user: current_user))
+    assign(:previous, previous = build_stubbed(:contact, user: current_user))
 
     render
     expect(rendered).to include("$('#contact_#{previous.id}').replaceWith")

data/spec/views/contacts/index.haml_spec.rb

@@ -19,7 +19,7 @@ describe "/contacts/index" do
   end
 
   it "should render a list of contacts if it's not empty" do
-    assign(:contacts, [FactoryGirl.build_stubbed(:contact)].paginate)
+    assign(:contacts, [build_stubbed(:contact)].paginate)
 
     render
     expect(view).to render_template(partial: "_contact")

data/spec/views/contacts/index.js.html_spec.rb

@@ -15,7 +15,7 @@ describe "/contacts/index" do
   end
 
   it "should render [contact] template with @contacts collection if there are contacts" do
-    assign(:contacts, [FactoryGirl.build_stubbed(:contact, id: 42)].paginate)
+    assign(:contacts, [build_stubbed(:contact, id: 42)].paginate)
 
     render template: 'contacts/index', formats: [:js]
 

data/spec/views/contacts/new.js.haml_spec.rb

@@ -12,7 +12,7 @@ describe "/contacts/new" do
 
   before do
     login
-    @account = FactoryGirl.build_stubbed(:account)
+    @account = build_stubbed(:account)
     assign(:contact, Contact.new(user: current_user))
     assign(:users, [current_user])
     assign(:account, @account)