fat_free_crm 0.16.4 → 0.17.1

data/spec/lib/permissions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/lib/secret_token_generator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2014 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/lib/view_factory_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/mailers/subscription_mailer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -14,14 +16,6 @@ describe SubscriptionMailer do
     let(:comment) { build(:comment, commentable: commentable, user: user) }
     let(:mail) { SubscriptionMailer.comment_notification(user, comment) }
 
-    before :each do
-      allow(Setting.email_comment_replies).to receive(:[]).with(:address).and_return("email_comment_reply@example.com")
-    end
-
-    it "uses email defined in settings as the sender" do
-      expect(mail.from).to eql(["email_comment_reply@example.com"])
-    end
-
     it "sets user 'notify_me@example.com' as recipient" do
       expect(mail.to).to eq(["notify_me@example.com"])
     end
@@ -34,16 +28,21 @@ describe SubscriptionMailer do
       expect(mail.body.encoded).to match('http://www.example.com/opportunities/47')
     end
 
-    it "should set default reply-to address if email doesn't exist" do
-      allow(Setting.email_comment_replies).to receive(:[]).with(:address).and_return("")
-      allow(Setting).to receive(:host).and_return("fatfreecrm.com")
-      expect(mail.from).to eql(["no-reply@fatfreecrm.com"])
+    it "uses email defined in settings as the sender" do
+      allow(Setting).to receive(:dig).with(:email_comment_replies, :address).and_return("email_comment_reply@example.com")
+      expect(mail.from).to eql(["email_comment_reply@example.com"])
     end
 
-    it "should set default reply-to address if email and host don't exist" do
-      allow(Setting.email_comment_replies).to receive(:[]).with(:address).and_return("")
-      allow(Setting).to receive(:host).and_return("")
-      expect(mail.from).to eql(["no-reply@example.com"])
+    it "should fallback to smtp from address as the sender" do
+      allow(Setting).to receive(:dig).with(:email_comment_replies, :address).and_return("")
+      allow(Setting).to receive(:dig).with(:smtp, :from).and_return("smtp_from@example.com")
+      expect(mail.from).to eql(["smtp_from@example.com"])
+    end
+
+    it "should set default reply-to address if email doesn't exist" do
+      allow(Setting).to receive(:dig).with(:email_comment_replies, :address).and_return("")
+      allow(Setting).to receive(:dig).with(:smtp, :from).and_return("")
+      expect(mail.from).to eql(["noreply@fatfreecrm.com"])
     end
   end
 end

data/spec/mailers/user_mailer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/models/entities/account_contact_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -26,6 +28,7 @@ describe AccountContact do
   end
 
   it "should create a new instance given valid attributes" do
+    expect(@valid_attributes[:account]).to receive(:increment!)
     AccountContact.create!(@valid_attributes)
   end
 end

data/spec/models/entities/account_opportunity_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -26,6 +28,7 @@ describe AccountOpportunity do
   end
 
   it "should create a new instance given valid attributes" do
+    expect(@valid_attributes[:account]).to receive(:increment!)
     AccountOpportunity.create!(@valid_attributes)
   end
 end

data/spec/models/entities/account_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -28,7 +30,7 @@
 require 'spec_helper'
 
 describe Account do
-  before { login }
+  let(:current_user) { FactoryGirl.create(:user) }
 
   it "should create a new instance given valid attributes" do
     Account.create!(name: "Test Account", user: FactoryGirl.create(:user))

data/spec/models/entities/campaign_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -32,7 +34,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Campaign do
-  before { login }
+  let(:current_user) { FactoryGirl.create(:user) }
 
   it "should create a new instance given valid attributes" do
     Campaign.create!(name: "Campaign", user: FactoryGirl.create(:user))

data/spec/models/entities/contact_opportunity_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/models/entities/contact_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -39,7 +41,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Contact do
-  before { login }
+  let(:current_user) { FactoryGirl.create(:user) }
 
   it "should create a new instance given valid attributes" do
     Contact.create!(first_name: "Billy", last_name: "Bones")
@@ -52,49 +54,61 @@ describe Contact do
     end
 
     it "should create new account if requested so" do
-      expect {
+      expect do
         @contact.update_with_account_and_permissions(
-        account: { name: "New account" },
-        contact: { first_name: "Billy" }
-      )
-      }.to change(Account, :count).by(1)
+          account: { name: "New account" },
+          contact: { first_name: "Billy" }
+        )
+      end.to change(Account, :count).by(1)
       expect(Account.last.name).to eq("New account")
       expect(@contact.first_name).to eq("Billy")
     end
 
     it "should change account if another account was selected" do
       @another_account = FactoryGirl.create(:account)
-      expect {
+      expect do
         @contact.update_with_account_and_permissions(
-        account: { id: @another_account.id },
-        contact: { first_name: "Billy" }
-      )
-      }.not_to change(Account, :count)
+          account: { id: @another_account.id },
+          contact: { first_name: "Billy" }
+        )
+      end.not_to change(Account, :count)
       expect(@contact.account).to eq(@another_account)
       expect(@contact.first_name).to eq("Billy")
     end
 
     it "should drop existing Account if [create new account] is blank" do
-      expect {
+      expect do
         @contact.update_with_account_and_permissions(
-        account: { name: "" },
-        contact: { first_name: "Billy" }
-      )
-      }.not_to change(Account, :count)
+          account: { name: "" },
+          contact: { first_name: "Billy" }
+        )
+      end.not_to change(Account, :count)
       expect(@contact.account).to eq(nil)
       expect(@contact.first_name).to eq("Billy")
     end
 
     it "should drop existing Account if [-- None --] is selected from list of accounts" do
-      expect {
+      expect do
         @contact.update_with_account_and_permissions(
-        account: { id: "" },
-        contact: { first_name: "Billy" }
-      )
-      }.not_to change(Account, :count)
+          account: { id: "" },
+          contact: { first_name: "Billy" }
+        )
+      end.not_to change(Account, :count)
       expect(@contact.account).to eq(nil)
       expect(@contact.first_name).to eq("Billy")
     end
+
+    it "should change account if entered name of another account was found" do
+      @another_account = FactoryGirl.create(:account, name: "Another name")
+      expect do
+        @contact.update_with_account_and_permissions(
+          account: { name: "Another name" },
+          contact: { first_name: "Billy" }
+        )
+      end.not_to change(Account, :count)
+      expect(@contact.account).to eq(@another_account)
+      expect(@contact.first_name).to eq("Billy")
+    end
   end
 
   describe "Attach" do

data/spec/models/entities/lead_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -39,7 +41,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Lead do
-  before { login }
+  let(:current_user) { FactoryGirl.create(:user) }
 
   it "should create a new instance given valid attributes" do
     Lead.create!(first_name: "Billy", last_name: "Bones")

data/spec/models/entities/opportunity_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -28,15 +30,13 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe Opportunity do
-  before { login }
-
   it "should create a new instance given valid attributes" do
     Opportunity.create!(name: "Opportunity", stage: 'analysis')
   end
 
   it "should be possible to create opportunity with the same name" do
-    FactoryGirl.create(:opportunity, name: "Hello", user: current_user)
-    expect { FactoryGirl.create(:opportunity, name: "Hello", user: current_user) }.to_not raise_error
+    FactoryGirl.create(:opportunity, name: "Hello")
+    expect { FactoryGirl.create(:opportunity, name: "Hello") }.to_not raise_error
   end
 
   it "have a default stage" do
@@ -55,50 +55,62 @@ describe Opportunity do
     end
 
     it "should create new account if requested so" do
-      expect {
+      expect do
         @opportunity.update_with_account_and_permissions(
-        account: { name: "New account" },
-        opportunity: { name: "Hello" }
-      )
-      }.to change(Account, :count).by(1)
+          account: { name: "New account" },
+          opportunity: { name: "Hello" }
+        )
+      end.to change(Account, :count).by(1)
       expect(Account.last.name).to eq("New account")
       expect(@opportunity.name.gsub(/#\d+ /, '')).to eq("Hello")
     end
 
     it "should update the account another account was selected" do
       @another_account = FactoryGirl.create(:account)
-      expect {
+      expect do
         @opportunity.update_with_account_and_permissions(
-        account: { id: @another_account.id },
-        opportunity: { name: "Hello" }
-      )
-      }.not_to change(Account, :count)
+          account: { id: @another_account.id },
+          opportunity: { name: "Hello" }
+        )
+      end.not_to change(Account, :count)
       expect(@opportunity.account).to eq(@another_account)
       expect(@opportunity.name.gsub(/#\d+ /, '')).to eq("Hello")
     end
 
     it "should drop existing Account if [create new account] is blank" do
-      expect {
+      expect do
         @opportunity.update_with_account_and_permissions(
-        account: { name: "" },
-        opportunity: { name: "Hello" }
-      )
-      }.not_to change(Account, :count)
+          account: { name: "" },
+          opportunity: { name: "Hello" }
+        )
+      end.not_to change(Account, :count)
       expect(@opportunity.account).to be_nil
       expect(@opportunity.name.gsub(/#\d+ /, '')).to eq("Hello")
     end
 
     it "should drop existing Account if [-- None --] is selected from list of accounts" do
-      expect {
+      expect do
         @opportunity.update_with_account_and_permissions(
-        account: { id: "" },
-        opportunity: { name: "Hello" }
-      )
-      }.not_to change(Account, :count)
+          account: { id: "" },
+          opportunity: { name: "Hello" }
+        )
+      end.not_to change(Account, :count)
       expect(@opportunity.account).to be_nil
       expect(@opportunity.name.gsub(/#\d+ /, '')).to eq("Hello")
     end
 
+    it "should change account if entered name of another account was found" do
+      @another_account = FactoryGirl.create(:account, name: "Another name")
+      expect do
+        @opportunity.update_with_account_and_permissions(
+          account: { name: "Another name" },
+          opportunity: { name: "Hello" }
+        )
+      end.not_to change(Account, :count)
+      expect(@opportunity.account).to eq(@another_account)
+      expect(@opportunity.name.gsub(/#\d+ /, '')).to eq("Hello")
+    end
+
     it "should set the probability to 0% if opportunity has been lost" do
       opportunity = FactoryGirl.create(:opportunity, stage: "prospecting", probability: 25)
       opportunity.update_attributes(stage: 'lost')
@@ -151,7 +163,7 @@ describe Opportunity do
     end
 
     it "should return nil when attaching existing asset" do
-      @task = FactoryGirl.create(:task, asset: @opportunity, user: current_user)
+      @task = FactoryGirl.create(:task, asset: @opportunity)
       @contact = FactoryGirl.create(:contact)
       @opportunity.contacts << @contact
 
@@ -160,7 +172,7 @@ describe Opportunity do
     end
 
     it "should return non-empty list of attachments when attaching new asset" do
-      @task = FactoryGirl.create(:task, user: current_user)
+      @task = FactoryGirl.create(:task)
       @contact = FactoryGirl.create(:contact)
 
       expect(@opportunity.attach!(@task)).to eq([@task])
@@ -174,7 +186,7 @@ describe Opportunity do
     end
 
     it "should discard a task" do
-      @task = FactoryGirl.create(:task, asset: @opportunity, user: current_user)
+      @task = FactoryGirl.create(:task, asset: @opportunity)
       expect(@opportunity.tasks.count).to eq(1)
 
       @opportunity.discard!(@task)

data/spec/models/fields/custom_field_date_pair_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/models/fields/custom_field_pair_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/models/fields/custom_field_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/models/fields/field_group_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.

data/spec/models/fields/field_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright (c) 2008-2013 Michael Dvorkin and contributors.
 #
 # Fat Free CRM is freely distributable under the terms of MIT license.
@@ -19,6 +21,7 @@
 #  collection     :text
 #  disabled       :boolean
 #  required       :boolean
+#  minlength      :integer
 #  maxlength      :integer
 #  created_at     :datetime
 #  updated_at     :datetime
@@ -32,6 +35,7 @@ describe Field do
       name:      'skype_address',
       label:     'Skype address',
       as:        'string',
+      minlength: 12,
       maxlength: 220,
       position:  10
     )
@@ -53,10 +57,10 @@ describe Field do
     object = double('Object')
 
     #  as  |  value  |  expected
-    [["check_boxes", [1, 2, 3],               "1, 2<br />3"],
-     %w(checkbox 0 no),
-     ["checkbox",    1,                       "yes"],
-     ["date",        DateTime.new(2011, 4, 19), DateTime.new(2011, 4, 19).strftime(I18n.t("date.formats.mmddyy"))]].each do |as, value, expected|
+    [["check_boxes", [1, 2, 3], "1, 2<br />3"],
+     %w[checkbox 0 no],
+     ["checkbox", 1, "yes"],
+     ["date", Time.parse('2011-04-19'), Time.parse('2011-04-19').strftime(I18n.t("date.formats.mmddyy"))]].each do |as, value, expected|
       field.as = as
       allow(object).to receive(field.name).and_return(value)
       expect(field.render_value(object)).to eq(expected)