fat_free_crm 0.15.0.beta.2 → 0.15.0

data/spec/factories/campaign_factories.rb

@@ -9,7 +9,7 @@ FactoryGirl.define do
     name                { FFaker::Lorem.sentence[0, 64] }
     assigned_to nil
     access "Public"
-    status              { %w(planned started completed planned started completed on_hold called_off).sample }
+    status              { %w[planned started completed planned started completed on_hold called_off].sample }
     budget              { rand(500) }
     target_leads        { rand(200) }
     target_conversion   { rand(20) }

data/spec/factories/contact_factories.rb

@@ -14,7 +14,7 @@ FactoryGirl.define do
     access "Public"
     title               { FactoryGirl.generate(:title) }
     department          { FFaker::Name.name + " Dept." }
-    source              { %w(campaign cold_call conference online referral self web word_of_mouth other).sample }
+    source              { %w[campaign cold_call conference online referral self web word_of_mouth other].sample }
     email               { FFaker::Internet.email }
     alt_email           { FFaker::Internet.email }
     phone               { FFaker::PhoneNumber.phone_number }

data/spec/factories/field_factories.rb

@@ -5,7 +5,7 @@
 #------------------------------------------------------------------------------
 FactoryGirl.define do
   sequence :klass_name do |_x|
-    %w(Contact Account Opportunity Lead Campaign).sample
+    %w[Contact Account Opportunity Lead Campaign].sample
   end
 
   sequence(:field_position) { |x| x }

data/spec/factories/lead_factories.rb

@@ -13,8 +13,8 @@ FactoryGirl.define do
     access "Public"
     company             { FFaker::Company.name }
     title               { FactoryGirl.generate(:title) }
-    source              { %w(campaign cold_call conference online referral self web word_of_mouth other).sample }
-    status              { %w(new contacted converted rejected).sample }
+    source              { %w[campaign cold_call conference online referral self web word_of_mouth other].sample }
+    status              { %w[new contacted converted rejected].sample }
     rating 1
     referred_by         { FFaker::Name.name }
     do_not_call false

data/spec/factories/opportunity_factories.rb

@@ -5,11 +5,11 @@
 #------------------------------------------------------------------------------
 FactoryGirl.define do
   sequence :opportunity_status do |_s|
-    %w(prospecting analysis presentation proposal negotiation final_review won lost).sample
+    %w[prospecting analysis presentation proposal negotiation final_review won lost].sample
   end
 
   sequence :opportunity_open_status do |_s|
-    %w(prospecting analysis presentation proposal negotiation final_review).sample
+    %w[prospecting analysis presentation proposal negotiation final_review].sample
   end
 
   factory :opportunity do
@@ -19,7 +19,7 @@ FactoryGirl.define do
     assigned_to nil
     name                { FFaker::Lorem.sentence[0, 64] }
     access "Public"
-    source              { %w(campaign cold_call conference online referral self web word_of_mouth other).sample }
+    source              { %w[campaign cold_call conference online referral self web word_of_mouth other].sample }
     stage               { FactoryGirl.generate(:opportunity_status) }
     probability         { rand(50) }
     amount              { rand(1000) }

data/spec/factories/shared_factories.rb

@@ -50,7 +50,7 @@ FactoryGirl.define do
     zipcode             { FFaker::AddressUS.zip_code }
     country             { FFaker::AddressUK.country }
     full_address        { FactoryGirl.generate(:address) }
-    address_type        { %w(Business Billing Shipping).sample }
+    address_type        { %w[Business Billing Shipping].sample }
     updated_at          { FactoryGirl.generate(:time) }
     created_at          { FactoryGirl.generate(:time) }
     deleted_at nil

data/spec/factories/task_factories.rb

@@ -11,7 +11,7 @@ FactoryGirl.define do
     completed_by nil
     name                { FFaker::Lorem.sentence[0, 64] }
     priority nil
-    category            { %w(call email follow_up lunch meeting money presentation trip).sample }
+    category            { %w[call email follow_up lunch meeting money presentation trip].sample }
     bucket "due_asap"
     due_at              { FactoryGirl.generate(:time) }
     background_info     { FFaker::Lorem.paragraph[0, 255] }

data/spec/features/support/browser.rb

@@ -8,7 +8,15 @@
 #
 if ENV['BROWSER'] == 'chrome'
   Capybara.register_driver :selenium do |app|
-    Capybara::Selenium::Driver.new(app, browser: :chrome)
+    capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(chromeOptions: { args: ['no-sandbox', 'headless', 'disable-gpu'] })
+    Capybara::Selenium::Driver.new(app, browser: :chrome, desired_capabilities: capabilities)
+  end
+else
+  Capybara.register_driver :selenium do |app|
+    options = Selenium::WebDriver::Firefox::Options.new
+    options.args << '--headless'
+    capabilities = Selenium::WebDriver::Remote::Capabilities.firefox(marionette: false)
+    Capybara::Selenium::Driver.new(app, browser: :firefox, options: options, desired_capabilities: capabilities)
   end
 end
 

data/spec/lib/fields_spec.rb

@@ -36,7 +36,7 @@ describe 'FatFreeCRM::Fields' do
 
   describe "field_groups" do
     it "should call FieldGroup" do
-      expect(ActiveRecord::Base.connection).to receive(:table_exists?).with('field_groups').and_return(true)
+      expect(ActiveRecord::Base.connection).to receive(:data_source_exists?).with('field_groups').and_return(true)
       dummy_scope = double
       expect(dummy_scope).to receive(:order).with(:position)
       expect(FieldGroup).to receive(:where).and_return(dummy_scope)
@@ -44,7 +44,7 @@ describe 'FatFreeCRM::Fields' do
     end
 
     it "should not call FieldGroup if table doesn't exist (migrations not yet run)" do
-      expect(ActiveRecord::Base.connection).to receive(:table_exists?).with('field_groups').and_return(false)
+      expect(ActiveRecord::Base.connection).to receive(:data_source_exists?).with('field_groups').and_return(false)
       expect(Foo.new.field_groups).to eq([])
     end
   end

data/spec/lib/permissions_spec.rb

@@ -30,19 +30,22 @@ describe FatFreeCRM::Permissions do
 
     it "should assign permissions to the object" do
       expect(@entity.permissions.size).to eq(0)
-      @entity.update_attribute(:user_ids, %w(1 2 3))
+      @entity.user_ids = %w[1 2 3]
+      @entity.save!
       expect(@entity.permissions.where(user_id: [1, 2, 3]).size).to eq(3)
     end
 
     it "should handle [] permissions" do
-      @entity.update_attribute(:user_ids, [])
+      @entity.user_ids = []
+      @entity.save!
       expect(@entity.permissions.size).to eq(0)
     end
 
     it "should replace existing permissions" do
       @entity.permissions << FactoryGirl.create(:permission, user_id: 1, asset: @entity)
       @entity.permissions << FactoryGirl.create(:permission, user_id: 2, asset: @entity)
-      @entity.update_attribute(:user_ids, %w(2 3))
+      @entity.user_ids = %w[2 3]
+      @entity.save!
       expect(@entity.permissions.size).to eq(2)
       expect(@entity.permissions.where(user_id: [1]).size).to eq(0)
       expect(@entity.permissions.where(user_id: [2]).size).to eq(1)
@@ -56,12 +59,14 @@ describe FatFreeCRM::Permissions do
     end
     it "should assign permissions to the object" do
       expect(@entity.permissions.size).to eq(0)
-      @entity.update_attribute(:group_ids, %w(1 2 3))
+      @entity.group_ids = %w[1 2 3]
+      @entity.save!
       expect(@entity.permissions.where(group_id: [1, 2, 3]).size).to eq(3)
     end
 
     it "should handle [] permissions" do
-      @entity.update_attribute(:group_ids, [])
+      @entity.group_ids = []
+      @entity.save!
       expect(@entity.permissions.size).to eq(0)
     end
 
@@ -69,7 +74,8 @@ describe FatFreeCRM::Permissions do
       @entity.permissions << FactoryGirl.build(:permission, group_id: 1, user_id: nil, asset: @entity)
       @entity.permissions << FactoryGirl.build(:permission, group_id: 2, user_id: nil, asset: @entity)
       expect(@entity.permissions.size).to eq(2)
-      @entity.update_attribute(:group_ids, ['3'])
+      @entity.group_ids = ['3']
+      @entity.save!
       expect(@entity.permissions.size).to eq(1)
       expect(@entity.permissions.where(group_id: [1, 2]).size).to eq(0)
       expect(@entity.permissions.where(group_id: [3]).size).to eq(1)
@@ -131,4 +137,30 @@ describe FatFreeCRM::Permissions do
       entity.save_with_model_permissions(model)
     end
   end
+
+  describe 'remove_permissions' do
+    context 'with a new record' do
+      before :each do
+        @entity = UserWithPermission.new
+      end
+      it 'should have no relationships to destroy' do
+        expect(@entity.remove_permissions).to eq []
+      end
+    end
+
+    context 'with an existing record' do
+      before :each do
+        @entity = UserWithPermission.create
+
+        @permission1 = Permission.create(user_id: 1, group_id: 1, asset_id: @entity.id, asset_type: 'UserWithPermission')
+        @permission2 = Permission.create(user_id: 1, group_id: 2, asset_id: @entity.id, asset_type: 'UserWithPermission')
+      end
+      it 'should remove the related permissions' do
+        current = Permission.all.count
+
+        expect(@entity.remove_permissions.length).to eq 2
+        expect(Permission.all.count).to eq(current - 2)
+      end
+    end
+  end
 end

data/spec/lib/view_factory_spec.rb

@@ -13,7 +13,7 @@ describe FatFreeCRM::ViewFactory do
 
   describe "initialization" do
     before(:each) do
-      @view_params = { name: 'brief', title: 'Brief View', icon: 'fa-bars', controllers: ['contacts'], actions: %w(show index) }
+      @view_params = { name: 'brief', title: 'Brief View', icon: 'fa-bars', controllers: ['contacts'], actions: %w[show index] }
     end
 
     it "should initialize with required parameters" do
@@ -41,7 +41,7 @@ describe FatFreeCRM::ViewFactory do
 
   describe "views_for" do
     before(:each) do
-      @v1 = FatFreeCRM::ViewFactory.new name: 'brief', title: 'Brief View', controllers: ['contacts'], actions: %w(show index)
+      @v1 = FatFreeCRM::ViewFactory.new name: 'brief', title: 'Brief View', controllers: ['contacts'], actions: %w[show index]
       @v2 = FatFreeCRM::ViewFactory.new name: 'long', title: 'Long View', controllers: ['contacts'], actions: ['show']
       @v3 = FatFreeCRM::ViewFactory.new name: 'full', title: 'Full View', controllers: ['accounts'], actions: ['show']
     end

data/spec/models/fields/custom_field_spec.rb

@@ -45,7 +45,7 @@ describe CustomField do
     c = FactoryGirl.build(:custom_field, label: "Test Field", field_group: field_group)
 
     columns = []
-    %w(cf_test_field cf_test_field_2 cf_test_field_3 cf_test_field_4).each do |field|
+    %w[cf_test_field cf_test_field_2 cf_test_field_3 cf_test_field_4].each do |field|
       expect(c.send(:generate_column_name)).to eq(field)
       allow(Contact).to receive(:column_names).and_return(columns << field)
     end
@@ -63,8 +63,8 @@ describe CustomField do
   end
 
   it "should return a safe list of types for the 'as' select options" do
-    { "email"   => %w(check_boxes text string email url tel select radio_buttons),
-      "integer" => %w(integer float) }.each do |type, expected_arr|
+    { "email"   => %w[check_boxes text string email url tel select radio_buttons],
+      "integer" => %w[integer float] }.each do |type, expected_arr|
       c = FactoryGirl.build(:custom_field, as: type)
       opts = c.available_as
       expect(opts.map(&:first)).to match_array(expected_arr)

data/spec/models/observers/entity_observer_spec.rb

@@ -11,7 +11,7 @@ describe EntityObserver do
     allow(PaperTrail).to receive(:whodunnit).and_return(assigner)
   end
 
-  [:account, :contact, :lead, :opportunity].each do |entity_type|
+  %i[account contact lead opportunity].each do |entity_type|
     describe "on creation of #{entity_type}" do
       let(:assignee) { FactoryGirl.create(:user) }
       let(:assigner) { FactoryGirl.create(:user) }

data/spec/models/polymorphic/version_spec.rb

@@ -34,7 +34,7 @@ describe Version, versioning: true do
     before do
       @lead = FactoryGirl.create(:lead)
 
-      %w(create destroy update view).each do |event|
+      %w[create destroy update view].each do |event|
         FactoryGirl.create(:version, event: event, item: @lead, whodunnit: PaperTrail.whodunnit)
         FactoryGirl.create(:version, event: event, item: @lead, whodunnit: "1")
       end
@@ -54,12 +54,12 @@ describe Version, versioning: true do
 
     it "should include only destroy events" do
       @versions = Version.for(current_user).include_events(:destroy)
-      expect(@versions.pluck(:event).uniq).to eq(%w(destroy))
+      expect(@versions.pluck(:event).uniq).to eq(['destroy'])
     end
 
     it "should include create and update events" do
       @versions = Version.for(current_user).include_events(:create, :update)
-      expect(@versions.pluck(:event).uniq.sort).to eq(%w(create update))
+      expect(@versions.pluck(:event).uniq.sort).to eq(%w[create update])
     end
 
     it "should select all versions for a given user" do
@@ -68,7 +68,7 @@ describe Version, versioning: true do
     end
   end
 
-  %w(account campaign contact lead opportunity task).each do |item|
+  %w[account campaign contact lead opportunity task].each do |item|
     describe "Create, update, and delete (#{item})" do
       before :each do
         @item = FactoryGirl.create(item.to_sym, user: current_user)
@@ -122,7 +122,7 @@ describe Version, versioning: true do
       @task.update(name: 'New Name')
 
       versions = Version.where(@conditions)
-      expect(versions.pluck(:event).sort).to eq(%w(create update)) # but not view
+      expect(versions.pluck(:event).sort).to eq(%w[create update]) # but not view
     end
   end
 
@@ -179,7 +179,7 @@ describe Version, versioning: true do
       @item.update(name: 'New Name')
 
       versions = Version.where(item_id: @item.id, item_type: @item.class.name)
-      expect(versions.pluck(:event).sort).to eq(%w(create update))
+      expect(versions.pluck(:event).sort).to eq(%w[create update])
 
       visible_versions = Version.visible_to(@user)
       expect(visible_versions).to eq([])
@@ -190,7 +190,7 @@ describe Version, versioning: true do
       @item.destroy
 
       versions = Version.where(item_id: @item.id, item_type: @item.class.name)
-      expect(versions.pluck(:event).sort).to eq(%w(create destroy))
+      expect(versions.pluck(:event).sort).to eq(%w[create destroy])
 
       visible_versions = Version.visible_to(@user)
       expect(visible_versions).to eq([])
@@ -205,7 +205,7 @@ describe Version, versioning: true do
       @item.update(name: 'New Name')
 
       versions = Version.where(item_id: @item.id, item_type: @item.class.name)
-      expect(versions.pluck(:event).sort).to eq(%w(create update))
+      expect(versions.pluck(:event).sort).to eq(%w[create update])
 
       visible_versions = Version.visible_to(@user)
       expect(visible_versions).to eq([])
@@ -220,7 +220,7 @@ describe Version, versioning: true do
       @item.destroy
 
       versions = Version.where(item_id: @item.id, item_type: @item.class.name)
-      expect(versions.pluck(:event).sort).to eq(%w(create destroy))
+      expect(versions.pluck(:event).sort).to eq(%w[create destroy])
 
       visible_versions = Version.visible_to(@user)
       expect(visible_versions).to eq([])
@@ -235,10 +235,10 @@ describe Version, versioning: true do
       @item.update(name: 'New Name')
 
       versions = Version.where(item_id: @item.id, item_type: @item.class.name)
-      expect(versions.pluck(:event).sort).to eq(%w(create update))
+      expect(versions.pluck(:event).sort).to eq(%w[create update])
 
       visible_versions = Version.visible_to(@user)
-      expect(visible_versions.map(&:event).sort).to eq(%w(create update))
+      expect(visible_versions.map(&:event).sort).to eq(%w[create update])
     end
   end
 end

data/spec/models/users/abilities/user_ability_spec.rb

@@ -1,8 +1,13 @@
+# Copyright (c) 2008-2013 Michael Dvorkin and contributors.
+#
+# Fat Free CRM is freely distributable under the terms of MIT license.
+# See MIT-LICENSE file or http://www.opensource.org/licenses/mit-license.php
+#------------------------------------------------------------------------------
 require 'spec_helper'
 require 'cancan/matchers'
 
 def all_actions
-  [:index, :show, :create, :update, :destroy, :manage]
+  %i[index show create update destroy manage]
 end
 
 describe "User abilities" do
@@ -27,7 +32,7 @@ describe "User abilities" do
   context "when another user, I" do
     let(:user)  { create :user }
     let(:can)    { [] }
-    let(:cannot) { [:show, :create, :update, :index, :destroy, :manage] }
+    let(:cannot) { %i[show create update index destroy manage] }
     it do
       can.each do |do_action|
         is_expected.to be_able_to(do_action, subject_user)
@@ -43,7 +48,7 @@ describe "User abilities" do
   context "when anonymous user, I" do
     let(:user)  { nil }
     let(:can)    { [] }
-    let(:cannot) { [:show, :create, :update, :index, :destroy, :manage] }
+    let(:cannot) { %i[show create update index destroy manage] }
     it do
       can.each do |do_action|
         is_expected.to be_able_to(do_action, subject_user)

data/spec/models/users/permission_spec.rb

@@ -45,4 +45,12 @@ describe Permission do
     expect(p.errors['user_id']).to eq(["can't be blank"])
     expect(p.errors['group_id']).to eq(["can't be blank"])
   end
+
+  it 'should not allow duplicate records with (user_id, group_id, asset_type, asset_ids) the same' do
+    permission1 = Permission.create(user_id: 1, group_id: 1, asset_id: 1, asset_type: 'UserWithPermission')
+    permission2 = Permission.new(user_id: 1, group_id: 1, asset_id: 1, asset_type: 'UserWithPermission')
+
+    expect(permission1).to be_valid
+    expect(permission2).not_to be_valid
+  end
 end

data/spec/models/users/user_spec.rb

@@ -60,7 +60,7 @@ describe User do
         @user = FactoryGirl.build(:user)
       end
 
-      %w(account campaign lead contact opportunity).each do |asset|
+      %w[account campaign lead contact opportunity].each do |asset|
         it "should not destroy the user if she owns #{asset}" do
           FactoryGirl.create(asset, user: @user)
 

data/spec/shared/controllers.rb

@@ -10,13 +10,13 @@ shared_examples "auto complete" do
   end
 
   it "should do the search and find records that match autocomplete query" do
-    get :auto_complete, auto_complete_query: @query
+    get :auto_complete, params: { auto_complete_query: @query }
     expect(assigns[:query]).to eq(@query)
     expect(assigns[:auto_complete]).to eq(@auto_complete_matches) # Each controller must define it.
   end
 
   it "should save current autocomplete controller in a session" do
-    get :auto_complete, auto_complete_query: @query
+    get :auto_complete, params: { auto_complete_query: @query }
 
     # We don't save Admin/Users autocomplete controller in a session since Users are not
     # exposed through the Jumpbox.
@@ -26,14 +26,14 @@ shared_examples "auto complete" do
   end
 
   it "should render application/_auto_complete template" do
-    post :auto_complete, auto_complete_query: @query
+    post :auto_complete, params: { auto_complete_query: @query }
     expect(response).to render_template("application/_auto_complete")
   end
 end
 
 shared_examples "attach" do
   it "should attach existing asset to the parent asset of different type" do
-    xhr :put, :attach, id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id
+    put :attach, params: { id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id }, xhr: true
     expect(@model.send(@attachment.class.name.tableize)).to include(@attachment)
     expect(assigns[:attachment]).to eq(@attachment)
     expect(assigns[:attached]).to eq([@attachment])
@@ -53,7 +53,7 @@ shared_examples "attach" do
       @model.send(@attachment.class.name.tableize) << @attachment
     end
 
-    xhr :put, :attach, id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id
+    put :attach, params: { id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id }, xhr: true
     expect(assigns[:attached]).to eq(nil)
     expect(response).to render_template("entities/attach")
   end
@@ -61,14 +61,14 @@ shared_examples "attach" do
   it "should display flash warning when the model is no longer available" do
     @model.destroy
 
-    xhr :put, :attach, id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id
+    put :attach, params: { id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id }, xhr: true
     expect(flash[:warning]).not_to eq(nil)
     expect(response.body).to eq("window.location.reload();")
   end
   it "should display flash warning when the attachment is no longer available" do
     @attachment.destroy
 
-    xhr :put, :attach, id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id
+    put :attach, params: { id: @model.id, assets: @attachment.class.name.tableize, asset_id: @attachment.id }, xhr: true
     expect(flash[:warning]).not_to eq(nil)
     expect(response.body).to eq("window.location.reload();")
   end
@@ -76,7 +76,7 @@ end
 
 shared_examples "discard" do
   it "should discard the attachment without deleting it" do
-    xhr :post, :discard, id: @model.id, attachment: @attachment.class.name, attachment_id: @attachment.id
+    post :discard, params: { id: @model.id, attachment: @attachment.class.name, attachment_id: @attachment.id }, xhr: true
     expect(assigns[:attachment]).to eq(@attachment.reload)                     # The attachment should still exist.
     expect(@model.reload.send(@attachment.class.name.tableize.to_s)).to eq([]) # But no longer associated with the model.
     expect(assigns[:account]).to eq(@model) if @model.is_a?(Account)
@@ -88,7 +88,7 @@ shared_examples "discard" do
   it "should display flash warning when the model is no longer available" do
     @model.destroy
 
-    xhr :post, :discard, id: @model.id, attachment: @attachment.class.name, attachment_id: @attachment.id
+    post :discard, params: { id: @model.id, attachment: @attachment.class.name, attachment_id: @attachment.id }, xhr: true
     expect(flash[:warning]).not_to eq(nil)
     expect(response.body).to eq("window.location.reload();")
   end
@@ -96,7 +96,7 @@ shared_examples "discard" do
   it "should display flash warning when the attachment is no longer available" do
     @attachment.destroy
 
-    xhr :post, :discard, id: @model.id, attachment: @attachment.class.name, attachment_id: @attachment.id
+    post :discard, params: { id: @model.id, attachment: @attachment.class.name, attachment_id: @attachment.id }, xhr: true
     expect(flash[:warning]).not_to eq(nil)
     expect(response.body).to eq("window.location.reload();")
   end