fat_core 5.1.0 → 5.3.0

data/lib/fat_core/enumerable.rb

@@ -31,7 +31,7 @@ module Enumerable
   #    end
   def each_with_flags
     # Test for beginless range
-    return nil if is_a?(Range) && self.begin.nil?
+    return if is_a?(Range) && self.begin.nil?
 
     last_k = size - 1
     each_with_index do |v, k|

data/lib/fat_core/nil.rb

@@ -8,7 +8,7 @@ module FatCore
     def as_string
       ''
     end
-    alias entitle as_string
+    alias_method :entitle, :as_string
 
     # Allow nils to respond to #tex_quote for use in TeX documents
     #

data/lib/fat_core/numeric.rb

@@ -15,13 +15,11 @@ module FatCore
     #
     # @return [Integer] -1, 0, or 1 for negative, zero or positive self
     def signum
-      if positive?
-        1
-      elsif negative?
-        -1
-      else
-        0
-      end
+      raise NotImplementedError unless real?
+      return 1 if positive?
+      return -1 if negative?
+
+      0
     end
 
     # Convert this number into a string and insert grouping commas into the
@@ -65,7 +63,7 @@ module FatCore
 
       # Only convert to string numbers with exponent unless they are
       # less than 1 (to ensure that really small numbers round to 0.0)
-      return to_s if abs > 1.0 && to_s =~ /e/
+      return to_s if abs > 1.0 && to_s.include?('e')
 
       # Round if places given
       str =
@@ -135,13 +133,20 @@ module FatCore
       mins, secs = divmod(60)
       hrs, mins = mins.divmod(60)
       if frac.round(5) > 0.0
-        format('%02<hrs>d:%02<mins>d:%02<secs>d.%<frac>d',
-               { hrs: hrs,
-                 mins: mins, secs: secs,
-                 frac: frac.round(5) * 100 })
+        format(
+          '%02<hrs>d:%02<mins>d:%02<secs>d.%<frac>d',
+          {
+            hrs: hrs,
+            mins: mins,
+            secs: secs,
+            frac: frac.round(5) * 100
+          },
+        )
       else
-        format('%02<hrs>d:%02<mins>d:%02<secs>d',
-               { hrs: hrs, mins: mins, secs: secs })
+        format(
+          '%02<hrs>d:%02<mins>d:%02<secs>d',
+          { hrs: hrs, mins: mins, secs: secs },
+        )
       end
     end
 

data/lib/fat_core/range.rb

@@ -128,11 +128,11 @@ module FatCore
     # @param other [Range] the Range self is intersected with
     # @return [Range, nil] a Range representing the intersection
     def intersection(other)
-      return nil unless overlaps?(other)
+      return unless overlaps?(other)
 
       ([min, other.min].max..[max, other.max].min)
     end
-    alias & intersection
+    alias_method :&, :intersection
 
     # Return a Range that represents the union between this range and the
     # `other` range.  If there is no overlap and self is not contiguous with
@@ -146,11 +146,11 @@ module FatCore
     # @param other [Range] the Range self is union-ed with
     # @return [Range, nil] a Range representing the union
     def union(other)
-      return nil unless overlaps?(other) || contiguous?(other)
+      return unless overlaps?(other) || contiguous?(other)
 
       ([min, other.min].min..[max, other.max].max)
     end
-    alias + union
+    alias_method :+, :union
 
     # The difference method, -, removes the overlapping part of the other
     # argument from self.  Because in the case where self is a superset of the
@@ -187,7 +187,7 @@ module FatCore
         [(min..isec.min.pred), (isec.max.succ..max)]
       end
     end
-    alias - difference
+    alias_method :-, :difference
 
     # Allow erb or erubis documents to directly interpolate a Range.
     #

data/lib/fat_core/string.rb

@@ -63,7 +63,7 @@ module FatCore
         result << w
         first_word_on_line = false
         line_width_so_far += 1 + w.length
-        next unless line_width_so_far >= width
+        next if line_width_so_far < width
 
         result << "\n"
         line_width_so_far = 0
@@ -108,9 +108,11 @@ module FatCore
     # @return [Date] the translated Date
     def as_date
       if self =~ %r{(?<yr>\d\d\d\d)[-/]?(?<mo>\d\d?)[-/]?(?<dy>\d\d?)}
-        ::Date.new(Regexp.last_match[:yr].to_i,
-                   Regexp.last_match[:mo].to_i,
-                   Regexp.last_match[:dy].to_i)
+        ::Date.new(
+          Regexp.last_match[:yr].to_i,
+          Regexp.last_match[:mo].to_i,
+          Regexp.last_match[:dy].to_i,
+        )
       end
     end
 
@@ -149,8 +151,26 @@ module FatCore
     #
     # @return [String]
     def entitle
-      little_words = %w[a an the at for up and but
-                        or nor in on under of from as by to]
+      little_words = %w[
+        a
+        an
+        the
+        at
+        for
+        up
+        and
+        but
+        or
+        nor
+        in
+        on
+        under
+        of
+        from
+        as
+        by
+        to
+      ]
       preserve_acronyms = !all_upper?
       newwords = []
       capitalize_next = false
@@ -159,26 +179,26 @@ module FatCore
       words.each_with_index do |w, k|
         first = k.zero?
         last = (k == last_k)
-        if w =~ %r{c/o}i
+        if %r{c/o}i.match?(w)
           # Care of
           newwords.push('c/o')
-        elsif w =~ /^p\.?o\.?$/i
+        elsif /^p\.?o\.?$/i.match?(w)
           # Post office
           newwords.push('P.O.')
-        elsif w =~ /^[0-9]+(st|nd|rd|th)$/i
+        elsif /^[0-9]+(st|nd|rd|th)$/i.match?(w)
           # Ordinals
           newwords.push(w.downcase)
-        elsif w =~ /^(cr|dr|st|rd|ave|pk|cir)$/i
+        elsif /^(cr|dr|st|rd|ave|pk|cir)$/i.match?(w)
           # Common abbrs to capitalize
           newwords.push(w.capitalize)
-        elsif w =~ /^(us|ne|se|rr)$/i
+        elsif /^(us|ne|se|rr)$/i.match?(w)
           # Common 2-letter abbrs to upcase
           newwords.push(w.upcase)
-        elsif w =~ /^[0-9].*$/i
+        elsif /^[0-9].*$/i.match?(w)
           # Other runs starting with numbers,
           # like 3-A
           newwords.push(w.upcase)
-        elsif w =~ /^(N|S|E|W|NE|NW|SE|SW)$/i
+        elsif /^(N|S|E|W|NE|NW|SE|SW)$/i.match?(w)
           # Compass directions all caps
           newwords.push(w.upcase)
         elsif w =~ /^[^aeiouy]*$/i && w.size > 2
@@ -202,7 +222,7 @@ module FatCore
           newwords.push(w.capitalize)
         end
         # Capitalize following a ':'
-        capitalize_next = true if newwords.last =~ /:\s*\z/
+        capitalize_next = true if /:\s*\z/.match?(newwords.last)
       end
       newwords.join(' ')
     end
@@ -272,11 +292,11 @@ module FatCore
       matcher = matcher.strip.gsub(/[\*.,']/, '')
       if matcher.start_with?(':')
         begin_anchor = true
-        matcher.sub!(/\A:/, '')
+        matcher.delete_prefix!(':')
       end
       if matcher.end_with?(':')
         end_anchor = true
-        matcher.sub!(/:\z/, '')
+        matcher.delete_suffix!(':')
       end
       target = gsub(/[\*.,']/, '')
       matchers = matcher.split(/[: ]+/)
@@ -364,7 +384,7 @@ module FatCore
     # @return [String] commified number as a String
     def commas(places = nil)
       numeric_re = /\A([-+])?([\d_]*)((\.)?([\d_]*))?([eE][+-]?[\d_]+)?\z/
-      return self unless clean =~ numeric_re
+      return self unless clean&.match?(numeric_re)
 
       to_f.commas(places)
     end

data/lib/fat_core/symbol.rb

@@ -16,7 +16,7 @@ module FatCore
     def as_string
       to_s.tr('_', ' ').split.join(' ').entitle
     end
-    alias entitle as_string
+    alias_method :entitle, :as_string
 
     # Return self. This (together with String#as_sym) allows `#as_sym` to be
     # applied to a string or Symbol and get back a Symbol with out testing for

data/lib/fat_core/version.rb

@@ -2,7 +2,7 @@
 
 module FatCore
   MAJOR = 5
-  MINOR = 1
+  MINOR = 3
   PATCH = 0
 
   # FatCore version number

data/spec/lib/date_spec.rb

@@ -23,21 +23,21 @@ describe Date do
         expect(described_class.ensure(described_class.today).class).to be described_class
       end
 
-      it 'converts Time as a date' do
-        expect(described_class.ensure_date(Time.now).class).to be described_class
-        expect(described_class.ensure(Time.now).class).to be described_class
+      it 'converts Time as a DateTime' do
+        expect(described_class.ensure_date(Time.now).class).to be DateTime
+        expect(described_class.ensure(Time.now).class).to be DateTime
       end
 
       it 'raises an error for bad date string' do
-        expect { described_class.ensure_date('2012-mm-tu') }.to raise_error(/invalid date/)
-        expect { described_class.ensure('2012-mm-tu') }.to raise_error(/invalid date/)
+        expect { described_class.ensure_date('2012-mm-tu') }.to raise_error(/cannot convert string/)
+        expect { described_class.ensure('2012-mm-tu') }.to raise_error(/cannot convert string/)
       end
 
       it 'raises an error for unknown class' do
         expect { described_class.ensure_date([2011, 11, 12]) }
-          .to raise_error(/requires String, Date, DateTime, or Time/)
+          .to raise_error(/cannot convert/)
         expect { described_class.ensure([2011, 11, 12]) }
-          .to raise_error(/requires String, Date, DateTime, or Time/)
+          .to raise_error(/cannot convert/)
       end
     end
 
@@ -61,6 +61,32 @@ describe Date do
         expect { described_class.days_in_month(2004, 13) }.to raise_error(ArgumentError)
       end
 
+      it 'knows a Date\'s half year' do
+        expect(Date.parse('2024-05-14').half).to eq(1)
+        expect(Date.parse('2024-09-14').half).to eq(2)
+      end
+
+      it 'knows a Date\'s quarter year' do
+        expect(Date.parse('2024-03-14').quarter).to eq(1)
+        expect(Date.parse('2024-05-14').quarter).to eq(2)
+        expect(Date.parse('2024-09-14').quarter).to eq(3)
+        expect(Date.parse('2024-11-14').quarter).to eq(4)
+      end
+
+      it 'knows a Date\'s bimonth' do
+        expect(Date.parse('2024-03-14').bimonth).to eq(2)
+        expect(Date.parse('2024-05-14').bimonth).to eq(3)
+        expect(Date.parse('2024-09-14').bimonth).to eq(5)
+        expect(Date.parse('2024-11-14').bimonth).to eq(6)
+      end
+
+      it 'knows a Date\'s semimonth' do
+        expect(Date.parse('2024-03-14').semimonth).to eq(5)
+        expect(Date.parse('2024-05-14').semimonth).to eq(9)
+        expect(Date.parse('2024-09-24').semimonth).to eq(18)
+        expect(Date.parse('2024-11-14').semimonth).to eq(21)
+      end
+
       it 'knows the nth weekday in a year, month' do
         # Sunday is 0, Saturday is 6
         #     January 2014
@@ -246,6 +272,14 @@ describe Date do
         expect(described_class.parse_spec('2011/08/05')).to eq described_class.parse('2011-08-05')
       end
 
+      it 'parses YYYY-ddd day-of-year dates correctly' do
+        expect(described_class.parse_spec('2011-115')).to eq described_class.parse('2011-04-25')
+        expect(described_class.parse_spec('2011/001')).to eq described_class.parse('2011-01-01')
+        expect {
+          described_class.parse_spec('2023-366')
+        }.to raise_error(/invalid day-of-year/)
+      end
+
       it "parses week numbers such as 'W23' or '23W' correctly" do
         expect(described_class.parse_spec('W1')).to eq described_class.parse('2012-01-02')
         expect(described_class.parse_spec('W23')).to eq described_class.parse('2012-06-04')
@@ -257,7 +291,19 @@ describe Date do
         }.to raise_error(ArgumentError)
       end
 
-      it 'parse year-week numbers \'YYYY-W23\' correctly' do
+      it "parses week-day numbers such as 'W23-4' or '23W-3' correctly" do
+        expect(described_class.parse_spec('W1-4')).to eq described_class.parse('2012-01-05')
+        expect(described_class.parse_spec('W23-3')).to eq described_class.parse('2012-06-06')
+        expect(described_class.parse_spec('W23-3', :to)).to eq described_class.parse('2012-06-06')
+        expect(described_class.parse_spec('23W-2')).to eq described_class.parse('2012-06-05')
+        expect(described_class.parse_spec('23W-2', :to)).to eq described_class.parse('2012-06-05')
+        expect {
+          described_class.parse_spec('W38-9', :to)
+        }.to raise_error(ArgumentError)
+      end
+
+      it 'parse year-week numbers \'YYYY-Wnn\' correctly' do
+        expect(described_class.parse_spec('2002-W52')).to eq described_class.parse('2002-12-23')
         expect(described_class.parse_spec('2003-W1')).to eq described_class.parse('2002-12-30')
         expect(described_class.parse_spec('2003-W1', :to)).to eq described_class.parse('2003-01-05')
         expect(described_class.parse_spec('2003-W23')).to eq described_class.parse('2003-06-02')
@@ -269,6 +315,27 @@ describe Date do
         }.to raise_error(ArgumentError)
       end
 
+      it 'parse year-week-day numbers \'YYYY-Wnn-d\' correctly' do
+        # Examples from the Wikipedia page on ISO 8601 dates
+        expect(described_class.parse_spec('1976-W53-6')).to eq described_class.parse('1977-01-01')
+        expect(described_class.parse_spec('1977-W52-6')).to eq described_class.parse('1977-12-31')
+        expect(described_class.parse_spec('1977-W52-7')).to eq described_class.parse('1978-01-01')
+        expect(described_class.parse_spec('1978-W01-1')).to eq described_class.parse('1978-01-02')
+        expect(described_class.parse_spec('1978-W52-7')).to eq described_class.parse('1978-12-31')
+        expect(described_class.parse_spec('1979-W01-1')).to eq described_class.parse('1979-01-01')
+        expect(described_class.parse_spec('1979-W52-7')).to eq described_class.parse('1979-12-30')
+        expect(described_class.parse_spec('1980-W01-1')).to eq described_class.parse('1979-12-31')
+        expect(described_class.parse_spec('1980-W52-7')).to eq described_class.parse('1980-12-28')
+        expect(described_class.parse_spec('1981-W01-2')).to eq described_class.parse('1980-12-30')
+        expect(described_class.parse_spec('1981-W01-3')).to eq described_class.parse('1980-12-31')
+        expect(described_class.parse_spec('1981-W01-4')).to eq described_class.parse('1981-01-01')
+        expect(described_class.parse_spec('1981-W53-4')).to eq described_class.parse('1981-12-31')
+        expect(described_class.parse_spec('1981-W53-5')).to eq described_class.parse('1982-01-01')
+        expect {
+          described_class.parse_spec('2003-W83', :to)
+        }.to raise_error(ArgumentError)
+      end
+
       it 'parses year-half specs such as YYYY-NH or YYYY-HN' do
         expect(described_class.parse_spec('2011-2H', :from)).to eq described_class.parse('2011-07-01')
         expect(described_class.parse_spec('2011-2H', :to)).to eq described_class.parse('2011-12-31')
@@ -311,7 +378,8 @@ describe Date do
         expect(described_class.parse_spec('10', :from)).to eq described_class.parse('2012-10-01')
         expect(described_class.parse_spec('10', :to)).to eq described_class.parse('2012-10-31')
         expect { described_class.parse_spec('99') }.to raise_error(ArgumentError)
-        expect { described_class.parse_spec('011') }.to raise_error(ArgumentError)
+        # This is a valid day-of-year spec
+        expect { described_class.parse_spec('011') }.not_to raise_error(ArgumentError)
       end
 
       it 'parses month-day specs such as MM-DD' do
@@ -335,11 +403,102 @@ describe Date do
         expect { described_class.parse_spec('99999') }.to raise_error(ArgumentError)
       end
 
+      it 'parses half-month specs such as YYYY-MM-I and YYYY-MM-II' do
+        expect(described_class.parse_spec('2010-09-I', :from)).to eq described_class.parse('2010-09-01')
+        expect(described_class.parse_spec('2010-09-I', :to)).to eq described_class.parse('2010-09-15')
+        expect(described_class.parse_spec('2010-09-II', :from)).to eq described_class.parse('2010-09-16')
+        expect(described_class.parse_spec('2010-09-II', :to)).to eq described_class.parse('2010-09-30')
+      end
+
+      it 'parses intra-month week specs such as YYYY-MM-i and YYYY-MM-v begin Sunday' do
+        expect(described_class.parse_spec('2010-09-i', :from)).to eq described_class.parse('2010-09-01')
+        expect(described_class.parse_spec('2010-09-ii', :from)).to eq described_class.parse('2010-09-06')
+        expect(described_class.parse_spec('2010-09-iii', :from)).to eq described_class.parse('2010-09-13')
+        expect(described_class.parse_spec('2010-09-iv', :from)).to eq described_class.parse('2010-09-20')
+        expect(described_class.parse_spec('2010-09-v', :from)).to eq described_class.parse('2010-09-27')
+        expect { described_class.parse_spec('2010-09-vi', :from) }.to raise_error(/no week/)
+        expect(described_class.parse_spec('2011-01-vi', :from)).to eq described_class.parse('2011-01-31')
+
+        expect(described_class.parse_spec('2010-09-i', :to)).to eq described_class.parse('2010-09-05')
+        expect(described_class.parse_spec('2010-09-ii', :to)).to eq described_class.parse('2010-09-12')
+        expect(described_class.parse_spec('2010-09-iii', :to)).to eq described_class.parse('2010-09-19')
+        expect(described_class.parse_spec('2010-09-iv', :to)).to eq described_class.parse('2010-09-26')
+        expect(described_class.parse_spec('2010-09-v', :to)).to eq described_class.parse('2010-09-30')
+        expect { described_class.parse_spec('2010-09-vi', :to) }.to raise_error(/no week/)
+        expect(described_class.parse_spec('2011-01-vi', :to)).to eq described_class.parse('2011-01-31')
+      end
+
+      it 'parses intra-month week specs such as YYYY-MM-i and YYYY-MM-v begin Monday' do
+        expect(described_class.parse_spec('2010-09-i', :from)).to eq described_class.parse('2010-09-01')
+        expect(described_class.parse_spec('2010-09-ii', :from)).to eq described_class.parse('2010-09-06')
+        expect(described_class.parse_spec('2010-09-iii', :from)).to eq described_class.parse('2010-09-13')
+        expect(described_class.parse_spec('2010-09-iv', :from)).to eq described_class.parse('2010-09-20')
+        expect(described_class.parse_spec('2010-09-v', :from)).to eq described_class.parse('2010-09-27')
+        expect { described_class.parse_spec('2010-09-vi', :from) }.to raise_error(/no week/)
+        expect { described_class.parse_spec('2010-10-vi', :from) }.to raise_error(/no week/)
+        expect(described_class.parse_spec('2011-01-vi', :to)).to eq described_class.parse('2011-01-31')
+
+        expect(described_class.parse_spec('2010-09-i', :to)).to eq described_class.parse('2010-09-05')
+        expect(described_class.parse_spec('2010-09-ii', :to)).to eq described_class.parse('2010-09-12')
+        expect(described_class.parse_spec('2010-09-iii', :to)).to eq described_class.parse('2010-09-19')
+        expect(described_class.parse_spec('2010-09-iv', :to)).to eq described_class.parse('2010-09-26')
+        expect(described_class.parse_spec('2010-09-v', :to)).to eq described_class.parse('2010-09-30')
+        expect { described_class.parse_spec('2010-09-vi', :to) }.to raise_error(/no week/)
+        expect { described_class.parse_spec('2010-09-vi', :to) }.to raise_error(/no week/)
+        expect(described_class.parse_spec('2011-01-vi', :to)).to eq described_class.parse('2011-01-31')
+
+        travel_to Time.local(2020, 9, 15)
+        expect(described_class.parse_spec('9-i', :from)).to eq described_class.parse('2020-09-01')
+        expect(described_class.parse_spec('09-i', :to)).to eq described_class.parse('2020-09-06')
+        expect(described_class.parse_spec('09-iii', :from)).to eq described_class.parse('2020-09-14')
+        expect(described_class.parse_spec('09-iii', :to)).to eq described_class.parse('2020-09-20')
+        expect(described_class.parse_spec('09-v', :from)).to eq described_class.parse('2020-09-28')
+        expect(described_class.parse_spec('09-v', :to)).to eq described_class.parse('2020-09-30')
+
+        expect(described_class.parse_spec('i', :to)).to eq described_class.parse('2020-09-06')
+        expect(described_class.parse_spec('ii', :to)).to eq described_class.parse('2020-09-13')
+        expect(described_class.parse_spec('iii', :to)).to eq described_class.parse('2020-09-20')
+        expect(described_class.parse_spec('iv', :to)).to eq described_class.parse('2020-09-27')
+        expect(described_class.parse_spec('v', :to)).to eq described_class.parse('2020-09-30')
+        travel_back
+      end
+
+      it 'parses Easter-relative dates' do
+        expect(described_class.parse_spec('2024-E')).to eq described_class.parse('2024-03-31')
+        expect(described_class.parse_spec('2024-E+12')).to eq described_class.parse('2024-04-12')
+        expect(described_class.parse_spec('2024-E-12')).to eq described_class.parse('2024-03-19')
+        travel_to Time.local(2020, 9, 15)
+        expect(described_class.parse_spec('E-12')).to eq described_class.parse('2020-03-31')
+        expect(described_class.parse_spec('E+12')).to eq described_class.parse('2020-04-24')
+        travel_back
+      end
+
+      it 'parses DOW ordinals' do
+        expect(described_class.parse_spec('2024-11-4Th')).to eq described_class.parse('2024-11-28')
+        expect { described_class.parse_spec('2024-11-40Th') }.to raise_error(/invalid ordinal/)
+        expect { described_class.parse_spec('2024-15-4Th') }.to raise_error(/invalid month/)
+        expect { described_class.parse_spec('2024-11-5Th') }.to raise_error(/there is no 5th/i)
+        travel_to Time.local(2020, 9, 15)
+        expect(described_class.parse_spec('11-4Th')).to eq described_class.parse('2020-11-26')
+        expect(described_class.parse_spec('4Th')).to eq described_class.parse('2020-09-24')
+        travel_back
+      end
+
+      it 'parses DOY three-digit specs' do
+        expect(described_class.parse_spec('2024-001')).to eq described_class.parse('2024-01-01')
+        expect(described_class.parse_spec('2024-366')).to eq described_class.parse('2024-12-31')
+        expect { described_class.parse_spec('2024-885') }.to raise_error(/invalid day-of-year/)
+        travel_to Time.local(2020, 9, 15)
+        expect(described_class.parse_spec('150')).to eq described_class.parse('2020-05-29')
+        travel_back
+      end
+
       it 'parses relative day names: today, yesterday' do
         expect(described_class.parse_spec('today')).to eq described_class.current
         expect(described_class.parse_spec('this_day')).to eq described_class.current
         expect(described_class.parse_spec('yesterday')).to eq described_class.current - 1.day
         expect(described_class.parse_spec('last_day')).to eq described_class.current - 1.day
+        expect(described_class.parse_spec('tomorrow')).to eq described_class.current + 1.day
       end
 
       it 'parses relative weeks: this_week, last_week' do
@@ -445,7 +604,7 @@ describe Date do
         expect(described_class.mo_name_to_num("octagon")).to eq 10
         expect(described_class.mo_name_to_num("   novena   this month")).to eq 11
         expect(described_class.mo_name_to_num("decimal")).to eq 12
-        expect(described_class.mo_name_to_num("  dewey decimal")).to be nil
+        expect(described_class.mo_name_to_num("  dewey decimal")).to be_nil
       end
     end
   end
@@ -704,7 +863,6 @@ describe Date do
           .to be false
         expect(described_class.parse('2013-11-04').beginning_of_chunk?(:week))
           .to be true
-        # Sunday is not beginning of commercial week
         expect(described_class.parse('2013-11-03').beginning_of_chunk?(:week))
           .to be false
         expect(described_class.parse('2013-11-01').beginning_of_chunk?(:day))
@@ -758,8 +916,9 @@ describe Date do
           .to be false
         expect(described_class.parse('2013-11-04').end_of_chunk?(:week))
           .to be false
-        # Sunday is not end of commercial week
-        expect(described_class.parse('2013-11-03').end_of_chunk?(:week))
+        expect(described_class.parse('2013-11-09').end_of_chunk?(:week))
+          .to be false
+        expect(described_class.parse('2013-11-10').end_of_chunk?(:week))
           .to be true
         expect(described_class.parse('2013-11-01').end_of_chunk?(:day))
           .to be true

data/spec/lib/enumerable_spec.rb

@@ -4,7 +4,7 @@ require 'fat_core/enumerable'
 describe Enumerable do
   it 'enumerates groups of size k' do
     letters = ('a'..'z').to_a
-    letters.groups_of(3).each do |k, grp|
+    letters.groups_of(3).each do |_k, grp|
       expect(grp.class).to eq Array
       if grp.last == 'z'
         expect(grp.size).to eq(2)
@@ -34,14 +34,17 @@ describe Enumerable do
 
   it 'returns nil enumerating a beginless Range' do
     bless = (..100)
-    result = bless.each_with_flags { |l, first, last| 44 }
-    expect(result).to be nil
+    result = bless.each_with_flags { |_l, _first, _last| 44 }
+    expect(result).to be_nil
   end
 
   it 'enumerates an endless Range' do
     eless = (1..)
     num = 0
-    eless.each_with_flags { |i, first, last| num += i; break if i >= 100 }
+    eless.each_with_flags do |i, _first, _last|
+      num += i
+      break if i >= 100
+    end
     # Look at me, I'm Gauss
     expect(num).to eq(5050)
   end

data/spec/lib/kernel_spec.rb

@@ -3,11 +3,11 @@ require 'fat_core/kernel'
 
 describe Kernel do
   it 'knows how to time a block of code' do
-    $stdout = StringIO.new
-    result = time_it 'do something' do
-      (1..10_000_000).each { |k| k * k }
-      'hello'
-    end
-    expect(result).to eq('hello')
+    expect {
+      time_it 'do something' do
+        (1..10_000_000).each { |k| k * k }
+        'hello'
+      end
+    }.to output(/Ran do something in/i).to_stdout
   end
 end

data/spec/lib/range_spec.rb

@@ -74,8 +74,10 @@ describe Range do
 
     it 'knows the difference with another range' do
       # Other is same as self
+      # rubocop:disable Lint/BinaryOperatorWithIdenticalOperands
       expect(((4..10) - (4..10)).size).to eq(0)
       expect(((4..10) - (4..10))).to be_empty
+      # rubocop:enable Lint/BinaryOperatorWithIdenticalOperands
 
       # Other is proper subset of self
       expect(((4..10) - (6..7)).first).to eq((4..5))
@@ -129,7 +131,7 @@ describe Range do
     end
 
     it 'can determine that overlapping ranges do not span' do
-      expect((0..10)).to_not be_spanned_by([(0..3), (3..6), (7..10)])
+      expect((0..10)).not_to be_spanned_by([(0..3), (3..6), (7..10)])
     end
 
     it 'allows spanning ranges to be any Enumerable' do
@@ -137,7 +139,7 @@ describe Range do
       set = [(0..3), (4..6), (7..10)].to_set
       expect((0..10)).to be_spanned_by(set)
       set = [(0...3), (4..6), (7..10)].to_set
-      expect((0..10)).to_not be_spanned_by(set)
+      expect((0..10)).not_to be_spanned_by(set)
     end
 
     it 'allows the spanning set to be wider than itself' do
@@ -149,20 +151,20 @@ describe Range do
 
   describe 'overlapping a single range' do
     it 'knows if another range overlaps it' do
-      expect((0..10).overlaps?(-3..5)).to be_truthy
-      expect((0..10).overlaps?(3..5)).to be_truthy
-      expect((0..10).overlaps?(8..15)).to be_truthy
-      expect((0..10).overlaps?(0..10)).to be_truthy
-      expect((0..10).overlaps?(11..12)).to be_falsy
-      expect((0..10).overlaps?(-11..-1)).to be_falsy
+      expect((0..10)).to be_overlaps(-3..5)
+      expect((0..10)).to be_overlaps(3..5)
+      expect((0..10)).to be_overlaps(8..15)
+      expect((0..10)).to be_overlaps(0..10)
+      expect((0..10)).not_to be_overlaps(11..12)
+      expect((0..10)).not_to be_overlaps(-11..-1)
 
       # Order of operands should not matter
-      expect((-3..5).overlaps?(0..10)).to be_truthy
-      expect((3..5).overlaps?(0..10)).to be_truthy
-      expect((8..15).overlaps?(0..10)).to be_truthy
-      expect((0..10).overlaps?(0..10)).to be_truthy
-      expect((11..12).overlaps?(0..10)).to be_falsy
-      expect((-11..-1).overlaps?(0..10)).to be_falsy
+      expect((-3..5)).to be_overlaps(0..10)
+      expect((3..5)).to be_overlaps(0..10)
+      expect((8..15)).to be_overlaps(0..10)
+      expect((0..10)).to be_overlaps(0..10)
+      expect((11..12)).not_to be_overlaps(0..10)
+      expect((-11..-1)).not_to be_overlaps(0..10)
     end
 
     it 'can determine whether a set contains covered overlaps' do