fat_core 4.8.0 → 4.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd64293fd2c62f0fc9e089c000b8853e71500fcd14cc3899b45402aa33d237d4
-  data.tar.gz: fa7909a5eeab9e94a54c389e60257b64a626fc9d572029709509dd044ef2a410
+  metadata.gz: c90648dd1bf02d613aa456a276788456ad6db68c388c9d5b77299efcf873d701
+  data.tar.gz: 7e1db9a329844c017bbce95086f18b1417015776aedef20645c1b163f16326a7
 SHA512:
-  metadata.gz: 43a94a1cdfa9595041ec2076981bca528d4da3824baf8a459fef8c41d44c88441003acfc8b804cb52f1b3fb6dcf7e7d9aa03b2f430b8db72af7d029fdbafa558
-  data.tar.gz: d8c430838d4b4cb1610b9a1f7ab7cf679df6e828043b452751c0cf5bee58afab5752f5dd9184c4f04397e7e4335953414d6a7025be16ac7e3e10583992f1d3ca
+  metadata.gz: 189ba88410e8af0b51da95eb3cf543183584fc692194e4d66838e13dacc927ced464093c9b6410b1dc66b0cad816bd357a38066b39b0389a8f7876dfeb75d5e7
+  data.tar.gz: 2cd18de337ca05bb40bfb2e39d1ce86d7ecb6fe476a0d8ce2d8d4a156f877a904afeabe5c57bddcf72eab43b199545289503a8aeeb3fa4e48139020dde832674

data/.gitignore

@@ -20,3 +20,4 @@ tmp
 /GTAGS
 /.rubocop_todo.yml
 /gtags.files
+/.ruby-version

data/.rubocop.yml

@@ -1,3 +1,16 @@
-inherit_from:
-  - '~/.rubocop.yml'
-  - '.rubocop_todo.yml'
+inherit_gem:
+    rubocop-shopify: rubocop.yml
+
+AllCops:
+  TargetRubyVersion: 2.7
+  Exclude:
+    - 'test/tmp/**/*'
+    - 'vendor/bundle/**/*'
+
+Style/MethodCallWithArgsParentheses:
+  Exclude:
+    - '**/Gemfile'
+
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'test/**/*'

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 bundler_args: --without debug
 rvm:
-  - 2.2.2
-  - 2.3
-  - 2.4
-  - ruby-head
+  - 2.5
+  - 2.6
+  - 2.7
+  - 3.0

data/Gemfile

@@ -1,5 +1,8 @@
 source 'https://rubygems.org'
 
+gem 'damerau-levenshtein', git: 'https://github.com/ddoherty03/damerau-levenshtein'
+gem 'rubocop-shopify', require: false
+
 # Specify your gem's dependencies in fat_core.gemspec
 gemspec
 

data/lib/fat_core/all.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fat_core/array'
 require 'fat_core/bigdecimal'
 require 'fat_core/date'

data/lib/fat_core/array.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module FatCore
   module Array
     # Return the index of the last element of this Array.  This is just a
     # convenience for an oft-needed Array attribute.
     def last_i
-      self.size - 1
+      size - 1
     end
 
     # Return a new Array that is the intersection of this Array with +other+,

data/lib/fat_core/bigdecimal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bigdecimal'
 
 module FatCore

data/lib/fat_core/date.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'date'
 require 'active_support/core_ext/date'
 require 'active_support/core_ext/time'
@@ -106,7 +108,7 @@ module FatCore
     # form.
     # @return [String]
     def american
-      strftime '%-m/%-d/%Y'
+      strftime('%-m/%-d/%Y')
     end
 
     # :category: Queries
@@ -117,7 +119,7 @@ module FatCore
     # Self's calendar "half" by analogy to calendar quarters: 1 or 2, depending
     # on whether the date falls in the first or second half of the calendar
     # year.
-    # @return [1, 2]
+    # @return [Integer]
     def half
       case month
       when (1..6)
@@ -131,7 +133,7 @@ module FatCore
 
     # Self's calendar quarter: 1, 2, 3, or 4, depending on which calendar quarter
     # the date falls in.
-    # @return [1, 2, 3, 4]
+    # @return [Integer]
     def quarter
       case month
       when (1..3)
@@ -147,7 +149,7 @@ module FatCore
 
     # Self's calendar bimonth: 1, 2, 3, 4, 5, or 6 depending on which calendar
     # bimonth the date falls in.
-    # @return [1, 2, 3, 4, 5, 6]
+    # @return [Integer]
     def bimonth
       case month
       when (1..2)
@@ -497,12 +499,16 @@ module FatCore
     # :category: Relative ::Dates
 
     # Return the date that is the last day of the commercial biweek in which
-    # self falls. A biweek is a period of two commercial weeks starting with an
-    # odd-numbered week and with each week starting in Monday and ending on
+    # self falls. A biweek is a period of two commercial weeks starting with
+    # an odd-numbered week and with each week starting in Monday and ending on
     # Sunday. So this will always return a Sunday in an even-numbered week.
-    # @return [::Date]
+    # In the last week of the year (if it is not part of next year's first
+    # week) the end of the biweek will not extend beyond self's week, so that
+    # week 1 of the following year will start a new biweek.  @return [::Date]
     def end_of_biweek
-      if cweek.odd?
+      if cweek >= 52 && end_of_week(:monday).year > year
+        end_of_week(:monday)
+      elsif cweek.odd?
         (self + 1.week).end_of_week(:monday)
       else
         end_of_week(:monday)
@@ -853,7 +859,8 @@ module FatCore
         ::Date.parse('2012-12-24'),
         # And Trump
         ::Date.parse('2018-12-24'),
-        ::Date.parse('2019-12-24')
+        ::Date.parse('2019-12-24'),
+        ::Date.parse('2020-12-24'),
       ].freeze
 
     # Presidential funeral since JFK
@@ -873,7 +880,7 @@ module FatCore
       # GTF Funeral
       ::Date.parse('2007-01-02'),
       # GHWBFuneral
-      ::Date.parse('2018-12-05')
+      ::Date.parse('2018-12-05'),
     ].freeze
 
     # Return whether this date is a United States federal holiday.
@@ -1111,7 +1118,7 @@ module FatCore
     def nyse_workday?
       !nyse_holiday?
     end
-    alias trading_day? nyse_workday?
+    alias_method :trading_day?, :nyse_workday?
 
     # Return the date that is n NYSE trading days after or before (if n < 0) this
     # date.
@@ -1130,7 +1137,7 @@ module FatCore
       end
       d
     end
-    alias add_trading_days add_nyse_workdays
+    alias_method :add_trading_days, :add_nyse_workdays
 
     # Return the next NYSE trading day after this date. The date returned is always
     # a date at least one day after this date, never this date.
@@ -1139,7 +1146,7 @@ module FatCore
     def next_nyse_workday
       add_nyse_workdays(1)
     end
-    alias next_trading_day next_nyse_workday
+    alias_method :next_trading_day, :next_nyse_workday
 
     # Return the last NYSE trading day before this date. The date returned is always
     # a date at least one day before this date, never this date.
@@ -1148,7 +1155,7 @@ module FatCore
     def prior_nyse_workday
       add_nyse_workdays(-1)
     end
-    alias prior_trading_day prior_nyse_workday
+    alias_method :prior_trading_day, :prior_nyse_workday
 
     # Return this date if its a trading day, otherwise skip forward to the first
     # later trading day.
@@ -1208,11 +1215,15 @@ module FatCore
         # MLK's Birthday (Third Monday in Jan) since 1998
         year >= 1998 && nth_wday_in_month?(3, 1, 1)
       when 2
-        # Lincoln's birthday until 1953
-        # Washington's Birthday (Third Monday in Feb)
-        (year <= 1953 && month == 2 && day == 12) ||
-          (year <= 1970 ? (month == 2 && day == 22)
-           : nth_wday_in_month?(3, 1, 2))
+        # Washington's Birthday was celebrated on February 22 until 1970. In
+        # 1971 and later, it was moved to the third Monday in February.  Note:
+        # Lincoln's birthday is not an official holiday, but is sometimes
+        # included with Washington's and called "Presidents' Day."
+        if year <= 1970
+          month == 2 && day == 22
+        else
+          nth_wday_in_month?(3, 1, 2)
+        end
       when 3, 4
         # Good Friday
         if !friday?
@@ -1415,7 +1426,7 @@ module FatCore
       #
       # @param spec [String, #to_s] the spec to be interpreted as a calendar period
       #
-      # @param spec_type [:from, :to] return the first (:from) or last (:to)
+      # @param spec_type [Symbol, :from, :to] return the first (:from) or last (:to)
       #   date in the spec's period respectively
       #
       # @return [::Date] date that is the first (:from) or last (:to) in the period
@@ -1428,11 +1439,12 @@ module FatCore
 
         today = ::Date.current
         case spec.clean
-        when %r{\A(\d\d\d\d)[-/](\d\d?)[-/](\d\d?)\z}
+        when %r{\A(?<yr>\d\d\d\d)[-/](?<mo>\d\d?)[-/](?<dy>\d\d?)\z}
           # A specified date
-          ::Date.new($1.to_i, $2.to_i, $3.to_i)
-        when /\AW(\d\d?)\z/, /\A(\d\d?)W\z/
-          week_num = $1.to_i
+          ::Date.new(Regexp.last_match[:yr].to_i, Regexp.last_match[:mo].to_i,
+                     Regexp.last_match[:dy].to_i)
+        when /\AW(?<wk>\d\d?)\z/, /\A(?<wk>\d\d?)W\z/
+          week_num = Regexp.last_match[:wk].to_i
           if week_num < 1 || week_num > 53
             raise ArgumentError, "invalid week number (1-53): '#{spec}'"
           end
@@ -1442,9 +1454,9 @@ module FatCore
           else
             ::Date.commercial(today.year, week_num).end_of_week
           end
-        when %r{\A(\d\d\d\d)[-/]W(\d\d?)\z}, %r{\A(\d\d\d\d)[-/](\d\d?)W\z}
-          year = $1.to_i
-          week_num = $2.to_i
+        when %r{\A(?<yr>\d\d\d\d)[-/]W(?<wk>\d\d?)\z}, %r{\A(?<yr>\d\d\d\d)[-/](?<wk>\d\d?)W\z}
+          year = Regexp.last_match[:yr].to_i
+          week_num = Regexp.last_match[:wk].to_i
           if week_num < 1 || week_num > 53
             raise ArgumentError, "invalid week number (1-53): '#{spec}'"
           end
@@ -1454,10 +1466,10 @@ module FatCore
           else
             ::Date.commercial(year, week_num).end_of_week
           end
-        when %r{^(\d\d\d\d)[-/](\d)[Qq]$}, %r{^(\d\d\d\d)[-/][Qq](\d)$}
+        when %r{^(?<yr>\d\d\d\d)[-/](?<qt>\d)[Qq]$}, %r{^(?<yr>\d\d\d\d)[-/][Qq](?<qt>\d)$}
           # Year-Quarter
-          year = $1.to_i
-          quarter = $2.to_i
+          year = Regexp.last_match[:yr].to_i
+          quarter = Regexp.last_match[:qt].to_i
           unless [1, 2, 3, 4].include?(quarter)
             raise ArgumentError, "invalid quarter number (1-4): '#{spec}'"
           end
@@ -1468,10 +1480,10 @@ module FatCore
           else
             ::Date.new(year, month, 1).end_of_quarter
           end
-        when /^([1234])[qQ]$/, /^[qQ]([1234])$/
+        when /^(?<qt>[1234])[qQ]$/, /^[qQ](?<qt>[1234])$/
           # Quarter only
           this_year = today.year
-          quarter = $1.to_i
+          quarter = Regexp.last_match[:qt].to_i
           unless [1, 2, 3, 4].include?(quarter)
             raise ArgumentError, "invalid quarter number (1-4): '#{spec}'"
           end
@@ -1482,10 +1494,10 @@ module FatCore
           else
             date.end_of_quarter
           end
-        when %r{^(\d\d\d\d)[-/](\d)[Hh]$}, %r{^(\d\d\d\d)[-/][Hh](\d)$}
+        when %r{^(?<yr>\d\d\d\d)[-/](?<hf>\d)[Hh]$}, %r{^(?<yr>\d\d\d\d)[-/][Hh](?<hf>\d)$}
           # Year-Half
-          year = $1.to_i
-          half = $2.to_i
+          year = Regexp.last_match[:yr].to_i
+          half = Regexp.last_match[:hf].to_i
           msg = "invalid half number: '#{spec}'"
           raise ArgumentError,  msg unless [1, 2].include?(half)
 
@@ -1495,10 +1507,10 @@ module FatCore
           else
             ::Date.new(year, month, 1).end_of_half
           end
-        when /^([12])[hH]$/, /^[hH]([12])$/
+        when /^(?<hf>[12])[hH]$/, /^[hH](?<hf>[12])$/
           # Half only
           this_year = today.year
-          half = $1.to_i
+          half = Regexp.last_match[:hf].to_i
           msg = "invalid half number: '#{spec}'"
           raise ArgumentError, msg unless [1, 2].include?(half)
 
@@ -1508,10 +1520,10 @@ module FatCore
           else
             date.end_of_half
           end
-        when %r{^(\d\d\d\d)[-/](\d\d?)*$}
+        when %r{^(?<yr>\d\d\d\d)[-/](?<mo>\d\d?)*$}
           # Year-Month only
-          year = $1.to_i
-          month = $2.to_i
+          year = Regexp.last_match[:yr].to_i
+          month = Regexp.last_match[:mo].to_i
           unless [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12].include?(month)
             raise ArgumentError, "invalid month number (1-12): '#{spec}'"
           end
@@ -1521,10 +1533,10 @@ module FatCore
           else
             ::Date.new(year, month, 1).end_of_month
           end
-        when %r{^(\d\d?)[-/](\d\d?)*$}
+        when %r{^(?<mo>\d\d?)[-/](?<dy>\d\d?)*$}
           # Month-Day only
-          month = $1.to_i
-          day = $2.to_i
+          month = Regexp.last_match[:mo].to_i
+          day = Regexp.last_match[:dy].to_i
           unless [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12].include?(month)
             raise ArgumentError, "invalid month number (1-12): '#{spec}'"
           end
@@ -1534,9 +1546,9 @@ module FatCore
           else
             ::Date.new(today.year, month, day).end_of_month
           end
-        when /\A(\d\d?)\z/
+        when /\A(?<mo>\d\d?)\z/
           # Month only
-          month = $1.to_i
+          month = Regexp.last_match[:mo].to_i
           unless [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12].include?(month)
             raise ArgumentError, "invalid month number (1-12): '#{spec}'"
           end
@@ -1546,12 +1558,13 @@ module FatCore
           else
             ::Date.new(today.year, month, 1).end_of_month
           end
-        when /^(\d\d\d\d)$/
+        when /^(?<yr>\d\d\d\d)$/
           # Year only
+          year = Regexp.last_match[:yr].to_i
           if spec_type == :from
-            ::Date.new($1.to_i, 1, 1)
+            ::Date.new(year, 1, 1)
           else
-            ::Date.new($1.to_i, 12, 31)
+            ::Date.new(year, 12, 31)
           end
         when /^(to|this_?)?day/
           today
@@ -1675,6 +1688,43 @@ module FatCore
         end
       end
 
+      # Return the 1-indexed integer that corresponds to a month name.
+      #
+      # @param name [String] a name of a month
+      #
+      # @return [Integer] the integer integer that corresponds to a month
+      #   name, or nil of no month recognized.
+      def mo_name_to_num(name)
+        case name.clean
+        when /\Ajan/i
+          1
+        when /\Afeb/i
+          2
+        when /\Amar/i
+          3
+        when /\Aapr/i
+          4
+        when /\Amay/i
+          5
+        when /\Ajun/i
+          6
+        when /\Ajul/i
+          7
+        when /\Aaug/i
+          8
+        when /\Asep/i
+          9
+        when /\Aoct/i
+          10
+        when /\Anov/i
+          11
+        when /\Adec/i
+          12
+        else
+          nil
+        end
+      end
+
       # Return the nth weekday in the given month. If n is negative, count from
       # last day of month.
       #
@@ -1740,8 +1790,8 @@ module FatCore
       # Ensure that date is of class Date based either on a string or Date
       # object.
       #
-      # @param dat [String|Date|Time] the object to be converted to Date
-      # @return [Date]
+      # @param dat [String, Date, Time] the object to be converted to Date
+      # @return [Date, DateTime]
       def ensure_date(dat)
         case dat
         when String

data/lib/fat_core/enumerable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Enumerable
   # Yield items in groups of n, for each group yield the group number, starting
   # with zero and an Array of n items, or all remaining items if less than n.
@@ -8,7 +10,10 @@ module Enumerable
   #    end
   def groups_of(num)
     k = -1
-    group_by { k += 1; k.div(num) }
+    group_by do
+      k += 1
+      k.div(num)
+    end
   end
 
   # Yield each item together with two booleans that indicate whether the item is

data/lib/fat_core/hash.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+#
 # The FatCore extensions to Hash provide a handful of generally useful methods
 # on Ruby Hash objects.
 #

data/lib/fat_core/kernel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fat_core/numeric'
 
 module Kernel

data/lib/fat_core/nil.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FatCore
   module NilClass
     # Allow nils to respond to #as_string like String and Symbol
@@ -6,7 +8,7 @@ module FatCore
     def as_string
       ''
     end
-    alias entitle as_string
+    alias_method :entitle, :as_string
 
     # Allow nils to respond to #tex_quote for use in TeX documents
     #

data/lib/fat_core/numeric.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fat_core/patches'
 require 'active_support/core_ext/object/blank'
 
@@ -74,11 +76,11 @@ module FatCore
         end
 
       # Break the number into parts; underscores are possible in all components.
-      str =~ /\A([-+])?([\d_]*)((\.)?([\d_]*))?([eE][+-]?[\d_]+)?\z/
-      sig = $1 || ''
-      whole = $2 ? $2.delete('_') : ''
-      frac = $5 || ''
-      exp = $6 || ''
+      str =~ /\A(?<sg>[-+])?(?<wh>[\d_]*)((\.)?(?<fr>[\d_]*))?(?<ex>x[eE][+-]?[\d_]+)?\z/
+      sig = Regexp.last_match[:sg] || ''
+      whole = Regexp.last_match[:wh] ? Regexp.last_match[:wh].delete('_') : ''
+      frac = Regexp.last_match[:fr] || ''
+      exp = Regexp.last_match[:ex] || ''
 
       # Pad out the fractional part with zeroes to the right
       unless places.nil?
@@ -133,12 +135,13 @@ module FatCore
       mins, secs = divmod(60)
       hrs, mins = mins.divmod(60)
       if frac.round(5) > 0.0
-        '%02<hrs>d:%02<mins>d:%02<secs>d.%<frac>d' % { hrs: hrs,
-                                                       mins: mins, secs: secs,
-                                                       frac: frac.round(5) * 100 }
+        format('%02<hrs>d:%02<mins>d:%02<secs>d.%<frac>d',
+               { hrs: hrs,
+                 mins: mins, secs: secs,
+                 frac: frac.round(5) * 100 })
       else
-        '%02<hrs>d:%02<mins>d:%02<secs>d' % { hrs: hrs, mins: mins,
-                                              secs: secs }
+        format('%02<hrs>d:%02<mins>d:%02<secs>d',
+               { hrs: hrs, mins: mins, secs: secs })
       end
     end
 

data/lib/fat_core/patches.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Provide #positive? and #negative? for older versions of Ruby.
 unless 2.respond_to?(:positive?)
   # Patch Numeric

data/lib/fat_core/range.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # FatCore extends the Range class with methods that
 #
 # 1. provide some set operations operations on Ranges, union, intersection, and
@@ -130,7 +132,7 @@ module FatCore
 
       ([min, other.min].max..[max, other.max].min)
     end
-    alias & intersection
+    alias_method :&, :intersection
 
     # Return a Range that represents the union between this range and the
     # `other` range.  If there is no overlap and self is not contiguous with
@@ -148,36 +150,44 @@ module FatCore
 
       ([min, other.min].min..[max, other.max].max)
     end
-    alias + union
+    alias_method :+, :union
 
     # The difference method, -, removes the overlapping part of the other
     # argument from self.  Because in the case where self is a superset of the
     # other range, this will result in the difference being two non-contiguous
     # ranges, this returns an array of ranges.  If there is no overlap or if
     # self is a subset of the other range, return an array of self
+    #
+    # @param other [Range] the Range whose overlap is removed from self
+    # @return [Array<Range>] the Ranges representing self with other removed
     def difference(other)
       unless max.respond_to?(:succ) && min.respond_to?(:pred) &&
              other.max.respond_to?(:succ) && other.min.respond_to?(:pred)
         raise 'Range difference requires objects have pred and succ methods'
       end
 
-      if subset_of?(other)
-        # (4..7) - (0..10)
-        []
-      elsif proper_superset_of?(other)
-        # (4..7) - (5..5) -> [(4..4), (6..7)]
-        [(min..other.min.pred), (other.max.succ..max)]
-      elsif overlaps?(other) && other.min <= min
-        # (4..7) - (2..5) -> (6..7)
-        [(other.max.succ..max)]
-      elsif overlaps?(other) && other.max >= max
-        # (4..7) - (6..10) -> (4..5)
-        [(min..other.min.pred)]
+      # Remove the intersection of self and other from self.  The intersection
+      # is either (a) empty, so return self, (b) coincides with self, so
+      # return nothing,
+      isec = self & other
+      return [self] if isec.nil?
+      return [] if isec == self
+
+      # (c) touches self on the right, (d) touches self on the left, or (e)
+      # touches on neither the left or right, in which case the difference is
+      # two ranges.
+      if isec.max == max && isec.min > min
+        # Return the part to the left of isec
+        [(min..isec.min.pred)]
+      elsif isec.min == min && isec.max < max
+        # Return the part to the right of isec
+        [(isec.max.succ..max)]
       else
-        [self]
+        # Return the parts to the left and right of isec
+        [(min..isec.min.pred), (isec.max.succ..max)]
       end
     end
-    alias - difference
+    alias_method :-, :difference
 
     # Allow erb or erubis documents to directly interpolate a Range.
     #
@@ -280,13 +290,14 @@ module FatCore
       min >= other.min && max <= other.max
     end
 
-    # Return whether self is contained within `other` range, without their
-    # boundaries touching.
+    # Return whether self is contained within `other` range, with at most one
+    # boundary touching.
     #
     # @param other [Range] the containing range
     # @return [Boolean] is self wholly within other
     def proper_subset_of?(other)
-      min > other.min && max < other.max
+      subset_of?(other) &&
+      (min > other.min || max < other.max)
     end
 
     # Return whether self contains `other` range, even if their
@@ -298,13 +309,14 @@ module FatCore
       min <= other.min && max >= other.max
     end
 
-    # Return whether self contains `other` range, without their
-    # boundaries touching.
+    # Return whether self contains `other` range, with at most one
+    # boundary touching.
     #
     # @param other [Range] the contained range
     # @return [Boolean] does self wholly contain other
     def proper_superset_of?(other)
-      min < other.min && max > other.max
+      superset_of?(other) &&
+        (min < other.min || max > other.max)
     end
 
     # Return whether self overlaps with other Range.
@@ -368,7 +380,7 @@ module FatCore
     #   (4..8) <=> (4..8) #=> 0
     #
     # @param other [Range] range to compare self with
-    # @return [-1, 0, 1] if self is less, equal, or greater than other
+    # @return [Integer, -1, 0, 1] if self is less, equal, or greater than other
     def <=>(other)
       [min, max] <=> other.minmax
     end

data/lib/fat_core/string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bigdecimal'
 require 'fat_core/patches'
 require 'damerau-levenshtein'
@@ -49,14 +51,14 @@ module FatCore
     #
     # @return [String] self wrapped
     def wrap(width = 70, hang = 0)
-      result = ''
+      result = ::String.new
       first_line = true
       first_word_on_line = true
       line_width_so_far = 0
       words = split(' ')
       words.each do |w|
-        w = ' ' * hang + w if !first_line && first_word_on_line
-        w = ' ' + w unless first_word_on_line
+        w = ::String.new(' ') * hang + w if !first_line && first_word_on_line
+        w = ::String.new(' ') + w unless first_word_on_line
         result << w
         first_word_on_line = false
         line_width_so_far += 1 + w.length
@@ -104,8 +106,10 @@ module FatCore
     #
     # @return [Date] the translated Date
     def as_date
-      if self =~ %r{(\d\d\d\d)[-/]?(\d\d?)[-/]?(\d\d?)}
-        ::Date.new($1.to_i, $2.to_i, $3.to_i)
+      if self =~ %r{(?<yr>\d\d\d\d)[-/]?(?<mo>\d\d?)[-/]?(?<dy>\d\d?)}
+        ::Date.new(Regexp.last_match[:yr].to_i,
+                   Regexp.last_match[:mo].to_i,
+                   Regexp.last_match[:dy].to_i)
       end
     end
 

data/lib/fat_core/symbol.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fat_core/string'
 
 module FatCore
@@ -14,7 +16,7 @@ module FatCore
     def as_string
       to_s.tr('_', ' ').split(' ').join(' ').entitle
     end
-    alias entitle as_string
+    alias_method :entitle, :as_string
 
     # Return self. This (together with String#as_sym) allows `#as_sym` to be
     # applied to a string or Symbol and get back a Symbol with out testing for

data/lib/fat_core/version.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module FatCore
   MAJOR = 4
-  MINOR = 8
-  PATCH = 0
+  MINOR = 9
+  PATCH = 2
 
   # FatCore version number
   VERSION = [MAJOR, MINOR, PATCH].compact.join('.')

data/spec/lib/bigdecimal_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 require 'fat_core/bigdecimal'
 
 describe BigDecimal do

data/spec/lib/date_spec.rb

@@ -1,6 +1,6 @@
 # coding: utf-8
-#require 'spec_helper'
 
+require 'spec_helper'
 require 'fat_core/date'
 
 describe Date do
@@ -425,6 +425,22 @@ describe Date do
         expect(Date.parse_spec('forever', :to)).to eq Date::EOT
         expect(Date.parse_spec('never')).to be_nil
       end
+
+      it 'should be able to convert a month name into its sequential number' do
+        expect(Date.mo_name_to_num(' January')).to eq 1
+        expect(Date.mo_name_to_num(' feb  ')).to eq 2
+        expect(Date.mo_name_to_num(' mAr  ')).to eq 3
+        expect(Date.mo_name_to_num(' Aprol  ')).to eq 4
+        expect(Date.mo_name_to_num("\t  \tmaybe")).to eq 5
+        expect(Date.mo_name_to_num("\t  \tjunta\t  \t")).to eq 6
+        expect(Date.mo_name_to_num("\t  \tjulia\t  \t")).to eq 7
+        expect(Date.mo_name_to_num("\t  \tAugustus\t  \t")).to eq 8
+        expect(Date.mo_name_to_num("September")).to eq 9
+        expect(Date.mo_name_to_num("octagon")).to eq 10
+        expect(Date.mo_name_to_num("   novena   this month")).to eq 11
+        expect(Date.mo_name_to_num("decimal")).to eq 12
+        expect(Date.mo_name_to_num("  dewey decimal")).to be nil
+      end
     end
   end
 
@@ -577,6 +593,10 @@ describe Date do
           .to eq Date.parse('2013-11-17')
         expect(Date.parse('2013-03-11')).to be_beginning_of_biweek
         expect(Date.parse('2013-03-24')).to be_end_of_biweek
+        expect(Date.parse('2013-12-30').end_of_biweek)
+          .to eq Date.parse('2014-01-12')
+        expect(Date.parse('2009-12-30').end_of_biweek)
+          .to eq Date.parse('2010-01-03')
       end
 
       it 'should know about weeks' do

data/spec/lib/enumerable_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-
 require 'fat_core/enumerable'
 
 describe Enumerable do

data/spec/lib/hash_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-
 require 'fat_core/hash'
 
 describe Hash do

data/spec/lib/kernel_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-
 require 'fat_core/kernel'
 
 describe Kernel do

data/spec/lib/nil_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-
 require 'fat_core/nil'
 
 describe NilClass do

data/spec/lib/numeric_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 require 'fat_core/numeric'
 
 describe Numeric do

data/spec/lib/range_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 require 'fat_core/range'
 
 describe Range do
@@ -12,6 +13,7 @@ describe Range do
 
     it 'should know if it is a proper subset of another range' do
       expect((4..8)).to be_proper_subset_of((2..9))
+      expect((4..8)).to be_proper_subset_of((4..9))
       expect((4..8)).not_to be_proper_subset_of((4..8))
       expect((4..8)).not_to be_proper_subset_of((2..7))
       expect((4..8)).not_to be_proper_subset_of((5..8))
@@ -34,8 +36,8 @@ describe Range do
 
     it 'should know if it is a proper superset of another range' do
       expect((4..8)).to be_proper_superset_of((5..7))
-      expect((4..8)).not_to be_proper_superset_of((6..8))
-      expect((4..8)).not_to be_proper_superset_of((4..7))
+      expect((4..8)).to be_proper_superset_of((6..8))
+      expect((4..8)).to be_proper_superset_of((4..7))
       expect((4..8)).not_to be_proper_superset_of((4..8))
       expect((4..8)).not_to be_proper_superset_of((2..9))
       expect((4..8)).not_to be_proper_superset_of((2..8))

data/spec/lib/symbol_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 require 'fat_core/symbol'
 
 describe Symbol do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fat_core
 version: !ruby/object:Gem::Version
-  version: 4.8.0
+  version: 4.9.2
 platform: ruby
 authors:
 - Daniel E. Doherty
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-08 00:00:00.000000000 Z
+date: 2021-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov
@@ -218,7 +218,7 @@ licenses:
 - MIT
 metadata:
   yard.run: yri
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -233,8 +233,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: fat_core provides some useful core extensions
 test_files: