fat_core 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49d7213a1c1d8f0372f9a5f0e057dec4a194e541
-  data.tar.gz: 6f8ee1ddc0bfb0e8b66247453e2f4c11fc51d0d1
+  metadata.gz: c3022e21efd8b8e152772e4e7c02ef38561f2fdb
+  data.tar.gz: f79d325c96f94aa4d961f2315dcc6901533c6b46
 SHA512:
-  metadata.gz: 074407a3a3e4b7885d841b8fe351c18fd03d001620058e9364129fe82f995d3e25554c4b3c2bb364851e006faa95778929bc7342d7799ed8d8c10956421fb64f
-  data.tar.gz: 4d0d70cfc49d8f1152db707a8eb43672d5fcf1586f088e41646a3f33f2d49c2634c15d5944246624a80bc325e277559a960e5e9840077804d4296f2ba1b00d61
+  metadata.gz: 431ecd4c693f038bdf70b026a5f9445e45b497f36658180d6f7db12a653a85e7ce55770b7245e3ed5cec064ca185d8318423bc5ce835650cc6d0be2e5dacef4e
+  data.tar.gz: a2de458910bda7ffe1841684ffe128cd012455280dc7efcc21c0b3f8c48d9f847b458a68542c1ba5fec7ee3af8f54cdc1038d9496ce3dfa0b1da59f3949e7eef

data/lib/fat_core/period.rb

@@ -216,6 +216,28 @@ class Period
     end
   end
 
+  # The smallest number of days possible in each chunk
+  def self.chunk_sym_to_min_days(sym)
+    case sym
+    when :semimonth
+      15
+    when :month
+      28
+    when :bimonth
+      59
+    when :quarter
+      86
+    when :half
+      180
+    when :year
+      365
+    when :irregular
+      raise ArgumentError, 'no minimum period for :irregular chunk'
+    else
+      chunk_sym_to_days(sym)
+    end
+  end
+
   # The largest number of days possible in each chunk
   def self.chunk_sym_to_max_days(sym)
     case sym
@@ -430,15 +452,18 @@ class Period
       .map { |r| Period.new(r.first, r.last) }
   end
 
-  # Return an array of Periods wholly-contained within self in chunks of
-  # size, defaulting to monthly chunks.  Partial chunks at the beginning and
-  # end of self are not included unless partial_first or partial_last,
-  # respectively, are set true.  The last chunk can be made to extend beyond
-  # the end of self to make it a whole chunk if round_up_last is set true,
-  # in which case, partial_last is ignored.
+  # Return an array of Periods wholly-contained within self in chunks of size,
+  # defaulting to monthly chunks. Partial chunks at the beginning and end of
+  # self are not included unless partial_first or partial_last, respectively,
+  # are set true. The last chunk can be made to extend beyond the end of self to
+  # make it a whole chunk if round_up_last is set true, in which case,
+  # partial_last is ignored.
   def chunks(size: :month, partial_first: false, partial_last: false,
              round_up_last: false)
     size = size.to_sym
+    if Period.chunk_sym_to_min_days(size) > length
+      raise ArgumentError, "any #{size} is longer than this period's #{length} days"
+    end
     result = []
     chunk_start = first.dup
     while chunk_start <= last

data/lib/fat_core/version.rb

@@ -1,7 +1,7 @@
 module FatCore
   MAJOR = 1
   MINOR = 3
-  PATCH = 0
+  PATCH = 1
 
   VERSION = [MAJOR, MINOR, PATCH].compact.join('.')
 end

data/spec/lib/period_spec.rb

@@ -455,7 +455,13 @@ describe Period do
     it 'should raise error for invalid chunk name' do
       expect {
         Period.new('2012-12-28', '2012-12-31').chunks(size: :wally)
-      }.to raise_error(ArgumentError)
+      }.to raise_error /unknown chunk sym/
+    end
+
+    it 'should raise error for too large a chunk' do
+      expect {
+        Period.new('2012-12-01', '2012-12-31').chunks(size: :bimonth)
+      }.to raise_error /longer than/
     end
 
     it 'should not include a partial final chunk by default' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fat_core
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Daniel E. Doherty