fat_core 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db29f2ee46cdaa3602d37b2a1f9af253f07e651e
-  data.tar.gz: 85dddc16c5d33ca582b081a138de6a3fb617522d
+  metadata.gz: b32e345632ac5b6bccac049d806eed45e6a2074b
+  data.tar.gz: e585990b0c1b6102e0d96f010107a5ec79b093a0
 SHA512:
-  metadata.gz: 6badb8b5fc9cb201aa41a8244f8b53b95f180ce683d22b8b1e1be6fc352b0783b50f6149b402b54b354aa207079b33f31bb1b38a827c726aa10d2fc09501a320
-  data.tar.gz: 5fc8edbd029a4de5f7922c2ca3e7f4cb06f1bb125dd3a366aab98f4c85ec877beef09f557bfc069b098ffb047f6b388f54bfcaafcaa6d71aeb34e8ed94c7052e
+  metadata.gz: d57d6d4df7e207a6aec6801ce6af4dff27b696a9e1fa76d301b1d550c7904fa95bc6cd5e275f39ff9e9455d242c965bd6bbf5d04d31414a9f2f67ae4eb9fca9a
+  data.tar.gz: 804231e68d96590a6a898eb0de9e1fd206f1f8e1fbdaa95b59904f25702e971e8db6ba510f02fad2a4116e8e1cac94171dcd0f3f970077cdc4c222daca8a20e0

data/lib/fat_core/period.rb

@@ -186,7 +186,7 @@ class Period
 
   def self.chunk_syms
     [:day, :week, :biweek, :semimonth, :month, :bimonth,
-     :quarter, :year, :irregular]
+     :quarter, :half, :year, :irregular]
   end
 
   def self.chunk_sym_to_days(sym)
@@ -238,10 +238,7 @@ class Period
     end
   end
 
-  # This is only used for inferring statement frequency based on the
-  # number of days between statements, so it will not consider all
-  # possible chunks, only :year, :quarter, :month, and :week.  And
-  # distinguishing between :semimonth and :biweek is impossible in
+  # Distinguishing between :semimonth and :biweek is impossible in
   # some cases since a :semimonth can be 14 days just like a :biweek.
   # This ignores that possiblity and requires a :semimonth to be at
   # least 15 days.
@@ -354,6 +351,9 @@ class Period
     if first.beginning_of_year? && last.end_of_year? &&
         (365..366) === last - first + 1
       :year
+    elsif first.beginning_of_half? && last.end_of_half? &&
+        (180..183) === last - first + 1
+      :half
     elsif first.beginning_of_quarter? && last.end_of_quarter? &&
         (90..92) === last - first + 1
       :quarter
@@ -388,6 +388,8 @@ class Period
     case Period.days_to_chunk_sym(length)
     when :year
       'Year'
+    when :half
+      'Half'
     when :quarter
       'Quarter'
     when :bimonth
@@ -491,7 +493,7 @@ class Period
       when :day
         chunk_end = chunk_start
       else
-        chunk_end = last
+        raise ArgumentError, "invalid chunk size '#{size}'"
       end
       if chunk_end <= last
         result << Period.new(chunk_start, chunk_end)

data/lib/fat_core/version.rb

@@ -1,7 +1,7 @@
 module FatCore
   MAJOR = 1
   MINOR = 0
-  PATCH = 2
+  PATCH = 3
 
   VERSION = [MAJOR, MINOR, PATCH].compact.join('.')
 end

data/spec/lib/period_spec.rb

@@ -50,6 +50,14 @@ describe Period do
       expect(pd.first).to eq(Date.parse('2012-07-01'))
       expect(pd.last).to eq(Date.parse('2012-12-31'))
 
+      pd = Period.parse_phrase('from 1H')
+      expect(pd.first).to eq(Date.parse('2012-01-01'))
+      expect(pd.last).to eq(Date.parse('2012-06-30'))
+
+      pd = Period.parse_phrase('to 2H')
+      expect(pd.first).to eq(Date.parse('2012-07-01'))
+      expect(pd.last).to eq(Date.parse('2012-12-31'))
+
       pd = Period.parse_phrase('from 2Q')
       expect(pd.first).to eq(Date.parse('2012-04-01'))
       expect(pd.last).to eq(Date.parse('2012-06-30'))
@@ -118,7 +126,7 @@ describe Period do
     end
 
     it 'should know what the valid chunk syms are' do
-      expect(Period.chunk_syms.size).to eq 9
+      expect(Period.chunk_syms.size).to eq(10)
     end
 
     it 'should know the days in a chunk sym' do
@@ -154,6 +162,7 @@ describe Period do
 
     it 'should know the chunk sym for given days but only :year, :quarter, :month' do
       (356..376).each { |d| expect(Period.days_to_chunk_sym(d)).to eq(:year) }
+      (180..183).each { |d| expect(Period.days_to_chunk_sym(d)).to eq(:half) }
       (86..96).each { |d| expect(Period.days_to_chunk_sym(d)).to eq(:quarter) }
       (28..31).each { |d| expect(Period.days_to_chunk_sym(d)).to eq(:month) }
       expect(Period.days_to_chunk_sym(7)).to eq(:week)
@@ -162,6 +171,7 @@ describe Period do
 
     it 'should know what to call a chunk based on its size' do
       expect(Period.new('2011-01-01', '2011-12-31').chunk_name).to eq('Year')
+      expect(Period.new('2011-01-01', '2011-06-30').chunk_name).to eq('Half')
       expect(Period.new('2011-01-01', '2011-03-31').chunk_name).to eq('Quarter')
       expect(Period.new('2011-01-01', '2011-02-28').chunk_name)
         .to eq('Bi-month')
@@ -443,6 +453,12 @@ describe Period do
       expect(chunks.last.last.iso).to eq('2012-12-31')
     end
 
+    it 'should raise error for invalid chunk name' do
+      expect do
+        Period.new('2012-12-28', '2012-12-31').chunks(size: :wally)
+      end.to raise_error(ArgumentError)
+    end
+
     it 'should not include a partial final chunk by default' do
       chunks = Period.new('2012-01-01', '2012-03-30').chunks(size: :month)
       expect(chunks.size).to eq(2)
@@ -487,10 +503,13 @@ describe Period do
       expect(chunks.last.last).to eq(Date.parse('2012-03-31'))
     end
 
-    it 'should be able to its chunk_sym' do
+    it 'should be able to determine its chunk_sym' do
       expect(Period.new('2013-01-01', '2013-12-31').chunk_sym).to eq(:year)
       expect(Period.new('2012-01-01', '2013-12-31').chunk_sym).to_not eq(:year)
 
+      expect(Period.new('2013-01-01', '2013-06-30').chunk_sym).to eq(:half)
+      expect(Period.new('2012-01-01', '2013-05-31').chunk_sym).to_not eq(:half)
+
       expect(Period.new('2013-04-01', '2013-06-30').chunk_sym).to eq(:quarter)
       expect(Period.new('2013-04-01', '2013-09-30').chunk_sym)
         .to_not eq(:quarter)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fat_core
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Daniel E. Doherty