fasttrack 0.1 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dc5f004ecff917644512a6ed9c218ab813f301c
-  data.tar.gz: 20705b32a6e116f5582f18f03c5f8335c2939b16
+  metadata.gz: 92afd46fce7b9bfab35852ec7f2913ce2ae49b9f
+  data.tar.gz: 6db8750a2a8512f6f9de77cfb9b23dd34fa644f1
 SHA512:
-  metadata.gz: 948a92e633033f52356023a57b7c711e7a29d1bc466197265624be23ba51448ebf1474eca92a6711ac5b9505efbce22a1b6f6014189943d8a57864ed4f3e2aad
-  data.tar.gz: 64f802661ea14141431cad5a4020111f8f888336cd0c86547a7f6e7707e84608dd0543375ee39ab327d6024f0d1235bdae963dc7bc3b6021565b770b725b0d1d
+  metadata.gz: cc315ff8e11ac8f1910f9647c5cfc3bc8583127ff0c4b70fd2fa1367ce52c3d0a07ebab6335943b791b60adf88616f0ed776e38992c0213f5b64c7ec450168e0
+  data.tar.gz: f3fd4f57a8cbb969d10b47959e234665c70c643de2674af3e4c8971a3464959168844f31cf710bc26cb480006b0229c99b547f61668bcb32699e6d5b9c82350d

data/fasttrack.gemspec

@@ -20,9 +20,10 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = Fasttrack::VERSION
 
-  gem.add_dependency 'exempi', '>= 0.1'
+  gem.add_dependency 'exempi', '>= 0.2'
 
   gem.add_development_dependency 'rake', '>= 0.9.2.2'
   gem.add_development_dependency 'mocha', '>= 0.13.0'
+  gem.add_development_dependency 'minitest'
   gem.add_development_dependency 'nokogiri', '>= 1.5.5'
 end

data/lib/fasttrack/file.rb

@@ -49,6 +49,7 @@ module Fasttrack
     # @raise [Fasttrack::FileFormatError] if the file can't have XMP
     #   metadata
     def initialize path, mode="r"
+      @open = false
       @path = Pathname.new(path).expand_path
       if not @path.exist?
         raise Errno::ENOENT, "#{@path} does not exist"
@@ -155,6 +156,7 @@ module Fasttrack
       @open = Exempi.xmp_files_open @file_ptr, @path.to_s, open_option
 
       if not @open
+        Exempi.xmp_files_free(@file_ptr)
         Fasttrack.handle_exempi_failure
       else
         @xmp = Fasttrack::XMP.from_file_pointer @file_ptr
@@ -162,6 +164,5 @@ module Fasttrack
 
       @open
     end
-
   end
-end
+end

data/lib/fasttrack/version.rb

@@ -1,3 +1,3 @@
 module Fasttrack
-  VERSION = "0.1"
+  VERSION = "0.2"
 end

data/test/filehandle_leak_test.rb

@@ -0,0 +1,21 @@
+require 'fasttrack'
+require 'open3'
+
+describe Fasttrack::File do
+  before do
+    @test_file = File.join(__FILE__,'..','data','test.rtf')
+  end
+
+  it 'should not leak filehandles' do
+    exempi_mock = MiniTest::Mock.new
+    exempi_mock.expect(:xmp_files_open, false, [])
+    exempi_mock.expect(:xmp_files_free, true, [])
+    Exempi.stub(:xmp_files_open, false) { exempi_mock.xmp_files_open }
+    Exempi.stub(:xmp_files_free, true) { exempi_mock.xmp_files_free }
+
+    assert_raises Exempi::ExempiError do
+      Fasttrack::File.new(@test_file)
+    end
+    exempi_mock.verify
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fasttrack
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: '0.2'
 platform: ruby
 authors:
 - Misty De Meo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-03 00:00:00.000000000 Z
+date: 2016-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: exempi
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.13.0
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -91,8 +105,10 @@ files:
 - lib/fasttrack/xmp.rb
 - test/data/avchd.xmp
 - test/data/image.jpg
+- test/data/test.rtf
 - test/fasttrack_test.rb
 - test/file_test.rb
+- test/filehandle_leak_test.rb
 - test/xmp_test.rb
 homepage: https://github.com/mistydemeo/fasttrack
 licenses: []
@@ -113,14 +129,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Ruby sugar for Exempi
 test_files:
 - test/data/avchd.xmp
 - test/data/image.jpg
+- test/data/test.rtf
 - test/fasttrack_test.rb
 - test/file_test.rb
+- test/filehandle_leak_test.rb
 - test/xmp_test.rb
-has_rdoc: