fastly_nsq 1.16.0 → 1.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7ddfaca7ffa4121e56b173447b114ccd61ea104bc3804f2833920438492f4da
-  data.tar.gz: 570739450b84d445d190cb29b6d2ce7f22287bb4bde73f2af75e533eb00b2fc3
+  metadata.gz: 7c499298a1a690208afc03693e6bdae6730408f7e61544033f5b6fdbab778364
+  data.tar.gz: 3c346c1bcb3a7d44508144beb14b91edad7f8bcb2cb07e35cd8a301a67069e57
 SHA512:
-  metadata.gz: 9b9b61eb6bfb2cc6453f259887e4b045368fc87ab4d88f05ef1591c83c1a488d36bf555034990495221a92ef697933a9ed0d007f650f0f11ee8bf4357f0b826d
-  data.tar.gz: 9e0202b599608733735097989d7f853b0e98def7299f366321509550ce9ea850ac23d757f81505bc2c7df1a73d3f742200b078733a9ba8036f6e96b175d7a4a5
+  metadata.gz: b350e9fd2f0d2c993aa3d3a84b24935137faa7cbf65967f0342434c108e7b13213b3dd45b753c2e73de3e487729f2038a8a07045ef1987c1d3e5d55d78797ee3
+  data.tar.gz: a2f4494d86c8d5d37db0ed59e149edebfecee56888971cc2e1cfecff5d88fbcbd05e65a72cfe5d1d1e6d8758f88296a20b877d43a8ebed06d663519070e6f7fd

data/.env

@@ -1,4 +1,4 @@
-NSQD_TCP_ADDRESS=127.0.0.1:4150
 NSQD_HTTP_ADDRESS=127.0.0.1:4151
-NSQLOOKUPD_TCP_ADDRESS=127.0.0.1:4160
 NSQLOOKUPD_HTTP_ADDRESS=127.0.0.1:4161
+NSQD_CONSUMERS=127.0.0.1:4150
+NSQD_PRODUCERS=127.0.0.1:4150

data/.git-blame-ignore-revs

@@ -0,0 +1,6 @@
+25bc1d8cd908a86e8f7536192541a0d3b66f07db
+7c4cf244c4586d3bd280fee7909b6bcabda34998
+2e09ec7d8205b3ed3c2093777ae5382723919787
+5381db0ed1493235a7095a51cdbd67b88caa47d2
+d77aee840f7affb6ccdeb3748e0c50ccea96f7ef
+ca9a1aa122ead418879ecb6a104fb61054fe675e

data/.ruby-version

@@ -1 +1 @@
-2.5.1
+3.0.3

data/.travis.yml

@@ -2,14 +2,15 @@ language: ruby
 cache: bundler
 sudo: false
 rvm:
-  - 2.3.5
-  - 2.4.2
-  - 2.5.1
+  - 2.6.9
+  - 2.7.5
+  - 3.0.3
 script:
   - bundle exec rake
 services:
   - docker
 before_install:
+  - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
   - docker-compose up -d
 before_script:
   - gem update --system

data/ChangeLog.md

@@ -1,7 +1,37 @@
 # Change Log
 
-## [v1.15.0](https://github.com/fastly/fastly_nsq/tree/v1.15.0)
+## [v1.18.0](https://github.com/fastly/fastly_nsq/tree/v1.18.0) (2022-03-04)
+[Full Changelog](https://github.com/fastly/fastly_nsq/compare/v1.17.1...v1.18.0)
 
+**Merged pull requests:**
+
+- Configurable NSQDs for Consumers and Producers [\#105](https://github.com/fastly/fastly_nsq/pull/105)
+
+## [v1.17.1](https://github.com/fastly/fastly_nsq/tree/v1.17.1) (2022-02-23)
+[Full Changelog](https://github.com/fastly/fastly_nsq/compare/v1.17.0...v1.17.1)
+
+**Merged pull requests:**
+
+- Use standardrb for style and formatting [\#104](https://github.com/fastly/fastly_nsq/pull/104)
+
+## [v1.17.0](https://github.com/fastly/fastly_nsq/tree/v1.17.0) (2021-02-11)
+[Full Changelog](https://github.com/fastly/fastly_nsq/compare/v1.16.0...v1.17.0)
+
+**Merged pull requests:**
+
+- Support for arbitary sent\_at Time [\#99](https://github.com/fastly/fastly_nsq/pull/99) ([leklund](https://github.com/leklund))
+- remove version pin on rake for development [\#97](https://github.com/fastly/fastly_nsq/pull/97) ([leklund](https://github.com/leklund))
+- Ignore from Humane Registry [\#96](https://github.com/fastly/fastly_nsq/pull/96) ([leklund](https://github.com/leklund))
+
+## [v1.16.0](https://github.com/fastly/fastly_nsq/tree/v1.16.0) (2019-08-16)
+[Full Changelog](https://github.com/fastly/fastly_nsq/compare/v1.15.0...v1.16.0)
+
+**Merged pull requests:**
+
+- Log the internal NSQ id [\#95](https://github.com/fastly/fastly_nsq/pull/95) ([leklund](https://github.com/leklund))
+- Consumer still attempts connections in Test mode [\#93](https://github.com/fastly/fastly_nsq/pull/93) ([alieander](https://github.com/alieander))
+
+## [v1.15.0](https://github.com/fastly/fastly_nsq/tree/v1.15.0) (2018-10-05)
 [Full Changelog](https://github.com/fastly/fastly_nsq/compare/v1.14.0...v1.15.0)
 
 **Merged pull requests:**

data/Gemfile

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
-gem 'bundler-audit'
-gem 'newrelic_rpm', require: false
-gem 'overcommit', '~> 0.32.0'
-gem 'rake', '~> 11.1.2'
-gem 'rdoc', '~> 4.2.2'
-gem 'rubocop', '~> 0.51.0'
-gem 'rubygems-tasks', '~> 0.2'
+gem "bundler-audit"
+gem "newrelic_rpm", require: false
+gem "overcommit", "~> 0.32.0"
+gem "rake"
+gem "rdoc"
+gem "standard"
+gem "rubygems-tasks", "~> 0.2"

data/README.md

@@ -1,4 +1,4 @@
-# fastly_nsq [![Build Status](https://travis-ci.org/fastly/fastly_nsq.svg?branch=master)](https://travis-ci.org/fastly/fastly_nsq)
+# fastly_nsq [![Build Status](https://travis-ci.com/fastly/fastly_nsq.svg?branch=main)](https://travis-ci.com/fastly/fastly_nsq)
 
 NSQ adapter and testing objects
 for using the NSQ messaging system
@@ -12,9 +12,9 @@ We also include fakes
 to make testing easier.
 
 This library is dependent
-on the [`nsq-ruby`] gem.
+on the [`nsq-ruby-fastly`] gem.
 
-[`nsq-ruby`]: https://github.com/wistia/nsq-ruby
+[`nsq-ruby-fastly`]: https://github.com/fastly/nsq-ruby
 
 Please use [GitHub Issues] to report bugs.
 
@@ -34,6 +34,65 @@ and `bundle install`.
 
 ## Usage
 
+### Connections
+
+NSQD cconnections can be discovered via nsqlookupd's or
+specified explicity for consumers and producers.
+
+#### Using nsqlookup:
+
+Set the ENV variable to a comma sepearated string of lookups:
+
+```
+ENV['NSQLOOKUPD_HTTP_ADDRESS'] = "lookup01:1234,lookup01:1234"
+```
+
+Or configure them directly:
+
+```
+FastlyNsq.configure do |config|
+  config.lookupd_http_addresses = ["lookup01:1234", "lookup02:1234"]
+end
+```
+
+#### Using nsqd directly:
+
+NSQD connections can be specified for consumers and producers. Being able to set
+different sets for consumers and producers facilitates removing and adding new instances
+without downtime.
+
+Set the following ENV variables to a comma sepearted string of nsqds:
+
+```
+ENV['NSQD_CONSUMERS']="nsqd01:4150,nsd02:4150"
+ENV['NSQD_PRODUCERS']="nsqd01:4150,nsd02:4150"
+```
+
+Or configure them directly:
+
+```
+FastlyNsq.configure do |config|
+  config.consumer_nsqds = ["nsqd01:4150", "nsqd02:4150"]
+  config.producer_nsqds = ["nsqd01:4150", "nsqd02:4150"]
+end
+```
+
+### Connection Priority
+
+When `FastlyNsq.consumer_nsqds` or `FastlyNsq.producer_nsqds` are set they
+will be used instead of `FastlyNsq.lookupd_http_addresses`.
+
+### TLS
+
+Set the following ENV variables to enable TLS support:
+
+```
+NSQ_SSL_KEY
+NSQ_SSL_CERTIFICATE
+NSQ_SSL_CA_CERTIFICATE
+NSQ_SSL_VERIFY_MODE (optional)
+```
+
 ### `FastlyNsq::Producer`
 
 This is a class
@@ -50,7 +109,6 @@ message_data = {
 }
 
 producer = FastlyNsq::Producer.new(
-  nsqd: ENV.fetch('NSQD_TCP_ADDRESS'),
   topic: topic,
 )
 
@@ -281,6 +339,22 @@ expect(some_result)
 
 ## Configuration
 
+See the [documentation](https://www.rubydoc.info/gems/fastly_nsq/FastlyNsq) for additional settings
+
+Example:
+
+```
+FastlyNsq.configure do |config|
+ config.channel = "z"
+ config.producer_nsqds = ["nsqd01:4150", "nsqd02:4150"]
+ config.lookupd_http_addresses = ["lookupd01:4161", "lookupd02:4161"]
+ config.logger = Logger.new(STDOUT)
+ config.max_attempts = 10
+ config.max_req_timeout = 10_000
+ config.max_processing_pool_threads = 42
+end
+```
+
 ### Environment Variables
 
 The URLs for the various
@@ -293,10 +367,10 @@ stock NSQ on OS X,
 installed via Homebrew:
 
 ```shell
-NSQD_TCP_ADDRESS='127.0.0.1:4150'
 NSQD_HTTP_ADDRESS='127.0.0.1:4151'
-NSQLOOKUPD_TCP_ADDRESS='127.0.0.1:4160'
 NSQLOOKUPD_HTTP_ADDRESS='127.0.0.1:4161, 10.1.1.101:4161'
+NSQD_CONSUMERS='127.0.0.1:4150'
+NSQD_PRODUCERS='127.0.0.1:4150'
 ```
 
 See the [`.sample.env`](examples/.sample.env) file
@@ -334,3 +408,7 @@ You will still need the `ENV` variables as defined above.
 Copyright (c) 2016 [Fastly, Inc](https://fastly.com) under an MIT license.
 
 See [LICENSE.txt](LICENSE.txt) for details.
+
+# Metadata
+
+- Ignore

data/Rakefile

@@ -1,28 +1,28 @@
 # frozen_string_literal: true
 
-require 'rubygems'
+require "rubygems"
 
 begin
-  require 'bundler/setup'
+  require "bundler/setup"
 rescue LoadError => e
   abort e.message
 end
 
-require 'rake'
+require "rake"
 
-require 'rubygems/tasks'
+require "rubygems/tasks"
 Gem::Tasks.new
 
-require 'rdoc/task'
+require "rdoc/task"
 RDoc::Task.new
 task doc: :rdoc
 
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
-require 'bundler/audit/cli'
+require "bundler/audit/cli"
 namespace :bundler do
-  desc 'Updates the ruby-advisory-db and runs audit'
+  desc "Updates the ruby-advisory-db and runs audit"
   task :audit do
     %w[update check].each do |command|
       Bundler::Audit::CLI.start [command]
@@ -30,8 +30,7 @@ namespace :bundler do
   end
 end
 
-require 'rubocop/rake_task'
-RuboCop::RakeTask.new
+require "standard/rake"
 
 task(:default).clear
-task default: ['spec', 'rubocop', 'bundler:audit']
+task default: ["spec", "standard", "bundler:audit"]

data/fastly_nsq.gemspec

@@ -1,36 +1,36 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'fastly_nsq/version'
+require "fastly_nsq/version"
 
 Gem::Specification.new do |gem|
-  gem.name          = 'fastly_nsq'
-  gem.version       = FastlyNsq::VERSION
-  gem.summary       = 'Fastly NSQ Adapter'
-  gem.description   = "Helper classes for Fastly's NSQ Services"
-  gem.license       = 'MIT'
-  gem.authors       = ["Tommy O'Neil", 'Adarsh Pandit', 'Joshua Wehner', 'Lukas Eklund', 'Josh Lane', 'Hassan Shahid']
-  gem.email         = 'tommy@fastly.com'
-  gem.homepage      = 'https://github.com/fastly/fastly_nsq'
+  gem.name = "fastly_nsq"
+  gem.version = FastlyNsq::VERSION
+  gem.summary = "Fastly NSQ Adapter"
+  gem.description = "Helper classes for Fastly's NSQ Services"
+  gem.license = "MIT"
+  gem.authors = ["Tommy O'Neil", "Adarsh Pandit", "Joshua Wehner", "Lukas Eklund", "Josh Lane", "Hassan Shahid"]
+  gem.email = "tommy@fastly.com"
+  gem.homepage = "https://github.com/fastly/fastly_nsq"
 
-  gem.files         = `git ls-files`.split("\n")
+  gem.files = `git ls-files`.split("\n")
 
-  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|features)/})
-  gem.require_paths = ['lib']
+  gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
+  gem.test_files = gem.files.grep(%r{^(test|features)/})
+  gem.require_paths = ["lib"]
 
-  gem.add_development_dependency 'awesome_print', '~> 1.6'
-  gem.add_development_dependency 'bundler'
-  gem.add_development_dependency 'dotenv'
-  gem.add_development_dependency 'pry-byebug', '~> 3.3'
-  gem.add_development_dependency 'rspec', '~> 3.4'
-  gem.add_development_dependency 'rspec-eventually', '0.2'
-  gem.add_development_dependency 'timecop'
-  gem.add_development_dependency 'webmock', '~> 3.0'
-  gem.add_development_dependency 'yard'
+  gem.add_development_dependency "awesome_print", "~> 1.6"
+  gem.add_development_dependency "bundler"
+  gem.add_development_dependency "dotenv"
+  gem.add_development_dependency "pry-byebug", "~> 3.3"
+  gem.add_development_dependency "rspec", "~> 3.4"
+  gem.add_development_dependency "rspec-eventually", "0.2"
+  gem.add_development_dependency "timecop"
+  gem.add_development_dependency "webmock", "~> 3.0"
+  gem.add_development_dependency "yard"
 
-  gem.add_dependency 'concurrent-ruby', '~> 1.0'
-  gem.add_dependency 'nsq-ruby', '~> 2.3'
-  gem.add_dependency 'priority_queue_cxx', '~> 0.3'
+  gem.add_dependency "concurrent-ruby", "~> 1.0"
+  gem.add_dependency "nsq-ruby-fastly", "~> 2.4"
+  gem.add_dependency "priority_queue_cxx", "~> 0.3"
 end

data/lib/fastly_nsq/cli.rb

@@ -1,14 +1,13 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/ClassLength
 $stdout.sync = true
 
-require 'fastly_nsq'
-require 'fastly_nsq/launcher'
-require 'fastly_nsq/manager'
-require 'fileutils'
-require 'optparse'
-require 'singleton'
+require "fastly_nsq"
+require "fastly_nsq/launcher"
+require "fastly_nsq/manager"
+require "fileutils"
+require "optparse"
+require "singleton"
 
 # Provides functionality to support running FastlyNsq as a command line
 # application that listens and processes NSQ messages.
@@ -44,26 +43,24 @@ class FastlyNsq::CLI
 
     read_loop
   rescue Interrupt
-    FastlyNsq.logger.info 'Shutting down'
+    FastlyNsq.logger.info "Shutting down"
     launcher.stop
     # Explicitly exit so busy Processor threads can't block
     # process shutdown.
-    FastlyNsq.logger.info 'Bye!'
+    FastlyNsq.logger.info "Bye!"
     exit(0)
   end
 
   private
 
   def launcher
-    @launcher ||= FastlyNsq::Launcher.new(options)
+    @launcher ||= FastlyNsq::Launcher.new(**options)
   end
 
   def read_loop
     trapped_read_io = trap_signals
-    loop do
-      readable_io = IO.select([trapped_read_io])
-      break unless readable_io
-      signal = readable_io.first[0].gets.strip
+    while trapped_read_io.wait_readable
+      signal = trapped_read_io.gets.strip
       handle_signal signal
     end
   end
@@ -72,51 +69,51 @@ class FastlyNsq::CLI
     boot_rails
     require options[:require] if options[:require]
     FastlyNsq.logger.info "Running in #{RUBY_DESCRIPTION}"
-    FastlyNsq.logger.info 'Starting processing, hit Ctrl-C to stop' unless options[:daemon]
+    FastlyNsq.logger.info "Starting processing, hit Ctrl-C to stop" unless options[:daemon]
   end
 
   def boot_rails
-    return unless ENV['RAILS_ENV']
+    return unless ENV["RAILS_ENV"]
 
-    require 'rails'
-    require File.expand_path('./config/application.rb')
-    require File.expand_path('./config/environment.rb')
+    require "rails"
+    require File.expand_path("./config/application.rb")
+    require File.expand_path("./config/environment.rb")
   end
 
   def parse(args)
     opts = {}
 
     @parser = OptionParser.new do |o|
-      o.on '-c', '--concurrency COUNT', 'Number of threads used to process messages' do |arg|
+      o.on "-c", "--concurrency COUNT", "Number of threads used to process messages" do |arg|
         opts[:max_threads] = arg
       end
 
-      o.on '-d', '--daemon', 'Daemonize process' do |arg|
+      o.on "-d", "--daemon", "Daemonize process" do |arg|
         opts[:daemonize] = arg
       end
 
-      o.on '-L', '--logfile PATH', 'path to writable logfile' do |arg|
+      o.on "-L", "--logfile PATH", "path to writable logfile" do |arg|
         opts[:logfile] = arg
       end
 
-      o.on '-P', '--pidfile PATH', 'path to pidfile' do |arg|
+      o.on "-P", "--pidfile PATH", "path to pidfile" do |arg|
         opts[:pidfile] = arg
       end
 
-      o.on '-r', '--require [PATH|DIR]', 'Location of message_processor definition' do |arg|
+      o.on "-r", "--require [PATH|DIR]", "Location of message_processor definition" do |arg|
         opts[:require] = arg
       end
 
-      o.on '-v', '--verbose', 'enable verbose logging output' do |arg|
+      o.on "-v", "--verbose", "enable verbose logging output" do |arg|
         opts[:verbose] = arg
       end
 
-      o.on '-t', '--timeout SECONDS', 'shutdown deadline timeout' do |arg|
+      o.on "-t", "--timeout SECONDS", "shutdown deadline timeout" do |arg|
         opts[:timeout] = arg
       end
     end
 
-    @parser.banner = 'fastly_nsq [options]'
+    @parser.banner = "fastly_nsq [options]"
     @parser.parse!(args)
 
     @options = opts
@@ -171,13 +168,11 @@ class FastlyNsq::CLI
     sigs = %w[INT TERM TTIN USR1]
 
     sigs.each do |sig|
-      begin
-        trap sig do
-          self_write.puts(sig)
-        end
-      rescue ArgumentError
-        puts "Signal #{sig} not supported"
+      trap sig do
+        self_write.puts(sig)
       end
+    rescue ArgumentError
+      puts "Signal #{sig} not supported"
     end
     self_read
   end
@@ -185,28 +180,28 @@ class FastlyNsq::CLI
   def handle_signal(sig)
     FastlyNsq.logger.debug "Got #{sig} signal"
     case sig
-    when 'INT'
+    when "INT"
       # Handle Ctrl-C in JRuby like MRI
       # http://jira.codehaus.org/browse/JRUBY-4637
       raise Interrupt
-    when 'TERM'
+    when "TERM"
       # Heroku sends TERM and then waits 10 seconds for process to exit.
       raise Interrupt
-    when 'USR1'
-      FastlyNsq.logger.info 'Received USR1, no longer accepting new work'
+    when "USR1"
+      FastlyNsq.logger.info "Received USR1, no longer accepting new work"
       launcher.stop_listeners
-    when 'TTIN'
+    when "TTIN"
       handle_ttin
     end
   end
 
   def handle_ttin
     Thread.list.each do |thread|
-      FastlyNsq.logger.warn "Thread TID-#{thread.object_id.to_s(36)} #{thread['fastly_nsq_label']}"
+      FastlyNsq.logger.warn "Thread TID-#{thread.object_id.to_s(36)} #{thread["fastly_nsq_label"]}"
       if thread.backtrace
         FastlyNsq.logger.warn thread.backtrace.join("\n")
       else
-        FastlyNsq.logger.warn '<no backtrace available>'
+        FastlyNsq.logger.warn "<no backtrace available>"
       end
     end
   end
@@ -224,26 +219,24 @@ class FastlyNsq::CLI
     reopen(files_to_reopen)
 
     [$stdout, $stderr].each do |io|
-      File.open(options.fetch(:logfile, '/dev/null'), 'ab') do |f|
+      File.open(options.fetch(:logfile, "/dev/null"), "ab") do |f|
         io.reopen(f)
       end
       io.sync = true
     end
-    $stdin.reopen('/dev/null')
+    $stdin.reopen("/dev/null")
 
     setup_logger
   end
 
   def reopen(files)
     files.each do |file|
-      begin
-        file.reopen file.path, 'a+'
-        file.sync = true
-      rescue IOError => e
-        FastlyNsq.logger.warn "IOError reopening file:  #{e.message}"
-      rescue StandardError => e
-        FastlyNsq.logger.error "Non IOError reopening file:  #{e.message}"
-      end
+      file.reopen file.path, "a+"
+      file.sync = true
+    rescue IOError => e
+      FastlyNsq.logger.warn "IOError reopening file:  #{e.message}"
+    rescue => e
+      FastlyNsq.logger.error "Non IOError reopening file:  #{e.message}"
     end
   end
 

data/lib/fastly_nsq/consumer.rb

@@ -61,6 +61,9 @@ class FastlyNsq::Consumer
   ##
   # Create a FastlyNsq::Consumer
   #
+  # Will connect to NSQDs in this priority: 1. direct from FastlyNsq.consumer_nsqds 2. discovered via FastlyNsq.lookupd_http_addresses.
+  # If both `consumer_nsqds` and `lookupd_http_addresses` are set only the FastlyNsq.consumer_nsqds will be used.
+  #
   # @param topic [String] NSQ topic from which to consume
   # @param channel [String] NSQ channel from which to consume
   # @param queue [#pop, #size] Queue object, most likely an instance of {FastlyNsq::Feeder}
@@ -78,11 +81,11 @@ class FastlyNsq::Consumer
   #     channel: 'channel'
   #   )
   def initialize(topic:, channel:, queue: nil, tls_options: nil, connect_timeout: DEFAULT_CONNECTION_TIMEOUT, max_attempts: FastlyNsq.max_attempts, **options)
-    @topic           = topic
-    @channel         = channel
-    @tls_options     = FastlyNsq::TlsOptions.as_hash(tls_options)
+    @topic = topic
+    @channel = channel
+    @tls_options = FastlyNsq::TlsOptions.as_hash(tls_options)
     @connect_timeout = connect_timeout
-    @max_attempts    = max_attempts
+    @max_attempts = max_attempts
 
     @connection = connect(queue, **options)
   end
@@ -99,15 +102,25 @@ class FastlyNsq::Consumer
   attr_reader :tls_options
 
   def connect(queue, **options)
-    Nsq::Consumer.new(
-      {
-        nsqlookupd: FastlyNsq.lookupd_http_addresses,
-        topic: topic,
-        channel: channel,
-        queue: queue,
-        max_attempts: max_attempts,
-        **options,
-      }.merge(tls_options),
-    )
+    consumers = FastlyNsq.consumer_nsqds
+    lookupd = FastlyNsq.lookupd_http_addresses
+
+    opts = {
+      topic: topic,
+      channel: channel,
+      queue: queue,
+      max_attempts: max_attempts,
+      **options
+    }.merge(tls_options)
+
+    if !consumers.empty?
+      opts[:nsqd] = consumers
+    elsif !lookupd.empty?
+      opts[:nsqlookupd] = lookupd
+    else
+      raise FastlyNsq::ConnectionFailed, "One of FastlyNsq.consumer_nsqds or FastlyNsq.lookupd_http_addresses must be present"
+    end
+
+    Nsq::Consumer.new(opts)
   end
 end

data/lib/fastly_nsq/feeder.rb

@@ -36,13 +36,11 @@ class FastlyNsq::Feeder
   # @see Nsq::Connection#read_loop
   def push(message)
     FastlyNsq.manager.pool.post(priority) do
-      begin
-        processor.call(message)
-      rescue => ex
-        FastlyNsq.logger.error ex
-        FastlyNsq.tracer.notice_error ex
-        raise ex
-      end
+      processor.call(message)
+    rescue => ex
+      FastlyNsq.logger.error ex
+      FastlyNsq.tracer.notice_error ex
+      raise ex
     end
   end
 end