fastlane_hotfix 2.165.1 → 2.187.0

data/fastlane/lib/fastlane/actions/commit_github_file.rb

@@ -33,6 +33,7 @@ module Fastlane
         GithubApiAction.run({
           server_url: params[:server_url],
           api_token: params[:api_token],
+          api_bearer: params[:api_bearer],
           secure: params[:secure],
           http_method: "PUT",
           path: File.join("repos", params[:repository_name], "contents", api_file_path),
@@ -104,12 +105,20 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_COMMIT_GITHUB_FILE_API_TOKEN",
                                        description: "Personal API Token for GitHub - generate one at https://github.com/settings/tokens",
+                                       conflicting_options: [:api_bearer],
                                        sensitive: true,
-                                       is_string: true,
                                        code_gen_sensitive: true,
                                        default_value: ENV["GITHUB_API_TOKEN"],
                                        default_value_dynamic: true,
-                                       optional: false),
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :api_bearer,
+                                       env_name: "FL_COMMIT_GITHUB_FILE_API_BEARER",
+                                       sensitive: true,
+                                       code_gen_sensitive: true,
+                                       description: "Use a Bearer authorization token. Usually generated by Github Apps, e.g. GitHub Actions GITHUB_TOKEN environment variable",
+                                       conflicting_options: [:api_token],
+                                       optional: true,
+                                       default_value: nil),
           FastlaneCore::ConfigItem.new(key: :branch,
                                        env_name: "FL_COMMIT_GITHUB_FILE_BRANCH",
                                        description: "The branch that the file should be committed on (default: master)",
@@ -119,7 +128,6 @@ module Fastlane
                                        env_name: 'FL_COMMIT_GITHUB_FILE_PATH',
                                        description: 'The relative path to your file from project root e.g. assets/my_app.xcarchive',
                                        optional: false,
-                                       is_string: true,
                                        verify_block: proc do |value|
                                          value = File.expand_path(value)
                                          UI.user_error!("File not found at path '#{value}'") unless File.exist?(value)
@@ -132,7 +140,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :secure,
                                        env_name: "FL_COMMIT_GITHUB_FILE_SECURE",
                                        description: "Optionally disable secure requests (ssl_verify_peer)",
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: true,
                                        optional: true)
         ]

data/fastlane/lib/fastlane/actions/commit_version_bump.rb

@@ -164,20 +164,19 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :force,
                                        env_name: "FL_FORCE_COMMIT",
                                        description: "Forces the commit, even if other files than the ones containing the version number have been modified",
+                                       type: Boolean,
                                        optional: true,
-                                       default_value: false,
-                                       is_string: false),
+                                       default_value: false),
           FastlaneCore::ConfigItem.new(key: :settings,
                                        env_name: "FL_COMMIT_INCLUDE_SETTINGS",
                                        description: "Include Settings.bundle/Root.plist with version bump",
+                                       skip_type_validation: true, # allows Boolean, String, Array
                                        optional: true,
-                                       default_value: false,
-                                       is_string: false),
+                                       default_value: false),
           FastlaneCore::ConfigItem.new(key: :ignore,
                                        description: "A regular expression used to filter matched plist files to be modified",
-                                       optional: true,
-                                       default_value: nil,
-                                       is_string: false),
+                                       skip_type_validation: true, # allows Regex
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :include,
                                        description: "A list of extra files to be included in the version bump (string array or comma-separated string)",
                                        optional: true,

data/fastlane/lib/fastlane/actions/copy_artifacts.rb

@@ -57,22 +57,21 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :keep_original,
                                        description: "Set this to false if you want move, rather than copy, the found artifacts",
-                                       is_string: false,
+                                       type: Boolean,
                                        optional: true,
                                        default_value: true),
           FastlaneCore::ConfigItem.new(key: :target_path,
                                        description: "The directory in which you want your artifacts placed",
-                                       is_string: false,
                                        optional: false,
                                        default_value: 'artifacts'),
           FastlaneCore::ConfigItem.new(key: :artifacts,
                                        description: "An array of file patterns of the files/folders you want to preserve",
-                                       is_string: false,
+                                       type: Array,
                                        optional: false,
                                        default_value: []),
           FastlaneCore::ConfigItem.new(key: :fail_on_missing,
                                        description: "Fail when a source file isn't found",
-                                       is_string: false,
+                                       type: Boolean,
                                        optional: true,
                                        default_value: false)
         ]

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -2,9 +2,6 @@ module Fastlane
   module Actions
     class CrashlyticsAction < Action
       def self.run(params)
-        params[:groups] = params[:groups].join(",") if params[:groups].kind_of?(Array)
-        params[:emails] = params[:emails].join(",") if params[:emails].kind_of?(Array)
-
         params.values # to validate all inputs before looking for the ipa/apk
         tempfiles = []
 
@@ -133,28 +130,27 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :notes,
                                        env_name: "CRASHLYTICS_NOTES",
                                        description: "The release notes as string - uses :notes_path under the hood",
-                                       optional: true,
-                                       is_string: true),
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :groups,
                                        env_name: "CRASHLYTICS_GROUPS",
                                        description: "The groups used for distribution, separated by commas",
-                                       optional: true,
-                                       is_string: false),
+                                       type: Array,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :emails,
                                        env_name: "CRASHLYTICS_EMAILS",
                                        description: "Pass email addresses of testers, separated by commas",
-                                       optional: true,
-                                       is_string: false),
+                                       type: Array,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :notifications,
                                        env_name: "CRASHLYTICS_NOTIFICATIONS",
                                        description: "Crashlytics notification option (true/false)",
                                        default_value: true,
-                                       is_string: false),
+                                       type: Boolean),
           FastlaneCore::ConfigItem.new(key: :debug,
                                        env_name: "CRASHLYTICS_DEBUG",
                                        description: "Crashlytics debug option (true/false)",
                                        default_value: false,
-                                       is_string: false)
+                                       type: Boolean)
 
         ]
       end

data/fastlane/lib/fastlane/actions/create_app_on_managed_play_store.rb

@@ -52,91 +52,85 @@ module Fastlane
       def self.available_options
         [
           # Authorization
-          FastlaneCore::ConfigItem.new(
-            key: :json_key,
-            env_name: "SUPPLY_JSON_KEY",
-            short_option: "-j",
-            conflicting_options: [:json_key_data],
-            optional: true, # optional until it is possible specify either json_key OR json_key_data are required
-            description: "The path to a file containing service account JSON, used to authenticate with Google",
-            code_gen_sensitive: true,
-            default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_file),
-            default_value_dynamic: true,
-            verify_block: proc do |value|
-              UI.user_error!("Could not find service account json file at path '#{File.expand_path(value)}'") unless File.exist?(File.expand_path(value))
-              UI.user_error!("'#{value}' doesn't seem to be a JSON file") unless FastlaneCore::Helper.json_file?(File.expand_path(value))
-            end
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :json_key_data,
-            env_name: "SUPPLY_JSON_KEY_DATA",
-            short_option: "-c",
-            conflicting_options: [:json_key],
-            optional: true,
-            description: "The raw service account JSON data used to authenticate with Google",
-            code_gen_sensitive: true,
-            default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_data_raw),
-            default_value_dynamic: true,
-            verify_block: proc do |value|
-              begin
-                JSON.parse(value)
-              rescue JSON::ParserError
-                UI.user_error!("Could not parse service account json: JSON::ParseError")
-              end
-            end
-          ),
+          FastlaneCore::ConfigItem.new(key: :json_key,
+                                       env_name: "SUPPLY_JSON_KEY",
+                                       short_option: "-j",
+                                       conflicting_options: [:json_key_data],
+                                       optional: true, # optional until it is possible specify either json_key OR json_key_data are required
+                                       description: "The path to a file containing service account JSON, used to authenticate with Google",
+                                       code_gen_sensitive: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_file),
+                                       default_value_dynamic: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Could not find service account json file at path '#{File.expand_path(value)}'") unless File.exist?(File.expand_path(value))
+                                         UI.user_error!("'#{value}' doesn't seem to be a JSON file") unless FastlaneCore::Helper.json_file?(File.expand_path(value))
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :json_key_data,
+                                       env_name: "SUPPLY_JSON_KEY_DATA",
+                                       short_option: "-c",
+                                       conflicting_options: [:json_key],
+                                       optional: true,
+                                       description: "The raw service account JSON data used to authenticate with Google",
+                                       code_gen_sensitive: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_data_raw),
+                                       default_value_dynamic: true,
+                                       verify_block: proc do |value|
+                                         begin
+                                           JSON.parse(value)
+                                         rescue JSON::ParserError
+                                           UI.user_error!("Could not parse service account json: JSON::ParseError")
+                                         end
+                                       end),
           FastlaneCore::ConfigItem.new(key: :developer_account_id,
-            short_option: "-k",
-            env_name: "SUPPLY_DEVELOPER_ACCOUNT_ID",
-            description: "The ID of your Google Play Console account. Can be obtained from the URL when you log in (`https://play.google.com/apps/publish/?account=...` or when you 'Obtain private app publishing rights' (https://developers.google.com/android/work/play/custom-app-api/get-started#retrieve_the_developer_account_id)",
-            code_gen_sensitive: true,
-            default_value: CredentialsManager::AppfileConfig.try_fetch_value(:developer_account_id),
-            default_value_dynamic: true),
+                                       short_option: "-k",
+                                       env_name: "SUPPLY_DEVELOPER_ACCOUNT_ID",
+                                       description: "The ID of your Google Play Console account. Can be obtained from the URL when you log in (`https://play.google.com/apps/publish/?account=...` or when you 'Obtain private app publishing rights' (https://developers.google.com/android/work/play/custom-app-api/get-started#retrieve_the_developer_account_id)",
+                                       code_gen_sensitive: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:developer_account_id),
+                                       default_value_dynamic: true),
           # APK
-          FastlaneCore::ConfigItem.new(
-            key: :apk,
-            env_name: "SUPPLY_APK",
-            description: "Path to the APK file to upload",
-            short_option: "-b",
-            code_gen_sensitive: true,
-            default_value: Dir["*.apk"].last || Dir[File.join("app", "build", "outputs", "apk", "app-release.apk")].last,
-            default_value_dynamic: true,
-            verify_block: proc do |value|
-              UI.user_error!("No value found for 'apk'") if value.to_s.length == 0
-              UI.user_error!("Could not find apk file at path '#{value}'") unless File.exist?(value)
-              UI.user_error!("apk file is not an apk") unless value.end_with?('.apk')
-            end
-          ),
+          FastlaneCore::ConfigItem.new(key: :apk,
+                                       env_name: "SUPPLY_APK",
+                                       description: "Path to the APK file to upload",
+                                       short_option: "-b",
+                                       code_gen_sensitive: true,
+                                       default_value: Dir["*.apk"].last || Dir[File.join("app", "build", "outputs", "apk", "app-release.apk")].last,
+                                       default_value_dynamic: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("No value found for 'apk'") if value.to_s.length == 0
+                                         UI.user_error!("Could not find apk file at path '#{value}'") unless File.exist?(value)
+                                         UI.user_error!("apk file is not an apk") unless value.end_with?('.apk')
+                                       end),
           # Title
           FastlaneCore::ConfigItem.new(key: :app_title,
-            env_name: "SUPPLY_APP_TITLE",
-            short_option: "-q",
-            description: "App Title"),
+                                       env_name: "SUPPLY_APP_TITLE",
+                                       short_option: "-q",
+                                       description: "App Title"),
           # Language
           FastlaneCore::ConfigItem.new(key: :language,
-            short_option: "-m",
-            env_name: "SUPPLY_LANGUAGE",
-            description: "Default app language (e.g. 'en_US')",
-            default_value: "en_US",
-            verify_block: proc do |language|
-              unless Supply::Languages::ALL_LANGUAGES.include?(language)
-                UI.user_error!("Please enter one of the available languages: #{Supply::Languages::ALL_LANGUAGES}")
-              end
-            end),
+                                       short_option: "-m",
+                                       env_name: "SUPPLY_LANGUAGE",
+                                       description: "Default app language (e.g. 'en_US')",
+                                       default_value: "en_US",
+                                       verify_block: proc do |language|
+                                         unless Supply::Languages::ALL_LANGUAGES.include?(language)
+                                           UI.user_error!("Please enter one of the available languages: #{Supply::Languages::ALL_LANGUAGES}")
+                                         end
+                                       end),
           # Google Play API
           FastlaneCore::ConfigItem.new(key: :root_url,
-            env_name: "SUPPLY_ROOT_URL",
-            description: "Root URL for the Google Play API. The provided URL will be used for API calls in place of https://www.googleapis.com/",
-            optional: true,
-            verify_block: proc do |value|
-              UI.user_error!("Could not parse URL '#{value}'") unless value =~ URI.regexp
-            end),
+                                       env_name: "SUPPLY_ROOT_URL",
+                                       description: "Root URL for the Google Play API. The provided URL will be used for API calls in place of https://www.googleapis.com/",
+                                       optional: true,
+                                       verify_block: proc do |value|
+                                         UI.user_error!("Could not parse URL '#{value}'") unless value =~ URI.regexp
+                                       end),
           FastlaneCore::ConfigItem.new(key: :timeout,
-            env_name: "SUPPLY_TIMEOUT",
-            optional: true,
-            description: "Timeout for read, open, and send (in seconds)",
-            type: Integer,
-            default_value: 300)
+                                       env_name: "SUPPLY_TIMEOUT",
+                                       optional: true,
+                                       description: "Timeout for read, open, and send (in seconds)",
+                                       type: Integer,
+                                       default_value: 300)
         ]
       end
 

data/fastlane/lib/fastlane/actions/create_keychain.rb

@@ -47,7 +47,10 @@ module Fastlane
         commands << Fastlane::Actions.sh("security unlock-keychain -p #{escaped_password} #{keychain_path}", log: false) if params[:unlock]
 
         command = "security set-keychain-settings"
-        command << " -t #{params[:timeout]}" if params[:timeout]
+
+        # https://ss64.com/osx/security-keychain-settings.html
+        # omitting 'timeout' option to specify "no timeout" if required
+        command << " -t #{params[:timeout]}" if params[:timeout] > 0
         command << " -l" if params[:lock_when_sleeps]
         command << " -u" if params[:lock_after_timeout]
         command << " #{keychain_path}"
@@ -105,46 +108,45 @@ module Fastlane
                                        env_name: "KEYCHAIN_NAME",
                                        description: "Keychain name",
                                        conflicting_options: [:path],
-                                       is_string: true,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :path,
                                        env_name: "KEYCHAIN_PATH",
                                        description: "Path to keychain",
-                                       is_string: true,
                                        conflicting_options: [:name],
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :password,
                                        env_name: "KEYCHAIN_PASSWORD",
                                        description: "Password for the keychain",
                                        sensitive: true,
+                                       code_gen_sensitive: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :default_keychain,
                                        description: 'Should the newly created Keychain be the new system default keychain',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :unlock,
                                        description: 'Unlock keychain after create',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :timeout,
-                                       description: 'timeout interval in seconds. Set `false` if you want to specify "no time-out"',
-                                       is_string: false,
+                                       description: 'timeout interval in seconds. Set `0` if you want to specify "no time-out"',
+                                       type: Integer,
                                        default_value: 300),
           FastlaneCore::ConfigItem.new(key: :lock_when_sleeps,
                                        description: 'Lock keychain when the system sleeps',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :lock_after_timeout,
                                        description: 'Lock keychain after timeout interval',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false),
           FastlaneCore::ConfigItem.new(key: :add_to_search_list,
                                        description: 'Add keychain to search list',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: true),
           FastlaneCore::ConfigItem.new(key: :require_create,
                                        description: 'Fail the action if the Keychain already exists',
-                                       is_string: false,
+                                       type: Boolean,
                                        default_value: false)
         ]
       end

data/fastlane/lib/fastlane/actions/create_pull_request.rb

@@ -20,6 +20,7 @@ module Fastlane
         GithubApiAction.run(
           server_url: params[:api_url],
           api_token: params[:api_token],
+          api_bearer: params[:api_bearer],
           http_method: 'POST',
           path: "repos/#{params[:repo]}/pulls",
           body: payload,
@@ -60,6 +61,7 @@ module Fastlane
         GithubApiAction.run(
           server_url: params[:api_url],
           api_token: params[:api_token],
+          api_bearer: params[:api_bearer],
           http_method: 'PATCH',
           path: "repos/#{params[:repo]}/issues/#{number}",
           body: payload,
@@ -79,6 +81,7 @@ module Fastlane
         GithubApiAction.run(
           server_url: params[:api_url],
           api_token: params[:api_token],
+          api_bearer: params[:api_bearer],
           http_method: 'POST',
           path: "repos/#{params[:repo]}/issues/#{number}/assignees",
           body: payload,
@@ -103,6 +106,7 @@ module Fastlane
         GithubApiAction.run(
           server_url: params[:api_url],
           api_token: params[:api_token],
+          api_bearer: params[:api_bearer],
           http_method: 'POST',
           path: "repos/#{params[:repo]}/pulls/#{number}/requested_reviewers",
           body: payload,
@@ -124,6 +128,7 @@ module Fastlane
         GithubApiAction.run(
           server_url: params[:api_url],
           api_token: params[:api_token],
+          api_bearer: params[:api_bearer],
           http_method: 'PATCH',
           path: "repos/#{params[:repo]}/issues/#{number}",
           body: payload,
@@ -160,22 +165,27 @@ module Fastlane
                                        code_gen_sensitive: true,
                                        default_value: ENV["GITHUB_API_TOKEN"],
                                        default_value_dynamic: true,
-                                       is_string: true,
-                                       optional: false),
+                                       conflicting_options: [:api_bearer],
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :api_bearer,
+                                       env_name: "GITHUB_PULL_REQUEST_API_BEARER",
+                                       description: "Use a Bearer authorization token. Usually generated by Github Apps, e.g. GitHub Actions GITHUB_TOKEN environment variable",
+                                       sensitive: true,
+                                       code_gen_sensitive: true,
+                                       conflicting_options: [:api_token],
+                                       optional: true,
+                                       default_value: nil),
           FastlaneCore::ConfigItem.new(key: :repo,
                                        env_name: "GITHUB_PULL_REQUEST_REPO",
                                        description: "The name of the repository you want to submit the pull request to",
-                                       is_string: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :title,
                                        env_name: "GITHUB_PULL_REQUEST_TITLE",
                                        description: "The title of the pull request",
-                                       is_string: true,
                                        optional: false),
           FastlaneCore::ConfigItem.new(key: :body,
                                        env_name: "GITHUB_PULL_REQUEST_BODY",
                                        description: "The contents of the pull request",
-                                       is_string: true,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :draft,
                                        env_name: "GITHUB_PULL_REQUEST_DRAFT",
@@ -195,21 +205,17 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :head,
                                        env_name: "GITHUB_PULL_REQUEST_HEAD",
                                        description: "The name of the branch where your changes are implemented (defaults to the current branch name)",
-                                       is_string: true,
-                                       code_gen_sensitive: true,
                                        default_value: Actions.git_branch,
                                        default_value_dynamic: true,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :base,
                                        env_name: "GITHUB_PULL_REQUEST_BASE",
                                        description: "The name of the branch you want your changes pulled into (defaults to `master`)",
-                                       is_string: true,
                                        default_value: 'master',
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :api_url,
                                        env_name: "GITHUB_PULL_REQUEST_API_URL",
                                        description: "The URL of GitHub API - used when the Enterprise (default to `https://api.github.com`)",
-                                       is_string: true,
                                        code_gen_default_value: 'https://api.github.com',
                                        default_value: 'https://api.github.com',
                                        optional: true),