fastlane_core 0.52.1 → 0.52.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91c208ecad2dc40bf4ead9fcea1e8a24a985a3c9
-  data.tar.gz: 435d1e0657e3c6864dd48d29c03e671dc3568cb5
+  metadata.gz: e254d0408efc312fe0c1c30f8049a92bf8f30413
+  data.tar.gz: f1a07a4d4c11e320a934b481ef53e61707c665af
 SHA512:
-  metadata.gz: 41aae20ba8a0b58e78bdb08e424d863bfaae2a7908c5036bfa3a54e3201f10311e333c0340d282f4f5081e20303be59a9eb3090040ee6ad5b11f2623616f883b
-  data.tar.gz: 4a9fd09d821f3dba43d7f5f552a0a739781a97a38e9d74c86d13a6620694b9ac2e1db117309f70e6242599cbcddfb91959794c76c3b2a3797003c7e895c36d80
+  metadata.gz: e99fd51fbc0f68215832cec1e9ab8a1a19c4951c9bdb07fbac6751291cd908f3a464315fb6ee2aed8dcd1ddd93b8732e4b286fc941b5886bd0bfcdc5e1686204
+  data.tar.gz: 7d8c8bafef81a8db11e4f9978ab005d57f90baf6dcd20324b8f7e56f0c805db506b81b701aeb8b17e24b458a27ca876cccaabfe00812ba3d487575a96fdd1642

data/lib/fastlane_core/ui/fastlane_runner.rb

@@ -1,17 +1,19 @@
+unless Object.const_defined?("Faraday")
+  # We create these empty error classes if we didn't require Faraday
+  # so that we can use it in the rescue block below even if we didn't
+  # require Faraday or didn't use it
+  module Faraday
+    class Error < StandardError; end
+    class ClientError < Error; end
+    class SSLError < ClientError; end
+    class ConnectionFailed < ClientError; end
+  end
+end
+
 module Commander
   # This class override the run method with our custom stack trace handling
   # In particular we want to distinguish between user_error! and crash! (one with, one without stack trace)
   class Runner
-    unless Object.const_defined?("Faraday")
-      module Faraday
-        class SSLError < StandardError
-          # We create this empty error class if we didn't require Faraday
-          # so that we can use it in the rescue block below
-          # even if we didn't require Faraday or didn't use it
-        end
-      end
-    end
-
     # Code taken from https://github.com/commander-rb/commander/blob/master/lib/commander/runner.rb#L50
     def run!
       require_program :version, :description
@@ -53,22 +55,13 @@ module Commander
         show_github_issues(e.message) if e.show_github_issues
         display_user_error!(e, e.message)
       rescue Faraday::SSLError => e # SSL issues are very common
-        # SSL errors are very common when the Ruby or OpenSSL installation is somehow broken
-        # We want to show a nice error message to the user here
-        # We have over 20 GitHub issues just for this one error:
-        #   https://github.com/fastlane/fastlane/search?q=errno%3D0+state%3DSSLv3+read+server&type=Issues
-        ui = FastlaneCore::UI
-        ui.error "-----------------------------------------------------------------------"
-        ui.error e.to_s
-        ui.error "SSL errors can be caused by various components on your local machine"
-        ui.error "- Make sure OpenSSL is installed with Homebrew: `brew update && brew upgrade openssl`"
-        ui.error "- If you use rvm:"
-        ui.error "  - First run `rvm osx-ssl-certs update all`"
-        ui.error "  - Then run `rvm reinstall ruby-2.2.3 --with-openssl-dir=/usr/local"
-        ui.error "- If that doesn't fix your issue, please google for the following error message:"
-        ui.error "  '#{e}'"
-        ui.error "-----------------------------------------------------------------------"
-        display_user_error!(e, e.to_s)
+        handle_ssl_error!(e)
+      rescue Faraday::ConnectionFailed => e
+        if e.message.include? 'Connection reset by peer - SSL_connect'
+          handle_tls_error!(e)
+        else
+          handle_unknown_error!(e)
+        end
       rescue => e # high chance this is actually FastlaneCore::Interface::FastlaneCrash, but can be anything else
         collector.did_crash(@program[:name])
         handle_unknown_error!(e)
@@ -77,6 +70,51 @@ module Commander
       end
     end
 
+    def handle_tls_error!(e)
+      # Apple has upgraded its iTunes Connect servers to require TLS 1.2, but
+      # system Ruby 2.0 does not support it. We want to suggest that users upgrade
+      # their Ruby version
+      suggest_ruby_reinstall(e)
+      display_user_error!(e, e.to_s)
+    end
+
+    def handle_ssl_error!(e)
+      # SSL errors are very common when the Ruby or OpenSSL installation is somehow broken
+      # We want to show a nice error message to the user here
+      # We have over 20 GitHub issues just for this one error:
+      #   https://github.com/fastlane/fastlane/search?q=errno%3D0+state%3DSSLv3+read+server&type=Issues
+      suggest_ruby_reinstall(e)
+      display_user_error!(e, e.to_s)
+    end
+
+    def suggest_ruby_reinstall(e)
+      ui = FastlaneCore::UI
+      ui.error "-----------------------------------------------------------------------"
+      ui.error e.to_s
+      ui.error ""
+      ui.error "SSL errors can be caused by various components on your local machine."
+      if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.1')
+        ui.error "Apple has recently changed their servers to require TLS 1.2, which may"
+        ui.error "not be available to your system installed Ruby (#{RUBY_VERSION})"
+      end
+      ui.error ""
+      ui.error "The best solution is to install a new version of Ruby"
+      ui.error ""
+      ui.error "- Make sure OpenSSL is installed with Homebrew: `brew update && brew upgrade openssl`"
+      ui.error "- If you use system Ruby:"
+      ui.error "  - Run `brew update && brew install ruby`"
+      ui.error "- If you use rbenv with ruby-build:"
+      ui.error "  - Run `brew update && brew upgrade ruby-build && rbenv install ruby-2.3.1`"
+      ui.error "  - Run `rbenv global ruby-2.3.1` to make it the new global default Ruby version"
+      ui.error "- If you use rvm:"
+      ui.error "  - First run `rvm osx-ssl-certs update all`"
+      ui.error "  - Then run `rvm reinstall ruby-2.3.1 --with-openssl-dir=/usr/local"
+      ui.error ""
+      ui.error "If that doesn't fix your issue, please google for the following error message:"
+      ui.error "  '#{e}'"
+      ui.error "-----------------------------------------------------------------------"
+    end
+
     def handle_unknown_error!(e)
       # Some spaceship exception classes implement #preferred_error_info in order to share error info
       # that we'd rather display instead of crashing with a stack trace. However, fastlane_core and

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.52.1".freeze
+  VERSION = "0.52.2".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.52.1
+  version: 0.52.2
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-05 00:00:00.000000000 Z
+date: 2016-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -138,30 +138,42 @@ dependencies:
   name: plist
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.1.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.4.5
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.4.5
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: gh_inspector
   requirement: !ruby/object:Gem::Requirement