fastlane_core 0.46.1 → 0.46.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd19ed1b75a82e1c47f24d3ff0639c8e5b4bc56e
-  data.tar.gz: d5030bf2771ff27adc8152064546cce6ee3a71f4
+  metadata.gz: 57c9dfb3493b58bd5d74cca8e791effe06c970b8
+  data.tar.gz: 829ed1c0dfb471b3f3f38f865447a6ddd4561628
 SHA512:
-  metadata.gz: 6e1ae94c8f44df1d3f69fb5eaa197bf35cadfa7d862b709c6955561f9f532594e2890d88ac69b6dca2b84f155aa6e12fde8a1e9d7da9f06808a2cb298c3390b8
-  data.tar.gz: 854e9180a55ed7938a5bd2e97a7b196f0647ec8483fa9fa986d8109b264190db748a88f52fcdf9312a41f111375afed87e01ab4a017ca0ff2b441aa64449e935
+  metadata.gz: 7e522176c56c7d91cc0f6b802c52d829b5727f588aca609c32b818c44698fb690ff192ca2f09ace14e6b8ffa4506a859fae1135ef7aa977859d256b466244efe
+  data.tar.gz: 9ca1c53365ce1237e82159b588df7341233de8ed6bffa6a578d1b9dc6ff6e8de0902349d2fd6448d10e1a8ae2c3b12592d218ab715cf250768aa30ba407f9f3d

data/lib/fastlane_core/itunes_transporter.rb

@@ -133,7 +133,7 @@ module FastlaneCore
 
   # Generates commands and executes the iTMSTransporter through the shell script it provides by the same name
   class ShellScriptTransporterExecutor < TransporterExecutor
-    def build_upload_command(username, password, source = "/tmp")
+    def build_upload_command(username, password, source = "/tmp", provider_short_name = "")
       [
         '"' + Helper.transporter_path + '"',
         "-m upload",
@@ -142,19 +142,21 @@ module FastlaneCore
         "-f '#{source}'",
         ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
         "-t 'Signiant'",
-        "-k 100000"
-      ].join(' ')
+        "-k 100000",
+        ("-itc_provider #{provider_short_name}" unless provider_short_name.to_s.empty?)
+      ].compact.join(' ')
     end
 
-    def build_download_command(username, password, apple_id, destination = "/tmp")
+    def build_download_command(username, password, apple_id, destination = "/tmp", provider_short_name = "")
       [
         '"' + Helper.transporter_path + '"',
         "-m lookupMetadata",
         "-u \"#{username}\"",
         "-p #{shell_escaped_password(password)}",
         "-apple_id #{apple_id}",
-        "-destination '#{destination}'"
-      ].join(' ')
+        "-destination '#{destination}'",
+        ("-itc_provider #{provider_short_name}" unless provider_short_name.to_s.empty?)
+      ].compact.join(' ')
     end
 
     def handle_error(password)
@@ -190,7 +192,7 @@ module FastlaneCore
   # Generates commands and executes the iTMSTransporter by invoking its Java app directly, to avoid the crazy parameter
   # escaping problems in its accompanying shell script.
   class JavaTransporterExecutor < TransporterExecutor
-    def build_upload_command(username, password, source = "/tmp")
+    def build_upload_command(username, password, source = "/tmp", provider_short_name = "")
       [
         Helper.transporter_java_executable_path.shellescape,
         "-Djava.ext.dirs=#{Helper.transporter_java_ext_dir.shellescape}",
@@ -209,11 +211,12 @@ module FastlaneCore
         ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
         '-t Signiant',
         '-k 100000',
+        ("-itc_provider #{provider_short_name}" unless provider_short_name.to_s.empty?),
         '2>&1' # cause stderr to be written to stdout
       ].compact.join(' ') # compact gets rid of the possibly nil ENV value
     end
 
-    def build_download_command(username, password, apple_id, destination = "/tmp")
+    def build_download_command(username, password, apple_id, destination = "/tmp", provider_short_name = "")
       [
         Helper.transporter_java_executable_path.shellescape,
         "-Djava.ext.dirs=#{Helper.transporter_java_ext_dir.shellescape}",
@@ -230,8 +233,9 @@ module FastlaneCore
         "-p #{password.shellescape}",
         "-apple_id #{apple_id.shellescape}",
         "-destination #{destination.shellescape}",
+        ("-itc_provider #{provider_short_name}" unless provider_short_name.to_s.empty?),
         '2>&1' # cause stderr to be written to stdout
-      ].join(' ')
+      ].compact.join(' ')
     end
 
     def handle_error(password)
@@ -270,7 +274,13 @@ module FastlaneCore
     # @param use_shell_script if true, forces use of the iTMSTransporter shell script.
     #                         if false, allows a direct call to the iTMSTransporter Java app (preferred).
     #                         see: https://github.com/fastlane/fastlane/pull/4003
-    def initialize(user = nil, password = nil, use_shell_script = false)
+    # @param provider_short_name The provider short name to be given to the iTMSTransporter to identify the
+    #                            correct team for this work. The provider short name is usually your Developer
+    #                            Portal team ID, but in certain cases it is different!
+    #                            see: https://github.com/fastlane/fastlane/issues/1524#issuecomment-196370628
+    #                            for more information about how to use the iTMSTransporter to list your provider
+    #                            short names
+    def initialize(user = nil, password = nil, use_shell_script = false, provider_short_name = nil)
       # Xcode 6.x doesn't have the same iTMSTransporter Java setup as later Xcode versions, so
       # we can't default to using the better direct Java invocation strategy for those versions.
       use_shell_script ||= Helper.is_mac? && Helper.xcode_version.start_with?('6.')
@@ -292,6 +302,7 @@ module FastlaneCore
       end
 
       @transporter_executor = use_shell_script ? ShellScriptTransporterExecutor.new : JavaTransporterExecutor.new
+      @provider_short_name = provider_short_name
     end
 
     # Downloads the latest version of the app metadata package from iTC.
@@ -304,8 +315,8 @@ module FastlaneCore
       dir ||= "/tmp"
 
       UI.message("Going to download app metadata from iTunes Connect")
-      command = @transporter_executor.build_download_command(@user, @password, app_id, dir)
-      UI.verbose(@transporter_executor.build_download_command(@user, 'YourPassword', app_id, dir))
+      command = @transporter_executor.build_download_command(@user, @password, app_id, dir, @provider_short_name)
+      UI.verbose(@transporter_executor.build_download_command(@user, 'YourPassword', app_id, dir, @provider_short_name))
 
       begin
         result = @transporter_executor.execute(command, ItunesTransporter.hide_transporter_output?)
@@ -340,8 +351,8 @@ module FastlaneCore
       UI.message("Going to upload updated app to iTunes Connect")
       UI.success("This might take a few minutes, please don't interrupt the script")
 
-      command = @transporter_executor.build_upload_command(@user, @password, actual_dir)
-      UI.verbose(@transporter_executor.build_upload_command(@user, 'YourPassword', actual_dir))
+      command = @transporter_executor.build_upload_command(@user, @password, actual_dir, @provider_short_name)
+      UI.verbose(@transporter_executor.build_upload_command(@user, 'YourPassword', actual_dir, @provider_short_name))
 
       begin
         result = @transporter_executor.execute(command, ItunesTransporter.hide_transporter_output?)

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.46.1".freeze
+  VERSION = "0.46.2".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.46.1
+  version: 0.46.2
 platform: ruby
 authors:
 - Felix Krause
@@ -385,7 +385,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Contains all shared code/dependencies of the fastlane.tools