fastlane_core 0.46.0 → 0.46.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46f75e6ce99bc7d7a20f8a175b717f772912b1e9
-  data.tar.gz: bbf4f5d4b1ba46504b221cd5b27e2f066a41d84e
+  metadata.gz: bd19ed1b75a82e1c47f24d3ff0639c8e5b4bc56e
+  data.tar.gz: d5030bf2771ff27adc8152064546cce6ee3a71f4
 SHA512:
-  metadata.gz: e5959fc3b5814b26575364a4c6dd3f11e42252b90b3a00e3f59be339e799ca7b2cd21f00be60973b9824043524bd597f96d29a87c3b4b3b5ff58bb4e8c246a7b
-  data.tar.gz: a75cc58a5649171a7a8f30232d7251947fd87827d62a8e326532f07adc69a91257dbcf9e323a45f1c32f8adfa3717390b7fe991337658fcffb5240d8e522aa4d
+  metadata.gz: 6e1ae94c8f44df1d3f69fb5eaa197bf35cadfa7d862b709c6955561f9f532594e2890d88ac69b6dca2b84f155aa6e12fde8a1e9d7da9f06808a2cb298c3390b8
+  data.tar.gz: 854e9180a55ed7938a5bd2e97a7b196f0647ec8483fa9fa986d8109b264190db748a88f52fcdf9312a41f111375afed87e01ab4a017ca0ff2b441aa64449e935

data/lib/fastlane_core/configuration/config_item.rb

@@ -87,14 +87,14 @@ module FastlaneCore
 
     # Returns an updated value type (if necessary)
     def auto_convert_value(value)
-      # Weird because of https://stackoverflow.com/questions/9537895/using-a-class-object-in-case-statement
-      case
-      when data_type == Array
+      return nil if value.nil?
+
+      if data_type == Array
         return value.split(',') if value.kind_of?(String)
-      when data_type == Integer
-        return value.to_i unless value.nil?
-      when data_type == Float
-        return value.to_f unless value.nil?
+      elsif data_type == Integer
+        return value.to_i if value.to_i.to_s == value.to_s
+      elsif data_type == Float
+        return value.to_f if value.to_f.to_s == value.to_s
       else
         # Special treatment if the user specified true, false or YES, NO
         # There is no boolean type, so we just do it here

data/lib/fastlane_core/configuration/configuration.rb

@@ -54,11 +54,11 @@ module FastlaneCore
       # Make sure the given value keys exist
       @values.each do |key, value|
         next if key == :trace # special treatment
-
         option = option_for_key(key)
         if option
+          @values[key] = option.auto_convert_value(value)
           UI.deprecated("Using deprecated option: '--#{key}' (#{option.deprecated})") if option.deprecated
-          option.verify!(value) # Call the verify block for it too
+          option.verify!(@values[key]) # Call the verify block for it too
         else
           UI.user_error!("Could not find option '#{key}' in the list of available options: #{@available_options.collect(&:key).join(', ')}")
         end

data/lib/fastlane_core/itunes_transporter.rb

@@ -133,7 +133,7 @@ module FastlaneCore
 
   # Generates commands and executes the iTMSTransporter through the shell script it provides by the same name
   class ShellScriptTransporterExecutor < TransporterExecutor
-    def build_upload_command(username, password, source = "/tmp", team_id = "")
+    def build_upload_command(username, password, source = "/tmp")
       [
         '"' + Helper.transporter_path + '"',
         "-m upload",
@@ -142,21 +142,19 @@ module FastlaneCore
         "-f '#{source}'",
         ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
         "-t 'Signiant'",
-        "-k 100000",
-        ("-itc_provider #{team_id}" unless team_id.to_s.empty?)
-      ].compact.join(' ')
+        "-k 100000"
+      ].join(' ')
     end
 
-    def build_download_command(username, password, apple_id, destination = "/tmp", team_id = "")
+    def build_download_command(username, password, apple_id, destination = "/tmp")
       [
         '"' + Helper.transporter_path + '"',
         "-m lookupMetadata",
         "-u \"#{username}\"",
         "-p #{shell_escaped_password(password)}",
         "-apple_id #{apple_id}",
-        "-destination '#{destination}'",
-        ("-itc_provider #{team_id}" unless team_id.to_s.empty?)
-      ].compact.join(' ')
+        "-destination '#{destination}'"
+      ].join(' ')
     end
 
     def handle_error(password)
@@ -192,7 +190,7 @@ module FastlaneCore
   # Generates commands and executes the iTMSTransporter by invoking its Java app directly, to avoid the crazy parameter
   # escaping problems in its accompanying shell script.
   class JavaTransporterExecutor < TransporterExecutor
-    def build_upload_command(username, password, source = "/tmp", team_id = "")
+    def build_upload_command(username, password, source = "/tmp")
       [
         Helper.transporter_java_executable_path.shellescape,
         "-Djava.ext.dirs=#{Helper.transporter_java_ext_dir.shellescape}",
@@ -211,12 +209,11 @@ module FastlaneCore
         ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
         '-t Signiant',
         '-k 100000',
-        ("-itc_provider #{team_id}" unless team_id.to_s.empty?),
         '2>&1' # cause stderr to be written to stdout
       ].compact.join(' ') # compact gets rid of the possibly nil ENV value
     end
 
-    def build_download_command(username, password, apple_id, destination = "/tmp", team_id = "")
+    def build_download_command(username, password, apple_id, destination = "/tmp")
       [
         Helper.transporter_java_executable_path.shellescape,
         "-Djava.ext.dirs=#{Helper.transporter_java_ext_dir.shellescape}",
@@ -233,9 +230,8 @@ module FastlaneCore
         "-p #{password.shellescape}",
         "-apple_id #{apple_id.shellescape}",
         "-destination #{destination.shellescape}",
-        ("-itc_provider #{team_id}" unless team_id.to_s.empty?),
         '2>&1' # cause stderr to be written to stdout
-      ].compact.join(' ')
+      ].join(' ')
     end
 
     def handle_error(password)
@@ -274,10 +270,7 @@ module FastlaneCore
     # @param use_shell_script if true, forces use of the iTMSTransporter shell script.
     #                         if false, allows a direct call to the iTMSTransporter Java app (preferred).
     #                         see: https://github.com/fastlane/fastlane/pull/4003
-    # @param team_id Represents the developer team id (not the iTC id). If provided, will add the correct
-    #                flag to the upload command.
-    #                see: https://github.com/fastlane/fastlane/issues/1524
-    def initialize(user = nil, password = nil, use_shell_script = false, team_id = nil)
+    def initialize(user = nil, password = nil, use_shell_script = false)
       # Xcode 6.x doesn't have the same iTMSTransporter Java setup as later Xcode versions, so
       # we can't default to using the better direct Java invocation strategy for those versions.
       use_shell_script ||= Helper.is_mac? && Helper.xcode_version.start_with?('6.')
@@ -299,7 +292,6 @@ module FastlaneCore
       end
 
       @transporter_executor = use_shell_script ? ShellScriptTransporterExecutor.new : JavaTransporterExecutor.new
-      @team_id = team_id || (ENV['FASTLANE_TEAM_ID'] || '').strip
     end
 
     # Downloads the latest version of the app metadata package from iTC.
@@ -312,8 +304,8 @@ module FastlaneCore
       dir ||= "/tmp"
 
       UI.message("Going to download app metadata from iTunes Connect")
-      command = @transporter_executor.build_download_command(@user, @password, app_id, dir, @team_id)
-      UI.verbose(@transporter_executor.build_download_command(@user, 'YourPassword', app_id, dir, @team_id))
+      command = @transporter_executor.build_download_command(@user, @password, app_id, dir)
+      UI.verbose(@transporter_executor.build_download_command(@user, 'YourPassword', app_id, dir))
 
       begin
         result = @transporter_executor.execute(command, ItunesTransporter.hide_transporter_output?)
@@ -348,8 +340,8 @@ module FastlaneCore
       UI.message("Going to upload updated app to iTunes Connect")
       UI.success("This might take a few minutes, please don't interrupt the script")
 
-      command = @transporter_executor.build_upload_command(@user, @password, actual_dir, @team_id)
-      UI.verbose(@transporter_executor.build_upload_command(@user, 'YourPassword', actual_dir, @team_id))
+      command = @transporter_executor.build_upload_command(@user, @password, actual_dir)
+      UI.verbose(@transporter_executor.build_upload_command(@user, 'YourPassword', actual_dir))
 
       begin
         result = @transporter_executor.execute(command, ItunesTransporter.hide_transporter_output?)

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.46.0".freeze
+  VERSION = "0.46.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.46.0
+  version: 0.46.1
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-01 00:00:00.000000000 Z
+date: 2016-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -385,7 +385,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.0
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Contains all shared code/dependencies of the fastlane.tools