fastlane_core 0.37.0 → 0.38.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69d9a797fc7e20a98839ae7e0296d7215f95e08c
-  data.tar.gz: de39a88d7fd8c42a6d1988c291376d5eba49603f
+  metadata.gz: fd90b6bcd3c31ba350d8f5c98f1f124b69658a2f
+  data.tar.gz: 0989522b062f11d611db247372027624e56773f8
 SHA512:
-  metadata.gz: 44ece7894fb065c92ab2909d63d53760bb00386da1e836eeaa2ca74200363aa57170f5ba6790dbbe9d0cad4e7721426706e0a06728937e5c706daf6eba402ed9
-  data.tar.gz: 73a778016cf3e8dcb98a9bd4360c7b1a2b7891f1824718fca1c79d8fd08fdf92d269333b1c80791c2cc3db4c03ef2a7e1994487d47e1bd9df4f3ddff0b409ca1
+  metadata.gz: 4c5170391b985a73e8c2e63e6d6a71fe9844ca26a1643bdc3deb5b355702d136e287902dcfd5fa2a986973ac77c012453308c4632468eb4c836ffb5e7b057fea
+  data.tar.gz: 224ccc27980a142b2104b9c5d2faf8c2ec3283ef3a01aaf6403c495f0d4717d38b46f4321328ba319e01014eb3b11b3947c9cc9c6087cb6bfebceba09254ed35

data/README.md

@@ -1,24 +1,24 @@
 <h3 align="center">
-  <a href="https://github.com/fastlane/fastlane">
-    <img src="assets/fastlane.png" width="150" />
+  <a href="https://github.com/fastlane/fastlane/tree/master/fastlane">
+    <img src="../fastlane/assets/fastlane.png" width="150" />
     <br />
     fastlane
   </a>
 </h3>
 <p align="center">
-  <a href="https://github.com/fastlane/deliver">deliver</a> &bull; 
-  <a href="https://github.com/fastlane/snapshot">snapshot</a> &bull; 
-  <a href="https://github.com/fastlane/frameit">frameit</a> &bull; 
-  <a href="https://github.com/fastlane/pem">pem</a> &bull; 
-  <a href="https://github.com/fastlane/sigh">sigh</a> &bull; 
-  <a href="https://github.com/fastlane/produce">produce</a> &bull;
-  <a href="https://github.com/fastlane/cert">cert</a> &bull;
-  <a href="https://github.com/fastlane/spaceship">spaceship</a> &bull;
-  <a href="https://github.com/fastlane/pilot">pilot</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/deliver">deliver</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/snapshot">snapshot</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/frameit">frameit</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/pem">pem</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/sigh">sigh</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/produce">produce</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/cert">cert</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/spaceship">spaceship</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/pilot">pilot</a> &bull;
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
-  <a href="https://github.com/fastlane/gym">gym</a> &bull;
-  <a href="https://github.com/fastlane/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
 </p>
 -------
 
@@ -26,9 +26,9 @@ FastlaneCore
 ============
 
 [![Twitter: @FastlaneTools](https://img.shields.io/badge/contact-@FastlaneTools-blue.svg?style=flat)](https://twitter.com/FastlaneTools)
-[![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/fastlane/fastlane_core/blob/master/LICENSE)
+[![License](http://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/fastlane/fastlane/blob/master/fastlane_core/LICENSE)
 [![Gem](https://img.shields.io/gem/v/fastlane_core.svg?style=flat)](http://rubygems.org/gems/fastlane_core)
-[![Build Status](https://img.shields.io/travis/fastlane/fastlane_core/master.svg?style=flat)](https://travis-ci.org/fastlane/fastlane_core)
+[![Build Status](https://img.shields.io/circleci/project/fastlane/fastlane/master.svg?style=flat)](https://circleci.com/gh/fastlane/fastlane)
 
 All shared code of the fastlane tools is stored in this repository.
 
@@ -47,7 +47,7 @@ This gem contains all shared classes and code:
 You can hide the inline changelog by setting the `FASTLANE_HIDE_CHANGELOG` environment variable
 
 # Code of Conduct
-Help us keep `fastlane` open and inclusive. Please read and follow our [Code of Conduct](https://github.com/fastlane/code-of-conduct).
+Help us keep `fastlane` open and inclusive. Please read and follow our [Code of Conduct](https://github.com/fastlane/fastlane/blob/master/CODE_OF_CONDUCT.md).
 
 # License
 This project is licensed under the terms of the MIT license. See the LICENSE file.

data/lib/fastlane_core/cert_checker.rb

@@ -11,11 +11,9 @@ module FastlaneCore
     end
 
     # Legacy Method, use `installed?` instead
-    # rubocop:disable Style/PredicateName
     def self.is_installed?(path)
       installed?(path)
     end
-    # rubocop:enable Style/PredicateName
 
     def self.installed_identies
       install_wwdr_certificate unless wwdr_certificate_installed?

data/lib/fastlane_core/command_executor.rb

@@ -44,24 +44,27 @@ module FastlaneCore
 
         begin
           PTY.spawn(command) do |stdin, stdout, pid|
-            stdin.each do |l|
-              line = l.strip # strip so that \n gets removed
-              output << line
+            begin
+              stdin.each do |l|
+                line = l.strip # strip so that \n gets removed
+                output << line
 
-              next unless print_all
+                next unless print_all
 
-              # Prefix the current line with a string
-              prefix.each do |element|
-                line = element[:prefix] + line if element[:block] && element[:block].call(line)
-              end
+                # Prefix the current line with a string
+                prefix.each do |element|
+                  line = element[:prefix] + line if element[:block] && element[:block].call(line)
+                end
 
-              UI.command_output(line)
+                UI.command_output(line)
+              end
+            rescue Errno::EIO
+              # This is expected on some linux systems, that indicates that the subcommand finished
+              # and we kept trying to read, ignore ix
+            ensure
+              Process.wait(pid)
             end
-            Process.wait(pid)
           end
-        rescue Errno::EIO
-          # This is expected on some linux systems, that indicates that the subcommand finished
-          # and we kept trying to read, ignore it
         rescue => ex
           # This could happen when the environment is wrong:
           # > invalid byte sequence in US-ASCII (ArgumentError)

data/lib/fastlane_core/configuration/commander_generator.rb

@@ -51,12 +51,19 @@ module FastlaneCore
         description = option.description
         description += " (#{option.env_name})" unless option.env_name.to_s.empty?
 
-        # This is the sole call to Commander to set up the option we've been building.
+        # We compact this array here to remove the short_switch variable if it is nil.
+        # Passing a nil value to global_option has been shown to create problems with
+        # option parsing!
+        #
+        # See: https://github.com/fastlane/fastlane/tree/master/fastlane_core
         #
         # If we don't have a data type for this option, we tell it to act like a String.
         # This allows us to get a reasonable value for boolean options that can be
         # automatically coerced or otherwise handled by the ConfigItem for others.
-        global_option(short_switch, long_switch, (type || String), description)
+        args = [short_switch, long_switch, (type || String), description].compact
+
+        # This is the call to Commander to set up the option we've been building.
+        global_option(*args)
       end
     end
 

data/lib/fastlane_core/configuration/configuration_file.rb

@@ -36,7 +36,7 @@ module FastlaneCore
         return unless self.config._values[method_sym].to_s.empty?
 
         value = arguments.first
-        value = block.call if value.nil? && block_given?
+        value = yield if value.nil? && block_given?
 
         self.config[method_sym] = value unless value.nil?
       else

data/lib/fastlane_core/helper.rb

@@ -73,7 +73,6 @@ module FastlaneCore
     end
 
     # Use Helper.test? and Helper.ci? instead (legacy calls)
-    # rubocop:disable Style/PredicateName
     def self.is_test?
       self.test?
     end
@@ -85,7 +84,6 @@ module FastlaneCore
     def self.is_mac?
       self.mac?
     end
-    # rubocop:enable Style/PredicateName
 
     # Do we want to disable the colored output?
     def self.colors_disabled?

data/lib/fastlane_core/project.rb

@@ -14,7 +14,7 @@ module FastlaneCore
           workspace = Dir["./*.xcworkspace"]
           if workspace.count > 1
             puts "Select Workspace: "
-            config[:workspace] = choose(*(workspace))
+            config[:workspace] = choose(*workspace)
           elsif !workspace.first.nil?
             config[:workspace] = workspace.first
           end
@@ -26,7 +26,7 @@ module FastlaneCore
           project = Dir["./*.xcodeproj"]
           if project.count > 1
             puts "Select Project: "
-            config[:project] = choose(*(project))
+            config[:project] = choose(*project)
           elsif !project.first.nil?
             config[:project] = project.first
           end
@@ -126,7 +126,7 @@ module FastlaneCore
           raise "Multiple schemes found".red
         else
           puts "Select Scheme: "
-          options[:scheme] = choose(*(schemes))
+          options[:scheme] = choose(*schemes)
         end
       else
         Helper.log.error "Couldn't find any schemes in this project, make sure that the scheme is shared if you are using a workspace".red

data/lib/fastlane_core/simulator.rb

@@ -24,8 +24,8 @@ module FastlaneCore
         end
 
         output.split(/\n/).each do |line|
-          next if line.match(/^== /)
-          if line.match(/^-- /)
+          next if line =~ /^== /
+          if line =~ /^-- /
             (os_type, os_version) = line.gsub(/-- (.*) --/, '\1').split
           else
             # iPad 2 (0EDE6AFC-3767-425A-9658-AAA30A60F212) (Shutdown)

data/lib/fastlane_core/ui/fastlane_runner.rb

@@ -36,18 +36,41 @@ module Commander
         OptionParser::MissingArgument => e
         abort e.to_s
       rescue FastlaneCore::Interface::FastlaneError => e # user_error!
-        error_message = "\n[!] #{e}".red
-        if $verbose # with stack trace
-          raise e, "[!] #{e.message}".red, e.backtrace
-        else
-          abort error_message # without stack trace
-        end
+        display_user_error!(e, e.message)
       rescue => e # high chance this is actually FastlaneCore::Interface::FastlaneCrash, but can be anything else
+        handle_unknown_error!(e)
+      end
+    end
+
+    def handle_unknown_error!(e)
+      # Some spaceship exception classes implement #preferred_error_info in order to share error info
+      # that we'd rather display instead of crashing with a stack trace. However, fastlane_core and
+      # spaceship can not know about each other's classes! To make this information passing work, we
+      # use a bit of Ruby duck-typing to check whether the unknown exception type implements the right
+      # method. If so, we'll present any returned error info in the manner of a user_error!
+      error_info = e.respond_to?(:preferred_error_info) ? e.preferred_error_info : nil
+
+      if error_info
+        error_info = error_info.join("\n\t") if error_info.kind_of?(Array)
+        display_user_error!(e, error_info)
+      else
         FastlaneCore::CrashReporting.handle_crash(e)
         # From https://stackoverflow.com/a/4789702/445598
         # We do this to make the actual error message red and therefore more visible
-        raise e, "[!] #{e.message}".red, e.backtrace
+        reraise_formatted!(e, e.message)
       end
     end
+
+    def display_user_error!(e, message)
+      if $verbose # with stack trace
+        reraise_formatted!(e, message)
+      else
+        abort "\n[!] #{message}".red # without stack trace
+      end
+    end
+
+    def reraise_formatted!(e, message)
+      raise e, "[!] #{message}".red, e.backtrace
+    end
   end
 end

data/lib/fastlane_core/ui/implementations/shell.rb

@@ -93,7 +93,7 @@ module FastlaneCore
       verify_interactive!(message)
 
       important(message)
-      choose(*(options))
+      choose(*options)
     end
 
     def password(message)

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.37.0".freeze
+  VERSION = "0.38.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.37.0
+  version: 0.38.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-01 00:00:00.000000000 Z
+date: 2016-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -302,14 +302,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.35.1
+        version: 0.38.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.35.1
+        version: 0.38.0
 - !ruby/object:Gem::Dependency
   name: danger
   requirement: !ruby/object:Gem::Requirement
@@ -385,7 +385,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Contains all shared code/dependencies of the fastlane.tools