fastlane_core 0.22.3 → 0.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 441b4caf9f43629b1c8a325b968fd290654303c1
-  data.tar.gz: 811a5548a267f59c435fd709674aa64565b21d66
+  metadata.gz: f1ba9d9232242ae13d67b8a32b91d12aa0d1890d
+  data.tar.gz: 10deb2e04b0cadacc3c5f24f1a53e99fb60be0a5
 SHA512:
-  metadata.gz: f51d80154a0f1c7c0849c7ed7d1086634b432ce648cddc42aad15b25b27e32f3399ffb431398ea5c0e836010c4083c956046765eb720d32e018ed3a709fe231f
-  data.tar.gz: fec59c1f7475c054b1209bef3d4f9f72347baa2186740b69d180e3f4292a38d31d7d941c39059a356fe847eb9ac339dc3355753b776d02f5745a09b2a3254d06
+  metadata.gz: 055fffb2f956839bdf59129d3ea9b6ff0e36bc62f46442080a5b8db454f8c6e4e5ca671e86e63d9fa127e579e5ad22c6c5d00d64152b4e3d4fb261af8eb07ef8
+  data.tar.gz: 8c1132b2455d671470e2c0ff25e41d96dd000263ad2e7d0a5888651084f4e12e0d61a4f7dd432c546065157aebcc2917b43e636ff0858234f0d952ff9c9c4268

data/lib/fastlane_core.rb

@@ -14,6 +14,7 @@ require 'fastlane_core/ipa_upload_package_builder'
 require 'fastlane_core/print_table'
 require 'fastlane_core/project'
 require 'fastlane_core/simulator'
+require 'fastlane_core/crash_reporting/crash_reporting'
 
 # Third Party code
 require 'colored'

data/lib/fastlane_core/crash_reporting/clean_stack_trace.rb

@@ -0,0 +1,18 @@
+module Raven
+  # This class gets rid of the user folder, as we don't want to share the username
+  class Processor
+    class CleanStackTrace < Processor
+      def process(value)
+        if value[:exception]
+          value[:exception][:values].each do |single_exception|
+            single_exception[:stacktrace][:frames].each do |current|
+              current[:abs_path].gsub!(Dir.home, "~")
+            end
+          end
+        end
+
+        return value
+      end
+    end
+  end
+end

data/lib/fastlane_core/crash_reporting/crash_reporting.rb

@@ -0,0 +1,65 @@
+module FastlaneCore
+  class CrashReporting
+    URL = 'https://02c6a8be5bd4425389706655f3657f5c:de62aa2bffe643948ea6f81354adb8d6@app.getsentry.com/55281'
+    class << self
+      def file_path
+        File.expand_path(File.join('~/.fastlane_crash_reporting'))
+      end
+
+      def enable
+        File.write(file_path, "1")
+        puts "Successfully enabled crash reporting for future crashes".green
+        puts "This will only send the stack trace the installed gems to sentry".green
+        puts "Thanks for helping making fastlane better".green
+      end
+
+      def enabled?
+        File.exist?(file_path)
+      end
+
+      def show_message
+        puts "-------------------------------------------------------------------------------------------".yellow
+        puts "😨  An error occured. Please enable crash reports using `fastlane enable_crash_reporting`".yellow
+        puts "👍  This makes resolving issues much easier and helps improving fastlane".yellow
+        puts "🔒  The reports might contain personal data, but will be stored securely on getsentry.com".yellow
+        puts "✨  Once crash reporting is enabled, you have much cleaner output when something goes wrong".yellow
+        puts "-------------------------------------------------------------------------------------------".yellow
+      end
+
+      def handle_crash(ex)
+        unless enabled?
+          show_message
+          raise ex
+        end
+
+        raise ex if Helper.test?
+
+        send_crash(ex)
+      end
+
+      def send_crash(ex)
+        # https://github.com/getsentry/raven-ruby/wiki/Advanced-Configuration
+        require 'raven'
+        require 'json'
+        require 'fastlane_core/crash_reporting/clean_stack_trace'
+
+        Raven.configure do |config|
+          config.dsn = URL
+          config.logger = Logger.new('/dev/null') # we couldn't care less
+          config.sanitize_fields = %w(server_name)
+          config.processors << Raven::Processor::CleanStackTrace
+        end
+
+        Raven::Context.clear! # we don't want to transfer things like the host name
+        crash = Raven.capture_exception(ex)
+        path = "/tmp/sentry_#{crash.id}.json"
+        File.write(path, JSON.pretty_generate(crash.to_hash))
+        puts "Successfully submitted crash report. If this is a problem with one of the tools you want to report".yellow
+        puts "please submit an issue on GitHub and attach the following number to it: '#{crash.id}'".yellow
+        puts "Also stored the crash report locally '#{path}'".yellow
+      rescue => ex
+        Helper.log.debug ex # We don't want crash reporting to cause crash
+      end
+    end
+  end
+end

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.22.3"
+  VERSION = "0.23.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.22.3
+  version: 0.23.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-15 00:00:00.000000000 Z
+date: 2015-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -150,6 +150,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.4.5
+- !ruby/object:Gem::Dependency
+  name: sentry-raven
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.15'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: credentials_manager
   requirement: !ruby/object:Gem::Requirement
@@ -355,13 +369,11 @@ files:
 - lib/fastlane_core/configuration/config_item.rb
 - lib/fastlane_core/configuration/configuration.rb
 - lib/fastlane_core/configuration/configuration_file.rb
+- lib/fastlane_core/crash_reporting/clean_stack_trace.rb
+- lib/fastlane_core/crash_reporting/crash_reporting.rb
 - lib/fastlane_core/helper.rb
 - lib/fastlane_core/ipa_file_analyser.rb
 - lib/fastlane_core/ipa_upload_package_builder.rb
-- lib/fastlane_core/itunes_connect/itunes_connect.rb
-- lib/fastlane_core/itunes_connect/itunes_connect_apple_id.rb
-- lib/fastlane_core/itunes_connect/itunes_connect_helper.rb
-- lib/fastlane_core/itunes_connect/itunes_connect_login.rb
 - lib/fastlane_core/itunes_search_api.rb
 - lib/fastlane_core/itunes_transporter.rb
 - lib/fastlane_core/languages.rb
@@ -391,7 +403,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Contains all shared code/dependencies of the fastlane.tools

data/lib/fastlane_core/itunes_connect/itunes_connect.rb

@@ -1,64 +0,0 @@
-require 'capybara'
-require 'capybara/poltergeist'
-require 'credentials_manager/password_manager'
-require 'phantomjs/poltergeist' # this will download and store phantomjs
-
-require 'fastlane_core/itunes_connect/itunes_connect_helper.rb'
-require 'fastlane_core/itunes_connect/itunes_connect_login.rb'
-require 'fastlane_core/itunes_connect/itunes_connect_apple_id.rb'
-
-module FastlaneCore
-  # Everything that can't be achived using the {FastlaneCore::ItunesTransporter}
-  # will be scripted using the iTunesConnect frontend.
-  #
-  # Every method you call here, might take a time
-  class ItunesConnect
-    # This error occurs only if there is something wrong with the given login data
-    class ItunesConnectLoginError < StandardError
-    end
-
-    # This error can occur for many reaons. It is
-    # usually raised when an UI element could not be found
-    class ItunesConnectGeneralError < StandardError
-    end
-
-    include Capybara::DSL
-
-    ITUNESCONNECT_URL = "https://itunesconnect.apple.com/"
-    APP_DETAILS_URL = "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/ng/app/[[app_id]]"
-
-    BUTTON_STRING_NEW_VERSION = "New Version"
-    BUTTON_STRING_SUBMIT_FOR_REVIEW = "Submit for Review"
-
-    WAITING_FOR_REVIEW = "Waiting For Review"
-
-    def initialize
-      super
-
-      return if Helper.is_test?
-
-      Capybara.run_server = false
-      Capybara.default_driver = :poltergeist
-      Capybara.javascript_driver = :poltergeist
-      Capybara.current_driver = :poltergeist
-      Capybara.app_host = ITUNESCONNECT_URL
-
-      # Since Apple has some SSL errors, we have to configure the client properly:
-      # https://github.com/ariya/phantomjs/issues/11239
-      Capybara.register_driver :poltergeist do |a|
-        conf = ['--debug=no', '--ignore-ssl-errors=yes', '--ssl-protocol=TLSv1']
-        Capybara::Poltergeist::Driver.new(a, {
-          phantomjs: Phantomjs.path,
-          phantomjs_options: conf,
-          phantomjs_logger: File.open("/tmp/poltergeist_log.txt", "a"),
-          js_errors: false,
-          timeout: 90
-        })
-      end
-
-      page.driver.headers = { "Accept-Language" => "en" }
-
-      login
-    end
-  end
-end

data/lib/fastlane_core/itunes_connect/itunes_connect_apple_id.rb

@@ -1,15 +0,0 @@
-module FastlaneCore
-  # Find the Apple ID based on the App Identifier
-  class ItunesConnect
-    LIST_APPLE_IDS_URL = "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/manageyourapps/summary"
-    def find_apple_id(app_identifier)
-      login
-
-      apps = JSON.parse(page.evaluate_script("$.ajax({type: 'GET', url: '#{LIST_APPLE_IDS_URL}', async: false})")['responseText'])['data']
-
-      return apps['summaries'].find { |v| v['bundleId'] == app_identifier }['adamId'].to_i
-    rescue => ex
-      # Do nothing right now...
-    end
-  end
-end

data/lib/fastlane_core/itunes_connect/itunes_connect_helper.rb

@@ -1,85 +0,0 @@
-module FastlaneCore
-  class ItunesConnect
-    # All the private helpers
-
-    private
-
-      # Opens the app details page of the given app.
-      # @param app (Deliver::App) the app that should be opened
-      # @return (bool) true if everything worked fine
-      # @raise [ItunesConnectGeneralError] General error while executing
-      #  this action
-      # @raise [ItunesConnectLoginError] Login data is wrong
-      def open_app_page(app)
-        verify_app(app)
-
-        Helper.log.info "Opening detail page for app #{app}"
-
-        visit APP_DETAILS_URL.gsub("[[app_id]]", app.apple_id.to_s)
-
-        wait_for_elements('.page-subnav')
-        sleep 5
-
-        if current_url.include? "wa/defaultError" # app could not be found
-          raise "Could not open app details for app '#{app}'. Make sure you're using the correct Apple ID and the correct Apple developer account (#{CredentialsManager::PasswordManager.shared_manager.username}).".red
-        end
-
-        true
-      rescue => ex
-        error_occured(ex)
-      end
-
-      def verify_app(app)
-        raise ItunesConnectGeneralError.new("No valid Deliver::App given") unless app.kind_of? Deliver::App
-        raise ItunesConnectGeneralError.new("App is missing information (apple_id not given)") unless (app.apple_id || '').to_s.length > 5
-      end
-
-      def error_occured(ex)
-        snap
-        raise ex # re-raise the error after saving the snapshot
-      end
-
-      def snap
-        path = File.expand_path("Error#{Time.now.to_i}.png")
-        # rubocop:disable Lint/Debugger
-        save_screenshot(path, full: true)
-        # rubocop:enable Lint/Debugger
-        system("open '#{path}'") unless ENV['SIGH_DISABLE_OPEN_ERROR']
-      end
-
-      # Since Apple takes for ages, after the upload is properly processed, we have to wait here
-      def wait_for_preprocessing
-        started = Time.now
-
-        # Wait, while iTunesConnect is processing the uploaded file
-        while page.has_content? "Uploaded"
-          # iTunesConnect is super slow... so we have to wait...
-          Helper.log.info("Sorry, we have to wait for iTunesConnect, since it's still processing the uploaded ipa file\n" \
-            "If this takes longer than 45 minutes, you have to re-upload the ipa file again.\n" \
-            "You can always open the browser page yourself: '#{current_url}'\n" \
-            "Passed time: ~#{((Time.now - started) / 60.0).to_i} minute(s)")
-          sleep 30
-          visit current_url
-          sleep 30
-        end
-      end
-
-      def wait_for_elements(name)
-        counter = 0
-        results = all(name)
-        while results.count == 0
-          # Helper.log.debug "Waiting for #{name}"
-          sleep 0.2
-
-          results = all(name)
-
-          counter += 1
-          if counter > 100
-            Helper.log.debug caller
-            raise ItunesConnectGeneralError.new("Couldn't find element '#{name}' after waiting for quite some time")
-          end
-        end
-        return results
-      end
-  end
-end

data/lib/fastlane_core/itunes_connect/itunes_connect_login.rb

@@ -1,65 +0,0 @@
-module FastlaneCore
-  # Login code
-  class ItunesConnect
-    # Loggs in a user with the given login data on the iTC Frontend.
-    # You don't need to pass a username and password. It will
-    # Automatically be fetched using the {CredentialsManager::PasswordManager}.
-    # This method will also automatically be called when triggering other
-    # actions like {#open_app_page}
-    # @param user (String) (optional) The username/email address
-    # @param password (String) (optional) The password
-    # @return (bool) true if everything worked fine
-    # @raise [ItunesConnectGeneralError] General error while executing
-    #  this action
-    # @raise [ItunesConnectLoginError] Login data is wrong
-    def login(user = nil, password = nil)
-      Helper.log.info "Logging into iTunesConnect"
-
-      user ||= CredentialsManager::PasswordManager.shared_manager.username
-      password ||= CredentialsManager::PasswordManager.shared_manager.password
-
-      result = visit ITUNESCONNECT_URL
-      raise "Could not open iTunesConnect" unless result['status'] == 'success'
-
-      sleep 3
-
-      if page.has_content? "My Apps"
-        # Already logged in
-        return true
-      end
-
-      begin
-        wait_for_elements('#accountpassword')
-      rescue
-        # when the user is already logged in, this will raise an exception
-      end
-
-      fill_in "accountname", with: user
-      fill_in "accountpassword", with: password
-
-      begin
-        page.evaluate_script "appleConnectForm.submit()"
-        sleep 7
-
-        if page.has_content? "My Apps"
-          # Everything looks good
-        else
-          visit current_url # iTC sometimes is super buggy, try reloading the site
-          sleep 3
-          unless page.has_content? "My Apps"
-            raise ItunesConnectLoginError.new("Looks like your login data was correct, but you do not have access to the apps.".red)
-          end
-        end
-      rescue => ex
-        Helper.log.debug(ex)
-        raise ItunesConnectLoginError.new("Error logging in user #{user} with the given password. Make sure you entered them correctly.".red)
-      end
-
-      Helper.log.info "Successfully logged into iTunesConnect"
-
-      true
-    rescue => ex
-      error_occured(ex)
-    end
-  end
-end