fastlane 2.79.0.beta.20180124010003 → 2.79.0.beta.20180125010002

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 579b61a800e044e85c68ad8e8f2e530f0b134c0a
-  data.tar.gz: fc82399a894d4d8f3cb0bbe8c56a7dc6991e251e
+  metadata.gz: 11e6756a9c895869f254e318c69c43ed3baaa59e
+  data.tar.gz: 8055f34b7f3e1867796fb9b3c7f843f7357d5b60
 SHA512:
-  metadata.gz: d8629c6772657921a0f464128416520994af79754ba2c79d6fb1fd79382149971c37bb4c7a6593f44070cc124138a60dbf9ee7c0b126069d906e02c11ee3890c
-  data.tar.gz: a8a726bd15f676bba4a319d6804377958bc78162a76ff909baf7f32e8d6af29891f06c4ee5368b60a59c0666985b90064a522efa422ef13a2b4d3b823e26e72c
+  metadata.gz: 9a5e32e2274caace14cb5077d37800c5127ed8387d9c02f49692b2153c7fdd4ec84fb4e64d97d93ea2f8f3114de16d048eae3550e824afc130c6a487f00e81c1
+  data.tar.gz: 7533072ceaa9eacb2008edcfc70703bb9c4a3e67adfead9d3d5655a8bc258285d79a51675987d37c841ce240a7b4b46e12a3823f89838ed33e3034cf338ce1cb

data/credentials_manager/lib/credentials_manager/appfile_config.rb

@@ -32,7 +32,7 @@ module CredentialsManager
       if path and File.exist?(path) # it might not exist, we still want to use the default values
         full_path = File.expand_path(path)
         Dir.chdir(File.expand_path('..', path)) do
-          content = File.read(full_path)
+          content = File.read(full_path, encoding: "utf-8")
 
           # From https://github.com/orta/danger/blob/master/lib/danger/danger_core/dangerfile.rb
           if content.tr!('“”‘’‛', %(""'''))

data/deliver/lib/deliver/loader.rb

@@ -22,7 +22,7 @@ module Deliver
     def self.language_folders(root, ignore_validation)
       folders = Dir.glob(File.join(root, '*'))
 
-      if Helper.is_test?
+      if Helper.test?
         available_languages = FastlaneCore::Languages::ALL_LANGUAGES
       else
         available_languages = Spaceship::Tunes.client.available_languages.sort

data/fastlane/lib/fastlane/actions/apteligent.rb

@@ -11,7 +11,7 @@ module Fastlane
         # will reanable it when it is fixed
         # result = Fastlane::Actions.sh(command.join(' '), log: false)
         shell_command = command.join(' ')
-        return shell_command if Helper.is_test?
+        return shell_command if Helper.test?
         result = Actions.sh(shell_command)
         fail_on_error(result)
       end

data/fastlane/lib/fastlane/actions/ensure_no_debug_code.rb

@@ -28,7 +28,7 @@ module Fastlane
           end
         end
 
-        return command if Helper.is_test?
+        return command if Helper.test?
 
         UI.important(command)
         results = `#{command}` # we don't use `sh` as the return code of grep is wrong for some reason

data/fastlane/lib/fastlane/actions/get_build_number.rb

@@ -61,7 +61,7 @@ module Fastlane
                              optional: true,
                              verify_block: proc do |value|
                                UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
-                               UI.user_error!("Could not find Xcode project") if !File.exist?(value) and !Helper.is_test?
+                               UI.user_error!("Could not find Xcode project") if !File.exist?(value) and !Helper.test?
                              end),
           FastlaneCore::ConfigItem.new(key: :hide_error_when_versioning_disabled,
                              env_name: "FL_BUILD_NUMBER_HIDE_ERROR_WHEN_VERSIONING_DISABLED",

data/fastlane/lib/fastlane/actions/get_push_certificate.rb

@@ -10,7 +10,7 @@ module Fastlane
 
         PEM.config = params
 
-        if Helper.is_test?
+        if Helper.test?
           profile_path = './test.pem'
         else
           profile_path = PEM::Manager.start

data/fastlane/lib/fastlane/actions/get_version_number.rb

@@ -113,7 +113,7 @@ module Fastlane
                              optional: true,
                              verify_block: proc do |value|
                                UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
-                               UI.user_error!("Could not find Xcode project at path '#{File.expand_path(value)}'") if !File.exist?(value) and !Helper.is_test?
+                               UI.user_error!("Could not find Xcode project at path '#{File.expand_path(value)}'") if !File.exist?(value) and !Helper.test?
                              end),
           FastlaneCore::ConfigItem.new(key: :scheme,
                              env_name: "FL_VERSION_NUMBER_SCHEME",

data/fastlane/lib/fastlane/actions/hg_add_tag.rb

@@ -8,7 +8,7 @@ module Fastlane
         UI.message("Adding mercurial tag '#{tag}' 🎯.")
 
         command = "hg tag \"#{tag}\""
-        return command if Helper.is_test?
+        return command if Helper.test?
 
         Actions.sh(command)
       end

data/fastlane/lib/fastlane/actions/hg_commit_version_bump.rb

@@ -10,17 +10,17 @@ module Fastlane
 
         xcodeproj_path = params[:xcodeproj] ? File.expand_path(File.join('.', params[:xcodeproj])) : nil
 
-        if Helper.is_test?
+        if Helper.test?
           xcodeproj_path = "/tmp/Test.xcodeproj"
         end
 
         # get the repo root path
-        repo_path = Helper.is_test? ? '/tmp/repo' : Actions.sh('hg root').strip
+        repo_path = Helper.test? ? '/tmp/repo' : Actions.sh('hg root').strip
         repo_pathname = Pathname.new(repo_path)
 
         if xcodeproj_path
           # ensure that the xcodeproj passed in was OK
-          unless Helper.is_test?
+          unless Helper.test?
             UI.user_error!("Could not find the specified xcodeproj: #{xcodeproj_path}") unless File.directory?(xcodeproj_path)
           end
         else
@@ -42,7 +42,7 @@ module Fastlane
         end
 
         # find the pbxproj path, relative to hg directory
-        if Helper.is_test?
+        if Helper.test?
           hg_dirty_files = params[:test_dirty_files].split(",")
           expected_changed_files = params[:test_expected_files].split(",")
         else
@@ -94,7 +94,7 @@ module Fastlane
 
         # create a commit with a message
         command = "hg commit -m '#{params[:message]}'"
-        return command if Helper.is_test?
+        return command if Helper.test?
         begin
           Actions.sh(command)
 

data/fastlane/lib/fastlane/actions/hg_push.rb

@@ -8,7 +8,7 @@ module Fastlane
         command << '--force' if params[:force]
         command << params[:destination] unless params[:destination].empty?
 
-        return command.join(' ') if Helper.is_test?
+        return command.join(' ') if Helper.test?
 
         Actions.sh(command.join(' '))
         UI.success('Successfully pushed changes to remote 🚀.')

data/fastlane/lib/fastlane/actions/increment_build_number.rb

@@ -74,7 +74,7 @@ module Fastlane
                                        optional: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
-                                         UI.user_error!("Could not find Xcode project") if !File.exist?(value) and !Helper.is_test?
+                                         UI.user_error!("Could not find Xcode project") if !File.exist?(value) and !Helper.test?
                                        end)
         ]
       end

data/fastlane/lib/fastlane/actions/is_ci.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class IsCiAction < Action
       def self.run(params)
-        Helper.is_ci?
+        Helper.ci?
       end
 
       #####################################################

data/fastlane/lib/fastlane/actions/make_changelog_from_jenkins.rb

@@ -7,7 +7,7 @@ module Fastlane
 
         changelog = ""
 
-        if Helper.is_ci? || Helper.is_test?
+        if Helper.ci? || Helper.test?
           # The "BUILD_URL" environment variable is set automatically by Jenkins in every build
           jenkins_api_url = URI(ENV["BUILD_URL"] + "api/json\?wrapper\=changes\&xpath\=//changeSet//comment")
           begin

data/fastlane/lib/fastlane/actions/push_to_git_remote.rb

@@ -25,7 +25,7 @@ module Fastlane
 
         # execute our command
         Actions.sh('pwd')
-        return command.join(' ') if Helper.is_test?
+        return command.join(' ') if Helper.test?
 
         Actions.sh(command.join(' '))
         UI.message('Successfully pushed to remote.')

data/fastlane/lib/fastlane/actions/reset_git_repo.rb

@@ -8,7 +8,7 @@ module Fastlane
         if params[:force] || Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START]
           paths = params[:files]
 
-          return paths if Helper.is_test?
+          return paths if Helper.test?
 
           if paths.nil?
             Actions.sh('git reset --hard HEAD')

data/fastlane/lib/fastlane/actions/set_build_number_repository.rb

@@ -50,7 +50,7 @@ module Fastlane
                                        verify_block: proc do |value|
                                          path = File.expand_path(value)
                                          UI.user_error!("Please pass the path to the project, not the workspace") if path.end_with?(".xcworkspace")
-                                         UI.user_error!("Could not find Xcode project at #{path}") unless Helper.is_test? || File.exist?(path)
+                                         UI.user_error!("Could not find Xcode project at #{path}") unless Helper.test? || File.exist?(path)
                                        end)
         ]
       end

data/fastlane/lib/fastlane/actions/setup_circle_ci.rb

@@ -49,7 +49,7 @@ module Fastlane
       end
 
       def self.should_run?(params)
-        Helper.is_ci? || params[:force]
+        Helper.ci? || params[:force]
       end
 
       #####################################################

data/fastlane/lib/fastlane/actions/setup_jenkins.rb

@@ -19,7 +19,7 @@ module Fastlane
 
       def self.run(params)
         # Stop if not executed by CI
-        if !Helper.is_ci? && !params[:force]
+        if !Helper.ci? && !params[:force]
           UI.important("Not executed by Continuous Integration system.")
           return
         end

data/fastlane/lib/fastlane/actions/setup_travis.rb

@@ -3,7 +3,7 @@ module Fastlane
     class SetupTravisAction < Action
       def self.run(params)
         # Stop if not executed by CI
-        if !Helper.is_ci? && !params[:force]
+        if !Helper.ci? && !params[:force]
           UI.message("Currently not running on CI system, skipping travis setup")
           return
         end

data/fastlane/lib/fastlane/actions/slack.rb

@@ -37,7 +37,7 @@ module Fastlane
 
         slack_attachment = generate_slack_attachments(options)
 
-        return [notifier, slack_attachment] if Helper.is_test? # tests will verify the slack attachments and other properties
+        return [notifier, slack_attachment] if Helper.test? # tests will verify the slack attachments and other properties
 
         begin
           results = notifier.ping('', icon_url: icon_url, attachments: [slack_attachment])

data/fastlane/lib/fastlane/actions/splunkmint.rb

@@ -14,7 +14,7 @@ module Fastlane
         # will reanable it when it is fixed
         # result = Fastlane::Actions.sh(command.join(' '), log: false)
         shell_command = command.join(' ')
-        result = Helper.is_test? ? shell_command : `#{shell_command}`
+        result = Helper.test? ? shell_command : `#{shell_command}`
         fail_on_error(result)
 
         result

data/fastlane/lib/fastlane/actions/update_app_group_identifiers.rb

@@ -48,7 +48,7 @@ module Fastlane
                                        description: "The path to the entitlement file which contains the app group identifiers", # a short description of this parameter
                                        verify_block: proc do |value|
                                          UI.user_error!("Please pass a path to an entitlements file. ") unless value.include?(".entitlements")
-                                         UI.user_error!("Could not find entitlements file") if !File.exist?(value) and !Helper.is_test?
+                                         UI.user_error!("Could not find entitlements file") if !File.exist?(value) and !Helper.test?
                                        end),
           FastlaneCore::ConfigItem.new(key: :app_group_identifiers,
                                        env_name: "FL_UPDATE_APP_GROUP_IDENTIFIER_APP_GROUP_IDENTIFIERS",

data/fastlane/lib/fastlane/actions/update_icloud_container_identifiers.rb

@@ -56,7 +56,7 @@ module Fastlane
                                        description: "The path to the entitlement file which contains the iCloud container identifiers",
                                        verify_block: proc do |value|
                                          UI.user_error!("Please pass a path to an entitlements file. ") unless value.include?(".entitlements")
-                                         UI.user_error!("Could not find entitlements file") if !File.exist?(value) and !Helper.is_test?
+                                         UI.user_error!("Could not find entitlements file") if !File.exist?(value) and !Helper.test?
                                        end),
           FastlaneCore::ConfigItem.new(key: :icloud_container_identifiers,
                                        env_name: "FL_UPDATE_ICLOUD_CONTAINER_IDENTIFIERS_IDENTIFIERS",

data/fastlane/lib/fastlane/command_line_handler.rb

@@ -26,7 +26,7 @@ module Fastlane
         lane = platform_lane_info[0]
       end
 
-      dot_env = Helper.is_test? ? nil : options.env
+      dot_env = Helper.test? ? nil : options.env
 
       if FastlaneCore::FastlaneFolder.swift?
         disable_runner_upgrades = options.disable_runner_upgrades || false

data/fastlane/lib/fastlane/commands_generator.rb

@@ -56,7 +56,7 @@ module Fastlane
     end
 
     def self.confirm_troubleshoot
-      if Helper.is_ci?
+      if Helper.ci?
         UI.error("---")
         UI.error("You are trying to use '--troubleshoot' on CI")
         UI.error("this option is not usable in CI, as it is insecure")

data/fastlane/lib/fastlane/configuration_helper.rb

@@ -7,7 +7,7 @@ module Fastlane
         # default use case
         return FastlaneCore::Configuration.create(action.available_options, params)
       elsif first_element
-        UI.error("Old configuration format for action '#{action}'") if Helper.is_test?
+        UI.error("Old configuration format for action '#{action}'") if Helper.test?
         return params
       else
 

data/fastlane/lib/fastlane/environment_printer.rb

@@ -258,7 +258,7 @@ module Fastlane
         env_output << "<summary>`#{fastlane_path}`</summary>\n"
         env_output << "\n"
         env_output << "```ruby\n"
-        env_output <<  File.read(fastlane_path)
+        env_output <<  File.read(fastlane_path, encoding: "utf-8")
         env_output <<  "\n```\n"
         env_output << "</details>"
       else
@@ -272,7 +272,7 @@ module Fastlane
         env_output << "<summary>`#{appfile_path}`</summary>\n"
         env_output << "\n"
         env_output << "```ruby\n"
-        env_output <<  File.read(appfile_path)
+        env_output <<  File.read(appfile_path, encoding: "utf-8")
         env_output <<  "\n```\n"
         env_output << "</details>"
       else

data/fastlane/lib/fastlane/fast_file.rb

@@ -16,7 +16,7 @@ module Fastlane
       return unless (path || '').length > 0
       UI.user_error!("Could not find Fastfile at path '#{path}'") unless File.exist?(path)
       @path = File.expand_path(path)
-      content = File.read(path)
+      content = File.read(path, encoding: "utf-8")
 
       # From https://github.com/orta/danger/blob/master/lib/danger/Dangerfile.rb
       if content.tr!('“”‘’‛', %(""'''))

data/fastlane/lib/fastlane/helper/gem_helper.rb

@@ -18,7 +18,7 @@ module Fastlane
         UI.important("  gem '#{gem_name}'")
         UI.error("and run `bundle install`")
 
-        UI.user_error!("You have to install the `#{gem_name}` gem on this machine") unless Helper.is_test?
+        UI.user_error!("You have to install the `#{gem_name}` gem on this machine") unless Helper.test?
       end
       true
     end

data/fastlane/lib/fastlane/setup/setup.rb

@@ -34,7 +34,7 @@ module Fastlane
     # Start the setup process
     # rubocop:disable Metrics/BlockNesting
     def self.start(user: nil, is_swift_fastfile: false)
-      if FastlaneCore::FastlaneFolder.setup? and !Helper.is_test?
+      if FastlaneCore::FastlaneFolder.setup? and !Helper.test?
         require 'fastlane/lane_list'
         Fastlane::LaneList.output(FastlaneCore::FastlaneFolder.fastfile_path)
         UI.important("------------------")

data/fastlane/lib/fastlane/swift_lane_manager.rb

@@ -26,7 +26,7 @@ module Fastlane
         display_upgraded_message = false
         if disable_runner_upgrades
           UI.verbose("disable_runner_upgrades is true, not attempting to update the FastlaneRunner project".yellow)
-        elsif Helper.is_ci?
+        elsif Helper.ci?
           UI.verbose("Running in CI, not attempting to update the FastlaneRunner project".yellow)
         else
           display_upgraded_message = self.ensure_runner_up_to_date_fastlane!

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.79.0.beta.20180124010003'.freeze
+  VERSION = '2.79.0.beta.20180125010002'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core.rb

@@ -39,6 +39,7 @@ require_relative 'fastlane_core/analytics/analytics_event_builder'
 require_relative 'fastlane_core/analytics/analytics_ingester_client'
 require_relative 'fastlane_core/analytics/analytics_session'
 require_relative 'fastlane_core/tag_version'
+require_relative 'fastlane_core/fastlane_pty'
 
 # Third Party code
 require 'colored'

data/fastlane_core/lib/fastlane_core/analytics/analytics_session.rb

@@ -190,7 +190,7 @@ module FastlaneCore
     end
 
     def ci?
-      return Helper.is_ci?
+      return Helper.ci?
     end
 
     def operating_system_version

data/fastlane_core/lib/fastlane_core/command_executor.rb

@@ -1,5 +1,6 @@
 require_relative 'ui/ui'
 require_relative 'globals'
+require_relative 'fastlane_pty'
 
 module FastlaneCore
   # Executes commands and takes care of error handling and more
@@ -19,7 +20,7 @@ module FastlaneCore
         ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
           exts.each do |ext|
             cmd_path = File.join(path, "#{cmd}#{ext}")
-            return cmd_path if File.executable?(cmd_path) && !File.directory?(cmd_path)
+            return cmd_path if Helper.executable?(cmd_path)
           end
         end
 
@@ -46,8 +47,7 @@ module FastlaneCore
         end
 
         begin
-          require 'pty'
-          PTY.spawn(command) do |stdin, stdout, pid|
+          FastlaneCore::FastlanePty.spawn(command) do |stdin, stdout, pid|
             begin
               stdin.each do |l|
                 line = l.strip # strip so that \n gets removed

data/fastlane_core/lib/fastlane_core/configuration/configuration.rb

@@ -198,7 +198,7 @@ module FastlaneCore
       paths += Dir["./fastlane/#{config_file_name}"]
       paths += Dir["./.fastlane/#{config_file_name}"]
       paths += Dir["./#{config_file_name}"]
-      paths += Dir["./fastlane_core/spec/fixtures/#{config_file_name}"] if Helper.is_test?
+      paths += Dir["./fastlane_core/spec/fixtures/#{config_file_name}"] if Helper.test?
       return nil if paths.count == 0
       return paths.first
     end
@@ -231,7 +231,7 @@ module FastlaneCore
       return value unless value.nil? and !option.optional and ask
 
       # fallback to asking
-      if Helper.is_test? or !UI.interactive?
+      if Helper.test? or !UI.interactive?
         # Since we don't want to be asked on tests, we'll just call the verify block with no value
         # to raise the exception that is shown when the user passes an invalid value
         set(key, '')

data/fastlane_core/lib/fastlane_core/configuration/configuration_file.rb

@@ -31,7 +31,7 @@ module FastlaneCore
       self.options = {}
 
       @block_for_missing = block_for_missing
-      content = File.read(path)
+      content = File.read(path, encoding: "utf-8")
 
       # From https://github.com/orta/danger/blob/master/lib/danger/Dangerfile.rb
       if content.tr!('“”‘’‛', %(""'''))

data/fastlane_core/lib/fastlane_core/fastlane_pty.rb

@@ -0,0 +1,22 @@
+# Source: Mix of https://github.com/fastlane/fastlane/pull/7202/files,
+# https://github.com/fastlane/fastlane/pull/11384#issuecomment-356084518 and
+# https://github.com/DragonBox/u3d/blob/59e471ad78ac00cb629f479dbe386c5ad2dc5075/lib/u3d_core/command_runner.rb#L88-L96
+module FastlaneCore
+  class FastlanePty
+    def self.spawn(*command, &block)
+      require 'pty'
+      PTY.spawn(command) do |stdout, stdin, pid|
+        block.call(stdin, stdout, pid)
+      end
+    rescue LoadError
+      require 'open3'
+      Open3.popen2e(command) do |r, w, p|
+        yield(w, r, p.value.pid) # note the inversion
+
+        r.close
+        w.close
+        p.value.exitstatus
+      end
+    end
+  end
+end

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -9,48 +9,21 @@ require_relative 'env'
 
 module FastlaneCore
   module Helper
-    # This method is deprecated, use the `UI` class
-    # https://docs.fastlane.tools/advanced/#user-input-and-output
-    def self.log
-      UI.deprecated("Helper.log is deprecated. Use `UI` class instead")
-      UI.current.log
-    end
-
-    # Runs a given command using backticks (`)
-    # and prints them out using the UI.command method
-    def self.backticks(command, print: true)
-      UI.command(command) if print
-      result = `#{command}`
-      UI.command_output(result) if print
-      return result
-    end
-
-    # @return true if the currently running program is a unit test
-    def self.test?
-      Object.const_defined?("SpecHelper")
-    end
+    # fastlane
+    #
 
-    # @return true if it is enabled to execute external commands
-    def self.sh_enabled?
-      !self.test?
+    def self.fastlane_enabled?
+      # This is called from the root context on the first start
+      @enabled ||= !FastlaneCore::FastlaneFolder.path.nil?
     end
 
-    # removes ANSI colors from string
-    def self.strip_ansi_colors(str)
-      str.gsub(/\e\[([;\d]+)?m/, '')
+    # Checks if fastlane is enabled for this project and returns the folder where the configuration lives
+    def self.fastlane_enabled_folder_path
+      fastlane_enabled? ? FastlaneCore::FastlaneFolder.path : '.'
     end
 
-    # checks if given file is a valid json file
-    # base taken from: http://stackoverflow.com/a/26235831/1945875
-    def self.json_file?(filename)
-      return false unless File.exist?(filename)
-      begin
-        JSON.parse(File.read(filename))
-        return true
-      rescue JSON::ParserError
-        return false
-      end
-    end
+    # fastlane installation method
+    #
 
     # @return [boolean] true if executing with bundler (like 'bundle exec fastlane [action]')
     def self.bundler?
@@ -83,6 +56,19 @@ module FastlaneCore
       !self.bundler? && !self.contained_fastlane? && !self.homebrew? && !self.mac_app?
     end
 
+    # environment
+    #
+
+    # @return true if the currently running program is a unit test
+    def self.test?
+      Object.const_defined?("SpecHelper")
+    end
+
+    # @return true if it is enabled to execute external commands
+    def self.sh_enabled?
+      !self.test?
+    end
+
     # @return [boolean] true if building in a known CI environment
     def self.ci?
       # Check for Jenkins, Travis CI, ... environment variables
@@ -113,23 +99,6 @@ module FastlaneCore
       (/darwin/ =~ RUBY_PLATFORM) != nil
     end
 
-    # Use Helper.test? and Helper.ci? instead (legacy calls)
-    def self.is_test?
-      self.test?
-    end
-
-    def self.is_ci?
-      ci?
-    end
-
-    def self.is_mac?
-      self.mac?
-    end
-
-    def self.is_windows?
-      self.windows?
-    end
-
     # Do we want to disable the colored output?
     def self.colors_disabled?
       FastlaneCore::Env.truthy?("FASTLANE_DISABLE_COLORS")
@@ -145,13 +114,13 @@ module FastlaneCore
       return ENV["FL_BUILDLOG_PATH"] || "~/Library/Logs"
     end
 
-    # All Xcode Related things
+    # Xcode
     #
 
     # @return the full path to the Xcode developer tools of the currently
     #  running system
     def self.xcode_path
-      return "" unless self.is_mac?
+      return "" unless self.mac?
 
       if self.xcode_server?
         # Xcode server always creates a link here
@@ -170,7 +139,7 @@ module FastlaneCore
 
     # @return The version of the currently used Xcode installation (e.g. "7.0")
     def self.xcode_version
-      return nil unless self.is_mac?
+      return nil unless self.mac?
       return @xcode_version if @xcode_version && @developer_dir == ENV['DEVELOPER_DIR']
 
       xcodebuild_path = "#{xcode_path}/usr/bin/xcodebuild"
@@ -199,6 +168,9 @@ module FastlaneCore
       Gem::Version.new(v) >= Gem::Version.new(version)
     end
 
+    # iTMSTransporter
+    #
+
     def self.transporter_java_executable_path
       return File.join(self.transporter_java_path, 'bin', 'java')
     end
@@ -224,6 +196,24 @@ module FastlaneCore
       return File.join(self.itms_path, 'bin', 'iTMSTransporter')
     end
 
+    # @return the full path to the iTMSTransporter executable
+    def self.itms_path
+      return ENV["FASTLANE_ITUNES_TRANSPORTER_PATH"] if FastlaneCore::Env.truthy?("FASTLANE_ITUNES_TRANSPORTER_PATH")
+      return '' unless self.mac? # so tests work on Linux and Windows too
+
+      [
+        "../Applications/Application Loader.app/Contents/MacOS/itms",
+        "../Applications/Application Loader.app/Contents/itms"
+      ].each do |path|
+        result = File.expand_path(File.join(self.xcode_path, path))
+        return result if File.exist?(result)
+      end
+      UI.user_error!("Could not find transporter at #{self.xcode_path}. Please make sure you set the correct path to your Xcode installation.")
+    end
+
+    # keychain
+    #
+
     def self.keychain_path(keychain_name)
       # Existing code expects that a keychain name will be expanded into a default path to Library/Keychains
       # in the user's home directory. However, this will not allow the user to pass an absolute path
@@ -259,44 +249,25 @@ module FastlaneCore
       keychain_path
     end
 
-    # @return the full path to the iTMSTransporter executable
-    def self.itms_path
-      return ENV["FASTLANE_ITUNES_TRANSPORTER_PATH"] if FastlaneCore::Env.truthy?("FASTLANE_ITUNES_TRANSPORTER_PATH")
-      return '' unless self.is_mac? # so tests work on Linx too
-
-      [
-        "../Applications/Application Loader.app/Contents/MacOS/itms",
-        "../Applications/Application Loader.app/Contents/itms"
-      ].each do |path|
-        result = File.expand_path(File.join(self.xcode_path, path))
-        return result if File.exist?(result)
-      end
-      UI.user_error!("Could not find transporter at #{self.xcode_path}. Please make sure you set the correct path to your Xcode installation.")
-    end
+    # helper methods
+    #
 
-    def self.fastlane_enabled?
-      # This is called from the root context on the first start
-      @enabled ||= !FastlaneCore::FastlaneFolder.path.nil?
+    # Runs a given command using backticks (`)
+    # and prints them out using the UI.command method
+    def self.backticks(command, print: true)
+      UI.command(command) if print
+      result = `#{command}`
+      UI.command_output(result) if print
+      return result
     end
 
-    # Checks if fastlane is enabled for this project and returns the folder where the configuration lives
-    def self.fastlane_enabled_folder_path
-      fastlane_enabled? ? FastlaneCore::FastlaneFolder.path : '.'
+    # removes ANSI colors from string
+    def self.strip_ansi_colors(str)
+      str.gsub(/\e\[([;\d]+)?m/, '')
     end
 
-    # <b>DEPRECATED:</b> Use the `ROOT` constant from the appropriate tool module instead
-    # e.g. File.join(Sigh::ROOT, 'lib', 'assets', 'resign.sh')
+    # loading indicator
     #
-    # Path to the installed gem to load resources (e.g. resign.sh)
-    def self.gem_path(gem_name)
-      UI.deprecated('`Helper.gem_path` is deprecated. Use the `ROOT` constant from the appropriate tool module instead.')
-
-      if !Helper.is_test? and Gem::Specification.find_all_by_name(gem_name).any?
-        return Gem::Specification.find_by_name(gem_name).gem_dir
-      else
-        return './'
-      end
-    end
 
     def self.should_show_loading_indicator?
       return false if FastlaneCore::Env.truthy?("FASTLANE_DISABLE_ANIMATION")
@@ -322,5 +293,67 @@ module FastlaneCore
         @require_fastlane_spinner.success
       end
     end
+
+    # files
+    #
+
+    # checks if a given path is an executable file
+    def self.executable?(cmd_path)
+      # no executable files on Windows, so existing is enough there
+      cmd_path && !File.directory?(cmd_path) && (File.executable?(cmd_path) || (self.windows? && File.exist?(cmd_path)))
+    end
+
+    # checks if given file is a valid json file
+    # base taken from: http://stackoverflow.com/a/26235831/1945875
+    def self.json_file?(filename)
+      return false unless File.exist?(filename)
+      begin
+        JSON.parse(File.read(filename))
+        return true
+      rescue JSON::ParserError
+        return false
+      end
+    end
+
+    # deprecated
+    #
+
+    # Use Helper.test?, Helper.ci?, Helper.mac? or Helper.windows? instead (legacy calls)
+    def self.is_test?
+      self.test?
+    end
+
+    def self.is_ci?
+      ci?
+    end
+
+    def self.is_mac?
+      self.mac?
+    end
+
+    def self.is_windows?
+      self.windows?
+    end
+
+    # <b>DEPRECATED:</b> Use the `ROOT` constant from the appropriate tool module instead
+    # e.g. File.join(Sigh::ROOT, 'lib', 'assets', 'resign.sh')
+    #
+    # Path to the installed gem to load resources (e.g. resign.sh)
+    def self.gem_path(gem_name)
+      UI.deprecated('`Helper.gem_path` is deprecated. Use the `ROOT` constant from the appropriate tool module instead.')
+
+      if !Helper.test? and Gem::Specification.find_all_by_name(gem_name).any?
+        return Gem::Specification.find_by_name(gem_name).gem_dir
+      else
+        return './'
+      end
+    end
+
+    # This method is deprecated, use the `UI` class
+    # https://docs.fastlane.tools/advanced/#user-input-and-output
+    def self.log
+      UI.deprecated("Helper.log is deprecated. Use `UI` class instead")
+      UI.current.log
+    end
   end
 end

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -1,10 +1,10 @@
-require 'pty'
 require 'shellwords'
 require 'fileutils'
 require 'credentials_manager/account_manager'
 
 require_relative 'features'
 require_relative 'helper'
+require_relative 'fastlane_pty'
 
 module FastlaneCore
   # The TransporterInputError occurs when you passed wrong inputs to the {Deliver::ItunesTransporter}
@@ -31,7 +31,7 @@ module FastlaneCore
     private_constant :ERROR_REGEX, :WARNING_REGEX, :OUTPUT_REGEX, :RETURN_VALUE_REGEX, :SKIP_ERRORS
 
     def execute(command, hide_output)
-      return command if Helper.is_test?
+      return command if Helper.test?
 
       @errors = []
       @warnings = []
@@ -44,7 +44,7 @@ module FastlaneCore
       end
 
       begin
-        PTY.spawn(command) do |stdin, stdout, pid|
+        FastlaneCore::FastlanePty.spawn(command) do |stdin, stdout, pid|
           begin
             stdin.each do |line|
               @all_lines << line
@@ -113,7 +113,7 @@ module FastlaneCore
         if $1.include?("Your Apple ID or password was entered incorrectly") or
            $1.include?("This Apple ID has been locked for security reasons")
 
-          unless Helper.is_test?
+          unless Helper.test?
             CredentialsManager::AccountManager.new(user: @user).invalid_credentials
             UI.error("Please run this tool again to apply the new password")
           end
@@ -255,7 +255,7 @@ module FastlaneCore
     end
 
     def java_code_option
-      if Helper.is_mac? && Helper.xcode_at_least?(9)
+      if Helper.mac? && Helper.xcode_at_least?(9)
         return "-jar #{Helper.transporter_java_jar_path.shellescape}"
       else
         return "-classpath #{Helper.transporter_java_jar_path.shellescape} com.apple.transporter.Application"
@@ -337,7 +337,7 @@ module FastlaneCore
         return download(app_id, dir)
       end
 
-      return result if Helper.is_test?
+      return result if Helper.test?
 
       itmsp_path = File.join(dir, "#{app_id}.itmsp")
       successful = result && File.directory?(itmsp_path)
@@ -376,7 +376,7 @@ module FastlaneCore
       if result
         UI.header("Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.")
 
-        FileUtils.rm_rf(actual_dir) unless Helper.is_test? # we don't need the package any more, since the upload was successful
+        FileUtils.rm_rf(actual_dir) unless Helper.test? # we don't need the package any more, since the upload was successful
       else
         handle_error(@password)
       end

data/fastlane_core/lib/fastlane_core/project.rb

@@ -131,7 +131,7 @@ module FastlaneCore
         elsif automated_scheme_selection? && schemes.include?(project_name)
           UI.important("Using scheme matching project name (#{project_name}).")
           options[:scheme] = project_name
-        elsif Helper.is_ci?
+        elsif Helper.ci?
           UI.error("Multiple schemes found but you haven't specified one.")
           UI.error("Since this is a CI, please pass one using the `scheme` option")
           show_scheme_shared_information

data/fastlane_core/lib/fastlane_core/swag.rb

@@ -38,7 +38,7 @@ module FastlaneCore
 
     def self.should_be_shown?
       return false unless FastlaneCore::Env.truthy?("FL_ENABLE_LOGO_ANIMATION")
-      return false if Helper.is_ci?
+      return false if Helper.ci?
       return false unless UI.interactive?
       return true
     end

data/fastlane_core/lib/fastlane_core/tool_collector.rb

@@ -59,7 +59,7 @@ module FastlaneCore
     def did_finish
       return false if FastlaneCore::Env.truthy?("FASTLANE_OPT_OUT_USAGE")
 
-      if !did_show_message? and !Helper.is_ci?
+      if !did_show_message? and !Helper.ci?
         show_message
       end
 

data/fastlane_core/lib/fastlane_core/ui/implementations/shell.rb

@@ -15,7 +15,7 @@ module FastlaneCore
 
       $stdout.sync = true
 
-      if Helper.is_test? && !ENV.key?('DEBUG')
+      if Helper.test? && !ENV.key?('DEBUG')
         $stdout.puts("Logging disabled while running tests. Force them by setting the DEBUG environment variable")
         @log ||= Logger.new(nil) # don't show any logs when running tests
       else

data/fastlane_core/lib/fastlane_core/update_checker/update_checker.rb

@@ -10,7 +10,7 @@ module FastlaneCore
   # Verifies, the user runs the latest version of this gem
   class UpdateChecker
     def self.start_looking_for_update(gem_name)
-      return if Helper.is_test?
+      return if Helper.test?
       return if FastlaneCore::Env.truthy?("FASTLANE_SKIP_UPDATE_CHECK")
 
       @start_time = Time.now
@@ -124,7 +124,7 @@ module FastlaneCore
 
     def self.send_launch_analytic_events_for(gem_name)
       return if FastlaneCore::Env.truthy?("FASTLANE_OPT_OUT_USAGE")
-      ci = Helper.is_ci?.to_s
+      ci = Helper.ci?.to_s
       app_id_guesser = FastlaneCore::AppIdentifierGuesser.new(args: ARGV, gem_name: gem_name)
       project_hash = app_id_guesser.p_hash
       p_hash = project_hash if project_hash
@@ -198,7 +198,7 @@ module FastlaneCore
     def self.send_completion_events_for(gem_name)
       return if FastlaneCore::Env.truthy?("FASTLANE_OPT_OUT_USAGE")
 
-      ci = Helper.is_ci?.to_s
+      ci = Helper.ci?.to_s
       install_method = if Helper.rubygems?
                          'gem'
                        elsif Helper.bundler?

data/gym/lib/gym/runner.rb

@@ -1,4 +1,3 @@
-require 'pty'
 require 'open3'
 require 'fileutils'
 require 'shellwords'

data/match/lib/match/encrypt.rb

@@ -108,7 +108,7 @@ module Match
 
       # On non-Mac systems (more specific Ubuntu Linux) it might take some time for the file to actually be there (see #11182).
       # To try to circumvent this flakyness (in tests), we wait a bit until the file appears (max 2s) (usually only 0.1 is actually waited)
-      unless FastlaneCore::Helper.is_mac?
+      unless FastlaneCore::Helper.mac?
         count = 0
         # sleep until file exists or 20*0.1s (=2s) passed
         until File.exist?(tmpfile) || count == 20

data/scan/lib/scan/runner.rb

@@ -1,4 +1,3 @@
-require 'pty'
 require 'open3'
 require 'fileutils'
 require 'terminal-table'
@@ -88,7 +87,7 @@ module Scan
         UI.test_failure!("Test execution failed. Exit status: #{tests_exit_status}")
       end
 
-      if !Helper.is_ci? && Scan.cache[:open_html_report_path]
+      if !Helper.ci? && Scan.cache[:open_html_report_path]
         `open --hide '#{Scan.cache[:open_html_report_path]}'`
       end
     end

data/screengrab/lib/screengrab/android_environment.rb

@@ -1,3 +1,4 @@
+require_relative 'module'
 require 'fastlane_core/command_executor'
 
 module Screengrab
@@ -84,7 +85,7 @@ module Screengrab
     end
 
     def executable_command?(cmd_path)
-      cmd_path && File.executable?(cmd_path) && !File.directory?(cmd_path)
+      Helper.executable?(cmd_path)
     end
   end
 end

data/snapshot/lib/snapshot/screenshot_rotate.rb

@@ -1,10 +1,10 @@
 require_relative 'module'
+require 'fastlane_core/fastlane_pty'
 
 module Snapshot
   # This class takes care of rotating images
   class ScreenshotRotate
     require 'shellwords'
-    require 'pty'
 
     # @param (String) The path in which the screenshots are located in
     def run(path)
@@ -28,7 +28,7 @@ module Snapshot
         next unless command
 
         # Only rotate if we need to
-        PTY.spawn(command) do |r, w, pid|
+        FastlaneCore::FastlanePty.spawn(command) do |r, w, pid|
           r.sync
           r.each do |line|
             # We need to read this otherwise things hang

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.79.0.beta.20180124010003
+  version: 2.79.0.beta.20180125010002
 platform: ruby
 authors:
 - Josh Holtz
@@ -25,7 +25,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-24 00:00:00.000000000 Z
+date: 2018-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1270,6 +1270,7 @@ files:
 - fastlane_core/lib/fastlane_core/device_manager.rb
 - fastlane_core/lib/fastlane_core/env.rb
 - fastlane_core/lib/fastlane_core/fastlane_folder.rb
+- fastlane_core/lib/fastlane_core/fastlane_pty.rb
 - fastlane_core/lib/fastlane_core/feature/feature.rb
 - fastlane_core/lib/fastlane_core/features.rb
 - fastlane_core/lib/fastlane_core/globals.rb