fastlane 2.70.2 → 2.70.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83ac3d5b30435c890c6c68faeb4a41bfe3acb424
-  data.tar.gz: 39c65833f75f48ef0131faf206683adcacd9127c
+  metadata.gz: db2a79f0ea8502192be084f553b7611f25f83314
+  data.tar.gz: 99effa647bdaaab8564baded99feaa20306d10f9
 SHA512:
-  metadata.gz: 12b67636cf96d5debabd98bf4b2d53fce327af50830c504b80fda8aeb798c88fd6f69c242eabc200db9176eddeeb67cc789bcf062a65a0e95f74fd92b330753a
-  data.tar.gz: aadae44146f183fd6913c07b3b65f748768fee1e11756df9727c0681eb8f9e3e089261e23c58b20ed0a0e6f743fd5fab446b678fc51e0d3ebc071b84c2fb4f98
+  metadata.gz: e55c92ffa57592da478a44ebcb77cebdcfd7e9e32324daf6e59d4014e5c5e0da4a4659038404d0980b97d74fafc17df87d581c9ac71f229ee09c41060ada72c1
+  data.tar.gz: 9ea6bc9cde31f71aad51cfc0fe2af49fa6caccf818c053d1f1fa8619571a7f76257ddb1c87e0687a20ced19912727f0f4c57fed9538c7a6f8f0a44bca7b19835

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -5,6 +5,7 @@ module Fastlane
     end
 
     class DownloadDsymsAction < Action
+      # rubocop:disable Metrics/PerceivedComplexity
       def self.run(params)
         require 'spaceship'
         require 'net/http'
@@ -29,8 +30,12 @@ module Fastlane
         # Set version if it is latest
         if version == 'latest'
           # Try to grab the edit version first, else fallback to live version
+          UI.message("Looking for latest version...")
           latest_version = app.edit_version(platform: platform) || app.live_version(platform: platform)
-          version = nil
+
+          UI.user_error!("Could not find latest version for your app, please try setting a specific version") if latest_version.version.nil?
+
+          version = latest_version.version
           build_number = latest_version.build_version
         end
 
@@ -82,6 +87,7 @@ module Fastlane
           UI.error("No dSYM files found on iTunes Connect - this usually happens when no recompling happened yet")
         end
       end
+      # rubocop:enable Metrics/PerceivedComplexity
 
       def self.write_dsym(data, bundle_id, train_number, build_number, output_directory)
         file_name = "#{bundle_id}-#{train_number}-#{build_number}.dSYM.zip"

data/fastlane/lib/fastlane/actions/import_from_git.rb

@@ -34,7 +34,7 @@ module Fastlane
                                        default_value: 'fastlane/Fastfile',
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :version,
-                                       description: "The version to checkout on the respository. Optimistic operator can be used to select the latest version within constraints",
+                                       description: "The version to checkout on the respository. Optimistic match operator or multiple conditions can be used to select the latest version within constraints",
                                        default_value: nil,
                                        optional: true)
         ]
@@ -54,7 +54,13 @@ module Fastlane
             url: "git@github.com:fastlane/fastlane.git", # The URL of the repository to import the Fastfile from.
             branch: "HEAD", # The branch to checkout on the repository. Defaults to `HEAD`.
             path: "fastlane/Fastfile" # The path of the Fastfile in the repository. Defaults to `fastlane/Fastfile`.
-            version: "~> 1.0.0" #The version to checkout on the respository. Optimistic operator can be used to select the latest version within constraints.
+            version: "~> 1.0.0" # The version to checkout on the repository. Optimistic match operator can be used to select the latest version within constraints.
+          )',
+          'import_from_git(
+            url: "git@github.com:fastlane/fastlane.git", # The URL of the repository to import the Fastfile from.
+            branch: "HEAD", # The branch to checkout on the repository. Defaults to `HEAD`.
+            path: "fastlane/Fastfile" # The path of the Fastfile in the repository. Defaults to `fastlane/Fastfile`.
+            version: [">= 1.1.0", "< 2.0.0"] # The version to checkout on the repository. Multiple conditions can be used to select the latest version within constraints.
           )'
         ]
       end

data/fastlane/lib/fastlane/fast_file.rb

@@ -1,3 +1,5 @@
+require "rubygems/requirement"
+
 module Fastlane
   class FastFile
     # Stores all relevant information from the currently running process
@@ -229,7 +231,7 @@ module Fastlane
     # @param url [String] The git URL to clone the repository from
     # @param branch [String] The branch to checkout in the repository
     # @param path [String] The path to the Fastfile
-    # @param verion [String] Version of the required Fastlane version
+    # @param version [String, Array] Version requirement for repo tags
     def import_from_git(url: nil, branch: 'HEAD', path: 'fastlane/Fastfile', version: nil)
       UI.user_error!("Please pass a path to the `import_from_git` action") if url.to_s.length == 0
 
@@ -251,13 +253,10 @@ module Fastlane
           Actions.sh("GIT_TERMINAL_PROMPT=0 git clone '#{url}' '#{clone_folder}' --depth 1 -n #{branch_option}")
 
           unless version.nil?
-            git_tags = fetch_remote_tags(folder: clone_folder)
-
-            # Separate version from optimistic operator
-            version_number = version(version_string: version)
-            operator = operator(version_string: version)
-
-            checkout_param = checkout_param_for_operator(operator: operator, version: version_number, git_tags: git_tags)
+            req = Gem::Requirement.new(version)
+            all_tags = fetch_remote_tags(folder: clone_folder)
+            checkout_param = all_tags.select { |t| req =~ FastlaneCore::TagVersion.new(t) }.last
+            UI.user_error! "No tag found matching #{version.inspect}" if checkout_param.nil?
           end
 
           Actions.sh("cd '#{clone_folder}' && git checkout #{checkout_param} '#{path}'")
@@ -293,75 +292,10 @@ module Fastlane
       git_tags_string = Actions.sh("cd '#{folder}' && git tag -l")
       git_tags = git_tags_string.split("\n")
 
-      # Delete tags that are not a real version number
-      git_tags.delete_if { |tag| Gem::Version.correct?(tag) != 0 }
-
       # Sort tags based on their version number
-      git_tags.sort_by { |tag| Gem::Version.new(tag) }
-
       return git_tags
-    end
-
-    def checkout_param_for_operator(operator: nil, version: nil, git_tags: nil)
-      # ~> should select the latest version withing constraints.
-      # -> should select a specific version without fallback.
-      if operator == "~>"
-        return checkout_param_twiddle_wakka(version: version, git_tags: git_tags)
-
-      elsif operator == "->" || operator.nil?
-        return checkout_param_specific_version(version: version, git_tags: git_tags)
-
-      else
-        UI.user_error!("The specified operator \"#{operator}\" in \"#{version}\" is unknown. Please use one of these '~> ->'")
-      end
-    end
-
-    def checkout_param_specific_version(version: nil, git_tags: nil)
-      # Search matching version in array
-      matching_git_tags = git_tags.select do |tag|
-        tag == version
-      end
-
-      UI.user_error!("The specified version \"#{version}\" doesn't exist") if matching_git_tags.count == 0
-      return matching_git_tags.last
-    end
-
-    def checkout_param_twiddle_wakka(version: nil, git_tags: nil)
-      # Drop last specified digit in version
-      last_dot_index = version.rindex('.')
-      version_range = version[0..last_dot_index - 1]
-
-      # Search matching version in array
-      matching_git_tags = git_tags.select do |tag|
-        tag.start_with?(version_range)
-      end
-
-      UI.user_error!("No version found within the \"#{version_range}.*\" range") if matching_git_tags.count == 0
-
-      return matching_git_tags.last
-    end
-
-    def operator(version_string: nil)
-      version_info = version_range_info(version_string: version_string)
-
-      # version_info will have 2 elements if an optimistic operator is specified.
-      if version_info.count > 1
-
-        # Optimistic operator is always the first part. e.g.: ["~>", "2.0.0"]
-        return version_info.first
-      end
-
-      return nil
-    end
-
-    def version(version_string: nil)
-      version_info = version_range_info(version_string: version_string)
-      return version_info.last
-    end
-
-    def version_range_info(version_string: nil)
-      # Separate version from optimistic operator
-      return version_string.split(" ")
+             .select { |tag| FastlaneCore::TagVersion.correct?(tag) }
+             .sort_by { |tag| FastlaneCore::TagVersion.new(tag) }
     end
 
     #####################################################

data/fastlane/lib/fastlane/server/socket_server.rb

@@ -174,7 +174,8 @@ module Fastlane
         return_value = ""
       end
 
-      return JSON.generate(return_value.to_s)
+      # quirks_mode because sometimes the built-in library is used for some folks and that needs quirks_mode: true
+      return JSON.generate(return_value.to_s, quirks_mode: true)
     end
 
     def process_value_as_array_of_strings(return_value: nil)
@@ -182,6 +183,7 @@ module Fastlane
         return_value = []
       end
 
+      # quirks_mode shouldn't be required for real objects
       return JSON.generate(return_value)
     end
 
@@ -190,6 +192,7 @@ module Fastlane
         return_value = {}
       end
 
+      # quirks_mode shouldn't be required for real objects
       return JSON.generate(return_value)
     end
 
@@ -198,7 +201,8 @@ module Fastlane
         return_value = false
       end
 
-      return JSON.generate(return_value)
+      # quirks_mode because sometimes the built-in library is used for some folks and that needs quirks_mode: true
+      return JSON.generate(return_value.to_s, quirks_mode: true)
     end
 
     def process_value_as_int(return_value: nil)
@@ -206,7 +210,8 @@ module Fastlane
         return_value = 0
       end
 
-      return JSON.generate(return_value)
+      # quirks_mode because sometimes the built-in library is used for some folks and that needs quirks_mode: true
+      return JSON.generate(return_value.to_s, quirks_mode: true)
     end
   end
 end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.70.2'.freeze
+  VERSION = '2.70.3'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane/swift/Deliverfile.swift

@@ -11,4 +11,4 @@ class Deliverfile: DeliverfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane/swift/Gymfile.swift

@@ -11,4 +11,4 @@ class Gymfile: GymfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane/swift/Matchfile.swift

@@ -11,4 +11,4 @@ class Matchfile: MatchfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane/swift/Precheckfile.swift

@@ -11,4 +11,4 @@ class Precheckfile: PrecheckfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane/swift/Scanfile.swift

@@ -11,4 +11,4 @@ class Scanfile: ScanfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane/swift/Screengrabfile.swift

@@ -11,4 +11,4 @@ class Screengrabfile: ScreengrabfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane/swift/Snapshotfile.swift

@@ -11,4 +11,4 @@ class Snapshotfile: SnapshotfileProtocol {
 
 
 
-// Generated with fastlane 2.70.1
+// Generated with fastlane 2.70.2

data/fastlane_core/lib/fastlane_core.rb

@@ -46,6 +46,7 @@ require 'fastlane_core/analytics/action_launch_context'
 require 'fastlane_core/analytics/analytics_event_builder'
 require 'fastlane_core/analytics/analytics_ingester_client'
 require 'fastlane_core/analytics/analytics_session'
+require 'fastlane_core/tag_version'
 
 # Third Party code
 require 'colored'

data/fastlane_core/lib/fastlane_core/configuration/config_item.rb

@@ -23,6 +23,9 @@ module FastlaneCore
     # [Boolean] is false by default. If set to true, also string values will not be asked to the user
     attr_accessor :optional
 
+    # [Boolean] is false by default. If set to true, type of the parameter will not be validated.
+    attr_accessor :skip_type_validation
+
     # [Array] array of conflicting option keys(@param key). This allows to resolve conflicts intelligently
     attr_accessor :conflicting_options
 
@@ -53,6 +56,7 @@ module FastlaneCore
     #   You have to raise a specific exception if something goes wrong. Append .red after the string
     # @param is_string *DEPRECATED: Use `type` instead* (Boolean) is that parameter a string? Defaults to true. If it's true, the type string will be verified.
     # @param type (Class) the data type of this config item. Takes precedence over `is_string`. Use `:shell_string` to allow types `String`, `Hash` and `Array` that will be converted to shell-escaped strings
+    # @param skip_type_validation (Boolean) is false by default. If set to true, type of the parameter will not be validated.
     # @param optional (Boolean) is false by default. If set to true, also string values will not be asked to the user
     # @param conflicting_options ([]) array of conflicting option keys(@param key). This allows to resolve conflicts intelligently
     # @param conflict_block an optional block which is called when options conflict happens

data/fastlane_core/lib/fastlane_core/tag_version.rb

@@ -0,0 +1,24 @@
+require "rubygems/version"
+
+module FastlaneCore
+  # Utility class to construct a Gem::Version from a tag.
+  # Accepts vX.Y.Z and X.Y.Z.
+  class TagVersion < Gem::Version
+    class << self
+      def correct?(tag)
+        superclass.correct?(version_number_from_tag(tag))
+      end
+
+      # Gem::Version.new barfs on things like "v0.1.0", which is the style
+      # generated by the rake release task. Just strip off any initial v
+      # to generate a Gem::Version from a tag.
+      def version_number_from_tag(tag)
+        tag.sub(/^v/, "")
+      end
+    end
+
+    def initialize(tag)
+      super(self.class.version_number_from_tag(tag))
+    end
+  end
+end

data/supply/lib/supply/setup.rb

@@ -44,7 +44,7 @@ module Supply
       IMAGES_TYPES.each do |image_type|
         if ['featureGraphic'].include?(image_type)
           # we don't get all files in full resolution :(
-          UI.message("Due to a limitation of the Google Play API, there is no way for `supply` to download your existing feature graphic. Please copy your feature graphic to `metadata/android/en-US/images/featureGraphic.png`")
+          UI.message("Due to a limitation of the Google Play API, there is no way for `supply` to download your existing feature graphic. Please copy your feature graphic to `metadata/android/#{listing.language}/images/featureGraphic.png`")
           next
         end
 
@@ -71,7 +71,7 @@ module Supply
         FileUtils.mkdir_p(File.join(containing, IMAGES_FOLDER_NAME, screenshot_type))
       end
 
-      UI.message("Due to a limitation of the Google Play API, there is no way for `supply` to download your existing screenshots. Please copy your screenshots into `metadata/android/en-US/images/`")
+      UI.message("Due to a limitation of the Google Play API, there is no way for `supply` to download your existing screenshots. Please copy your screenshots into `metadata/android/#{listing.language}/images/`")
     end
 
     def store_apk_listing(apk_listing)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.70.2
+  version: 2.70.3
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-20 00:00:00.000000000 Z
+date: 2017-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -677,14 +677,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.7.4
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.7.4
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -829,7 +829,6 @@ files:
 - deliver/lib/deliver/upload_price_tier.rb
 - deliver/lib/deliver/upload_screenshots.rb
 - fastlane/README.md
-- fastlane/lib/.DS_Store
 - fastlane/lib/assets/ActionDetails.md.erb
 - fastlane/lib/assets/Actions.md.erb
 - fastlane/lib/assets/AppfileTemplate
@@ -852,7 +851,6 @@ files:
 - fastlane/lib/fastlane/.DS_Store
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
-- fastlane/lib/fastlane/actions/.DS_Store
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb
@@ -1088,7 +1086,6 @@ files:
 - fastlane/lib/fastlane/fast_file.rb
 - fastlane/lib/fastlane/fastlane_require.rb
 - fastlane/lib/fastlane/features.rb
-- fastlane/lib/fastlane/helper/.DS_Store
 - fastlane/lib/fastlane/helper/README.md
 - fastlane/lib/fastlane/helper/adb_helper.rb
 - fastlane/lib/fastlane/helper/cocoapod_helper.rb
@@ -1165,6 +1162,7 @@ files:
 - fastlane/swift/Fastlane.swift
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.pbxproj
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/contents.xcworkspacedata
+- fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/project.xcworkspace/xcuserdata/liebowitz.xcuserdatad/UserInterfaceState.xcuserstate
 - fastlane/swift/FastlaneSwiftRunner/FastlaneSwiftRunner.xcodeproj/xcshareddata/xcschemes/FastlaneRunner.xcscheme
 - fastlane/swift/Gymfile.swift
 - fastlane/swift/GymfileProtocol.swift
@@ -1187,10 +1185,8 @@ files:
 - fastlane/swift/SocketResponse.swift
 - fastlane/swift/main.swift
 - fastlane_core/README.md
-- fastlane_core/lib/.DS_Store
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
-- fastlane_core/lib/fastlane_core/.DS_Store
 - fastlane_core/lib/fastlane_core/analytics/action_completion_context.rb
 - fastlane_core/lib/fastlane_core/analytics/action_launch_context.rb
 - fastlane_core/lib/fastlane_core/analytics/analytics_event_builder.rb
@@ -1231,6 +1227,7 @@ files:
 - fastlane_core/lib/fastlane_core/provisioning_profile.rb
 - fastlane_core/lib/fastlane_core/string_filters.rb
 - fastlane_core/lib/fastlane_core/swag.rb
+- fastlane_core/lib/fastlane_core/tag_version.rb
 - fastlane_core/lib/fastlane_core/test_parser.rb
 - fastlane_core/lib/fastlane_core/tool_collector.rb
 - fastlane_core/lib/fastlane_core/ui/disable_colors.rb
@@ -1317,6 +1314,7 @@ files:
 - pilot/lib/pilot/tester_manager.rb
 - pilot/lib/pilot/tester_util.rb
 - precheck/README.md
+- precheck/lib/.DS_Store
 - precheck/lib/assets/PrecheckfileTemplate
 - precheck/lib/assets/PrecheckfileTemplate.swift
 - precheck/lib/precheck.rb
@@ -1562,10 +1560,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.2.5
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and
   Android apps
 test_files: []
-has_rdoc: