fastlane 2.54.0.beta.20170818010002 → 2.54.0.beta.20170819010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31f9f6b75b0447f30db831da38095ef3345a17a8
-  data.tar.gz: 3cfe94056b73a9d8c54262c62d134a4ebc6489df
+  metadata.gz: aa60520a646d56ac9ebd6c8fc6140053cae322a0
+  data.tar.gz: 0b1d7bc82b5e0053a73e6fcb58d1af7422edfe7e
 SHA512:
-  metadata.gz: 8212eb5a555c454e525c53264811ee6ea3b758e61d0ebcadcd7bf8fa3b7b6aab9faa43f64a3487d4db7d4042f50f592d1f5935be216f6da632ed924fe5361d6f
-  data.tar.gz: 9ac733a3f8a14e9230d6b92d403f53ad677287b382f56ad9ae830828deed0c2c33f982d8ed8d16f871cdffea23884294cc09c626e66f7e4e6d741cab53999e87
+  metadata.gz: 38a18c29a23bb28aafb75028f6133ed4b213550848c6fd26fecbadd02bc3e11d84d9e81a4a3d6957d2afd39c5aa82a8487064afbf12ec12b5cef1fe5b12cf5a4
+  data.tar.gz: 8ac94195d4046a98e71d880f6e9046d82a8dc09cba32a1aa202ab2d474c2bbf90364c682d81be7a70d301bf49b377ac462c8e8a6148ef0202d75eec529a5a798

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.54.0.beta.20170818010002'.freeze
+  VERSION = '2.54.0.beta.20170819010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -10,6 +10,10 @@ module Spaceship
     class ITunesConnectTemporaryError < ITunesConnectError
     end
 
+    # raised if the server failed to save, and it might be caused by an invisible server error
+    class ITunesConnectPotentialServerError < ITunesConnectError
+    end
+
     attr_reader :du_client
 
     def initialize
@@ -108,7 +112,9 @@ module Spaceship
     end
 
     # rubocop:disable Metrics/PerceivedComplexity
-    def handle_itc_response(raw)
+    # If the response is coming from a flaky api, set flaky_api_call to true so we retry a little.
+    # Patience is a virtue.
+    def handle_itc_response(raw, flaky_api_call: false)
       return unless raw
       return unless raw.kind_of? Hash
 
@@ -164,6 +170,8 @@ module Spaceship
           raise ITunesConnectTemporaryError.new, errors.first
         elsif errors.count == 1 and errors.first.include?("Forbidden")
           raise_insuffient_permission_error!
+        elsif flaky_api_call
+          raise ITunesConnectPotentialServerError.new, errors.join(' ')
         else
           raise ITunesConnectError.new, errors.join(' ')
         end
@@ -343,7 +351,7 @@ module Spaceship
           req.headers['Content-Type'] = 'application/json'
         end
 
-        handle_itc_response(r.body)
+        handle_itc_response(r.body, flaky_api_call: true)
       end
     end
 
@@ -1315,7 +1323,7 @@ module Spaceship
 
     private
 
-    def with_tunes_retry(tries = 5, &_block)
+    def with_tunes_retry(tries = 5, potential_server_error_tries = 3, &_block)
       return yield
     rescue Spaceship::TunesClient::ITunesConnectTemporaryError => ex
       unless (tries -= 1).zero?
@@ -1326,6 +1334,15 @@ module Spaceship
         retry
       end
       raise ex # re-raise the exception
+    rescue Spaceship::TunesClient::ITunesConnectPotentialServerError => ex
+      unless (potential_server_error_tries -= 1).zero?
+        msg = "Potential server error received: '#{ex.message}'. Retrying after 10 seconds (remaining: #{tries})..."
+        puts msg
+        logger.warn msg
+        sleep 10 unless defined? SpecHelper # unless FastlaneCore::Helper.is_test?
+        retry
+      end
+      raise ex
     end
 
     def clear_user_cached_data

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.54.0.beta.20170818010002
+  version: 2.54.0.beta.20170819010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-18 00:00:00.000000000 Z
+date: 2017-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier