fastlane 2.54.0.beta.20170817010002 → 2.54.0.beta.20170818010002

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bcc279ca63201b152f2ba3809f9c5f041d18a71f
-  data.tar.gz: 0d7a65d242ddd339dc0e6368b5b6d1a34c328567
+  metadata.gz: 31f9f6b75b0447f30db831da38095ef3345a17a8
+  data.tar.gz: 3cfe94056b73a9d8c54262c62d134a4ebc6489df
 SHA512:
-  metadata.gz: 365c195f0124ed7058d16e39494176b458a3fad3be8f73a14e918dd9ecbd3a09cf37db9206ce11ebf53ec0f163b72309dcad4858b0cb9898c66bdddbeb77324a
-  data.tar.gz: 7d46736eeb00f7b092eb6ee9488cb75840e6bbc584de39d4969d3cecf73c93e2447a471318e367123ec5cd35e2af5d0a5bd29e8b3bceacab17ac32d11e3f0678
+  metadata.gz: 8212eb5a555c454e525c53264811ee6ea3b758e61d0ebcadcd7bf8fa3b7b6aab9faa43f64a3487d4db7d4042f50f592d1f5935be216f6da632ed924fe5361d6f
+  data.tar.gz: 9ac733a3f8a14e9230d6b92d403f53ad677287b382f56ad9ae830828deed0c2c33f982d8ed8d16f871cdffea23884294cc09c626e66f7e4e6d741cab53999e87

data/credentials_manager/lib/credentials_manager/account_manager.rb

@@ -5,7 +5,7 @@ module CredentialsManager
   class AccountManager
     DEFAULT_PREFIX = "deliver"
     # @param prefix [String] Very optional, is used for the
-    #   iTunes Transporter which uses application specofic passwords
+    #   iTunes Transporter which uses application specific passwords
     # @param note [String] An optional note that will be shown next
     #   to the password and username prompt
     def initialize(user: nil, password: nil, prefix: nil, note: nil)
@@ -16,7 +16,7 @@ module CredentialsManager
       @note = note
     end
 
-    # Is the that default prefix "deliver"
+    # Is the default prefix "deliver"
     def default_prefix?
       @prefix == DEFAULT_PREFIX
     end
@@ -50,7 +50,7 @@ module CredentialsManager
     end
 
     # Call this method to ask the user to re-enter the credentials
-    # @param force: if false the user is asked before it gets deleted
+    # @param force: if false, the user is asked before it gets deleted
     # @return: Did the user decide to remove the old entry and enter a new password?
     def invalid_credentials(force: false)
       puts "The login credentials for '#{user}' seem to be wrong".red
@@ -117,7 +117,7 @@ module CredentialsManager
         prompt_text += " (#{@note})" if @note
         prompt_text += ": "
         @user = ask(prompt_text) while @user.to_s.length == 0
-        # we return here, as only the username was asked for now, we'll get called for the pw again anyway
+        # Returning here since only the username was asked for. This method will be called again when a password is needed.
         return
       end
 

data/fastlane/lib/fastlane/actions/add_git_tag.rb

@@ -3,7 +3,8 @@ module Fastlane
     # Adds a git tag to the current commit
     class AddGitTagAction < Action
       def self.run(options)
-        lane_name = Actions.lane_context[Actions::SharedValues::LANE_NAME].delete(' ') # no spaces allowed
+        # lane name in lane_context could be nil because you can just call $fastlane add_git_tag which has no context
+        lane_name = Actions.lane_context[Actions::SharedValues::LANE_NAME].to_s.delete(' ') # no spaces allowed
 
         tag = options[:tag] || "#{options[:grouping]}/#{lane_name}/#{options[:prefix]}#{options[:build_number]}"
         message = options[:message] || "#{tag} (fastlane)"

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.54.0.beta.20170817010002'.freeze
+  VERSION = '2.54.0.beta.20170818010002'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/spaceship/lib/spaceship/base.rb

@@ -43,6 +43,10 @@ module Spaceship
         ref[last] = value
       end
 
+      def delete(key)
+        @hash.delete(key)
+      end
+
       def lookup(keys)
         head, *tail = *keys
         if tail.empty?

data/spaceship/lib/spaceship/tunes/app_submission.rb

@@ -124,7 +124,13 @@ module Spaceship
 
       # Save and complete the app submission
       def complete!
-        client.send_app_submission(application.apple_id, raw_data)
+        raw_data_clone = raw_data.dup
+        if self.content_rights_has_rights.nil? || self.content_rights_contains_third_party_content.nil?
+          raw_data_clone.set(["contentRights"], nil)
+        end
+        raw_data_clone.delete("version")
+
+        client.send_app_submission(application.apple_id, application.edit_version.version_id, raw_data_clone)
         @submitted_for_review = true
       end
 

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -872,12 +872,12 @@ module Spaceship
       parse_response(r, 'data')
     end
 
-    def send_app_submission(app_id, data)
+    def send_app_submission(app_id, version, data)
       raise "app_id is required" unless app_id
 
       # ra/apps/1039164429/version/submit/complete
       r = request(:post) do |req|
-        req.url "ra/apps/#{app_id}/version/submit/complete"
+        req.url "ra/apps/#{app_id}/versions/#{version}/submit/complete"
         req.body = data.to_json
         req.headers['Content-Type'] = 'application/json'
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.54.0.beta.20170817010002
+  version: 2.54.0.beta.20170818010002
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-17 00:00:00.000000000 Z
+date: 2017-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier