fastlane 2.51.0.beta.20170804010003 → 2.51.0.beta.20170805010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57c9884308f495d707942d16b436d4d0172037c2
-  data.tar.gz: e7a1892b749733a8d963298da84a4f614b5527a6
+  metadata.gz: c80a60da667579980bad460738cbe5b059919917
+  data.tar.gz: 4357bd33a339313330880af387993c43f2f28c6f
 SHA512:
-  metadata.gz: ee578a32307a0944d05cff1271695ab3f43207276ae37545129d81f5c7a73e294bc09e0f79b9063a6e1ae60abefd05f38012e4456558cd933d9d5888be9250db
-  data.tar.gz: 4bad8baa4c401007a1f4fc9a23c5a6913c7089a6a0933fc14c9e62052ff91047235d9d97f3c41eed74b2c43b554446f2cc1873d1ad201572dad84434f475133f
+  metadata.gz: de777b2403bdd92db984ea1b8515a9183e13cfcea5430045956e486488a323a35ba50894add2fe7142dfd8f39c19bcbb3443d98afdbc54673f998a82c20384c6
+  data.tar.gz: 89d84c143b3b6838946a2a17c5e84f3db7b964a28bf40381feffb0ac0baccdf1ddc7646f3f70ad6c0f838954a54aeb4b9b8db8a401b4646f2cb01ecb43d22675

data/deliver/README.md

@@ -153,7 +153,7 @@ Already using `deliver` and just updated to 1.0? Check out the [Migration Guide]
 
 A detailed description about how your credentials are handled is available in a [credentials_manager](https://github.com/fastlane/fastlane/tree/master/credentials_manager).
 
-### How does this thing even work? Is magic involved? 🎩###
+### How does this thing even work? Is magic involved? 🎩
 
 Your password will be stored in the macOS keychain, but can also be passed using environment variables. (More information available on [CredentialsManager](https://github.com/fastlane/fastlane/tree/master/credentials_manager))
 

data/fastlane/lib/fastlane/actions/appetize_viewing_url_generator.rb

@@ -5,7 +5,7 @@ module Fastlane
 
     class AppetizeViewingUrlGeneratorAction < Action
       def self.run(params)
-        link = "https://appetize.io/embed/#{params[:public_key]}"
+        link = "#{params[:base_url]}/#{params[:public_key]}"
 
         if params[:scale].nil? # sensible default values for scaling
           case params[:device].downcase.to_sym
@@ -27,6 +27,8 @@ module Fastlane
         url_params << "launchUrl=#{params[:launch_url]}" if params[:launch_url]
         url_params << "language=#{params[:language]}" if params[:language]
         url_params << "osVersion=#{params[:os_version]}" if params[:os_version]
+        url_params << "params=#{CGI.escape params[:params]}" if params[:params]
+        url_params << "proxy=#{CGI.escape params[:proxy]}" if params[:proxy]
 
         return link + "?" + url_params.join("&")
       end
@@ -57,6 +59,12 @@ module Fastlane
                                            UI.user_error!("You provided a private key to appetize, please provide the public key")
                                          end
                                        end),
+          FastlaneCore::ConfigItem.new(key: :base_url,
+                                       env_name: "APPETIZE_VIEWING_URL_GENERATOR_BASE",
+                                       description: "Base URL of Appetize service",
+                                       is_string: true,
+                                       default_value: "https://appetize.io/embed",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :device,
                                        env_name: "APPETIZE_VIEWING_URL_GENERATOR_DEVICE",
                                        description: "Device type: iphone4s, iphone5s, iphone6, iphone6plus, ipadair, iphone6s, iphone6splus, ipadair2, nexus5, nexus7 or nexus9",
@@ -103,6 +111,16 @@ module Fastlane
                                        env_name: "APPETIZE_VIEWING_URL_GENERATOR_OS_VERSION",
                                        description: "The operating system version on which to run your app, e.g. 10.3, 8.0",
                                        is_string: true,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :params,
+                                       env_name: "APPETIZE_VIEWING_URL_GENERATOR_PARAMS",
+                                       description: "Specifiy params value to be passed to Appetize",
+                                       is_string: true,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :proxy,
+                                       env_name: "APPETIZE_VIEWING_URL_GENERATOR_PROXY",
+                                       description: "Specify a HTTP proxy to be passed to Appetize",
+                                       is_string: true,
                                        optional: true)
         ]
       end

data/fastlane/lib/fastlane/actions/import_certificate.rb

@@ -4,7 +4,7 @@ module Fastlane
   module Actions
     class ImportCertificateAction < Action
       def self.run(params)
-        keychain_path = FastlaneCore::Helper.keychain_path(params[:keychain_name])
+        keychain_path = params[:keychain_path] || FastlaneCore::Helper.keychain_path(params[:keychain_name])
 
         FastlaneCore::KeychainImporter.import_file(params[:certificate_path], keychain_path, keychain_password: params[:keychain_password], certificate_password: params[:certificate_password], output: params[:log_output])
       end
@@ -19,6 +19,10 @@ module Fastlane
                                        env_name: "KEYCHAIN_NAME",
                                        description: "Keychain the items should be imported to",
                                        optional: false),
+          FastlaneCore::ConfigItem.new(key: :keychain_path,
+                                       env_name: "KEYCHAIN_PATH",
+                                       description: "Path to the Keychain file to which the items should be imported",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :keychain_password,
                                        env_name: "FL_IMPORT_CERT_KEYCHAIN_PASSWORD",
                                        description: "The password for the keychain. Note that for the login keychain this is your user's password",

data/fastlane/lib/fastlane/actions/set_github_release.rb

@@ -118,10 +118,7 @@ module Fastlane
         require 'addressable/template'
         file_name = File.basename(file)
         expanded_url = Addressable::Template.new(url_template).expand(name: file_name).to_s
-        headers = {}
-        if File.extname(file_name).to_s.casecmp('.zip').zero?
-          headers['Content-Type'] = 'application/zip'
-        end
+        headers = { 'Content-Type' => 'application/zip' } # works for all binary files
         UI.important("Uploading #{file_name}")
         GithubApiAction.run(
           api_token: api_token,

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.51.0.beta.20170804010003'.freeze
+  VERSION = '2.51.0.beta.20170805010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/pem/lib/pem/manager.rb

@@ -16,11 +16,11 @@ module PEM
         if existing_certificate
           remaining_days = (existing_certificate.expires - Time.now) / 60 / 60 / 24
           UI.message "Existing push notification profile for '#{existing_certificate.owner_name}' is valid for #{remaining_days.round} more days."
-          if remaining_days > 30
+          if remaining_days > PEM.config[:active_days_limit]
             if PEM.config[:force]
               UI.success "You already have an existing push certificate, but a new one will be created since the --force option has been set."
             else
-              UI.success "You already have a push certificate, which is active for more than 30 more days. No need to create a new one"
+              UI.success "You already have a push certificate, which is active for more than #{PEM.config[:active_days_limit]} more days. No need to create a new one"
               UI.success "If you still want to create a new one, use the --force option when running PEM."
               return false
             end

data/pem/lib/pem/options.rb

@@ -18,9 +18,16 @@ module PEM
                                      description: "Generate a p12 file additionally to a PEM file",
                                      is_string: false,
                                      default_value: true),
+        FastlaneCore::ConfigItem.new(key: :active_days_limit,
+                                     env_name: "PEM_ACTIVE_DAYS_LIMIT",
+                                     description: "If the current certificate is active for less than this number of days, generate a new one. Default value is 30 days",
+                                     default_value: 30,
+                                     verify_block: proc do |value|
+                                       UI.user_error!("Value of active_days_limit must be a positive integer or left blank") unless value.kind_of?(Integer) && value > 0
+                                     end),
         FastlaneCore::ConfigItem.new(key: :force,
                                      env_name: "PEM_FORCE",
-                                     description: "Create a new push certificate, even if the current one is active for 30 more days",
+                                     description: "Create a new push certificate, even if the current one is active for 30 (or PEM_ACTIVE_DAYS_LIMIT) more days",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :save_private_key,

data/pilot/lib/pilot/tester_manager.rb

@@ -38,9 +38,10 @@ module Pilot
     def find_tester(options)
       start(options)
 
-      tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
-      tester ||= Spaceship::Tunes::Tester::External.find(config[:email])
+      app_filter = (config[:apple_id] || config[:app_identifier])
+      app = find_app(app_filter: app_filter)
 
+      tester = find_app_tester(email: config[:email], app: app)
       UI.user_error!("Tester #{config[:email]} not found") unless tester
 
       describe_tester(tester)
@@ -50,11 +51,12 @@ module Pilot
     def remove_tester(options)
       start(options)
 
-      tester = Spaceship::Tunes::Tester::External.find(config[:email])
-      tester ||= Spaceship::Tunes::Tester::Internal.find(config[:email])
-      UI.user_error!("Tester not found: #{config[:email]}") if tester.nil?
+      app_filter = (config[:apple_id] || config[:app_identifier])
+      app = find_app(app_filter: app_filter)
+
+      tester = find_app_tester(email: config[:email], app: app)
+      UI.user_error!("Tester #{config[:email]} not found") unless tester
 
-      app = find_app(app_filter: config[:apple_id] || config[:app_identifier])
       unless app
         tester.delete!
         UI.success("Successfully removed tester #{tester.email} from Users and Roles")
@@ -223,7 +225,7 @@ module Pilot
       rows << ["Last name", tester.last_name]
       rows << ["Email", tester.email]
 
-      if tester.groups.length > 0
+      if tester.groups.to_s.length > 0
         rows << ["Groups", tester.groups_list]
       end
 
@@ -232,7 +234,7 @@ module Pilot
         rows << ["Latest Install Date", tester.pretty_install_date]
       end
 
-      if tester.devices.length == 0
+      if tester.devices.to_s.length == 0
         rows << ["Devices", "No devices"]
       else
         rows << ["#{tester.devices.count} Devices", ""]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.51.0.beta.20170804010003
+  version: 2.51.0.beta.20170805010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-04 00:00:00.000000000 Z
+date: 2017-08-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier