fastlane 2.40.0.beta.20170622010014 → 2.40.0

data/precheck/lib/precheck/rules/test_words_rule.rb

@@ -0,0 +1,31 @@
+require 'precheck/rule'
+require 'precheck/rules/abstract_text_match_rule'
+
+module Precheck
+  class TestWordsRule < AbstractTextMatchRule
+    def self.key
+      :test_words
+    end
+
+    def self.env_name
+      "RULE_TEST_WORDS"
+    end
+
+    def self.friendly_name
+      "No words indicating test content"
+    end
+
+    def self.description
+      "using text indicating this release is a test"
+    end
+
+    def lowercased_words_to_look_for
+      [
+        "testing",
+        "just a test",
+        "alpha test",
+        "beta test"
+      ].map(&:downcase)
+    end
+  end
+end

data/precheck/lib/precheck/rules/unreachable_urls_rule.rb

@@ -0,0 +1,42 @@
+require 'precheck/rule'
+
+module Precheck
+  class UnreachableURLRule < URLRule
+    def self.key
+      :unreachable_urls
+    end
+
+    def self.env_name
+      "RULE_UNREACHABLE_URLS"
+    end
+
+    def self.friendly_name
+      "No broken urls"
+    end
+
+    def self.description
+      "unreachable URLs in app metadata"
+    end
+
+    def rule_block
+      return lambda { |url|
+        url = url.to_s.strip
+        return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: "empty url") if url.empty?
+
+        begin
+          request = Faraday.new(url) do |connection|
+            connection.use FaradayMiddleware::FollowRedirects
+            connection.adapter :net_http
+          end
+          return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: url) unless request.head.status == 200
+        rescue
+          UI.verbose "URL #{url} not reachable 😵"
+          # I can only return :fail here, but I also want to return #{url}
+          return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "unreachable: #{url}")
+        end
+
+        return RuleReturn.new(validation_state: VALIDATION_STATES[:passed])
+      }
+    end
+  end
+end

data/precheck/lib/precheck/runner.rb

@@ -0,0 +1,164 @@
+require 'fastlane'
+require 'fastlane_core'
+require 'spaceship'
+require 'terminal-table'
+require 'precheck/rule_processor'
+
+module Precheck
+  class Runner
+    attr_accessor :spaceship
+
+    # Uses the spaceship to download app metadata and then run all rule checkers
+    def run
+      Precheck.config.load_configuration_file(Precheck.precheckfile_name)
+
+      FastlaneCore::PrintTable.print_values(config: Precheck.config,
+                                         hide_keys: [:output_path],
+                                             title: "Summary for precheck #{Fastlane::VERSION}")
+
+      unless Spaceship::Tunes.client
+        UI.message "Starting login with user '#{Precheck.config[:username]}'"
+        Spaceship::Tunes.login(Precheck.config[:username])
+        Spaceship::Tunes.select_team
+
+        UI.message "Successfully logged in"
+      end
+
+      UI.message "Checking app for precheck rule violations"
+
+      ensure_app_exists!
+
+      processor_result = check_for_rule_violations(app: app, app_version: latest_app_version)
+
+      if processor_result.items_not_checked?
+        print_items_not_checked(processor_result: processor_result)
+      end
+
+      if processor_result.has_errors_or_warnings?
+        summary_table = build_potential_problems_table(processor_result: processor_result)
+        puts summary_table
+      end
+
+      if processor_result.should_trigger_user_error?
+        UI.user_error!("precheck found one or more potential problems that must be addressed before submitting to review")
+        return false
+      end
+
+      if !processor_result.has_errors_or_warnings? && !processor_result.items_not_checked?
+        UI.message "precheck 👮‍♀️ 👮  finished without detecting any potential problems 🛫".green
+      end
+
+      return true
+    end
+
+    def print_items_not_checked(processor_result: nil)
+      names = processor_result.items_not_checked.map(&:friendly_name)
+      UI.message "😶  Metadata fields not checked by any rule: #{names.join(', ')}".yellow if names.length > 0
+    end
+
+    def build_potential_problems_table(processor_result: nil)
+      error_results = processor_result.error_results
+      warning_results = processor_result.warning_results
+
+      rows = []
+
+      warning_results.each do |rule, results|
+        results.each do |result|
+          rows << [result.item.friendly_name, result.rule_return.failure_data.yellow]
+        end
+      end
+
+      error_results.each do |rule, results|
+        results.each do |result|
+          rows << [result.item.friendly_name, result.rule_return.failure_data.red]
+        end
+      end
+
+      if rows.length == 0
+        return nil
+      else
+        return Terminal::Table.new(
+          title: "Potential problems".red,
+          headings: ["Field", "Failure reason"],
+          rows: FastlaneCore::PrintTable.transform_output(rows)
+        ).to_s
+      end
+    end
+
+    def check_for_rule_violations(app: nil, app_version: nil)
+      Precheck::RuleProcessor.process_app_and_version(
+        app: app,
+        app_version: app_version,
+        rules: Precheck::Options.rules
+      )
+    end
+
+    def rendered_failed_results_table(failed_results: nil)
+      rows = []
+      failed_results.each do |failed_result|
+        rows << [failed_result.rule.key, failed_result.item.friendly_name]
+      end
+
+      return Terminal::Table.new(
+        title: "Failed rules".red,
+        headings: ["Name", "App metadata field: (language code)"],
+        rows: FastlaneCore::PrintTable.transform_output(rows)
+      ).to_s
+    end
+
+    def rendered_rules_checked_table(rules_checked: nil)
+      rows = []
+      rules_checked.each do |rule|
+        rows << [rule.key, rule.description]
+      end
+
+      return Terminal::Table.new(
+        title: "Enabled rules".green,
+        headings: ["Name", "Description"],
+        rows: FastlaneCore::PrintTable.transform_output(rows)
+      ).to_s
+    end
+
+    def rendered_skipped_rules_table(skipped_rules: nil)
+      return nil if skipped_rules.empty?
+
+      rows = []
+      skipped_rules.each do |rule|
+        rows << [rule.key, rule.description]
+      end
+
+      return Terminal::Table.new(
+        title: "Skipped rules".yellow,
+        headings: ["Name", "Description"],
+        rows: FastlaneCore::PrintTable.transform_output(rows)
+      ).to_s
+    end
+
+    def build_items_not_checked_table(items_not_checked: nil)
+      rows = []
+      items_not_checked.each do |item|
+        rows << [item.item_name, item.friendly_name]
+      end
+
+      return Terminal::Table.new(
+        title: "Not analyzed".yellow,
+        headings: ["Name", "Friendly name"],
+        rows: FastlaneCore::PrintTable.transform_output(rows)
+      ).to_s
+    end
+
+    def app
+      Spaceship::Tunes::Application.find(Precheck.config[:app_identifier])
+    end
+
+    def latest_app_version
+      @latest_version ||= app.latest_version
+    end
+
+    # Makes sure the current App ID exists. If not, it will show an appropriate error message
+    def ensure_app_exists!
+      return if app
+      UI.user_error!("Could not find app with App Identifier '#{Precheck.config[:app_identifier]}'")
+    end
+  end
+end

data/produce/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------
@@ -244,6 +245,7 @@ You'll still have to fill out the remaining information (like screenshots, app d
 - [`gym`](https://github.com/fastlane/fastlane/tree/master/gym): Building your iOS apps has never been easier
 - [`scan`](https://github.com/fastlane/fastlane/tree/master/scan): The easiest way to run tests of your iOS and Mac app
 - [`match`](https://github.com/fastlane/fastlane/tree/master/match): Easily sync your certificates and profiles across your team using git
+- [`precheck`](https://github.com/fastlane/fastlane/tree/master/precheck): Check your app using a community driven set of App Store review rules to avoid being rejected
 
 ##### [Do you like fastlane? Be the first to know about updates and new fastlane tools](https://tinyletter.com/fastlane-tools)
 

data/scan/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <b>scan</b> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------
@@ -205,6 +206,7 @@ For more information visit the [fastlane GitHub page](https://github.com/fastlan
 - [`boarding`](https://github.com/fastlane/boarding): The easiest way to invite your TestFlight beta testers
 - [`gym`](https://github.com/fastlane/fastlane/tree/master/gym): Building your iOS apps has never been easier
 - [`match`](https://github.com/fastlane/fastlane/tree/master/match): Easily sync your certificates and profiles across your team using git
+- [`precheck`](https://github.com/fastlane/fastlane/tree/master/precheck): Check your app using a community driven set of App Store review rules to avoid being rejected
 
 ##### [Do you like fastlane? Be the first to know about updates and new fastlane tools](https://tinyletter.com/fastlane-tools)
 

data/screengrab/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------

data/sigh/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------
@@ -228,6 +229,7 @@ If you're using [cert](https://github.com/fastlane/fastlane/tree/master/cert) in
 - [`gym`](https://github.com/fastlane/fastlane/tree/master/gym): Building your iOS apps has never been easier
 - [`scan`](https://github.com/fastlane/fastlane/tree/master/scan): The easiest way to run tests of your iOS and Mac app
 - [`match`](https://github.com/fastlane/fastlane/tree/master/match): Easily sync your certificates and profiles across your team using git
+- [`precheck`](https://github.com/fastlane/fastlane/tree/master/precheck): Check your app using a community driven set of App Store review rules to avoid being rejected
 
 ##### [Do you like fastlane? Be the first to know about updates and new fastlane tools](https://tinyletter.com/fastlane-tools)
 

data/snapshot/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------
@@ -360,6 +361,7 @@ Radar [23062925](https://openradar.appspot.com/radar?id=5056366381105152) has be
 - [`gym`](https://github.com/fastlane/fastlane/tree/master/gym): Building your iOS apps has never been easier
 - [`scan`](https://github.com/fastlane/fastlane/tree/master/scan): The easiest way to run tests of your iOS and Mac app
 - [`match`](https://github.com/fastlane/fastlane/tree/master/match): Easily sync your certificates and profiles across your team using git
+- [`precheck`](https://github.com/fastlane/fastlane/tree/master/precheck): Check your app using a community driven set of App Store review rules to avoid being rejected
 
 ##### [Do you like fastlane? Be the first to know about updates and new fastlane tools](https://tinyletter.com/fastlane-tools)
 

data/spaceship/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------

data/spaceship/lib/spaceship/tunes/language_item.rb

@@ -13,13 +13,17 @@ module Spaceship
       end
 
       def [](key)
-        get_lang(key)[identifier]['value']
+        get_value(key: key)
       end
 
       def []=(key, value)
         get_lang(key)[identifier]['value'] = value
       end
 
+      def get_value(key: nil)
+        get_lang(key)[identifier]['value']
+      end
+
       def get_lang(lang)
         result = self.original_array.find do |current|
           current['language'] == lang or current['localeCode'] == lang # Apple being consistent

data/supply/README.md

@@ -18,7 +18,8 @@
   <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
   <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a>
+  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
+  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
 </p>
 
 -------
@@ -199,6 +200,7 @@ This can be done using the `--track_promote_to` parameter.  The `--track_promote
 - [`boarding`](https://github.com/fastlane/boarding): The easiest way to invite your TestFlight beta testers
 - [`gym`](https://github.com/fastlane/fastlane/tree/master/gym): Building your iOS apps has never been easier
 - [`match`](https://github.com/fastlane/fastlane/tree/master/match): Easily sync your certificates and profiles across your team using git
+- [`precheck`](https://github.com/fastlane/fastlane/tree/master/precheck): Check your app using a community driven set of App Store review rules to avoid being rejected
 
 ##### [Do you like fastlane? Be the first to know about updates and new fastlane tools](https://tinyletter.com/fastlane-tools)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.40.0.beta.20170622010014
+  version: 2.40.0
 platform: ruby
 authors:
 - Felix Krause
@@ -935,6 +935,7 @@ files:
 - fastlane/lib/fastlane/actions/pod_lib_lint.rb
 - fastlane/lib/fastlane/actions/pod_push.rb
 - fastlane/lib/fastlane/actions/podio_item.rb
+- fastlane/lib/fastlane/actions/precheck.rb
 - fastlane/lib/fastlane/actions/produce.rb
 - fastlane/lib/fastlane/actions/prompt.rb
 - fastlane/lib/fastlane/actions/push_git_tags.rb
@@ -1201,6 +1202,27 @@ files:
 - pilot/lib/pilot/tester_importer.rb
 - pilot/lib/pilot/tester_manager.rb
 - pilot/lib/pilot/tester_util.rb
+- precheck/README.md
+- precheck/lib/assets/PrecheckfileTemplate
+- precheck/lib/precheck.rb
+- precheck/lib/precheck/commands_generator.rb
+- precheck/lib/precheck/item_to_check.rb
+- precheck/lib/precheck/options.rb
+- precheck/lib/precheck/rule.rb
+- precheck/lib/precheck/rule_check_result.rb
+- precheck/lib/precheck/rule_processor.rb
+- precheck/lib/precheck/rules/abstract_text_match_rule.rb
+- precheck/lib/precheck/rules/copyright_date_rule.rb
+- precheck/lib/precheck/rules/curse_words_rule.rb
+- precheck/lib/precheck/rules/custom_text_rule.rb
+- precheck/lib/precheck/rules/future_functionality_rule.rb
+- precheck/lib/precheck/rules/negative_apple_sentiment_rule.rb
+- precheck/lib/precheck/rules/other_platforms_rule.rb
+- precheck/lib/precheck/rules/placeholder_words_rule.rb
+- precheck/lib/precheck/rules/rules_data/curse_word_hashes/en_us.txt
+- precheck/lib/precheck/rules/test_words_rule.rb
+- precheck/lib/precheck/rules/unreachable_urls_rule.rb
+- precheck/lib/precheck/runner.rb
 - produce/README.md
 - produce/lib/produce.rb
 - produce/lib/produce/available_default_languages.rb
@@ -1375,23 +1397,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- scan/lib
-- fastlane_core/lib
+- cert/lib
+- credentials_manager/lib
+- deliver/lib
 - fastlane/lib
+- fastlane_core/lib
+- frameit/lib
+- gym/lib
+- match/lib
 - pem/lib
-- deliver/lib
-- snapshot/lib
 - pilot/lib
+- precheck/lib
 - produce/lib
-- gym/lib
-- match/lib
+- scan/lib
+- screengrab/lib
 - sigh/lib
-- cert/lib
-- credentials_manager/lib
-- frameit/lib
+- snapshot/lib
 - spaceship/lib
 - supply/lib
-- screengrab/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -1399,14 +1422,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and
   Android apps
 test_files: []
+has_rdoc: