fastlane 2.39.0.beta.20170613010056 → 2.39.0.beta.20170614010012

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9609a3fb26dbf87c7496a3ce7e971d939696fd5
-  data.tar.gz: a9e5c7e87e54afa63f47f12682e3e1d3b3d90e7a
+  metadata.gz: 295c2d8d4545f7f8c59a6f90160ea85260312d44
+  data.tar.gz: cdbcd96a54341a4861d359a8092360098ac4aaae
 SHA512:
-  metadata.gz: 2d8234c9b0c7824d669238ed303579f67c204aa8123c8e4475d5f6745d80df2d0b1795474594c29bbe51a62bdb29dfbbb0a56df2b2a5e98cc20514f912ef3a59
-  data.tar.gz: 2620c8305021be03cd2b5ea9f439c63016198153ecf53c637936965d3aa2ca2be26eeb75cd43f67671ff92b73e07d7b9f5f089dd9d9a774cd65e83003d60c6ea
+  metadata.gz: d3ae3cdc1be6c4c7c0130db181e842685408edfd0344dc1b92bbdd6ac0ec2d1e1c40fc2a778549fb50318bf088a8952e1cb9cc120abe4cfef5912eb0674ed723
+  data.tar.gz: 95e5cc12d9711a2baea78e22b69bb433fb6a6282bfc808eb7f28ccdb63fa4c9d192983e853f012a8c110c39216d51a23940ca8d457dcebdb9906d8aced376271

data/deliver/lib/deliver/submit_for_review.rb

@@ -69,18 +69,17 @@ module Deliver
     end
 
     def find_build(candidate_builds)
-      build = nil
+      if (candidate_builds || []).count == 0
+        UI.user_error!("Could not find any available candidate builds on iTunes Connect to submit")
+      end
+
+      build = candidate_builds.first
       candidate_builds.each do |b|
-        if !build or b.upload_date > build.upload_date
+        if b.upload_date > build.upload_date
           build = b
         end
       end
 
-      unless build
-        UI.error(candidate_builds)
-        UI.crash!("Could not find build")
-      end
-
       return build
     end
   end

data/deliver/lib/deliver/upload_metadata.rb

@@ -118,8 +118,19 @@ module Deliver
 
       UI.message("Uploading metadata to iTunes Connect")
       v.save!
-      details.save!
-      UI.success("Successfully uploaded set of metadata to iTunes Connect")
+      begin
+        details.save!
+        UI.success("Successfully uploaded set of metadata to iTunes Connect")
+      rescue Spaceship::ITunesConnectError => e
+        # This makes sure that we log invalid app names as user errors
+        # If another string needs to be checked here we should
+        # figure out a more generic way to handle these cases.
+        if e.message.include?('App Name cannot be longer than 50 characters') || e.message.include?('The app name you entered is already being used')
+          UI.user_error!(e.message)
+        else
+          raise e
+        end
+      end
     end
 
     # If the user is using the 'default' language, then assign values where they are needed

data/fastlane/lib/fastlane/actions/ruby_version.rb

@@ -0,0 +1,54 @@
+module Fastlane
+  module Actions
+    module SharedValues
+    end
+
+    class RubyVersionAction < Action
+      def self.run(params)
+        params = nil unless params.kind_of?(Array)
+        value = (params || []).first
+        defined_version = Gem::Version.new(value) if value
+
+        UI.user_error!("Please pass minimum ruby version as parameter to ruby_version") unless defined_version
+
+        if Gem::Version.new(RUBY_VERSION) < defined_version
+          error_message = "The Fastfile requires a ruby version of >= #{defined_version}. You are on #{RUBY_VERSION}."
+          UI.user_error!(error_message)
+        end
+
+        UI.message("Your ruby version #{RUBY_VERSION} matches the minimum requirement of #{defined_version}  ✅")
+      end
+
+      def self.step_text
+        "Verifying required ruby version"
+      end
+
+      def self.author
+        "sebastianvarela"
+      end
+
+      def self.description
+        "Verifies the minimum ruby version required"
+      end
+
+      def self.example_code
+        ['ruby_version "2.4.0"']
+      end
+
+      def self.details
+        [
+          "Add this to your `Fastfile` to require a certain version of _ruby_.",
+          "Put it at the top of your `Fastfile to ensure that _fastlane_ is executed appropriately."
+        ].join("\n")
+      end
+
+      def self.category
+        :misc
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/actions/set_info_plist_value.rb

@@ -10,7 +10,16 @@ module Fastlane
         begin
           path = File.expand_path(params[:path])
           plist = Plist.parse_xml(path)
-          plist[params[:key]] = params[:value]
+          if params[:subkey]
+            if plist[params[:key]]
+              plist[params[:key]][params[:subkey]] = params[:value]
+            else
+              UI.message "Key doesn't exist, going to create new one ..."
+              plist[params[:key]] = { params[:subkey] => params[:value] }
+            end
+          else
+            plist[params[:key]] = params[:value]
+          end
           new_plist = Plist::Emit.dump(plist)
           File.write(path, new_plist)
 
@@ -31,6 +40,10 @@ module Fastlane
                                        env_name: "FL_SET_INFO_PLIST_PARAM_NAME",
                                        description: "Name of key in plist",
                                        optional: false),
+          FastlaneCore::ConfigItem.new(key: :subkey,
+                                       env_name: "FL_SET_INFO_PLIST_SUBPARAM_NAME",
+                                       description: "Name of subkey in plist",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :value,
                                        env_name: "FL_SET_INFO_PLIST_PARAM_VALUE",
                                        description: "Value to setup",
@@ -47,7 +60,7 @@ module Fastlane
       end
 
       def self.authors
-        ["kohtenko"]
+        ["kohtenko", "uwehollatz"]
       end
 
       def self.is_supported?(platform)
@@ -56,7 +69,8 @@ module Fastlane
 
       def self.example_code
         [
-          'set_info_plist_value(path: "./Info.plist", key: "CFBundleIdentifier", value: "com.krausefx.app.beta")'
+          'set_info_plist_value(path: "./Info.plist", key: "CFBundleIdentifier", value: "com.krausefx.app.beta")',
+          'set_info_plist_value(path: "./MyApp-Info.plist", key: "NSAppTransportSecurity", subkey: "NSAllowsArbitraryLoads", value: true)'
         ]
       end
 

data/fastlane/lib/fastlane/actions/swiftlint.rb

@@ -2,16 +2,17 @@ module Fastlane
   module Actions
     class SwiftlintAction < Action
       def self.run(params)
-        if `which swiftlint`.to_s.length == 0 and !Helper.test?
-          UI.user_error!("You have to install swiftlint using `brew install swiftlint`")
+        if `which swiftlint`.to_s.length == 0 && params[:executable].nil? && !Helper.test?
+          UI.user_error!("You have to install swiftlint using `brew install swiftlint` or specify the executable path with the `:executable` option.")
         end
 
-        version = swiftlint_version
+        version = swiftlint_version(executable: params[:executable])
         if params[:mode] == :autocorrect and version < Gem::Version.new('0.5.0') and !Helper.test?
           UI.user_error!("Your version of swiftlint (#{version}) does not support autocorrect mode.\nUpdate swiftlint using `brew update && brew upgrade swiftlint`")
         end
 
-        command = "swiftlint #{params[:mode]}"
+        command = params[:executable].nil? ? "swiftlint" : params[:executable]
+        command << " #{params[:mode]}"
         command << supported_option_switch(params, :strict, "0.9.2", true)
         command << " --config #{params[:config_file].shellescape}" if params[:config_file]
         command << " --reporter #{params[:reporter]}" if params[:reporter]
@@ -37,16 +38,18 @@ module Fastlane
       end
 
       # Get current SwiftLint version
-      def self.swiftlint_version
-        Gem::Version.new(`swiftlint version`.chomp)
+      def self.swiftlint_version(executable: nil)
+        binary = executable.nil? ? 'swiftlint' : executable
+        Gem::Version.new(`#{binary} version`.chomp)
       end
 
       # Return "--option" switch if option is on and current SwiftLint version is greater or equal than min version.
       # Return "" otherwise.
       def self.supported_option_switch(params, option, min_version, can_ignore = false)
         return "" unless params[option]
-        if swiftlint_version < Gem::Version.new(min_version)
-          message = "Your version of swiftlint (#{swiftlint_version}) does not support '--#{option}' option.\nUpdate swiftlint to #{min_version} or above using `brew update && brew upgrade swiftlint`"
+        version = swiftlint_version(executable: params[:executable])
+        if version < Gem::Version.new(min_version)
+          message = "Your version of swiftlint (#{version}) does not support '--#{option}' option.\nUpdate swiftlint to #{min_version} or above using `brew update && brew upgrade swiftlint`"
           message += "\nThe option will be ignored." if can_ignore
           can_ignore ? UI.important(message) : UI.user_error!(message)
           ""
@@ -102,6 +105,10 @@ module Fastlane
                                        description: "Don't print status logs like 'Linting <file>' & 'Done linting'",
                                        default_value: false,
                                        is_string: false,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :executable,
+                                       description: "Path to the `swiftlint` executable on your machine",
+                                       is_string: true,
                                        optional: true)
         ]
       end

data/fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -47,10 +47,10 @@ module Fastlane
 
         project = Xcodeproj::Project.open(folder)
         project.targets.each do |target|
-          if !target_filter || target.product_name.match(target_filter) || (target.respond_to?(:product_type) && target.product_type.match(target_filter))
-            UI.success("Updating target #{target.product_name}...")
+          if !target_filter || target.name.match(target_filter) || (target.respond_to?(:product_type) && target.product_type.match(target_filter))
+            UI.success("Updating target #{target.name}...")
           else
-            UI.important("Skipping target #{target.product_name} as it doesn't match the filter '#{target_filter}'")
+            UI.important("Skipping target #{target.name} as it doesn't match the filter '#{target_filter}'")
             next
           end
 

data/fastlane/lib/fastlane/lane_manager.rb

@@ -233,16 +233,11 @@ module Fastlane
         [key, content.to_s]
       end
 
-      begin
-        require 'terminal-table'
-        puts Terminal::Table.new({
-          title: "Lane Context".yellow,
-          rows: FastlaneCore::PrintTable.transform_output(rows)
-        })
-      rescue
-        os = Helper.linux? ? 'linux' : 'mac'
-        UI.crash!("Something went wrong trying to print the lane context on #{os}")
-      end
+      require 'terminal-table'
+      puts Terminal::Table.new({
+        title: "Lane Context".yellow,
+        rows: FastlaneCore::PrintTable.transform_output(rows)
+      })
     end
   end
 end

data/fastlane/lib/fastlane/runner.rb

@@ -257,13 +257,13 @@ module Fastlane
       rescue FastlaneCore::Interface::FastlaneCommonException => e # these are exceptions that we dont count as crashes
         raise e
       rescue FastlaneCore::Interface::FastlaneError => e # user_error!
-        FastlaneCore::CrashReporter.report_crash(exception: e, action: method_sym)
+        FastlaneCore::CrashReporter.report_crash(exception: e)
         collector.did_raise_error(method_sym) if e.fastlane_should_report_metrics?
         raise e
       rescue Exception => e # rubocop:disable Lint/RescueException
         # high chance this is actually FastlaneCore::Interface::FastlaneCrash, but can be anything else
         # Catches all exceptions, since some plugins might use system exits to get out
-        FastlaneCore::CrashReporter.report_crash(exception: e, action: method_sym)
+        FastlaneCore::CrashReporter.report_crash(exception: e)
         collector.did_crash(method_sym) if e.fastlane_should_report_metrics?
         raise e
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.39.0.beta.20170613010056'.freeze
+  VERSION = '2.39.0.beta.20170614010012'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/crash_reporter/crash_report_generator.rb

@@ -1,9 +1,9 @@
 module FastlaneCore
   class CrashReportGenerator
     class << self
-      def generate(exception: nil, action: nil)
+      def generate(exception: nil)
         message = format_crash_report_message(exception: exception)
-        crash_report_payload(message: message, action: action)
+        crash_report_payload(message: message)
       end
 
       private
@@ -35,11 +35,11 @@ module FastlaneCore
         message + backtrace
       end
 
-      def crash_report_payload(message: '', action: nil)
+      def crash_report_payload(message: '')
         {
           'eventTime' => Time.now.utc.to_datetime.rfc3339,
           'serviceContext' => {
-            'service' => action || 'fastlane',
+            'service' => 'fastlane',
             'version' => Fastlane::VERSION
           },
           'message' => message

data/fastlane_core/lib/fastlane_core/crash_reporter/crash_reporter.rb

@@ -16,7 +16,7 @@ module FastlaneCore
         !FastlaneCore::Env.truthy?("FASTLANE_OPT_OUT_CRASH_REPORTING")
       end
 
-      def report_crash(exception: nil, action: nil)
+      def report_crash(exception: nil)
         return unless enabled?
         return if @did_report_crash
         return if exception.fastlane_crash_came_from_custom_action?
@@ -26,7 +26,7 @@ module FastlaneCore
         # we want to test it
         return if Helper.test? && !@explicitly_enabled_for_testing
         begin
-          payload = CrashReportGenerator.generate(exception: exception, action: action)
+          payload = CrashReportGenerator.generate(exception: exception)
           send_report(payload: payload)
           save_file(payload: payload)
           show_message unless did_show_message?

data/fastlane_core/lib/fastlane_core/ui/errors/fastlane_error.rb

@@ -26,12 +26,12 @@ end
 
 class Exception
   def fastlane_crash_came_from_custom_action?
-    custom_frame = exception.backtrace.find { |frame| frame.start_with?('actions/') }
+    custom_frame = exception && exception.backtrace && exception.backtrace.find { |frame| frame.start_with?('actions/') }
     !custom_frame.nil?
   end
 
   def fastlane_crash_came_from_plugin?
-    plugin_frame = backtrace.find { |frame| frame.include?('fastlane-plugin-') }
+    plugin_frame = exception && exception.backtrace && exception.backtrace.find { |frame| frame.include?('fastlane-plugin-') }
     !plugin_frame.nil?
   end
 

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -43,7 +43,7 @@ module Commander
         if FastlaneCore::Helper.test?
           raise e
         else
-          FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
+          FastlaneCore::CrashReporter.report_crash(exception: e)
           abort "#{e}. Use --help for more information"
         end
       rescue Interrupt => e
@@ -62,7 +62,7 @@ module Commander
         if FastlaneCore::Helper.test?
           raise e
         else
-          FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
+          FastlaneCore::CrashReporter.report_crash(exception: e)
           if self.active_command.name == "help" && @default_command == :help # need to access directly via @
             # This is a special case, for example for pilot
             # when the user runs `fastlane pilot -u user@google.com`
@@ -105,7 +105,7 @@ module Commander
       FastlaneCore::UI.important("Error accessing file, this might be due to fastlane's directory handling")
       FastlaneCore::UI.important("Check out https://docs.fastlane.tools/advanced/#directory-behavior for more details")
       puts ""
-      FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
+      FastlaneCore::CrashReporter.report_crash(exception: e)
       raise e
     end
 
@@ -113,13 +113,13 @@ module Commander
       if e.message.include? 'Connection reset by peer - SSL_connect'
         handle_tls_error!(e)
       else
-        FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
+        FastlaneCore::CrashReporter.report_crash(exception: e)
         handle_unknown_error!(e)
       end
     end
 
     def rescue_unknown_error(e)
-      FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
+      FastlaneCore::CrashReporter.report_crash(exception: e)
       collector.did_crash(@program[:name]) if e.fastlane_should_report_metrics?
       handle_unknown_error!(e)
     end
@@ -127,7 +127,7 @@ module Commander
     def rescue_fastlane_error(e)
       collector.did_raise_error(@program[:name]) if e.fastlane_should_report_metrics?
       show_github_issues(e.message) if e.show_github_issues
-      FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
+      FastlaneCore::CrashReporter.report_crash(exception: e)
       display_user_error!(e, e.message)
     end
 

data/supply/lib/supply/client.rb

@@ -130,7 +130,7 @@ module Supply
     def listings
       ensure_active_edit!
 
-      result = call_google_api { android_publisher.list_listings(current_package_name, current_edit.id) }
+      result = call_google_api { android_publisher.list_edit_listings(current_package_name, current_edit.id) }
 
       return result.listings.map do |row|
         Listing.new(self, row.language, row)
@@ -142,7 +142,7 @@ module Supply
       ensure_active_edit!
 
       begin
-        result = android_publisher.get_listing(
+        result = android_publisher.get_edit_listing(
           current_package_name,
           current_edit.id,
           language
@@ -159,7 +159,7 @@ module Supply
     def apks_version_codes
       ensure_active_edit!
 
-      result = call_google_api { android_publisher.list_apks(current_package_name, current_edit.id) }
+      result = call_google_api { android_publisher.list_edit_apks(current_package_name, current_edit.id) }
 
       return result.apks.map(&:version_code)
     end
@@ -169,7 +169,7 @@ module Supply
       ensure_active_edit!
 
       result = call_google_api do
-        android_publisher.list_apk_listings(
+        android_publisher.list_edit_apklistings(
           current_package_name,
           current_edit.id,
           apk_version_code
@@ -198,7 +198,7 @@ module Supply
       })
 
       call_google_api do
-        android_publisher.update_listing(
+        android_publisher.update_edit_listing(
           current_package_name,
           current_edit.id,
           language,
@@ -211,7 +211,7 @@ module Supply
       ensure_active_edit!
 
       result_upload = call_google_api do
-        android_publisher.upload_apk(
+        android_publisher.upload_edit_apk(
           current_package_name,
           current_edit.id,
           upload_source: path_to_apk
@@ -249,7 +249,7 @@ module Supply
       })
 
       call_google_api do
-        android_publisher.update_track(
+        android_publisher.update_edit_track(
           current_package_name,
           current_edit.id,
           track,
@@ -262,8 +262,8 @@ module Supply
     def track_version_codes(track)
       ensure_active_edit!
 
-      result = call_google_api do
-        android_publisher.get_track(
+      begin
+        result = android_publisher.get_edit_track(
           current_package_name,
           current_edit.id,
           track
@@ -282,7 +282,7 @@ module Supply
       })
 
       call_google_api do
-        android_publisher.update_apk_listing(
+        android_publisher.update_edit_apklisting(
           current_package_name,
           current_edit.id,
           apk_listing.apk_version_code,
@@ -300,7 +300,7 @@ module Supply
       ensure_active_edit!
 
       result = call_google_api do
-        android_publisher.list_images(
+        android_publisher.list_edit_images(
           current_package_name,
           current_edit.id,
           language,
@@ -316,7 +316,7 @@ module Supply
       ensure_active_edit!
 
       call_google_api do
-        android_publisher.upload_image(
+        android_publisher.upload_edit_image(
           current_package_name,
           current_edit.id,
           language,
@@ -331,7 +331,7 @@ module Supply
       ensure_active_edit!
 
       call_google_api do
-        android_publisher.delete_all_images(
+        android_publisher.deleteall_edit_image(
           current_package_name,
           current_edit.id,
           language,
@@ -344,7 +344,7 @@ module Supply
       ensure_active_edit!
 
       call_google_api do
-        android_publisher.upload_expansion_file(
+        android_publisher.upload_edit_expansionfile(
           current_package_name,
           current_edit.id,
           apk_version_code,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.39.0.beta.20170613010056
+  version: 2.39.0.beta.20170614010012
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-13 00:00:00.000000000 Z
+date: 2017-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -345,16 +345,22 @@ dependencies:
   name: google-api-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.12.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 0.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.12.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 0.13.0
 - !ruby/object:Gem::Dependency
   name: highline
   requirement: !ruby/object:Gem::Requirement
@@ -944,6 +950,7 @@ files:
 - fastlane/lib/fastlane/actions/restore_file.rb
 - fastlane/lib/fastlane/actions/rocket.rb
 - fastlane/lib/fastlane/actions/rsync.rb
+- fastlane/lib/fastlane/actions/ruby_version.rb
 - fastlane/lib/fastlane/actions/s3.rb
 - fastlane/lib/fastlane/actions/say.rb
 - fastlane/lib/fastlane/actions/scan.rb
@@ -1368,23 +1375,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- scan/lib
-- spaceship/lib
-- frameit/lib
-- deliver/lib
 - supply/lib
+- deliver/lib
 - gym/lib
-- sigh/lib
-- credentials_manager/lib
-- fastlane/lib
-- match/lib
-- produce/lib
-- cert/lib
+- spaceship/lib
+- scan/lib
 - pem/lib
 - screengrab/lib
 - fastlane_core/lib
+- sigh/lib
+- fastlane/lib
+- cert/lib
 - pilot/lib
+- match/lib
+- credentials_manager/lib
 - snapshot/lib
+- produce/lib
+- frameit/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="