fastlane 2.29.0.beta.20170502010055 → 2.29.0.beta.20170503010035

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 539747f341885d0f76b91a8a9530efb0890768ac
-  data.tar.gz: 710a6bbfd47cee97b6d21cf63988a068848369ce
+  metadata.gz: 5af3635f331af53664a682ac1e0f327148b59255
+  data.tar.gz: 4c2519637d6f99b4279568c023afcbcdcf1d1320
 SHA512:
-  metadata.gz: 21b72adb90392e473ecc127f83594985256ce9074cc92511c6fa61dcb8dea203d681a7a774bc61c7a6a304b48ca886c8168388237f3e8b74d8cf74be70b558f6
-  data.tar.gz: bfd74ad36166a8a2683c1730a086345132a39ec56c765e0308a9a1ae60787af4659b4219179439e53b52069a229f8cc91047b3ac0c2eb2ce3aa98bf042b9bc88
+  metadata.gz: cba9b945d5edb104026efdbad536bd114c43c41756e3bcd16132fc9be5accbe09fffaebd3d2ecd069400b1687bca9aadbb7156a0f5d6e7df1adee4eac7d1fb5c
+  data.tar.gz: e1dcbf6170ab99f30dbef56f0257a165caf265e7713241d257280ad4fb5828deb98481a5558f1bfd0ec0e3bbc5b435d751ae192e635c36c82e44da4ab5f1c0c9

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.29.0.beta.20170502010055'.freeze
+  VERSION = '2.29.0.beta.20170503010035'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/project.rb

@@ -296,9 +296,16 @@ module FastlaneCore
     # @param [String] The key of which we want the value for (e.g. "PRODUCT_NAME")
     def build_settings(key: nil, optional: true)
       unless @build_settings
+        if is_workspace
+          if schemes.count == 0
+            UI.user_error!("Could not find any schemes for Xcode workspace at path '#{self.path}'. Please make sure that the schemes you want to use are marked as `Shared` from Xcode.")
+          end
+          options[:scheme] ||= schemes.first
+        end
+
         command = build_xcodebuild_showbuildsettings_command
 
-        # xcode might hang here and retrying fixes the problem, see fastlane#4059
+        # Xcode might hang here and retrying fixes the problem, see fastlane#4059
         begin
           timeout = FastlaneCore::Project.xcode_build_settings_timeout
           retries = FastlaneCore::Project.xcode_build_settings_retries
@@ -332,7 +339,7 @@ module FastlaneCore
 
     # Returns the build settings and sets the default scheme to the options hash
     def default_build_settings(key: nil, optional: true)
-      options[:scheme] = schemes.first if is_workspace
+      options[:scheme] ||= schemes.first if is_workspace
       build_settings(key: key, optional: optional)
     end
 

data/gym/lib/gym/generators/build_command_generator.rb

@@ -41,6 +41,7 @@ module Gym
         options << "-derivedDataPath '#{config[:derived_data_path]}'" if config[:derived_data_path]
         options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
         options << config[:xcargs] if config[:xcargs]
+        options << "OTHER_SWIFT_FLAGS=\"\$(inherited) -Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time]
 
         options
       end
@@ -64,6 +65,7 @@ module Gym
       def pipe
         pipe = []
         pipe << "| tee #{xcodebuild_log_path.shellescape}"
+        pipe << "| grep .[0-9]ms | grep -v ^0.[0-9]ms | sort -nr > culprits.txt" if Gym.config[:analyze_build_time]
         unless Gym.config[:disable_xcpretty]
           formatter = Gym.config[:xcpretty_formatter]
           pipe << "| xcpretty"

data/gym/lib/gym/options.rb

@@ -277,6 +277,11 @@ module Gym
                                      verify_block: proc do |value|
                                        UI.user_error!("Report output location not found at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                      end),
+        FastlaneCore::ConfigItem.new(key: :analyze_build_time,
+                                     env_name: "GYM_ANALYZE_BUILD_TIME",
+                                     description: "Analyze the project build time and store the output in culprits.txt file",
+                                     optional: true,
+                                     is_string: false),
         FastlaneCore::ConfigItem.new(key: :xcpretty_utf,
                                      env_name: "XCPRETTY_UTF",
                                      description: "Have xcpretty use unicode encoding when reporting builds",

data/spaceship/lib/spaceship/tunes/app_ratings.rb

@@ -47,9 +47,81 @@ module Spaceship
         instance_variable_set(:@store_fronts, unfolded_store_fronts)
       end
 
-      # @return (Array) of raw hashes representing user reviews for the given store front (and optional versionId)
+      # @return (Array) of Review Objects
       def reviews(store_front, versionId = '')
-        client.get_reviews(application.apple_id, application.platform, store_front, versionId)
+        raw_reviews = client.get_reviews(application.apple_id, application.platform, store_front, versionId)
+        raw_reviews.map do |review|
+          review["value"]["application"] = self.application
+          AppReview.factory(review["value"])
+        end
+      end
+    end
+
+    class DeveloperResponse < TunesBase
+      attr_reader :id
+      attr_reader :response
+      attr_reader :last_modified
+      attr_reader :hidden
+      attr_reader :state
+      attr_accessor :application
+      attr_accessor :review_id
+
+      attr_mapping({
+        'responseId' => :id,
+        'response' => :response,
+        'lastModified' => :last_modified,
+        'isHidden' => :hidden,
+        'pendingState' => :state
+      })
+    end
+
+    class AppReview < TunesBase
+      attr_accessor :application
+      attr_reader :rating
+      attr_reader :id
+      attr_reader :title
+      attr_reader :review
+      attr_reader :nickname
+      attr_reader :store_front
+      attr_reader :app_version
+      attr_reader :last_modified
+      attr_reader :helpful_views
+      attr_reader :total_views
+      attr_reader :edited
+      attr_reader :raw_developer_response
+      attr_accessor :developer_response
+
+      attr_mapping({
+        'id' => :id,
+        'rating' => :rating,
+        'title' => :title,
+        'review' => :review,
+        'nickname' => :nickname,
+        'storeFront' => :store_front,
+        'appVersionString' => :app_version,
+        'lastModified' => :last_modified,
+        'helpfulViews' => :helpful_views,
+        'totalViews' => :total_views,
+        'developerResponse' => :raw_developer_response,
+        'edited' => :edited
+      })
+      class << self
+        # Create a new object based on a hash.
+        # This is used to create a new object based on the server response.
+        def factory(attrs)
+          obj = self.new(attrs)
+          response_attrs = {}
+          response_attrs = obj.raw_developer_response if obj.raw_developer_response
+          response_attrs[:application] = obj.application
+          response_attrs[:review_id] = obj.id
+          obj.developer_response = DeveloperResponse.factory(response_attrs)
+          return obj
+        end
+      end
+
+      def responded?
+        return true if raw_developer_response
+        false
       end
     end
 

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -324,8 +324,19 @@ module Spaceship
     end
 
     def get_reviews(app_id, platform, storefront, versionId = '')
-      r = request(:get, "ra/apps/#{app_id}/reviews?platform=#{platform}&storefront=#{storefront}&versionId=#{versionId}")
-      parse_response(r, 'data')['reviews']
+      index = 0
+      per_page = 100 # apple default
+      all_reviews = []
+      loop do
+        r = request(:get, "ra/apps/#{app_id}/platforms/#{platform}/reviews?storefront=#{storefront}&versionId=#{versionId}&index=#{index}")
+        all_reviews.concat(parse_response(r, 'data')['reviews'])
+        if all_reviews.count < parse_response(r, 'data')['reviewCount']
+          index += per_page
+        else
+          break
+        end
+      end
+      all_reviews
     end
 
     #####################################################

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.29.0.beta.20170502010055
+  version: 2.29.0.beta.20170503010035
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-02 00:00:00.000000000 Z
+date: 2017-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1356,23 +1356,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- deliver/lib
-- cert/lib
-- produce/lib
 - snapshot/lib
-- match/lib
-- pilot/lib
-- fastlane_core/lib
-- supply/lib
+- produce/lib
 - gym/lib
+- fastlane_core/lib
+- scan/lib
+- match/lib
 - spaceship/lib
-- screengrab/lib
 - sigh/lib
-- credentials_manager/lib
+- pilot/lib
+- deliver/lib
 - fastlane/lib
+- cert/lib
 - frameit/lib
-- scan/lib
+- supply/lib
+- credentials_manager/lib
 - pem/lib
+- screengrab/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="