fastlane 2.29.0.beta.20170424010049 → 2.29.0.beta.20170425010038

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1052a99c1d0f413e8791403a2341fb880936b41
-  data.tar.gz: 11bf7fdf56a2dc8fb7ae271cbb1cf61add8446f8
+  metadata.gz: 808c6a8129169aa565f8d17b888fcdc5b9adb80a
+  data.tar.gz: d8496ea0117b5aef2de6461d1cc36d080fa83504
 SHA512:
-  metadata.gz: f8d563d31c28d4bfe4225512c6382f1816bdc71dc6be17c1bfbda8fc0cab4b66fa2ad65c446d5b6809803ccd61d2cbf403726dd3e050c42f0b295d86ef08a77a
-  data.tar.gz: 058f132ef186711b29c023ca2b6959f86bf60934d654eb6a464c9065f0b9a34eea0012e8500e571ec75c2d557bdb0511466249e47b4b9ad73b275e96a92981ea
+  metadata.gz: 20e6bd7f62ecc0df05335edc2eaf8b9bc3df77e4640bf1d79f099f7d8828c52e7226c980b5db39c407a3cff5c9d48adcd3be86c7fddbdeca5195544ee2784775
+  data.tar.gz: b2b04c14e9c02c391adab6e5473d0fc4951ff97e85e0681380291937487b29f2e9373b0240c62e6efa29a780b99ac5901c667c0012c6c0b27d924ba177a85901

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.29.0.beta.20170424010049'.freeze
+  VERSION = '2.29.0.beta.20170425010038'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -25,7 +25,7 @@ module FastlaneCore
         elsif matching_build.active?
           UI.success("Build #{matching_build.train_version} - #{matching_build.build_version} is already being tested")
           return matching_build
-        elsif matching_build.ready_to_submit?
+        elsif matching_build.ready_to_submit? || matching_build.export_compliance_missing?
           UI.success("Successfully finished processing the build #{matching_build.train_version} - #{matching_build.build_version}")
           return matching_build
         end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -108,6 +108,10 @@ module Commander
       FastlaneCore::UI.error("builds for testing, adding and removing testers from groups, and")
       FastlaneCore::UI.error("waiting for builds to process.")
       FastlaneCore::UI.error("")
+      FastlaneCore::UI.error("Please open an issue on https://github.com/fastlane/fastlane/issues")
+      FastlaneCore::UI.error("if you believe this failure is the result of a bug in _pilot_ and we")
+      FastlaneCore::UI.error("will be happy to look into this further.")
+      FastlaneCore::UI.error("")
       FastlaneCore::UI.error("Please stay tuned for more updates from _fastlane_ as we fix more issues!")
       FastlaneCore::UI.error("")
       if FastlaneCore::Globals.verbose?

data/pilot/lib/pilot/build_manager.rb

@@ -110,10 +110,10 @@ module Pilot
 
       # This is where we could add a check to see if encryption is required and has been updated
       uploaded_build.export_compliance.encryption_updated = false
-      uploaded_build.beta_review_info.demo_account_required = false
-      uploaded_build.submit_for_testflight_review!
 
       if options[:distribute_external]
+        uploaded_build.beta_review_info.demo_account_required = false
+        uploaded_build.submit_for_testflight_review!
         external_group = Spaceship::TestFlight::Group.default_external_group(app_id: uploaded_build.app_id)
         uploaded_build.add_group!(external_group) unless external_group.nil?
 
@@ -121,14 +121,18 @@ module Pilot
           UI.user_error!("You must specify at least one group using the `:groups` option to distribute externally")
         end
 
-      end
-
-      if options[:groups]
-        groups = Group.filter_groups(app_id: uploaded_build.app_id) do |group|
-          options[:groups].include?(group.name)
+        if options[:groups]
+          groups = Spaceship::TestFlight::Group.filter_groups(app_id: uploaded_build.app_id) do |group|
+            options[:groups].include?(group.name)
+          end
+          groups.each do |group|
+            uploaded_build.add_group!(group)
+          end
         end
-        groups.each do |group|
-          uploaded_build.add_group!(group)
+      else # distribute internally
+        # in case any changes to export_compliance are required
+        if uploaded_build.export_compliance_missing?
+          uploaded_build.save!
         end
       end
 

data/pilot/lib/pilot/tester_manager.rb

@@ -65,9 +65,18 @@ module Pilot
           begin
             app = Spaceship::Application.find(app_filter)
             UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
-            groups = remove_tester_from_groups!(tester: tester, app: app, groups: config[:groups])
-            group_names = groups.map(&:name).join(", ")
-            UI.success("Successfully removed tester #{tester.email} from app #{app_filter} in group(s) #{group_names}")
+
+            # If no groups are passed to options, remove the tester from the app-level,
+            # otherwise remove the tester from the groups specified.
+            if config[:groups].nil?
+              test_flight_tester = Spaceship::TestFlight::Tester.find(app_id: app.apple_id, email: tester.email)
+              test_flight_tester.remove_from_app!(app_id: app.apple_id)
+              UI.success("Successfully removed tester, #{test_flight_tester.email}, from app: #{app_filter}")
+            else
+              groups = remove_tester_from_groups!(tester: tester, app: app, groups: config[:groups])
+              group_names = groups.map(&:name).join(", ")
+              UI.success("Successfully removed tester #{tester.email} from app #{app_filter} in group(s) #{group_names}")
+            end
           rescue => ex
             UI.error("Could not remove #{tester.email} from app: #{ex}")
             raise ex

data/spaceship/lib/spaceship/test_flight.rb

@@ -7,3 +7,4 @@ require 'spaceship/test_flight/beta_review_info'
 require 'spaceship/test_flight/export_compliance'
 require 'spaceship/test_flight/test_info'
 require 'spaceship/test_flight/group'
+require 'spaceship/test_flight/tester'

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -121,6 +121,10 @@ module Spaceship::TestFlight
       external_state == BUILD_STATES[:processing]
     end
 
+    def export_compliance_missing?
+      external_state == BUILD_STATES[:export_compliance_missing]
+    end
+
     # Getting builds from BuildTrains only gets a partial Build object
     # We are then requesting the full build from iTC when we need to access
     # any of the variables below, because they are not inlcuded in the partial Build objects

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -20,6 +20,20 @@ module Spaceship::TestFlight
       handle_response(response)
     end
 
+    def testers_for_app(app_id: nil)
+      assert_required_params(__method__, binding)
+      url = "providers/#{team_id}/apps/#{app_id}/testers"
+      response = request(:get, url)
+      handle_response(response)
+    end
+
+    def delete_tester_from_app(app_id: nil, tester_id: nil)
+      assert_required_params(__method__, binding)
+      url = "providers/#{team_id}/apps/#{app_id}/testers/#{tester_id}"
+      response = request(:delete, url)
+      handle_response(response)
+    end
+
     def post_tester(app_id: nil, tester: nil)
       assert_required_params(__method__, binding)
       url = "providers/#{team_id}/apps/#{app_id}/testers"

data/spaceship/lib/spaceship/test_flight/tester.rb

@@ -0,0 +1,34 @@
+module Spaceship::TestFlight
+  class Tester < Base
+    # @return (String) The identifier of this tester, provided by iTunes Connect
+    # @example
+    #   "60f858b4-60a8-428a-963a-f943a3d68d17"
+    attr_accessor :tester_id
+
+    # @return (String) The email of this tester
+    # @example
+    #   "tester@spaceship.com"
+    attr_accessor :email
+
+    attr_mapping(
+      'id' => :tester_id,
+      'email' => :email
+    )
+
+    # @return (Array) Returns all beta testers available for this account
+    def self.all(app_id: nil)
+      client.testers_for_app(app_id: app_id).map { |data| self.new(data) }
+    end
+
+    # @return (Spaceship::TestFlight::Tester) Returns the tester matching the parameter
+    #   as either the Tester id or email
+    # @param email (String) (required): Value used to filter the tester, case insensitive
+    def self.find(app_id: nil, email: nil)
+      self.all(app_id: app_id).find { |tester| tester.email == email }
+    end
+
+    def remove_from_app!(app_id: nil)
+      client.delete_tester_from_app(app_id: app_id, tester_id: self.tester_id)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.29.0.beta.20170424010049
+  version: 2.29.0.beta.20170425010038
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-24 00:00:00.000000000 Z
+date: 2017-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1279,6 +1279,7 @@ files:
 - spaceship/lib/spaceship/test_flight/export_compliance.rb
 - spaceship/lib/spaceship/test_flight/group.rb
 - spaceship/lib/spaceship/test_flight/test_info.rb
+- spaceship/lib/spaceship/test_flight/tester.rb
 - spaceship/lib/spaceship/tunes/app_details.rb
 - spaceship/lib/spaceship/tunes/app_image.rb
 - spaceship/lib/spaceship/tunes/app_ratings.rb
@@ -1341,23 +1342,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- fastlane_core/lib
-- produce/lib
-- cert/lib
+- snapshot/lib
 - screengrab/lib
-- deliver/lib
-- gym/lib
 - spaceship/lib
-- frameit/lib
-- supply/lib
 - sigh/lib
-- match/lib
+- pilot/lib
+- supply/lib
 - fastlane/lib
+- frameit/lib
+- cert/lib
+- fastlane_core/lib
+- produce/lib
 - credentials_manager/lib
+- deliver/lib
+- gym/lib
 - scan/lib
-- pilot/lib
+- match/lib
 - pem/lib
-- snapshot/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="