fastlane 2.28.3 → 2.28.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 132c1e0c8db40d3853f4576395288e72daa87566
-  data.tar.gz: 7ee3eda821ffa5c322b26e71353ddc85f88762db
+  metadata.gz: 0741fe0112b31121452836380edebdb3b28bc426
+  data.tar.gz: 5993c9a13295c5d4e068c4d198c72950955860af
 SHA512:
-  metadata.gz: c6c0218b29725f2712368bb9509dbfaac34ec395f97025cf9d8d61b22d310449b77496e17d17ccd03524b55aab62c96cc0c3ca29e958bdeaf06bd03c675f9141
-  data.tar.gz: 3ac754b83ddcea678f21538cc171c05072668cb8ceed8c315f56452d2dcfe2f65d9a364847a67aff55ab0135de5a1004819eb5953543b0aca52dd100043ce4c9
+  metadata.gz: 7f17c50a5bf22101dd424d8aeba9dc18ee8e5ba136e2e051609cc67cf68b704ed458e1cf3e89ab36b8b57f7fb7f08312941eb7c302195a0d88b14ced356669ac
+  data.tar.gz: 60e9099954524f4e149cbd1a1645b4bdea6a157a4540fda6720bb2e75f6ad8f27a8d383660ea5c0156e285a0bb3a58535aa58dfcd9b1974f4a4ab866a6cfa7c7

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.28.3'.freeze
+  VERSION = '2.28.4'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -25,7 +25,7 @@ module FastlaneCore
         elsif matching_build.active?
           UI.success("Build #{matching_build.train_version} - #{matching_build.build_version} is already being tested")
           return matching_build
-        elsif matching_build.ready_to_submit?
+        elsif matching_build.ready_to_submit? || matching_build.export_compliance_missing?
           UI.success("Successfully finished processing the build #{matching_build.train_version} - #{matching_build.build_version}")
           return matching_build
         end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -108,6 +108,10 @@ module Commander
       FastlaneCore::UI.error("builds for testing, adding and removing testers from groups, and")
       FastlaneCore::UI.error("waiting for builds to process.")
       FastlaneCore::UI.error("")
+      FastlaneCore::UI.error("Please open an issue on https://github.com/fastlane/fastlane/issues")
+      FastlaneCore::UI.error("if you believe this failure is the result of a bug in _pilot_ and we")
+      FastlaneCore::UI.error("will be happy to look into this further.")
+      FastlaneCore::UI.error("")
       FastlaneCore::UI.error("Please stay tuned for more updates from _fastlane_ as we fix more issues!")
       FastlaneCore::UI.error("")
       if FastlaneCore::Globals.verbose?

data/fastlane_core/lib/fastlane_core/ui/github_issue_inspector_reporter.rb

@@ -45,8 +45,8 @@ module Fastlane
       status = (resolved ? issue.state.green : issue.state.red)
 
       puts "➡️  #{issue.title.yellow}"
-      puts "   #{issue.html_url} [#{status}] #{issue.comments} 💬"
-      puts "   #{Time.parse(issue.updated_at).to_pretty}"
+      puts "    #{issue.html_url} [#{status}] #{issue.comments} 💬"
+      puts "    #{Time.parse(issue.updated_at).to_pretty}"
       puts ""
     end
 

data/pilot/lib/pilot/build_manager.rb

@@ -46,11 +46,9 @@ module Pilot
         config[:app_identifier] = UI.input("App Identifier: ")
       end
 
-      unless config[:update_build_info_on_upload]
-        if should_update_build_information(options)
-          build.update_build_information!(whats_new: options[:changelog], description: options[:beta_app_description], feedback_email: options[:beta_app_feedback_email])
-          UI.success "Successfully set the changelog and/or description for build"
-        end
+      if should_update_build_information(options)
+        build.update_build_information!(whats_new: options[:changelog], description: options[:beta_app_description], feedback_email: options[:beta_app_feedback_email])
+        UI.success "Successfully set the changelog and/or description for build"
       end
 
       return if config[:skip_submission]
@@ -110,10 +108,10 @@ module Pilot
 
       # This is where we could add a check to see if encryption is required and has been updated
       uploaded_build.export_compliance.encryption_updated = false
-      uploaded_build.beta_review_info.demo_account_required = false
-      uploaded_build.submit_for_testflight_review!
 
       if options[:distribute_external]
+        uploaded_build.beta_review_info.demo_account_required = false
+        uploaded_build.submit_for_testflight_review!
         external_group = Spaceship::TestFlight::Group.default_external_group(app_id: uploaded_build.app_id)
         uploaded_build.add_group!(external_group) unless external_group.nil?
 
@@ -121,14 +119,18 @@ module Pilot
           UI.user_error!("You must specify at least one group using the `:groups` option to distribute externally")
         end
 
-      end
-
-      if options[:groups]
-        groups = Group.filter_groups(app_id: uploaded_build.app_id) do |group|
-          options[:groups].include?(group.name)
+        if options[:groups]
+          groups = Spaceship::TestFlight::Group.filter_groups(app_id: uploaded_build.app_id) do |group|
+            options[:groups].include?(group.name)
+          end
+          groups.each do |group|
+            uploaded_build.add_group!(group)
+          end
         end
-        groups.each do |group|
-          uploaded_build.add_group!(group)
+      else # distribute internally
+        # in case any changes to export_compliance are required
+        if uploaded_build.export_compliance_missing?
+          uploaded_build.save!
         end
       end
 

data/pilot/lib/pilot/options.rb

@@ -65,9 +65,10 @@ module Pilot
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :update_build_info_on_upload,
+                                     deprecated: true,
                                      short_option: "-x",
                                      env_name: "PILOT_UPDATE_BUILD_INFO_ON_UPLOAD",
-                                     description: "Update build info immediately after validation. This will set the changelog even if PILOT_SKIP_SUBMISSION is set, but will have no effect if PILOT_SKIP_WAITING_FOR_BUILD_PROCESSING is set",
+                                     description: "Update build info immediately after validation. This is deprecated and will be removed in a future release. iTunesConnect no longer supports setting build info until after build processing has completed, which is when build info is updated by default",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :apple_id,

data/pilot/lib/pilot/tester_manager.rb

@@ -65,9 +65,18 @@ module Pilot
           begin
             app = Spaceship::Application.find(app_filter)
             UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
-            groups = remove_tester_from_groups!(tester: tester, app: app, groups: config[:groups])
-            group_names = groups.map(&:name).join(", ")
-            UI.success("Successfully removed tester #{tester.email} from app #{app_filter} in group(s) #{group_names}")
+
+            # If no groups are passed to options, remove the tester from the app-level,
+            # otherwise remove the tester from the groups specified.
+            if config[:groups].nil?
+              test_flight_tester = Spaceship::TestFlight::Tester.find(app_id: app.apple_id, email: tester.email)
+              test_flight_tester.remove_from_app!(app_id: app.apple_id)
+              UI.success("Successfully removed tester, #{test_flight_tester.email}, from app: #{app_filter}")
+            else
+              groups = remove_tester_from_groups!(tester: tester, app: app, groups: config[:groups])
+              group_names = groups.map(&:name).join(", ")
+              UI.success("Successfully removed tester #{tester.email} from app #{app_filter} in group(s) #{group_names}")
+            end
           rescue => ex
             UI.error("Could not remove #{tester.email} from app: #{ex}")
             raise ex

data/snapshot/lib/assets/SnapshotHelper.swift

@@ -145,7 +145,7 @@ open class Snapshot: NSObject {
                 print("Can't prepare environment. Simulator home location is inaccessible. Does \(simulatorHostHome) exist?")
                 return nil
             }
-            homeDir = homeDirUrl
+            homeDir = URL(fileURLWithPath: homeDirUrl.path)
         #endif
         return homeDir.appendingPathComponent("Library/Caches/tools.fastlane")
     }

data/spaceship/lib/spaceship/test_flight.rb

@@ -7,3 +7,4 @@ require 'spaceship/test_flight/beta_review_info'
 require 'spaceship/test_flight/export_compliance'
 require 'spaceship/test_flight/test_info'
 require 'spaceship/test_flight/group'
+require 'spaceship/test_flight/tester'

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -121,6 +121,10 @@ module Spaceship::TestFlight
       external_state == BUILD_STATES[:processing]
     end
 
+    def export_compliance_missing?
+      external_state == BUILD_STATES[:export_compliance_missing]
+    end
+
     # Getting builds from BuildTrains only gets a partial Build object
     # We are then requesting the full build from iTC when we need to access
     # any of the variables below, because they are not inlcuded in the partial Build objects

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -20,6 +20,20 @@ module Spaceship::TestFlight
       handle_response(response)
     end
 
+    def testers_for_app(app_id: nil)
+      assert_required_params(__method__, binding)
+      url = "providers/#{team_id}/apps/#{app_id}/testers"
+      response = request(:get, url)
+      handle_response(response)
+    end
+
+    def delete_tester_from_app(app_id: nil, tester_id: nil)
+      assert_required_params(__method__, binding)
+      url = "providers/#{team_id}/apps/#{app_id}/testers/#{tester_id}"
+      response = request(:delete, url)
+      handle_response(response)
+    end
+
     def post_tester(app_id: nil, tester: nil)
       assert_required_params(__method__, binding)
       url = "providers/#{team_id}/apps/#{app_id}/testers"
@@ -128,12 +142,20 @@ module Spaceship::TestFlight
     #
     # @raises NameError if the values are nil
     def assert_required_params(method_name, binding)
-      parameter_names = Hash[method(method_name).parameters].values
+      parameter_names = method(method_name).parameters.map { |k, v| v }
       parameter_names.each do |name|
-        if binding.local_variable_get(name).nil?
+        if local_variable_get(binding, name).nil?
           raise NameError, "`#{name}' is a required parameter"
         end
       end
     end
+
+    def local_variable_get(binding, name)
+      if binding.respond_to?(:local_variable_get)
+        binding.local_variable_get(name)
+      else
+        binding.eval(name.to_s)
+      end
+    end
   end
 end

data/spaceship/lib/spaceship/test_flight/tester.rb

@@ -0,0 +1,34 @@
+module Spaceship::TestFlight
+  class Tester < Base
+    # @return (String) The identifier of this tester, provided by iTunes Connect
+    # @example
+    #   "60f858b4-60a8-428a-963a-f943a3d68d17"
+    attr_accessor :tester_id
+
+    # @return (String) The email of this tester
+    # @example
+    #   "tester@spaceship.com"
+    attr_accessor :email
+
+    attr_mapping(
+      'id' => :tester_id,
+      'email' => :email
+    )
+
+    # @return (Array) Returns all beta testers available for this account
+    def self.all(app_id: nil)
+      client.testers_for_app(app_id: app_id).map { |data| self.new(data) }
+    end
+
+    # @return (Spaceship::TestFlight::Tester) Returns the tester matching the parameter
+    #   as either the Tester id or email
+    # @param email (String) (required): Value used to filter the tester, case insensitive
+    def self.find(app_id: nil, email: nil)
+      self.all(app_id: app_id).find { |tester| tester.email == email }
+    end
+
+    def remove_from_app!(app_id: nil)
+      client.delete_tester_from_app(app_id: app_id, tester_id: self.tester_id)
+    end
+  end
+end

data/spaceship/lib/spaceship/tunes/app_status.rb

@@ -46,6 +46,7 @@ module Spaceship
           'developerRemovedFromSale' => DEVELOPER_REMOVED_FROM_SALE,
           'waitingForReview' => WAITING_FOR_REVIEW,
           'inReview' => IN_REVIEW,
+          'rejected' => REJECTED,
           'pendingDeveloperRelease' => PENDING_DEVELOPER_RELEASE,
           'metadataRejected' => METADATA_REJECTED
         }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.28.3
+  version: 2.28.4
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-21 00:00:00.000000000 Z
+date: 2017-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1279,6 +1279,7 @@ files:
 - spaceship/lib/spaceship/test_flight/export_compliance.rb
 - spaceship/lib/spaceship/test_flight/group.rb
 - spaceship/lib/spaceship/test_flight/test_info.rb
+- spaceship/lib/spaceship/test_flight/tester.rb
 - spaceship/lib/spaceship/tunes/app_details.rb
 - spaceship/lib/spaceship/tunes/app_image.rb
 - spaceship/lib/spaceship/tunes/app_ratings.rb